[INFO] cloning repository https://github.com/BartuV/Hamstery-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/BartuV/Hamstery-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBartuV%2FHamstery-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBartuV%2FHamstery-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7cebf53ac957fc4312d807b2ccf4bc15277d9b80 [INFO] linting BartuV/Hamstery-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBartuV%2FHamstery-rs" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/BartuV/Hamstery-rs [INFO] finished tweaking git repo https://github.com/BartuV/Hamstery-rs [INFO] tweaked toml for git repo https://github.com/BartuV/Hamstery-rs written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/BartuV/Hamstery-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/BartuV/Hamstery-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libc v0.2.122 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe8d619439305054027cc26e9ba70e1b6c37841bb3342efcec4907271e60fd99 [INFO] running `Command { std: "docker" "start" "-a" "fe8d619439305054027cc26e9ba70e1b6c37841bb3342efcec4907271e60fd99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe8d619439305054027cc26e9ba70e1b6c37841bb3342efcec4907271e60fd99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe8d619439305054027cc26e9ba70e1b6c37841bb3342efcec4907271e60fd99", kill_on_drop: false }` [INFO] [stdout] fe8d619439305054027cc26e9ba70e1b6c37841bb3342efcec4907271e60fd99 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b4478e5806d7b65ea80e3b23feb099ed80f59893d86286797f89f7cc0b47aed5 [INFO] running `Command { std: "docker" "start" "-a" "b4478e5806d7b65ea80e3b23feb099ed80f59893d86286797f89f7cc0b47aed5", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling libc v0.2.122 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking hamstery-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexpars.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | if !(n == ""){ [INFO] [stdout] | ^^^^^^^^^^ help: try: `(n != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexpars.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return res [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return res [INFO] [stdout] 28 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lexpars.rs:18:48 [INFO] [stdout] | [INFO] [stdout] 18 | let content = fs::read_to_string(filename).expect("Something went wrong reading the file".red().bold().to_string().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}", "Something went wrong reading the file".red().bold().to_string()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lexpars.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 22 | if !(n == ""){ [INFO] [stdout] | ^^^^^^^ help: using `is_empty` is clearer and more explicit: `n.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexpars.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | return res [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return res [INFO] [stdout] 67 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `input` [INFO] [stdout] --> src/lexpars.rs:38:14 [INFO] [stdout] | [INFO] [stdout] 38 | for i in 0..input.len()-1{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 38 - for i in 0..input.len()-1{ [INFO] [stdout] 38 + for (i, ) in input.iter().enumerate().take(input.len()-1){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lexpars.rs:94:87 [INFO] [stdout] | [INFO] [stdout] 94 | ..._owned()+PACK_INFO_NAME).expect("Error: Can't read file".red().bold().to_string().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}", "Error: Can't read file".red().bold().to_string()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lexpars.rs:95:50 [INFO] [stdout] | [INFO] [stdout] 95 | let json = Value::from_str(&content).expect("Error: Can't read file".red().bold().to_string().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}", "Error: Can't read file".red().bold().to_string()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexpars.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 - return res; [INFO] [stdout] 136 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lexpars.rs:106:41 [INFO] [stdout] | [INFO] [stdout] 106 | fn function_contents(start: usize,input:&Vec,varlist: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 106 - fn function_contents(start: usize,input:&Vec,varlist: &Vec) -> String { [INFO] [stdout] 106 + fn function_contents(start: usize,input:&[Token],varlist: &Vec) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `input` [INFO] [stdout] --> src/lexpars.rs:110:14 [INFO] [stdout] | [INFO] [stdout] 110 | for i in start..input.len(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 110 - for i in start..input.len(){ [INFO] [stdout] 110 + for (i, ) in input.iter().enumerate().skip(start){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `input` [INFO] [stdout] --> src/lexpars.rs:117:14 [INFO] [stdout] | [INFO] [stdout] 117 | for i in start..end{ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 117 - for i in start..end{ [INFO] [stdout] 117 + for in input.iter().take(end).skip(start){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/lexpars.rs:123:20 [INFO] [stdout] | [INFO] [stdout] 123 | res += &" ".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/lexpars.rs:127:16 [INFO] [stdout] | [INFO] [stdout] 127 | if &b.name == &cur.token_value{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 127 - if &b.name == &cur.token_value{ [INFO] [stdout] 127 + if b.name == cur.token_value{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexpars.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return res; [INFO] [stdout] 152 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lexpars.rs:139:48 [INFO] [stdout] | [INFO] [stdout] 139 | fn get_nearest_newline_index(start:usize,input:&Vec)->usize{ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 139 - fn get_nearest_newline_index(start:usize,input:&Vec)->usize{ [INFO] [stdout] 139 + fn get_nearest_newline_index(start:usize,input:&[Token])->usize{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `input` [INFO] [stdout] --> src/lexpars.rs:142:14 [INFO] [stdout] | [INFO] [stdout] 142 | for i in start..input.len(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 142 - for i in start..input.len(){ [INFO] [stdout] 142 + for (i, ) in input.iter().enumerate().skip(start){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexpars.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | return file; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return file; [INFO] [stdout] 157 + file [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lexpars.rs:156:54 [INFO] [stdout] | [INFO] [stdout] 156 | let file = fs::File::create(filepath.to_owned()).expect("Error: Can't read file".red().bold().to_string().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}", "Error: Can't read file".red().bold().to_string()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/lexpars.rs:156:33 [INFO] [stdout] | [INFO] [stdout] 156 | let file = fs::File::create(filepath.to_owned()).expect("Error: Can't read file".red().bold().to_string().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexpars.rs:163:5 [INFO] [stdout] | [INFO] [stdout] 163 | return path.to_str().unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 - return path.to_str().unwrap().to_string(); [INFO] [stdout] 163 + path.to_str().unwrap().to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/create.rs:36:187 [INFO] [stdout] | [INFO] [stdout] 36 | ...} {} {}","Failed to copy".to_owned().red().bold().to_string() ,&location.red().bold(),format!("{:?}",copyres.err()).red().bold())... [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/create.rs:66:54 [INFO] [stdout] | [INFO] [stdout] 66 | let mut file = File::create(filepath.to_string()+&r"\pack.mcmeta".to_string()).expect("Error"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `r"\pack.mcmeta"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/create.rs:82:50 [INFO] [stdout] | [INFO] [stdout] 82 | ...path.to_string()+&r"\data\minecraft\tags\functions\".to_string()+&filename.to_string()).expect("Something went wrong."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `r"\data\minecraft\tags\functions\"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/create.rs:86:121 [INFO] [stdout] | [INFO] [stdout] 86 | res1["values"] = Value::Array(vec![Value::String(res1["values"].to_string().replace('"', "").replace("place_holder",&name))]); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/create.rs:87:66 [INFO] [stdout] | [INFO] [stdout] 87 | file.write_all(res1.to_string().replace(r"\","").as_bytes()).expect(format!("{}","Something went wrong.".red().bold()).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}","Something went wrong.".red().bold()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/create.rs:90:40 [INFO] [stdout] | [INFO] [stdout] 90 | fn generate_info(path:&String,packname:&String){ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 90 - fn generate_info(path:&String,packname:&String){ [INFO] [stdout] 90 + fn generate_info(path:&String,packname:&str){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/create.rs:97:36 [INFO] [stdout] | [INFO] [stdout] 97 | let mut res1 = Value::from_str(&content).expect("Oops. Something went wrong."); [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/create.rs:100:49 [INFO] [stdout] | [INFO] [stdout] 100 | file.write_all(res1.to_string().as_bytes()).expect(format!("{}","Something went wrong.".red().bold()).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}","Something went wrong.".red().bold()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - error("Invalid path."); [INFO] [stdout] 33 - return [INFO] [stdout] 32 + error("Invalid path."); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - error("Invalid path."); [INFO] [stdout] 44 - return [INFO] [stdout] 43 + error("Invalid path."); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:26:73 [INFO] [stdout] | [INFO] [stdout] 26 | ...(),"shows this text","compile:".bold().green(),"compiles to minecraft datapack","create:".bold().green(),"create a example datapack") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 26 - println!("\n{} {}\n{} {}\n{} {}","help:".bold().green(),"shows this text","compile:".bold().green(),"compiles to minecraft datapack","create:".bold().green(),"create a example datapack") [INFO] [stdout] 26 + println!("\n{} shows this text\n{} compiles to minecraft datapack\n{} create a example datapack","help:".bold().green(),"compile:".bold().green(),"create:".bold().green()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexpars.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | if !(n == ""){ [INFO] [stdout] | ^^^^^^^^^^ help: try: `(n != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexpars.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return res [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return res [INFO] [stdout] 28 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lexpars.rs:18:48 [INFO] [stdout] | [INFO] [stdout] 18 | let content = fs::read_to_string(filename).expect("Something went wrong reading the file".red().bold().to_string().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}", "Something went wrong reading the file".red().bold().to_string()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lexpars.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 22 | if !(n == ""){ [INFO] [stdout] | ^^^^^^^ help: using `is_empty` is clearer and more explicit: `n.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexpars.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | return res [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return res [INFO] [stdout] 67 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `input` [INFO] [stdout] --> src/lexpars.rs:38:14 [INFO] [stdout] | [INFO] [stdout] 38 | for i in 0..input.len()-1{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 38 - for i in 0..input.len()-1{ [INFO] [stdout] 38 + for (i, ) in input.iter().enumerate().take(input.len()-1){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lexpars.rs:94:87 [INFO] [stdout] | [INFO] [stdout] 94 | ..._owned()+PACK_INFO_NAME).expect("Error: Can't read file".red().bold().to_string().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}", "Error: Can't read file".red().bold().to_string()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lexpars.rs:95:50 [INFO] [stdout] | [INFO] [stdout] 95 | let json = Value::from_str(&content).expect("Error: Can't read file".red().bold().to_string().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}", "Error: Can't read file".red().bold().to_string()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexpars.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 - return res; [INFO] [stdout] 136 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lexpars.rs:106:41 [INFO] [stdout] | [INFO] [stdout] 106 | fn function_contents(start: usize,input:&Vec,varlist: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 106 - fn function_contents(start: usize,input:&Vec,varlist: &Vec) -> String { [INFO] [stdout] 106 + fn function_contents(start: usize,input:&[Token],varlist: &Vec) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `input` [INFO] [stdout] --> src/lexpars.rs:110:14 [INFO] [stdout] | [INFO] [stdout] 110 | for i in start..input.len(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 110 - for i in start..input.len(){ [INFO] [stdout] 110 + for (i, ) in input.iter().enumerate().skip(start){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `input` [INFO] [stdout] --> src/lexpars.rs:117:14 [INFO] [stdout] | [INFO] [stdout] 117 | for i in start..end{ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 117 - for i in start..end{ [INFO] [stdout] 117 + for in input.iter().take(end).skip(start){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/lexpars.rs:123:20 [INFO] [stdout] | [INFO] [stdout] 123 | res += &" ".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `" "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/lexpars.rs:127:16 [INFO] [stdout] | [INFO] [stdout] 127 | if &b.name == &cur.token_value{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 127 - if &b.name == &cur.token_value{ [INFO] [stdout] 127 + if b.name == cur.token_value{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexpars.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return res; [INFO] [stdout] 152 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lexpars.rs:139:48 [INFO] [stdout] | [INFO] [stdout] 139 | fn get_nearest_newline_index(start:usize,input:&Vec)->usize{ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 139 - fn get_nearest_newline_index(start:usize,input:&Vec)->usize{ [INFO] [stdout] 139 + fn get_nearest_newline_index(start:usize,input:&[Token])->usize{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `input` [INFO] [stdout] --> src/lexpars.rs:142:14 [INFO] [stdout] | [INFO] [stdout] 142 | for i in start..input.len(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 142 - for i in start..input.len(){ [INFO] [stdout] 142 + for (i, ) in input.iter().enumerate().skip(start){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexpars.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | return file; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return file; [INFO] [stdout] 157 + file [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lexpars.rs:156:54 [INFO] [stdout] | [INFO] [stdout] 156 | let file = fs::File::create(filepath.to_owned()).expect("Error: Can't read file".red().bold().to_string().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}", "Error: Can't read file".red().bold().to_string()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/lexpars.rs:156:33 [INFO] [stdout] | [INFO] [stdout] 156 | let file = fs::File::create(filepath.to_owned()).expect("Error: Can't read file".red().bold().to_string().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexpars.rs:163:5 [INFO] [stdout] | [INFO] [stdout] 163 | return path.to_str().unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 - return path.to_str().unwrap().to_string(); [INFO] [stdout] 163 + path.to_str().unwrap().to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/create.rs:36:187 [INFO] [stdout] | [INFO] [stdout] 36 | ...} {} {}","Failed to copy".to_owned().red().bold().to_string() ,&location.red().bold(),format!("{:?}",copyres.err()).red().bold())... [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/create.rs:66:54 [INFO] [stdout] | [INFO] [stdout] 66 | let mut file = File::create(filepath.to_string()+&r"\pack.mcmeta".to_string()).expect("Error"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `r"\pack.mcmeta"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/create.rs:82:50 [INFO] [stdout] | [INFO] [stdout] 82 | ...path.to_string()+&r"\data\minecraft\tags\functions\".to_string()+&filename.to_string()).expect("Something went wrong."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `r"\data\minecraft\tags\functions\"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/create.rs:86:121 [INFO] [stdout] | [INFO] [stdout] 86 | res1["values"] = Value::Array(vec![Value::String(res1["values"].to_string().replace('"', "").replace("place_holder",&name))]); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/create.rs:87:66 [INFO] [stdout] | [INFO] [stdout] 87 | file.write_all(res1.to_string().replace(r"\","").as_bytes()).expect(format!("{}","Something went wrong.".red().bold()).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}","Something went wrong.".red().bold()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/create.rs:90:40 [INFO] [stdout] | [INFO] [stdout] 90 | fn generate_info(path:&String,packname:&String){ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 90 - fn generate_info(path:&String,packname:&String){ [INFO] [stdout] 90 + fn generate_info(path:&String,packname:&str){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/create.rs:97:36 [INFO] [stdout] | [INFO] [stdout] 97 | let mut res1 = Value::from_str(&content).expect("Oops. Something went wrong."); [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/create.rs:100:49 [INFO] [stdout] | [INFO] [stdout] 100 | file.write_all(res1.to_string().as_bytes()).expect(format!("{}","Something went wrong.".red().bold()).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}","Something went wrong.".red().bold()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - error("Invalid path."); [INFO] [stdout] 33 - return [INFO] [stdout] 32 + error("Invalid path."); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - error("Invalid path."); [INFO] [stdout] 44 - return [INFO] [stdout] 43 + error("Invalid path."); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:26:73 [INFO] [stdout] | [INFO] [stdout] 26 | ...(),"shows this text","compile:".bold().green(),"compiles to minecraft datapack","create:".bold().green(),"create a example datapack") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 26 - println!("\n{} {}\n{} {}\n{} {}","help:".bold().green(),"shows this text","compile:".bold().green(),"compiles to minecraft datapack","create:".bold().green(),"create a example datapack") [INFO] [stdout] 26 + println!("\n{} shows this text\n{} compiles to minecraft datapack\n{} create a example datapack","help:".bold().green(),"compile:".bold().green(),"create:".bold().green()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.01s [INFO] running `Command { std: "docker" "inspect" "b4478e5806d7b65ea80e3b23feb099ed80f59893d86286797f89f7cc0b47aed5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4478e5806d7b65ea80e3b23feb099ed80f59893d86286797f89f7cc0b47aed5", kill_on_drop: false }` [INFO] [stdout] b4478e5806d7b65ea80e3b23feb099ed80f59893d86286797f89f7cc0b47aed5