[INFO] cloning repository https://github.com/Bartekkur1/cli-interpreter
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Bartekkur1/cli-interpreter" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBartekkur1%2Fcli-interpreter", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBartekkur1%2Fcli-interpreter'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 44a1d0a11cdc5b3fc22218d00f7c8abb87d4840f
[INFO] linting Bartekkur1/cli-interpreter against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBartekkur1%2Fcli-interpreter" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Bartekkur1/cli-interpreter
[INFO] finished tweaking git repo https://github.com/Bartekkur1/cli-interpreter
[INFO] tweaked toml for git repo https://github.com/Bartekkur1/cli-interpreter written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Bartekkur1/cli-interpreter on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Bartekkur1/cli-interpreter already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 958885b784f15a3ca56fa4ee08f6f2678681b77f82d4146eef4728d2df6b257f
[INFO] running `Command { std: "docker" "start" "-a" "958885b784f15a3ca56fa4ee08f6f2678681b77f82d4146eef4728d2df6b257f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "958885b784f15a3ca56fa4ee08f6f2678681b77f82d4146eef4728d2df6b257f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "958885b784f15a3ca56fa4ee08f6f2678681b77f82d4146eef4728d2df6b257f", kill_on_drop: false }`
[INFO] [stdout] 958885b784f15a3ca56fa4ee08f6f2678681b77f82d4146eef4728d2df6b257f
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 6033aa9ebc77f6665541f9c14256fdc2bd48be5672b542594db7643ae98745e5
[INFO] running `Command { std: "docker" "start" "-a" "6033aa9ebc77f6665541f9c14256fdc2bd48be5672b542594db7643ae98745e5", kill_on_drop: false }`
[INFO] [stderr]     Checking cli-interpreter v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: associated function `operator` is never used
[INFO] [stdout]   --> src/lexer.rs:35:12
[INFO] [stdout]    |
[INFO] [stdout] 30 | impl Token {
[INFO] [stdout]    | ---------- associated function in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 35 |     pub fn operator(value: String, score: u8) -> Self {
[INFO] [stdout]    |            ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lexer.rs:97:9
[INFO] [stdout]    |
[INFO] [stdout] 97 |         return 1;
[INFO] [stdout]    |         ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 97 -         return 1;
[INFO] [stdout] 97 +         1
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lexer.rs:99:9
[INFO] [stdout]    |
[INFO] [stdout] 99 |         return 0;
[INFO] [stdout]    |         ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 99 -         return 0;
[INFO] [stdout] 99 +         0
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/lexer.rs:96:8
[INFO] [stdout]    |
[INFO] [stdout] 96 |     if *token == String::from("*") || *token == String::from("/") {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]    = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/lexer.rs:96:39
[INFO] [stdout]    |
[INFO] [stdout] 96 |     if *token == String::from("*") || *token == String::from("/") {
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]    --> src/lexer.rs:103:21
[INFO] [stdout]     |
[INFO] [stdout] 103 | pub fn lexer(input: &String) -> Result<Vec<Token>, String> {
[INFO] [stdout]     |                     ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 103 - pub fn lexer(input: &String) -> Result<Vec<Token>, String> {
[INFO] [stdout] 103 + pub fn lexer(input: &str) -> Result<Vec<Token>, String> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: compiling a regex in a loop
[INFO] [stdout]    --> src/lexer.rs:109:12
[INFO] [stdout]     |
[INFO] [stdout] 109 |         if Regex::new(r"\d").unwrap().is_match(&c.to_string()) {
[INFO] [stdout]     |            ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: move the regex construction outside this loop
[INFO] [stdout]    --> src/lexer.rs:108:5
[INFO] [stdout]     |
[INFO] [stdout] 108 |     while let Some(c) = input.pop() {
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops
[INFO] [stdout]     = note: `#[warn(clippy::regex_creation_in_loops)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: compiling a regex in a loop
[INFO] [stdout]    --> src/lexer.rs:111:19
[INFO] [stdout]     |
[INFO] [stdout] 111 |         } else if Regex::new(r"(\+|\-|\/|\*)").unwrap().is_match(&c.to_string()) {
[INFO] [stdout]     |                   ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: move the regex construction outside this loop
[INFO] [stdout]    --> src/lexer.rs:108:5
[INFO] [stdout]     |
[INFO] [stdout] 108 |     while let Some(c) = input.pop() {
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lexer.rs:112:16
[INFO] [stdout]     |
[INFO] [stdout] 112 |             if mem.len() > 0 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!mem.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lexer.rs:97:9
[INFO] [stdout]    |
[INFO] [stdout] 97 |         return 1;
[INFO] [stdout]    |         ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 97 -         return 1;
[INFO] [stdout] 97 +         1
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lexer.rs:99:9
[INFO] [stdout]    |
[INFO] [stdout] 99 |         return 0;
[INFO] [stdout]    |         ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 99 -         return 0;
[INFO] [stdout] 99 +         0
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/lexer.rs:96:8
[INFO] [stdout]    |
[INFO] [stdout] 96 |     if *token == String::from("*") || *token == String::from("/") {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]    = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/lexer.rs:96:39
[INFO] [stdout]    |
[INFO] [stdout] 96 |     if *token == String::from("*") || *token == String::from("/") {
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lexer.rs:124:8
[INFO] [stdout]     |
[INFO] [stdout] 124 |     if mem.len() > 0 {
[INFO] [stdout]     |        ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!mem.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]    --> src/lexer.rs:103:21
[INFO] [stdout]     |
[INFO] [stdout] 103 | pub fn lexer(input: &String) -> Result<Vec<Token>, String> {
[INFO] [stdout]     |                     ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 103 - pub fn lexer(input: &String) -> Result<Vec<Token>, String> {
[INFO] [stdout] 103 + pub fn lexer(input: &str) -> Result<Vec<Token>, String> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: compiling a regex in a loop
[INFO] [stdout]    --> src/lexer.rs:109:12
[INFO] [stdout]     |
[INFO] [stdout] 109 |         if Regex::new(r"\d").unwrap().is_match(&c.to_string()) {
[INFO] [stdout]     |            ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: move the regex construction outside this loop
[INFO] [stdout]    --> src/lexer.rs:108:5
[INFO] [stdout]     |
[INFO] [stdout] 108 |     while let Some(c) = input.pop() {
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops
[INFO] [stdout]     = note: `#[warn(clippy::regex_creation_in_loops)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `tokens.get(0)`
[INFO] [stdout]    --> src/lexer.rs:137:43
[INFO] [stdout]     |
[INFO] [stdout] 137 |     if let Some(Token::Value { value }) = tokens.get(0) {
[INFO] [stdout]     |                                           ^^^^^^^^^^^^^ help: try: `tokens.first()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]     = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: compiling a regex in a loop
[INFO] [stdout]    --> src/lexer.rs:111:19
[INFO] [stdout]     |
[INFO] [stdout] 111 |         } else if Regex::new(r"(\+|\-|\/|\*)").unwrap().is_match(&c.to_string()) {
[INFO] [stdout]     |                   ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] help: move the regex construction outside this loop
[INFO] [stdout]    --> src/lexer.rs:108:5
[INFO] [stdout]     |
[INFO] [stdout] 108 |     while let Some(c) = input.pop() {
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lexer.rs:112:16
[INFO] [stdout]     |
[INFO] [stdout] 112 |             if mem.len() > 0 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!mem.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lexer.rs:124:8
[INFO] [stdout]     |
[INFO] [stdout] 124 |     if mem.len() > 0 {
[INFO] [stdout]     |        ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!mem.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/syntax_analysis.rs:3:31
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub fn analyze_syntax(tokens: &Vec<Token>) -> Result<(), String> {
[INFO] [stdout]   |                               ^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 3 - pub fn analyze_syntax(tokens: &Vec<Token>) -> Result<(), String> {
[INFO] [stdout] 3 + pub fn analyze_syntax(tokens: &[Token]) -> Result<(), String> {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/execute.rs:21:5
[INFO] [stdout]    |
[INFO] [stdout] 21 |     return Token::value(result.to_string());
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 21 -     return Token::value(result.to_string());
[INFO] [stdout] 21 +     Token::value(result.to_string())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/execute.rs:40:8
[INFO] [stdout]    |
[INFO] [stdout] 40 |     if !max_operator.1.is_some() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `max_operator.1.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/execute.rs:63:5
[INFO] [stdout]    |
[INFO] [stdout] 63 |     return execute(outgoing_tokens);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 63 -     return execute(outgoing_tokens);
[INFO] [stdout] 63 +     execute(outgoing_tokens)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/syntax_analysis.rs:3:31
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub fn analyze_syntax(tokens: &Vec<Token>) -> Result<(), String> {
[INFO] [stdout]   |                               ^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 3 - pub fn analyze_syntax(tokens: &Vec<Token>) -> Result<(), String> {
[INFO] [stdout] 3 + pub fn analyze_syntax(tokens: &[Token]) -> Result<(), String> {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]   --> src/execute.rs:29:16
[INFO] [stdout]    |
[INFO] [stdout] 29 |             if max_operator.1 == None {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `max_operator.1.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout]    = note: `#[warn(clippy::partialeq_to_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/execute.rs:34:34
[INFO] [stdout]    |
[INFO] [stdout] 34 |                 max_operator.0 = &token.score();
[INFO] [stdout]    |                                  ^^^^^^^^^^^^^^ help: change this to: `token.score()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `tokens.get(0)`
[INFO] [stdout]   --> src/execute.rs:41:21
[INFO] [stdout]    |
[INFO] [stdout] 41 |         let value = tokens.get(0).unwrap().token_value().parse::<f32>();
[INFO] [stdout]    |                     ^^^^^^^^^^^^^ help: try: `tokens.first()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]    = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/execute.rs:52:44
[INFO] [stdout]    |
[INFO] [stdout] 52 |     let operator_result = execute_operator(&operator, &left, &right);
[INFO] [stdout]    |                                            ^^^^^^^^^ help: change this to: `operator`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/execute.rs:52:55
[INFO] [stdout]    |
[INFO] [stdout] 52 |     let operator_result = execute_operator(&operator, &left, &right);
[INFO] [stdout]    |                                                       ^^^^^ help: change this to: `left`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/execute.rs:52:62
[INFO] [stdout]    |
[INFO] [stdout] 52 |     let operator_result = execute_operator(&operator, &left, &right);
[INFO] [stdout]    |                                                              ^^^^^^ help: change this to: `right`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calls to `push` immediately after creation
[INFO] [stdout]   --> src/syntax_analysis.rs:60:5
[INFO] [stdout]    |
[INFO] [stdout] 60 | /     let mut tokens: Vec<Token> = Vec::new();
[INFO] [stdout] 61 | |     tokens.push(Token::value("1".to_string()));
[INFO] [stdout] 62 | |     tokens.push(Token::operator("*".to_string(), 1));
[INFO] [stdout]    | |_____________________________________________________^ help: consider using the `vec![]` macro: `let tokens: Vec<Token> = vec![..];`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
[INFO] [stdout]    = note: `#[warn(clippy::vec_init_then_push)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]   --> src/execute.rs:59:9
[INFO] [stdout]    |
[INFO] [stdout] 59 |         &vec![operator_result],
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[operator_result]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout]    = note: `#[warn(clippy::useless_vec)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calls to `push` immediately after creation
[INFO] [stdout]   --> src/syntax_analysis.rs:71:5
[INFO] [stdout]    |
[INFO] [stdout] 71 | /     let mut tokens: Vec<Token> = Vec::new();
[INFO] [stdout] 72 | |     tokens.push(Token::operator("*".to_string(), 1));
[INFO] [stdout] 73 | |     tokens.push(Token::value("1".to_string()));
[INFO] [stdout]    | |_______________________________________________^ help: consider using the `vec![]` macro: `let tokens: Vec<Token> = vec![..];`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calls to `push` immediately after creation
[INFO] [stdout]   --> src/syntax_analysis.rs:82:5
[INFO] [stdout]    |
[INFO] [stdout] 82 | /     let mut tokens: Vec<Token> = Vec::new();
[INFO] [stdout] 83 | |     tokens.push(Token::operator("*".to_string(), 1));
[INFO] [stdout] 84 | |     tokens.push(Token::value("1".to_string()));
[INFO] [stdout]    | |_______________________________________________^ help: consider using the `vec![]` macro: `let tokens: Vec<Token> = vec![..];`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calls to `push` immediately after creation
[INFO] [stdout]   --> src/syntax_analysis.rs:93:5
[INFO] [stdout]    |
[INFO] [stdout] 93 | /     let mut tokens: Vec<Token> = Vec::new();
[INFO] [stdout] 94 | |     tokens.push(Token::value("1".to_string()));
[INFO] [stdout] 95 | |     tokens.push(Token::operator("*".to_string(), 1));
[INFO] [stdout] 96 | |     tokens.push(Token::operator("*".to_string(), 1));
[INFO] [stdout]    | |_____________________________________________________^ help: consider using the `vec![]` macro: `let tokens: Vec<Token> = vec![..];`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calls to `push` immediately after creation
[INFO] [stdout]    --> src/syntax_analysis.rs:108:5
[INFO] [stdout]     |
[INFO] [stdout] 108 | /     let mut tokens: Vec<Token> = Vec::new();
[INFO] [stdout] 109 | |     tokens.push(Token::value("1".to_string()));
[INFO] [stdout]     | |_______________________________________________^ help: consider using the `vec![]` macro: `let tokens: Vec<Token> = vec![..];`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/execute.rs:21:5
[INFO] [stdout]    |
[INFO] [stdout] 21 |     return Token::value(result.to_string());
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 21 -     return Token::value(result.to_string());
[INFO] [stdout] 21 +     Token::value(result.to_string())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/execute.rs:40:8
[INFO] [stdout]    |
[INFO] [stdout] 40 |     if !max_operator.1.is_some() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `max_operator.1.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/execute.rs:63:5
[INFO] [stdout]    |
[INFO] [stdout] 63 |     return execute(outgoing_tokens);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 63 -     return execute(outgoing_tokens);
[INFO] [stdout] 63 +     execute(outgoing_tokens)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]   --> src/execute.rs:29:16
[INFO] [stdout]    |
[INFO] [stdout] 29 |             if max_operator.1 == None {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `max_operator.1.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout]    = note: `#[warn(clippy::partialeq_to_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/execute.rs:34:34
[INFO] [stdout]    |
[INFO] [stdout] 34 |                 max_operator.0 = &token.score();
[INFO] [stdout]    |                                  ^^^^^^^^^^^^^^ help: change this to: `token.score()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `tokens.get(0)`
[INFO] [stdout]   --> src/execute.rs:41:21
[INFO] [stdout]    |
[INFO] [stdout] 41 |         let value = tokens.get(0).unwrap().token_value().parse::<f32>();
[INFO] [stdout]    |                     ^^^^^^^^^^^^^ help: try: `tokens.first()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/execute.rs:52:44
[INFO] [stdout]    |
[INFO] [stdout] 52 |     let operator_result = execute_operator(&operator, &left, &right);
[INFO] [stdout]    |                                            ^^^^^^^^^ help: change this to: `operator`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/execute.rs:52:55
[INFO] [stdout]    |
[INFO] [stdout] 52 |     let operator_result = execute_operator(&operator, &left, &right);
[INFO] [stdout]    |                                                       ^^^^^ help: change this to: `left`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/execute.rs:52:62
[INFO] [stdout]    |
[INFO] [stdout] 52 |     let operator_result = execute_operator(&operator, &left, &right);
[INFO] [stdout]    |                                                              ^^^^^^ help: change this to: `right`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `vec!`
[INFO] [stdout]   --> src/execute.rs:59:9
[INFO] [stdout]    |
[INFO] [stdout] 59 |         &vec![operator_result],
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[operator_result]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stdout]    = note: `#[warn(clippy::useless_vec)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.25s
[INFO] running `Command { std: "docker" "inspect" "6033aa9ebc77f6665541f9c14256fdc2bd48be5672b542594db7643ae98745e5", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "6033aa9ebc77f6665541f9c14256fdc2bd48be5672b542594db7643ae98745e5", kill_on_drop: false }`
[INFO] [stdout] 6033aa9ebc77f6665541f9c14256fdc2bd48be5672b542594db7643ae98745e5