[INFO] cloning repository https://github.com/Bai-Jinlin/shuttlings-cch24 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Bai-Jinlin/shuttlings-cch24" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBai-Jinlin%2Fshuttlings-cch24", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBai-Jinlin%2Fshuttlings-cch24'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d900525c2d128ecf033c9ffd1f4f2b65a26a7611 [INFO] linting Bai-Jinlin/shuttlings-cch24 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBai-Jinlin%2Fshuttlings-cch24" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Bai-Jinlin/shuttlings-cch24 [INFO] finished tweaking git repo https://github.com/Bai-Jinlin/shuttlings-cch24 [INFO] tweaked toml for git repo https://github.com/Bai-Jinlin/shuttlings-cch24 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Bai-Jinlin/shuttlings-cch24 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Bai-Jinlin/shuttlings-cch24 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded globset v0.4.15 [INFO] [stderr] Downloaded ordered-float v4.5.0 [INFO] [stderr] Downloaded shuttle-runtime v0.49.0 [INFO] [stderr] Downloaded shuttle-api-client v0.49.0 [INFO] [stderr] Downloaded shuttle-codegen v0.49.0 [INFO] [stderr] Downloaded shuttle-shared-db v0.49.0 [INFO] [stderr] Downloaded ignore v0.4.23 [INFO] [stderr] Downloaded shuttle-axum v0.49.0 [INFO] [stderr] Downloaded cargo-manifest v0.17.0 [INFO] [stderr] Downloaded leaky-bucket v1.1.2 [INFO] [stderr] Downloaded shuttle-common v0.49.0 [INFO] [stderr] Downloaded shuttle-proto v0.49.0 [INFO] [stderr] Downloaded shuttle-service v0.49.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8720204d383209f8e858b435ec2f95cd7e7dac2b9d2fc2fe7e0605b18c1c1a59 [INFO] running `Command { std: "docker" "start" "-a" "8720204d383209f8e858b435ec2f95cd7e7dac2b9d2fc2fe7e0605b18c1c1a59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8720204d383209f8e858b435ec2f95cd7e7dac2b9d2fc2fe7e0605b18c1c1a59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8720204d383209f8e858b435ec2f95cd7e7dac2b9d2fc2fe7e0605b18c1c1a59", kill_on_drop: false }` [INFO] [stdout] 8720204d383209f8e858b435ec2f95cd7e7dac2b9d2fc2fe7e0605b18c1c1a59 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 412b430eb952e35629a3b535d0fa5e487b49743ddba44a233651f1b3eed8be91 [INFO] running `Command { std: "docker" "start" "-a" "412b430eb952e35629a3b535d0fa5e487b49743ddba44a233651f1b3eed8be91", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.168 [INFO] [stderr] Compiling serde v1.0.215 [INFO] [stderr] Checking itoa v1.0.14 [INFO] [stderr] Checking pin-project-lite v0.2.15 [INFO] [stderr] Checking bytes v1.9.0 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Compiling cc v1.2.3 [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Checking indexmap v2.7.0 [INFO] [stderr] Compiling serde_json v1.0.133 [INFO] [stderr] Compiling rustversion v1.0.18 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling httparse v1.9.5 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking unicode-bidi v0.3.17 [INFO] [stderr] Compiling thiserror v2.0.6 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling anyhow v1.0.94 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling unicase v2.8.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking cpufeatures v0.2.16 [INFO] [stderr] Compiling subtle v2.6.1 [INFO] [stderr] Compiling rustls v0.23.20 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Compiling tinyvec_macros v0.1.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking http v1.2.0 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Compiling rustls-pki-types v1.10.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking ordered-float v4.5.0 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking ipnet v2.10.1 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling percent-encoding v2.3.1 [INFO] [stderr] Compiling futures-sink v0.3.31 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling axum-core v0.3.4 [INFO] [stderr] Compiling parking v2.2.1 [INFO] [stderr] Compiling zeroize v1.8.1 [INFO] [stderr] Compiling crc-catalog v2.4.0 [INFO] [stderr] Compiling iana-time-zone v0.1.61 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling rustix v0.38.42 [INFO] [stderr] Compiling futures-io v0.3.31 [INFO] [stderr] Compiling unicode_categories v0.1.1 [INFO] [stderr] Compiling chrono v0.4.39 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Compiling crc v3.2.1 [INFO] [stderr] Compiling event-listener v5.3.1 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling tokio v1.42.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling webpki-roots v0.26.7 [INFO] [stderr] Compiling rustls-pemfile v2.2.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling axum v0.6.20 [INFO] [stderr] Compiling uuid v1.11.0 [INFO] [stderr] Compiling unicode-properties v0.1.3 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Compiling url v2.5.2 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Compiling home v0.5.11 [INFO] [stderr] Compiling whoami v1.5.2 [INFO] [stderr] Checking time v0.3.37 [INFO] [stderr] Compiling serde_derive v1.0.215 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Compiling thiserror-impl v2.0.6 [INFO] [stderr] Compiling pin-project-internal v1.1.7 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling typeshare-annotation v1.0.4 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling rustls-webpki v0.102.8 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking pin-project v1.1.7 [INFO] [stderr] Checking opentelemetry v0.21.0 [INFO] [stderr] Compiling sqlformat v0.2.6 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking opentelemetry-http v0.10.0 [INFO] [stderr] Compiling pest v2.7.15 [INFO] [stderr] Compiling tempfile v3.14.0 [INFO] [stderr] Compiling tokio-stream v0.1.17 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Compiling hashlink v0.9.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking task-local-extensions v0.1.4 [INFO] [stderr] Checking bstr v1.11.1 [INFO] [stderr] Compiling multer v3.1.0 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking strfmt v0.2.4 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking headers v0.3.9 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking globset v0.4.15 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Checking winnow v0.6.20 [INFO] [stderr] Checking opentelemetry_sdk v0.21.2 [INFO] [stderr] Checking ignore v0.4.23 [INFO] [stderr] Compiling pest_meta v2.7.15 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling shuttle-codegen v0.49.0 [INFO] [stderr] Checking unic-ucd-segment v0.9.0 [INFO] [stderr] Compiling axum-macros v0.4.2 [INFO] [stderr] Checking ucd-trie v0.1.7 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Checking deunicode v1.6.0 [INFO] [stderr] Checking slug v0.1.6 [INFO] [stderr] Checking unic-segment v0.9.0 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Checking simple_asn1 v0.6.2 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Checking http-range-header v0.4.2 [INFO] [stderr] Compiling pest_generator v2.7.15 [INFO] [stderr] Compiling pest_derive v2.7.15 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tracing-serde v0.2.0 [INFO] [stderr] Checking semver v1.0.23 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking toml_edit v0.22.22 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking futures-intrusive v0.5.0 [INFO] [stderr] Checking tungstenite v0.20.1 [INFO] [stderr] Checking tower-cookies v0.10.0 [INFO] [stderr] Checking comfy-table v6.2.0 [INFO] [stderr] Compiling sqlx-core v0.8.2 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking jsonwebtoken v9.3.0 [INFO] [stderr] Checking typeshare v1.0.4 [INFO] [stderr] Compiling prost-derive v0.12.6 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking cargo-manifest v0.17.0 [INFO] [stderr] Checking prost v0.12.6 [INFO] [stderr] Checking tracing-opentelemetry v0.22.0 [INFO] [stderr] Checking prost-types v0.12.6 [INFO] [stderr] Compiling sqlx-postgres v0.8.2 [INFO] [stderr] Checking tera v1.20.0 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tokio-io-timeout v1.2.0 [INFO] [stderr] Checking hyper v1.5.1 [INFO] [stderr] Checking tower v0.5.1 [INFO] [stderr] Checking leaky-bucket v1.1.2 [INFO] [stderr] Checking tokio-tungstenite v0.20.1 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tower-http v0.6.2 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking axum v0.7.9 [INFO] [stderr] Compiling sqlx-macros-core v0.8.2 [INFO] [stderr] Checking hyper v0.14.31 [INFO] [stderr] Compiling sqlx-macros v0.8.2 [INFO] [stderr] Checking sqlx v0.8.2 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking hyper-timeout v0.4.1 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking shuttle-common v0.49.0 [INFO] [stderr] Checking reqwest-middleware v0.2.5 [INFO] [stderr] Checking shuttle-service v0.49.0 [INFO] [stderr] Checking shuttle-api-client v0.49.0 [INFO] [stderr] Checking shuttle-shared-db v0.49.0 [INFO] [stderr] Checking tonic v0.10.2 [INFO] [stderr] Checking shuttle-proto v0.49.0 [INFO] [stderr] Checking shuttle-runtime v0.49.0 [INFO] [stderr] Checking shuttle-axum v0.49.0 [INFO] [stderr] Checking shuttlings-cch24 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/day19.rs:121:11 [INFO] [stdout] | [INFO] [stdout] 121 | .bind(&id) [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/day19.rs:163:22 [INFO] [stdout] | [INFO] [stdout] 163 | let number = map [INFO] [stdout] | ______________________^ [INFO] [stdout] 164 | | .get(&query.token) [INFO] [stdout] 165 | | .map(|i| *i) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 163 ~ let number = map [INFO] [stdout] 164 + .get(&query.token).copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/day2.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 20 | .zip(k.octets().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 20 - .zip(k.octets().into_iter()) [INFO] [stdout] 20 + .zip(k.octets()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/day2.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 44 | .zip(f.octets().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 44 - .zip(f.octets().into_iter()) [INFO] [stdout] 44 + .zip(f.octets()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/day2.rs:69:18 [INFO] [stdout] | [INFO] [stdout] 69 | .zip(k.octets().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 69 - .zip(k.octets().into_iter()) [INFO] [stdout] 69 + .zip(k.octets()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/day2.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 92 | .zip(f.octets().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 92 - .zip(f.octets().into_iter()) [INFO] [stdout] 92 + .zip(f.octets()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/day5.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | / enum MyErr { [INFO] [stdout] 26 | | MetadataError, [INFO] [stdout] 27 | | InvalidError, [INFO] [stdout] 28 | | MagicError, [INFO] [stdout] 29 | | ContentUnsupportedError, [INFO] [stdout] 30 | | UnknownError, [INFO] [stdout] 31 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/day5.rs:86:36 [INFO] [stdout] | [INFO] [stdout] 86 | let metadata = package.map(|p| p.metadata).flatten(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|p| p.metadata)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/day5.rs:117:24 [INFO] [stdout] | [INFO] [stdout] 117 | let content_type = if let Some(content_type) = headers.get(header::CONTENT_TYPE) { [INFO] [stdout] | ________________________^ [INFO] [stdout] 118 | | content_type [INFO] [stdout] 119 | | } else { [INFO] [stdout] 120 | | return None; [INFO] [stdout] 121 | | }; [INFO] [stdout] | |_____^ help: replace it with: `headers.get(header::CONTENT_TYPE)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/day5.rs:135:40 [INFO] [stdout] | [INFO] [stdout] 135 | if mime.subtype() == "toml" || mime.suffix().map_or(false, |name| name == "toml") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 135 - if mime.subtype() == "toml" || mime.suffix().map_or(false, |name| name == "toml") { [INFO] [stdout] 135 + if mime.subtype() == "toml" || mime.suffix().is_some_and(|name| name == "toml") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/day5.rs:137:47 [INFO] [stdout] | [INFO] [stdout] 137 | } else if mime.subtype() == "yaml" || mime.suffix().map_or(false, |name| name == "yaml") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 137 - } else if mime.subtype() == "yaml" || mime.suffix().map_or(false, |name| name == "yaml") { [INFO] [stdout] 137 + } else if mime.subtype() == "yaml" || mime.suffix().is_some_and(|name| name == "yaml") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/day5.rs:139:47 [INFO] [stdout] | [INFO] [stdout] 139 | } else if mime.subtype() == "json" || mime.suffix().map_or(false, |name| name == "json") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 139 - } else if mime.subtype() == "json" || mime.suffix().map_or(false, |name| name == "json") { [INFO] [stdout] 139 + } else if mime.subtype() == "json" || mime.suffix().is_some_and(|name| name == "json") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/day9.rs:26:46 [INFO] [stdout] | [INFO] [stdout] 26 | Self::Liters(n) => Self::Gallons(0.264172060 * n), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 26 - Self::Liters(n) => Self::Gallons(0.264172060 * n), [INFO] [stdout] 26 + Self::Liters(n) => Self::Gallons(0.264_172_05 * n), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/day9.rs:54:41 [INFO] [stdout] | [INFO] [stdout] 54 | && (mime.subtype() == "json" || mime.suffix().map_or(false, |name| name == "json")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 54 - && (mime.subtype() == "json" || mime.suffix().map_or(false, |name| name == "json")); [INFO] [stdout] 54 + && (mime.subtype() == "json" || mime.suffix().is_some_and(|name| name == "json")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/day23.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | / color [INFO] [stdout] 80 | | .chars() [INFO] [stdout] 81 | | .all(|c| match c { [INFO] [stdout] 82 | | '0'..='9' => true, [INFO] [stdout] ... | [INFO] [stdout] 85 | | }) [INFO] [stdout] 86 | | .then(|| ())?; [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 86 - .then(|| ())?; [INFO] [stdout] 86 + .then_some(())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/day23.rs:81:22 [INFO] [stdout] | [INFO] [stdout] 81 | .all(|c| match c { [INFO] [stdout] | ______________________^ [INFO] [stdout] 82 | | '0'..='9' => true, [INFO] [stdout] 83 | | 'a'..='f' => true, [INFO] [stdout] 84 | | _ => false, [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 81 - .all(|c| match c { [INFO] [stdout] 82 - '0'..='9' => true, [INFO] [stdout] 83 - 'a'..='f' => true, [INFO] [stdout] 84 - _ => false, [INFO] [stdout] 85 - }) [INFO] [stdout] 81 + .all(|c| matches!(c, '0'..='9' | 'a'..='f')) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/day19.rs:121:11 [INFO] [stdout] | [INFO] [stdout] 121 | .bind(&id) [INFO] [stdout] | ^^^ help: change this to: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/day19.rs:163:22 [INFO] [stdout] | [INFO] [stdout] 163 | let number = map [INFO] [stdout] | ______________________^ [INFO] [stdout] 164 | | .get(&query.token) [INFO] [stdout] 165 | | .map(|i| *i) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 163 ~ let number = map [INFO] [stdout] 164 + .get(&query.token).copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/day2.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 20 | .zip(k.octets().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 20 - .zip(k.octets().into_iter()) [INFO] [stdout] 20 + .zip(k.octets()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/day2.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 44 | .zip(f.octets().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 44 - .zip(f.octets().into_iter()) [INFO] [stdout] 44 + .zip(f.octets()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/day2.rs:69:18 [INFO] [stdout] | [INFO] [stdout] 69 | .zip(k.octets().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 69 - .zip(k.octets().into_iter()) [INFO] [stdout] 69 + .zip(k.octets()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/day2.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 92 | .zip(f.octets().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 92 - .zip(f.octets().into_iter()) [INFO] [stdout] 92 + .zip(f.octets()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/day5.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | / enum MyErr { [INFO] [stdout] 26 | | MetadataError, [INFO] [stdout] 27 | | InvalidError, [INFO] [stdout] 28 | | MagicError, [INFO] [stdout] 29 | | ContentUnsupportedError, [INFO] [stdout] 30 | | UnknownError, [INFO] [stdout] 31 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/day5.rs:86:36 [INFO] [stdout] | [INFO] [stdout] 86 | let metadata = package.map(|p| p.metadata).flatten(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|p| p.metadata)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/day5.rs:117:24 [INFO] [stdout] | [INFO] [stdout] 117 | let content_type = if let Some(content_type) = headers.get(header::CONTENT_TYPE) { [INFO] [stdout] | ________________________^ [INFO] [stdout] 118 | | content_type [INFO] [stdout] 119 | | } else { [INFO] [stdout] 120 | | return None; [INFO] [stdout] 121 | | }; [INFO] [stdout] | |_____^ help: replace it with: `headers.get(header::CONTENT_TYPE)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/day5.rs:135:40 [INFO] [stdout] | [INFO] [stdout] 135 | if mime.subtype() == "toml" || mime.suffix().map_or(false, |name| name == "toml") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 135 - if mime.subtype() == "toml" || mime.suffix().map_or(false, |name| name == "toml") { [INFO] [stdout] 135 + if mime.subtype() == "toml" || mime.suffix().is_some_and(|name| name == "toml") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/day5.rs:137:47 [INFO] [stdout] | [INFO] [stdout] 137 | } else if mime.subtype() == "yaml" || mime.suffix().map_or(false, |name| name == "yaml") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 137 - } else if mime.subtype() == "yaml" || mime.suffix().map_or(false, |name| name == "yaml") { [INFO] [stdout] 137 + } else if mime.subtype() == "yaml" || mime.suffix().is_some_and(|name| name == "yaml") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/day5.rs:139:47 [INFO] [stdout] | [INFO] [stdout] 139 | } else if mime.subtype() == "json" || mime.suffix().map_or(false, |name| name == "json") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 139 - } else if mime.subtype() == "json" || mime.suffix().map_or(false, |name| name == "json") { [INFO] [stdout] 139 + } else if mime.subtype() == "json" || mime.suffix().is_some_and(|name| name == "json") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/day9.rs:26:46 [INFO] [stdout] | [INFO] [stdout] 26 | Self::Liters(n) => Self::Gallons(0.264172060 * n), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 26 - Self::Liters(n) => Self::Gallons(0.264172060 * n), [INFO] [stdout] 26 + Self::Liters(n) => Self::Gallons(0.264_172_05 * n), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/day9.rs:54:41 [INFO] [stdout] | [INFO] [stdout] 54 | && (mime.subtype() == "json" || mime.suffix().map_or(false, |name| name == "json")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 54 - && (mime.subtype() == "json" || mime.suffix().map_or(false, |name| name == "json")); [INFO] [stdout] 54 + && (mime.subtype() == "json" || mime.suffix().is_some_and(|name| name == "json")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/day23.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | / color [INFO] [stdout] 80 | | .chars() [INFO] [stdout] 81 | | .all(|c| match c { [INFO] [stdout] 82 | | '0'..='9' => true, [INFO] [stdout] ... | [INFO] [stdout] 85 | | }) [INFO] [stdout] 86 | | .then(|| ())?; [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 86 - .then(|| ())?; [INFO] [stdout] 86 + .then_some(())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/day23.rs:81:22 [INFO] [stdout] | [INFO] [stdout] 81 | .all(|c| match c { [INFO] [stdout] | ______________________^ [INFO] [stdout] 82 | | '0'..='9' => true, [INFO] [stdout] 83 | | 'a'..='f' => true, [INFO] [stdout] 84 | | _ => false, [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 81 - .all(|c| match c { [INFO] [stdout] 82 - '0'..='9' => true, [INFO] [stdout] 83 - 'a'..='f' => true, [INFO] [stdout] 84 - _ => false, [INFO] [stdout] 85 - }) [INFO] [stdout] 81 + .all(|c| matches!(c, '0'..='9' | 'a'..='f')) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 47s [INFO] running `Command { std: "docker" "inspect" "412b430eb952e35629a3b535d0fa5e487b49743ddba44a233651f1b3eed8be91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "412b430eb952e35629a3b535d0fa5e487b49743ddba44a233651f1b3eed8be91", kill_on_drop: false }` [INFO] [stdout] 412b430eb952e35629a3b535d0fa5e487b49743ddba44a233651f1b3eed8be91