[INFO] cloning repository https://github.com/Az0xI/Ascii_Rotating_Cube [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Az0xI/Ascii_Rotating_Cube" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAz0xI%2FAscii_Rotating_Cube", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAz0xI%2FAscii_Rotating_Cube'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 08f32f25b536c254c997f07706948a8bf221196a [INFO] linting Az0xI/Ascii_Rotating_Cube against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAz0xI%2FAscii_Rotating_Cube" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Az0xI/Ascii_Rotating_Cube [INFO] finished tweaking git repo https://github.com/Az0xI/Ascii_Rotating_Cube [INFO] tweaked toml for git repo https://github.com/Az0xI/Ascii_Rotating_Cube written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Az0xI/Ascii_Rotating_Cube on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Az0xI/Ascii_Rotating_Cube already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9b61b5f1d7a751565b57169e0514de370b4a1b406a32daa4daedac30df6f456 [INFO] running `Command { std: "docker" "start" "-a" "b9b61b5f1d7a751565b57169e0514de370b4a1b406a32daa4daedac30df6f456", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9b61b5f1d7a751565b57169e0514de370b4a1b406a32daa4daedac30df6f456", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9b61b5f1d7a751565b57169e0514de370b4a1b406a32daa4daedac30df6f456", kill_on_drop: false }` [INFO] [stdout] b9b61b5f1d7a751565b57169e0514de370b4a1b406a32daa4daedac30df6f456 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d9700317e7c7ba4d3fc32cf363df08ea83e29edd6b6c0934ca1963e200ede1db [INFO] running `Command { std: "docker" "start" "-a" "d9700317e7c7ba4d3fc32cf363df08ea83e29edd6b6c0934ca1963e200ede1db", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.176 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling litrs v0.4.2 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking Ascii_Rotating_Cube v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/draw.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | size: size, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/draw.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | size: size, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SHADOW` is never used [INFO] [stdout] --> src/main.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | const SHADOW: [char; 10] = [' ', '.', ':', '-', '=', '+', '*', '#', '%', '@']; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SHADOW` is never used [INFO] [stdout] --> src/main.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | const SHADOW: [char; 10] = [' ', '.', ':', '-', '=', '+', '*', '#', '%', '@']; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/draw.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 20 | / let term = TermInfo { [INFO] [stdout] 21 | | size: size, [INFO] [stdout] 22 | | center: (size.0 / 2, size.1 / 2), [INFO] [stdout] 23 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 24 | term [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 20 ~ [INFO] [stdout] 21 ~ TermInfo { [INFO] [stdout] 22 + size: size, [INFO] [stdout] 23 + center: (size.0 / 2, size.1 / 2), [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/draw.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 20 | / let term = TermInfo { [INFO] [stdout] 21 | | size: size, [INFO] [stdout] 22 | | center: (size.0 / 2, size.1 / 2), [INFO] [stdout] 23 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 24 | term [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 20 ~ [INFO] [stdout] 21 ~ TermInfo { [INFO] [stdout] 22 + size: size, [INFO] [stdout] 23 + center: (size.0 / 2, size.1 / 2), [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/draw.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return Ok(()); [INFO] [stdout] 45 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/draw.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return Ok(()); [INFO] [stdout] 45 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | if (len > 1 && args[1] == "-h") || (len > 1 && args[1] == "--help") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 - if (len > 1 && args[1] == "-h") || (len > 1 && args[1] == "--help") { [INFO] [stdout] 30 + if !(len <= 1 || args[1] != "-h" && args[1] != "--help") { [INFO] [stdout] | [INFO] [stdout] 30 - if (len > 1 && args[1] == "-h") || (len > 1 && args[1] == "--help") { [INFO] [stdout] 30 + if (args[1] == "--help" || args[1] == "-h") && len > 1 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | if (len > 1 && args[1] == "-h") || (len > 1 && args[1] == "--help") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 - if (len > 1 && args[1] == "-h") || (len > 1 && args[1] == "--help") { [INFO] [stdout] 30 + if !(len <= 1 || args[1] != "-h" && args[1] != "--help") { [INFO] [stdout] | [INFO] [stdout] 30 - if (len > 1 && args[1] == "-h") || (len > 1 && args[1] == "--help") { [INFO] [stdout] 30 + if (args[1] == "--help" || args[1] == "-h") && len > 1 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | if tog_axis == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `tog_axis` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | if tog_axis == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `tog_axis` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / match read()? { [INFO] [stdout] 61 | | Event::Key(event) => { [INFO] [stdout] 62 | | if event.code == KeyCode::Char('q') { [INFO] [stdout] 63 | | break; [INFO] [stdout] ... | [INFO] [stdout] 68 | | _ => (), [INFO] [stdout] 69 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 60 ~ if let Event::Key(event) = read()? { [INFO] [stdout] 61 + if event.code == KeyCode::Char('q') { [INFO] [stdout] 62 + break; [INFO] [stdout] 63 + } else { [INFO] [stdout] 64 + handle_key_event(event, &mut tog_axis); [INFO] [stdout] 65 + } [INFO] [stdout] 66 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / match read()? { [INFO] [stdout] 61 | | Event::Key(event) => { [INFO] [stdout] 62 | | if event.code == KeyCode::Char('q') { [INFO] [stdout] 63 | | break; [INFO] [stdout] ... | [INFO] [stdout] 68 | | _ => (), [INFO] [stdout] 69 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 60 ~ if let Event::Key(event) = read()? { [INFO] [stdout] 61 + if event.code == KeyCode::Char('q') { [INFO] [stdout] 62 + break; [INFO] [stdout] 63 + } else { [INFO] [stdout] 64 + handle_key_event(event, &mut tog_axis); [INFO] [stdout] 65 + } [INFO] [stdout] 66 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | / match event.code { [INFO] [stdout] 80 | | KeyCode::Char('a') => *tog_axis = !*tog_axis, [INFO] [stdout] 81 | | _ => (), [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____^ help: try: `if let KeyCode::Char('a') = event.code { *tog_axis = !*tog_axis }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | / match event.code { [INFO] [stdout] 80 | | KeyCode::Char('a') => *tog_axis = !*tog_axis, [INFO] [stdout] 81 | | _ => (), [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____^ help: try: `if let KeyCode::Char('a') = event.code { *tog_axis = !*tog_axis }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.24s [INFO] running `Command { std: "docker" "inspect" "d9700317e7c7ba4d3fc32cf363df08ea83e29edd6b6c0934ca1963e200ede1db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9700317e7c7ba4d3fc32cf363df08ea83e29edd6b6c0934ca1963e200ede1db", kill_on_drop: false }` [INFO] [stdout] d9700317e7c7ba4d3fc32cf363df08ea83e29edd6b6c0934ca1963e200ede1db