[INFO] cloning repository https://github.com/Ayehavgunne/tdt [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Ayehavgunne/tdt" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAyehavgunne%2Ftdt", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAyehavgunne%2Ftdt'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d2978cadeb3c893a8e759f2ba59814961c8d53bc [INFO] linting Ayehavgunne/tdt against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAyehavgunne%2Ftdt" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Ayehavgunne/tdt [INFO] finished tweaking git repo https://github.com/Ayehavgunne/tdt [INFO] tweaked toml for git repo https://github.com/Ayehavgunne/tdt written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Ayehavgunne/tdt on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Ayehavgunne/tdt already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded htmlescape v0.3.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 66a94a60611b4e75eb8d7e3604ab3b33056b598a2eee7251b170141f8984d327 [INFO] running `Command { std: "docker" "start" "-a" "66a94a60611b4e75eb8d7e3604ab3b33056b598a2eee7251b170141f8984d327", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "66a94a60611b4e75eb8d7e3604ab3b33056b598a2eee7251b170141f8984d327", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66a94a60611b4e75eb8d7e3604ab3b33056b598a2eee7251b170141f8984d327", kill_on_drop: false }` [INFO] [stdout] 66a94a60611b4e75eb8d7e3604ab3b33056b598a2eee7251b170141f8984d327 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8e51c5d6c9af7356087f6aced3884c6988ac9b66aa592168b5abe7b5489cf5ed [INFO] running `Command { std: "docker" "start" "-a" "8e51c5d6c9af7356087f6aced3884c6988ac9b66aa592168b5abe7b5489cf5ed", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Compiling serde_json v1.0.143 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Checking toml_writer v1.0.2 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Checking htmlescape v0.3.1 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Checking clap_builder v4.5.46 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking indexmap v2.11.0 [INFO] [stderr] Checking console v0.16.0 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking toml_parser v1.0.2 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling clap_derive v4.5.45 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking clap v4.5.46 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking toml_datetime v0.7.0 [INFO] [stderr] Checking serde_spanned v1.0.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking serde_yaml_ng v0.10.0 [INFO] [stderr] Checking toml v0.9.5 [INFO] [stderr] Checking tdt v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/tools.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use htmlescape; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/tools.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/tools.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use serde_yaml_ng; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/tools.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use toml; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/tools.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use htmlescape; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/tools.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/tools.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use serde_yaml_ng; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/tools.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use toml; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/select.rs:43:46 [INFO] [stdout] | [INFO] [stdout] 43 | (self.options[selection - 1].handle)(&self.args, &self.term); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return None; [INFO] [stdout] 58 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/select.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 63 | if !option.arg_name.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `option.arg_name.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `option.arg_name` after checking its variant with `is_none` [INFO] [stdout] --> src/select.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 63 | if !option.arg_name.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 66 | option.arg_name.as_ref().unwrap().to_string().as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tools.rs:35:31 [INFO] [stdout] | [INFO] [stdout] 35 | Ok(result_str) => return Ok(result_str), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - Ok(result_str) => return Ok(result_str), [INFO] [stdout] 35 + Ok(result_str) => Ok(result_str), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tools.rs:36:25 [INFO] [stdout] | [INFO] [stdout] 36 | Err(err) => return Err(format!("Error converting bytes to string: {err}")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - Err(err) => return Err(format!("Error converting bytes to string: {err}")), [INFO] [stdout] 36 + Err(err) => Err(format!("Error converting bytes to string: {err}")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tools.rs:38:21 [INFO] [stdout] | [INFO] [stdout] 38 | Err(err) => return Err(format!("Error decoding Base64 string: {err}")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - Err(err) => return Err(format!("Error decoding Base64 string: {err}")), [INFO] [stdout] 38 + Err(err) => Err(format!("Error decoding Base64 string: {err}")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `_base_64_decode` doesn't need a mutable reference [INFO] [stdout] --> src/tools.rs:186:38 [INFO] [stdout] | [INFO] [stdout] 186 | let header = _base_64_decode(&mut String::from_str(jwt_parts[0]).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 186 - let header = _base_64_decode(&mut String::from_str(jwt_parts[0]).unwrap()); [INFO] [stdout] 186 + let header = _base_64_decode(&String::from_str(jwt_parts[0]).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `_base_64_decode` doesn't need a mutable reference [INFO] [stdout] --> src/tools.rs:194:39 [INFO] [stdout] | [INFO] [stdout] 194 | let payload = _base_64_decode(&mut String::from_str(jwt_parts[1]).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 194 - let payload = _base_64_decode(&mut String::from_str(jwt_parts[1]).unwrap()); [INFO] [stdout] 194 + let payload = _base_64_decode(&String::from_str(jwt_parts[1]).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:218:17 [INFO] [stdout] | [INFO] [stdout] 218 | format!("{}", url.scheme()).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `url.scheme().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:224:17 [INFO] [stdout] | [INFO] [stdout] 224 | format!("{}", url.username()).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `url.username().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:230:17 [INFO] [stdout] | [INFO] [stdout] 230 | format!("{}", url.password().unwrap_or("")).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `url.password().unwrap_or("").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:236:17 [INFO] [stdout] | [INFO] [stdout] 236 | format!("{}", url.host_str().unwrap_or("")).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `url.host_str().unwrap_or("").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:242:17 [INFO] [stdout] | [INFO] [stdout] 242 | / format!( [INFO] [stdout] 243 | | "{}", [INFO] [stdout] 244 | | url.port().map_or("".to_string(), |port| port.to_string()) [INFO] [stdout] 245 | | ) [INFO] [stdout] | |_________________^ help: consider using `.to_string()`: `url.port().map_or("".to_string(), |port| port.to_string()).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:250:24 [INFO] [stdout] | [INFO] [stdout] 250 | success(t, format!("{}", url.path()).as_str(), Some("Path"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `url.path().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:253:17 [INFO] [stdout] | [INFO] [stdout] 253 | format!("{}", url.query().unwrap_or("")).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `url.query().unwrap_or("").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:259:17 [INFO] [stdout] | [INFO] [stdout] 259 | format!("{}", url.fragment().unwrap_or("")).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `url.fragment().unwrap_or("").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:247:41 [INFO] [stdout] | [INFO] [stdout] 247 | Some(option) => (option.handle)(&select.args, &select.term), [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `select.args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | return input; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 264 - return input; [INFO] [stdout] 264 + input [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:266:9 [INFO] [stdout] | [INFO] [stdout] 266 | return t.read_line().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 266 - return t.read_line().unwrap(); [INFO] [stdout] 266 + t.read_line().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/select.rs:43:46 [INFO] [stdout] | [INFO] [stdout] 43 | (self.options[selection - 1].handle)(&self.args, &self.term); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/select.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return None; [INFO] [stdout] 58 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/select.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 63 | if !option.arg_name.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `option.arg_name.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `option.arg_name` after checking its variant with `is_none` [INFO] [stdout] --> src/select.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 63 | if !option.arg_name.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 66 | option.arg_name.as_ref().unwrap().to_string().as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tools.rs:35:31 [INFO] [stdout] | [INFO] [stdout] 35 | Ok(result_str) => return Ok(result_str), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - Ok(result_str) => return Ok(result_str), [INFO] [stdout] 35 + Ok(result_str) => Ok(result_str), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tools.rs:36:25 [INFO] [stdout] | [INFO] [stdout] 36 | Err(err) => return Err(format!("Error converting bytes to string: {err}")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - Err(err) => return Err(format!("Error converting bytes to string: {err}")), [INFO] [stdout] 36 + Err(err) => Err(format!("Error converting bytes to string: {err}")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tools.rs:38:21 [INFO] [stdout] | [INFO] [stdout] 38 | Err(err) => return Err(format!("Error decoding Base64 string: {err}")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - Err(err) => return Err(format!("Error decoding Base64 string: {err}")), [INFO] [stdout] 38 + Err(err) => Err(format!("Error decoding Base64 string: {err}")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `_base_64_decode` doesn't need a mutable reference [INFO] [stdout] --> src/tools.rs:186:38 [INFO] [stdout] | [INFO] [stdout] 186 | let header = _base_64_decode(&mut String::from_str(jwt_parts[0]).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 186 - let header = _base_64_decode(&mut String::from_str(jwt_parts[0]).unwrap()); [INFO] [stdout] 186 + let header = _base_64_decode(&String::from_str(jwt_parts[0]).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `_base_64_decode` doesn't need a mutable reference [INFO] [stdout] --> src/tools.rs:194:39 [INFO] [stdout] | [INFO] [stdout] 194 | let payload = _base_64_decode(&mut String::from_str(jwt_parts[1]).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 194 - let payload = _base_64_decode(&mut String::from_str(jwt_parts[1]).unwrap()); [INFO] [stdout] 194 + let payload = _base_64_decode(&String::from_str(jwt_parts[1]).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:218:17 [INFO] [stdout] | [INFO] [stdout] 218 | format!("{}", url.scheme()).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `url.scheme().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:224:17 [INFO] [stdout] | [INFO] [stdout] 224 | format!("{}", url.username()).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `url.username().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:230:17 [INFO] [stdout] | [INFO] [stdout] 230 | format!("{}", url.password().unwrap_or("")).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `url.password().unwrap_or("").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:236:17 [INFO] [stdout] | [INFO] [stdout] 236 | format!("{}", url.host_str().unwrap_or("")).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `url.host_str().unwrap_or("").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:242:17 [INFO] [stdout] | [INFO] [stdout] 242 | / format!( [INFO] [stdout] 243 | | "{}", [INFO] [stdout] 244 | | url.port().map_or("".to_string(), |port| port.to_string()) [INFO] [stdout] 245 | | ) [INFO] [stdout] | |_________________^ help: consider using `.to_string()`: `url.port().map_or("".to_string(), |port| port.to_string()).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:250:24 [INFO] [stdout] | [INFO] [stdout] 250 | success(t, format!("{}", url.path()).as_str(), Some("Path"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `url.path().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:253:17 [INFO] [stdout] | [INFO] [stdout] 253 | format!("{}", url.query().unwrap_or("")).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `url.query().unwrap_or("").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tools.rs:259:17 [INFO] [stdout] | [INFO] [stdout] 259 | format!("{}", url.fragment().unwrap_or("")).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `url.fragment().unwrap_or("").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:247:41 [INFO] [stdout] | [INFO] [stdout] 247 | Some(option) => (option.handle)(&select.args, &select.term), [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `select.args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | return input; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 264 - return input; [INFO] [stdout] 264 + input [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:266:9 [INFO] [stdout] | [INFO] [stdout] 266 | return t.read_line().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 266 - return t.read_line().unwrap(); [INFO] [stdout] 266 + t.read_line().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.95s [INFO] running `Command { std: "docker" "inspect" "8e51c5d6c9af7356087f6aced3884c6988ac9b66aa592168b5abe7b5489cf5ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e51c5d6c9af7356087f6aced3884c6988ac9b66aa592168b5abe7b5489cf5ed", kill_on_drop: false }` [INFO] [stdout] 8e51c5d6c9af7356087f6aced3884c6988ac9b66aa592168b5abe7b5489cf5ed