[INFO] cloning repository https://github.com/AviTheBrown/Yomu [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AviTheBrown/Yomu" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAviTheBrown%2FYomu", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAviTheBrown%2FYomu'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 986846369d2c8aef232d093bbca5d6a51faa8122 [INFO] linting AviTheBrown/Yomu against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAviTheBrown%2FYomu" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/AviTheBrown/Yomu [INFO] finished tweaking git repo https://github.com/AviTheBrown/Yomu [INFO] tweaked toml for git repo https://github.com/AviTheBrown/Yomu written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/AviTheBrown/Yomu on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/AviTheBrown/Yomu already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: package.path [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zerocopy-derive v0.8.37 [INFO] [stderr] Downloaded safe_arch v0.9.3 [INFO] [stderr] Downloaded quantette v0.5.1 [INFO] [stderr] Downloaded wide v0.8.3 [INFO] [stderr] Downloaded zerocopy v0.8.37 [INFO] [stderr] Downloaded icy_sixel v0.5.0 [INFO] [stderr] Downloaded ratatui-image v10.0.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 54cdefc90d510215164d6addbc15f3901f7e44545af5a0ced4a16cef2fdf46c2 [INFO] running `Command { std: "docker" "start" "-a" "54cdefc90d510215164d6addbc15f3901f7e44545af5a0ced4a16cef2fdf46c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "54cdefc90d510215164d6addbc15f3901f7e44545af5a0ced4a16cef2fdf46c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54cdefc90d510215164d6addbc15f3901f7e44545af5a0ced4a16cef2fdf46c2", kill_on_drop: false }` [INFO] [stdout] 54cdefc90d510215164d6addbc15f3901f7e44545af5a0ced4a16cef2fdf46c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6b2635dfaa202541e4589b43720abdb61ec2a765740b4009f0d33d64500fdde6 [INFO] running `Command { std: "docker" "start" "-a" "6b2635dfaa202541e4589b43720abdb61ec2a765740b4009f0d33d64500fdde6", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: package.path [INFO] [stderr] Checking foldhash v0.2.0 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Compiling zerocopy v0.8.37 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Compiling anyhow v1.0.101 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Checking y4m v0.8.0 [INFO] [stderr] Compiling pastey v0.1.1 [INFO] [stderr] Checking compact_str v0.9.0 [INFO] [stderr] Compiling rav1e v0.8.1 [INFO] [stderr] Checking bitstream-io v4.9.0 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking imgref v1.12.0 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Checking zune-jpeg v0.4.21 [INFO] [stderr] Compiling cc v1.2.55 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking deranged v0.5.6 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking avif-serialize v0.8.8 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking time-core v0.1.8 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Compiling palette v0.7.6 [INFO] [stderr] Checking num-conv v0.2.0 [INFO] [stderr] Checking lru v0.16.3 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking zune-core v0.5.1 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking gif v0.14.1 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking png v0.18.1 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking zune-jpeg v0.5.12 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking line-clipping v0.3.5 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking rand_xoshiro v0.7.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ordered-float v5.1.0 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling ratatui-image v10.0.6 [INFO] [stderr] Checking vsimd v0.8.0 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Checking outref v0.5.2 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking unicode-truncate v2.0.1 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking base64-simd v0.8.0 [INFO] [stderr] Compiling aws-lc-sys v0.37.0 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling zerocopy-derive v0.8.37 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking av1-grain v0.2.5 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling palette_derive v0.7.6 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Compiling ref-cast-impl v1.0.25 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking av-scenechange v0.14.1 [INFO] [stderr] Checking kasuari v0.4.11 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking ref-cast v1.0.25 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking safe_arch v0.9.3 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Checking wide v0.8.3 [INFO] [stderr] Compiling instability v0.3.11 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking ratatui-core v0.1.0 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking ratatui-widgets v0.3.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking ratatui-crossterm v0.1.0 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking ratatui-macros v0.7.0 [INFO] [stderr] Checking ratatui v0.30.0 [INFO] [stderr] Checking ravif v0.12.0 [INFO] [stderr] Compiling aws-lc-rs v1.15.4 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking tiff v0.10.3 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.13.1 [INFO] [stderr] Checking quantette v0.5.1 [INFO] [stderr] Checking icy_sixel v0.5.0 [INFO] [stderr] Checking yomu v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/chapter.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | .get(&format!("{}/manga/{}/feed", self.client.base_url, manga_id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/manga/{}/feed", self.client.base_url, manga_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/client.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return SearchClient { client: self }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return SearchClient { client: self }; [INFO] [stdout] 65 + SearchClient { client: self } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/client.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return ChapterClient { client: self }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return ChapterClient { client: self }; [INFO] [stdout] 70 + ChapterClient { client: self } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/client.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | return ImageClient { client: self }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return ImageClient { client: self }; [INFO] [stdout] 74 + ImageClient { client: self } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/image.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 66 | if resp.content_length().map_or(false, |len| len > MAX_IMAGE_BYTES) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 66 - if resp.content_length().map_or(false, |len| len > MAX_IMAGE_BYTES) { [INFO] [stdout] 66 + if resp.content_length().is_some_and(|len| len > MAX_IMAGE_BYTES) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/chapter.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | .get(&format!("{}/manga/{}/feed", self.client.base_url, manga_id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/manga/{}/feed", self.client.base_url, manga_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/search.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 30 | .get(&format!("{}/manga", self.client.base_url)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/manga", self.client.base_url)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/client.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return SearchClient { client: self }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return SearchClient { client: self }; [INFO] [stdout] 65 + SearchClient { client: self } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/client.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return ChapterClient { client: self }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return ChapterClient { client: self }; [INFO] [stdout] 70 + ChapterClient { client: self } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/client.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | return ImageClient { client: self }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return ImageClient { client: self }; [INFO] [stdout] 74 + ImageClient { client: self } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/image.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 66 | if resp.content_length().map_or(false, |len| len > MAX_IMAGE_BYTES) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 66 - if resp.content_length().map_or(false, |len| len > MAX_IMAGE_BYTES) { [INFO] [stdout] 66 + if resp.content_length().is_some_and(|len| len > MAX_IMAGE_BYTES) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/search.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 30 | .get(&format!("{}/manga", self.client.base_url)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/manga", self.client.base_url)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / if let Some(ref titles) = manga.attributes.title { [INFO] [stdout] 34 | | if let Some(en_title) = titles.get("en") { [INFO] [stdout] 35 | | println!(" Title: {}", en_title); [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ if let Some(ref titles) = manga.attributes.title [INFO] [stdout] 34 ~ && let Some(en_title) = titles.get("en") { [INFO] [stdout] 35 | println!(" Title: {}", en_title); [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/lib.rs:49:28 [INFO] [stdout] | [INFO] [stdout] 49 | .fetch_chapter("a77742b1-befd-49a4-bff5-1ad4e6b0ef7b".into(), Some("en")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"a77742b1-befd-49a4-bff5-1ad4e6b0ef7b"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 111 | / if app.page_cache.len() > app::MAX_CACHE_PAGES { [INFO] [stdout] 112 | | if let Some(&evict_idx) = app.page_cache.keys().max_by_key(|&&k| { [INFO] [stdout] 113 | | (k as isize - app.current_page as isize).unsigned_abs() [INFO] [stdout] 114 | | }) { [INFO] [stdout] ... | [INFO] [stdout] 119 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 111 ~ if app.page_cache.len() > app::MAX_CACHE_PAGES [INFO] [stdout] 112 ~ && let Some(&evict_idx) = app.page_cache.keys().max_by_key(|&&k| { [INFO] [stdout] 113 | (k as isize - app.current_page as isize).unsigned_abs() [INFO] [stdout] ... [INFO] [stdout] 117 | app.proto_cache.remove(&(evict_idx, false)); [INFO] [stdout] 118 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | / if crossterm::event::poll(std::time::Duration::from_millis(16))? { [INFO] [stdout] 137 | | if let crossterm::event::Event::Key(key) = crossterm::event::read()? { [INFO] [stdout] 138 | | if key.code == crossterm::event::KeyCode::Esc { [INFO] [stdout] 139 | | break; [INFO] [stdout] ... | [INFO] [stdout] 144 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 136 ~ if crossterm::event::poll(std::time::Duration::from_millis(16))? [INFO] [stdout] 137 ~ && let crossterm::event::Event::Key(key) = crossterm::event::read()? { [INFO] [stdout] 138 | if key.code == crossterm::event::KeyCode::Esc { [INFO] [stdout] ... [INFO] [stdout] 142 | } [INFO] [stdout] 143 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:473:23 [INFO] [stdout] | [INFO] [stdout] 473 | let cache_valid = app [INFO] [stdout] | _______________________^ [INFO] [stdout] 474 | | .proto_cache [INFO] [stdout] 475 | | .get(&(page_idx, is_left)) [INFO] [stdout] 476 | | .map_or(false, |(cached_area, _)| { [INFO] [stdout] 477 | | cached_area.width == area.width && cached_area.height == area.height [INFO] [stdout] 478 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 476 - .map_or(false, |(cached_area, _)| { [INFO] [stdout] 476 + .is_some_and(|(cached_area, _)| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:609:17 [INFO] [stdout] | [INFO] [stdout] 609 | / if app.selected_index + 1 < app.search_result.len() { [INFO] [stdout] 610 | | app.selected_index += 1; [INFO] [stdout] 611 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 608 ~ KeyCode::Down [INFO] [stdout] 609 ~ if app.selected_index + 1 < app.search_result.len() => { [INFO] [stdout] 610 | app.selected_index += 1; [INFO] [stdout] 611 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:621:17 [INFO] [stdout] | [INFO] [stdout] 621 | / if app.selected_index + 1 < app.chapters.len() { [INFO] [stdout] 622 | | app.selected_index += 1; [INFO] [stdout] 623 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 620 ~ KeyCode::Down [INFO] [stdout] 621 ~ if app.selected_index + 1 < app.chapters.len() => { [INFO] [stdout] 622 | app.selected_index += 1; [INFO] [stdout] 623 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:661:17 [INFO] [stdout] | [INFO] [stdout] 661 | / if let Some(img_data) = app.image_data.clone() { [INFO] [stdout] 662 | | if app.current_page + 2 < img_data.chapter.data.len() { [INFO] [stdout] 663 | | app.current_page += 2; [INFO] [stdout] 664 | | load_spread(app, client.http_client(), &img_data, page_tx, proto_tx).await; [INFO] [stdout] 665 | | } [INFO] [stdout] 666 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 661 ~ if let Some(img_data) = app.image_data.clone() [INFO] [stdout] 662 ~ && app.current_page + 2 < img_data.chapter.data.len() { [INFO] [stdout] 663 | app.current_page += 2; [INFO] [stdout] 664 | load_spread(app, client.http_client(), &img_data, page_tx, proto_tx).await; [INFO] [stdout] 665 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:669:17 [INFO] [stdout] | [INFO] [stdout] 669 | / if let Some(img_data) = app.image_data.clone() { [INFO] [stdout] 670 | | if app.current_page >= 2 { [INFO] [stdout] 671 | | app.current_page -= 2; [INFO] [stdout] 672 | | load_spread(app, client.http_client(), &img_data, page_tx, proto_tx).await; [INFO] [stdout] 673 | | } [INFO] [stdout] 674 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 669 ~ if let Some(img_data) = app.image_data.clone() [INFO] [stdout] 670 ~ && app.current_page >= 2 { [INFO] [stdout] 671 | app.current_page -= 2; [INFO] [stdout] 672 | load_spread(app, client.http_client(), &img_data, page_tx, proto_tx).await; [INFO] [stdout] 673 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:705:31 [INFO] [stdout] | [INFO] [stdout] 705 | let needs_proto = app [INFO] [stdout] | _______________________________^ [INFO] [stdout] 706 | | .proto_cache [INFO] [stdout] 707 | | .get(&(current, false)) [INFO] [stdout] 708 | | .map_or(true, |(a, _)| { [INFO] [stdout] 709 | | a.width != app.last_right_area.width || a.height != app.last_right_area.height [INFO] [stdout] 710 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 708 - .map_or(true, |(a, _)| { [INFO] [stdout] 708 + .is_none_or(|(a, _)| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:738:35 [INFO] [stdout] | [INFO] [stdout] 738 | let needs_proto = app.proto_cache.get(&(next, true)).map_or(true, |(a, _)| { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 739 | | a.width != app.last_left_area.width || a.height != app.last_left_area.height [INFO] [stdout] 740 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 738 - let needs_proto = app.proto_cache.get(&(next, true)).map_or(true, |(a, _)| { [INFO] [stdout] 738 + let needs_proto = app.proto_cache.get(&(next, true)).is_none_or(|(a, _)| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:811:12 [INFO] [stdout] | [INFO] [stdout] 811 | if resp.content_length().map_or(false, |len| len > MAX_IMAGE_BYTES) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 811 - if resp.content_length().map_or(false, |len| len > MAX_IMAGE_BYTES) { [INFO] [stdout] 811 + if resp.content_length().is_some_and(|len| len > MAX_IMAGE_BYTES) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 111 | / if app.page_cache.len() > app::MAX_CACHE_PAGES { [INFO] [stdout] 112 | | if let Some(&evict_idx) = app.page_cache.keys().max_by_key(|&&k| { [INFO] [stdout] 113 | | (k as isize - app.current_page as isize).unsigned_abs() [INFO] [stdout] 114 | | }) { [INFO] [stdout] ... | [INFO] [stdout] 119 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 111 ~ if app.page_cache.len() > app::MAX_CACHE_PAGES [INFO] [stdout] 112 ~ && let Some(&evict_idx) = app.page_cache.keys().max_by_key(|&&k| { [INFO] [stdout] 113 | (k as isize - app.current_page as isize).unsigned_abs() [INFO] [stdout] ... [INFO] [stdout] 117 | app.proto_cache.remove(&(evict_idx, false)); [INFO] [stdout] 118 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | / if crossterm::event::poll(std::time::Duration::from_millis(16))? { [INFO] [stdout] 137 | | if let crossterm::event::Event::Key(key) = crossterm::event::read()? { [INFO] [stdout] 138 | | if key.code == crossterm::event::KeyCode::Esc { [INFO] [stdout] 139 | | break; [INFO] [stdout] ... | [INFO] [stdout] 144 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 136 ~ if crossterm::event::poll(std::time::Duration::from_millis(16))? [INFO] [stdout] 137 ~ && let crossterm::event::Event::Key(key) = crossterm::event::read()? { [INFO] [stdout] 138 | if key.code == crossterm::event::KeyCode::Esc { [INFO] [stdout] ... [INFO] [stdout] 142 | } [INFO] [stdout] 143 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:473:23 [INFO] [stdout] | [INFO] [stdout] 473 | let cache_valid = app [INFO] [stdout] | _______________________^ [INFO] [stdout] 474 | | .proto_cache [INFO] [stdout] 475 | | .get(&(page_idx, is_left)) [INFO] [stdout] 476 | | .map_or(false, |(cached_area, _)| { [INFO] [stdout] 477 | | cached_area.width == area.width && cached_area.height == area.height [INFO] [stdout] 478 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 476 - .map_or(false, |(cached_area, _)| { [INFO] [stdout] 476 + .is_some_and(|(cached_area, _)| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:609:17 [INFO] [stdout] | [INFO] [stdout] 609 | / if app.selected_index + 1 < app.search_result.len() { [INFO] [stdout] 610 | | app.selected_index += 1; [INFO] [stdout] 611 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 608 ~ KeyCode::Down [INFO] [stdout] 609 ~ if app.selected_index + 1 < app.search_result.len() => { [INFO] [stdout] 610 | app.selected_index += 1; [INFO] [stdout] 611 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:621:17 [INFO] [stdout] | [INFO] [stdout] 621 | / if app.selected_index + 1 < app.chapters.len() { [INFO] [stdout] 622 | | app.selected_index += 1; [INFO] [stdout] 623 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 620 ~ KeyCode::Down [INFO] [stdout] 621 ~ if app.selected_index + 1 < app.chapters.len() => { [INFO] [stdout] 622 | app.selected_index += 1; [INFO] [stdout] 623 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:661:17 [INFO] [stdout] | [INFO] [stdout] 661 | / if let Some(img_data) = app.image_data.clone() { [INFO] [stdout] 662 | | if app.current_page + 2 < img_data.chapter.data.len() { [INFO] [stdout] 663 | | app.current_page += 2; [INFO] [stdout] 664 | | load_spread(app, client.http_client(), &img_data, page_tx, proto_tx).await; [INFO] [stdout] 665 | | } [INFO] [stdout] 666 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 661 ~ if let Some(img_data) = app.image_data.clone() [INFO] [stdout] 662 ~ && app.current_page + 2 < img_data.chapter.data.len() { [INFO] [stdout] 663 | app.current_page += 2; [INFO] [stdout] 664 | load_spread(app, client.http_client(), &img_data, page_tx, proto_tx).await; [INFO] [stdout] 665 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:669:17 [INFO] [stdout] | [INFO] [stdout] 669 | / if let Some(img_data) = app.image_data.clone() { [INFO] [stdout] 670 | | if app.current_page >= 2 { [INFO] [stdout] 671 | | app.current_page -= 2; [INFO] [stdout] 672 | | load_spread(app, client.http_client(), &img_data, page_tx, proto_tx).await; [INFO] [stdout] 673 | | } [INFO] [stdout] 674 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 669 ~ if let Some(img_data) = app.image_data.clone() [INFO] [stdout] 670 ~ && app.current_page >= 2 { [INFO] [stdout] 671 | app.current_page -= 2; [INFO] [stdout] 672 | load_spread(app, client.http_client(), &img_data, page_tx, proto_tx).await; [INFO] [stdout] 673 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:705:31 [INFO] [stdout] | [INFO] [stdout] 705 | let needs_proto = app [INFO] [stdout] | _______________________________^ [INFO] [stdout] 706 | | .proto_cache [INFO] [stdout] 707 | | .get(&(current, false)) [INFO] [stdout] 708 | | .map_or(true, |(a, _)| { [INFO] [stdout] 709 | | a.width != app.last_right_area.width || a.height != app.last_right_area.height [INFO] [stdout] 710 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 708 - .map_or(true, |(a, _)| { [INFO] [stdout] 708 + .is_none_or(|(a, _)| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:738:35 [INFO] [stdout] | [INFO] [stdout] 738 | let needs_proto = app.proto_cache.get(&(next, true)).map_or(true, |(a, _)| { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 739 | | a.width != app.last_left_area.width || a.height != app.last_left_area.height [INFO] [stdout] 740 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 738 - let needs_proto = app.proto_cache.get(&(next, true)).map_or(true, |(a, _)| { [INFO] [stdout] 738 + let needs_proto = app.proto_cache.get(&(next, true)).is_none_or(|(a, _)| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:811:12 [INFO] [stdout] | [INFO] [stdout] 811 | if resp.content_length().map_or(false, |len| len > MAX_IMAGE_BYTES) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 811 - if resp.content_length().map_or(false, |len| len > MAX_IMAGE_BYTES) { [INFO] [stdout] 811 + if resp.content_length().is_some_and(|len| len > MAX_IMAGE_BYTES) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 09s [INFO] running `Command { std: "docker" "inspect" "6b2635dfaa202541e4589b43720abdb61ec2a765740b4009f0d33d64500fdde6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b2635dfaa202541e4589b43720abdb61ec2a765740b4009f0d33d64500fdde6", kill_on_drop: false }` [INFO] [stdout] 6b2635dfaa202541e4589b43720abdb61ec2a765740b4009f0d33d64500fdde6