[INFO] cloning repository https://github.com/Aure-git/game_of_life [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Aure-git/game_of_life" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAure-git%2Fgame_of_life", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAure-git%2Fgame_of_life'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e31bfbab110bcbe9d0cadf3a8b503b06038ad6cd [INFO] linting Aure-git/game_of_life against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAure-git%2Fgame_of_life" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Aure-git/game_of_life [INFO] finished tweaking git repo https://github.com/Aure-git/game_of_life [INFO] tweaked toml for git repo https://github.com/Aure-git/game_of_life written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Aure-git/game_of_life on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Aure-git/game_of_life already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cmake v0.1.51 [INFO] [stderr] Downloaded pistoncore-event_loop v1.0.0 [INFO] [stderr] Downloaded piston v1.0.0 [INFO] [stderr] Downloaded spin_sleep v1.2.1 [INFO] [stderr] Downloaded piston2d-opengl_graphics v0.85.1 [INFO] [stderr] Downloaded pistoncore-glfw_window v0.81.0 [INFO] [stderr] Downloaded glfw v0.56.0 [INFO] [stderr] Downloaded cc v1.1.19 [INFO] [stderr] Downloaded glfw-sys v5.0.0+3.3.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9385a1c4018990ae39308b3e3992f3cb6fca1936f8e16e243962efd6086e2460 [INFO] running `Command { std: "docker" "start" "-a" "9385a1c4018990ae39308b3e3992f3cb6fca1936f8e16e243962efd6086e2460", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9385a1c4018990ae39308b3e3992f3cb6fca1936f8e16e243962efd6086e2460", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9385a1c4018990ae39308b3e3992f3cb6fca1936f8e16e243962efd6086e2460", kill_on_drop: false }` [INFO] [stdout] 9385a1c4018990ae39308b3e3992f3cb6fca1936f8e16e243962efd6086e2460 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 95662e691f551fd0ce2de52c85f132a1ab6f677bc7ba6c05b4251c926a598624 [INFO] running `Command { std: "docker" "start" "-a" "95662e691f551fd0ce2de52c85f132a1ab6f677bc7ba6c05b4251c926a598624", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Checking aligned-vec v0.5.0 [INFO] [stderr] Compiling cc v1.1.19 [INFO] [stderr] Compiling xml-rs v0.8.22 [INFO] [stderr] Compiling built v0.7.4 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking bitstream-io v2.5.3 [INFO] [stderr] Checking imgref v1.10.1 [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking avif-serialize v0.8.1 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking zune-jpeg v0.4.13 [INFO] [stderr] Checking image-webp v0.1.3 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking v_frame v0.3.8 [INFO] [stderr] Compiling gl_generator v0.13.1 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking spin_sleep v1.2.1 [INFO] [stderr] Compiling glfw-sys v5.0.0+3.3.9 [INFO] [stderr] Compiling gl v0.13.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking av1-grain v0.2.3 [INFO] [stderr] Checking glfw v0.56.0 [INFO] [stderr] Compiling profiling-procmacros v1.0.15 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking pistoncore-input v1.0.1 [INFO] [stderr] Checking pistoncore-window v1.0.0 [INFO] [stderr] Checking pistoncore-event_loop v1.0.0 [INFO] [stderr] Checking pistoncore-glfw_window v0.81.0 [INFO] [stderr] Checking piston v1.0.0 [INFO] [stderr] Checking ravif v0.11.10 [INFO] [stderr] Checking image v0.25.2 [INFO] [stderr] Checking piston2d-opengl_graphics v0.85.1 [INFO] [stderr] Checking pistony v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/grid.rs:54:16 [INFO] [stdout] | [INFO] [stdout] 54 | if !(dx == 0 && col == 0) && !(dx == 2 && col == self.cols-1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(dx == 0 && col == 0 || dx == 2 && col == self.cols-1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/grid.rs:56:24 [INFO] [stdout] | [INFO] [stdout] 56 | if !(dy == 0 && row == 0) && !(dy == 2 && row == self.rows-1) && !(dx == dy && dx == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(dy == 0 && row == 0 || dy == 2 && row == self.rows-1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/game/grid.rs:56:21 [INFO] [stdout] | [INFO] [stdout] 56 | / if !(dy == 0 && row == 0) && !(dy == 2 && row == self.rows-1) && !(dx == dy && dx == 1) { [INFO] [stdout] 57 | | if self.values[row + dy -1][col + dx -1] { [INFO] [stdout] 58 | | count += 1; [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 56 ~ if !(dy == 0 && row == 0) && !(dy == 2 && row == self.rows-1) && !(dx == dy && dx == 1) [INFO] [stdout] 57 ~ && self.values[row + dy -1][col + dx -1] { [INFO] [stdout] 58 | count += 1; [INFO] [stdout] 59 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `new_values` [INFO] [stdout] --> src/game/grid.rs:73:20 [INFO] [stdout] | [INFO] [stdout] 73 | for row in 0..self.rows { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 73 - for row in 0..self.rows { [INFO] [stdout] 73 + for (row, ) in new_values.iter_mut().enumerate().take(self.rows) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `col` is used to index `new_values` [INFO] [stdout] --> src/game/grid.rs:74:24 [INFO] [stdout] | [INFO] [stdout] 74 | for col in 0..self.cols { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 74 - for col in 0..self.cols { [INFO] [stdout] 74 + for (col, ) in new_values.iter_mut().enumerate().take(self.cols) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game/grid.rs:76:92 [INFO] [stdout] | [INFO] [stdout] 76 | if self.values[row][col] && (alive_neighbors == 2 || alive_neighbors == 3) { [INFO] [stdout] | ____________________________________________________________________________________________^ [INFO] [stdout] 77 | | new_values[row][col] = true; [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game/grid.rs:79:46 [INFO] [stdout] | [INFO] [stdout] 79 | else if alive_neighbors == 3 { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 80 | | new_values[row][col] = true; [INFO] [stdout] 81 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/game/positions.rs:40:30 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn to_world_position(self) -> WorldPosition { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/game/positions.rs:44:31 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn to_screen_position(self, camera: &Camera) -> Option { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/grid.rs:54:16 [INFO] [stdout] | [INFO] [stdout] 54 | if !(dx == 0 && col == 0) && !(dx == 2 && col == self.cols-1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(dx == 0 && col == 0 || dx == 2 && col == self.cols-1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game/grid.rs:56:24 [INFO] [stdout] | [INFO] [stdout] 56 | if !(dy == 0 && row == 0) && !(dy == 2 && row == self.rows-1) && !(dx == dy && dx == 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(dy == 0 && row == 0 || dy == 2 && row == self.rows-1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/game/grid.rs:56:21 [INFO] [stdout] | [INFO] [stdout] 56 | / if !(dy == 0 && row == 0) && !(dy == 2 && row == self.rows-1) && !(dx == dy && dx == 1) { [INFO] [stdout] 57 | | if self.values[row + dy -1][col + dx -1] { [INFO] [stdout] 58 | | count += 1; [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 56 ~ if !(dy == 0 && row == 0) && !(dy == 2 && row == self.rows-1) && !(dx == dy && dx == 1) [INFO] [stdout] 57 ~ && self.values[row + dy -1][col + dx -1] { [INFO] [stdout] 58 | count += 1; [INFO] [stdout] 59 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `new_values` [INFO] [stdout] --> src/game/grid.rs:73:20 [INFO] [stdout] | [INFO] [stdout] 73 | for row in 0..self.rows { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 73 - for row in 0..self.rows { [INFO] [stdout] 73 + for (row, ) in new_values.iter_mut().enumerate().take(self.rows) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `col` is used to index `new_values` [INFO] [stdout] --> src/game/grid.rs:74:24 [INFO] [stdout] | [INFO] [stdout] 74 | for col in 0..self.cols { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 74 - for col in 0..self.cols { [INFO] [stdout] 74 + for (col, ) in new_values.iter_mut().enumerate().take(self.cols) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game/grid.rs:76:92 [INFO] [stdout] | [INFO] [stdout] 76 | if self.values[row][col] && (alive_neighbors == 2 || alive_neighbors == 3) { [INFO] [stdout] | ____________________________________________________________________________________________^ [INFO] [stdout] 77 | | new_values[row][col] = true; [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game/grid.rs:79:46 [INFO] [stdout] | [INFO] [stdout] 79 | else if alive_neighbors == 3 { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 80 | | new_values[row][col] = true; [INFO] [stdout] 81 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/game/positions.rs:40:30 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn to_world_position(self) -> WorldPosition { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/game/positions.rs:44:31 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn to_screen_position(self, camera: &Camera) -> Option { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[[f64; 3]; 2]` which implements the `Copy` trait [INFO] [stdout] --> src/game.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 94 | ... transform.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `transform` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/game.rs:278:17 [INFO] [stdout] | [INFO] [stdout] 278 | / match mouse_button { [INFO] [stdout] 279 | | MouseButton::Left => { [INFO] [stdout] 280 | | self.pressed_buttons.insert(Button::Mouse(MouseButton::Left)); [INFO] [stdout] 281 | | if let Some(mouse_position) = self.mouse_coords { [INFO] [stdout] ... | [INFO] [stdout] 285 | | _ => {} [INFO] [stdout] 286 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/game.rs:277:27 [INFO] [stdout] | [INFO] [stdout] 277 | Button::Mouse(mouse_button) => { [INFO] [stdout] | ^^^^^^^^^^^^ replace this binding [INFO] [stdout] 278 | match mouse_button { [INFO] [stdout] 279 | MouseButton::Left => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/game.rs:278:17 [INFO] [stdout] | [INFO] [stdout] 278 | / match mouse_button { [INFO] [stdout] 279 | | MouseButton::Left => { [INFO] [stdout] 280 | | self.pressed_buttons.insert(Button::Mouse(MouseButton::Left)); [INFO] [stdout] 281 | | if let Some(mouse_position) = self.mouse_coords { [INFO] [stdout] ... | [INFO] [stdout] 285 | | _ => {} [INFO] [stdout] 286 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 278 ~ if mouse_button == MouseButton::Left { [INFO] [stdout] 279 + self.pressed_buttons.insert(Button::Mouse(MouseButton::Left)); [INFO] [stdout] 280 + if let Some(mouse_position) = self.mouse_coords { [INFO] [stdout] 281 + self.edit_at_position(mouse_position); [INFO] [stdout] 282 + } [INFO] [stdout] 283 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[[f64; 3]; 2]` which implements the `Copy` trait [INFO] [stdout] --> src/game.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 94 | ... transform.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `transform` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/game.rs:312:17 [INFO] [stdout] | [INFO] [stdout] 312 | / match mouse_button { [INFO] [stdout] 313 | | MouseButton::Left => { [INFO] [stdout] 314 | | self.pressed_buttons.remove(&Button::Mouse(MouseButton::Left)); [INFO] [stdout] 315 | | self.changed_tiles.clear(); [INFO] [stdout] 316 | | }, [INFO] [stdout] 317 | | _ => {} [INFO] [stdout] 318 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/game.rs:311:27 [INFO] [stdout] | [INFO] [stdout] 311 | Button::Mouse(mouse_button) => { [INFO] [stdout] | ^^^^^^^^^^^^ replace this binding [INFO] [stdout] 312 | match mouse_button { [INFO] [stdout] 313 | MouseButton::Left => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/game.rs:301:31 [INFO] [stdout] | [INFO] [stdout] 301 | Key::C => if self.state == GameState::Pause {self.clear()}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 301 - Key::C => if self.state == GameState::Pause {self.clear()}, [INFO] [stdout] 301 + Key::Cf self.state == GameState::Pause => {self.clear(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/game.rs:312:17 [INFO] [stdout] | [INFO] [stdout] 312 | / match mouse_button { [INFO] [stdout] 313 | | MouseButton::Left => { [INFO] [stdout] 314 | | self.pressed_buttons.remove(&Button::Mouse(MouseButton::Left)); [INFO] [stdout] 315 | | self.changed_tiles.clear(); [INFO] [stdout] 316 | | }, [INFO] [stdout] 317 | | _ => {} [INFO] [stdout] 318 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 312 ~ if mouse_button == MouseButton::Left { [INFO] [stdout] 313 + self.pressed_buttons.remove(&Button::Mouse(MouseButton::Left)); [INFO] [stdout] 314 + self.changed_tiles.clear(); [INFO] [stdout] 315 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/game.rs:278:17 [INFO] [stdout] | [INFO] [stdout] 278 | / match mouse_button { [INFO] [stdout] 279 | | MouseButton::Left => { [INFO] [stdout] 280 | | self.pressed_buttons.insert(Button::Mouse(MouseButton::Left)); [INFO] [stdout] 281 | | if let Some(mouse_position) = self.mouse_coords { [INFO] [stdout] ... | [INFO] [stdout] 285 | | _ => {} [INFO] [stdout] 286 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/game.rs:277:27 [INFO] [stdout] | [INFO] [stdout] 277 | Button::Mouse(mouse_button) => { [INFO] [stdout] | ^^^^^^^^^^^^ replace this binding [INFO] [stdout] 278 | match mouse_button { [INFO] [stdout] 279 | MouseButton::Left => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/game.rs:278:17 [INFO] [stdout] | [INFO] [stdout] 278 | / match mouse_button { [INFO] [stdout] 279 | | MouseButton::Left => { [INFO] [stdout] 280 | | self.pressed_buttons.insert(Button::Mouse(MouseButton::Left)); [INFO] [stdout] 281 | | if let Some(mouse_position) = self.mouse_coords { [INFO] [stdout] ... | [INFO] [stdout] 285 | | _ => {} [INFO] [stdout] 286 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 278 ~ if mouse_button == MouseButton::Left { [INFO] [stdout] 279 + self.pressed_buttons.insert(Button::Mouse(MouseButton::Left)); [INFO] [stdout] 280 + if let Some(mouse_position) = self.mouse_coords { [INFO] [stdout] 281 + self.edit_at_position(mouse_position); [INFO] [stdout] 282 + } [INFO] [stdout] 283 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/game.rs:312:17 [INFO] [stdout] | [INFO] [stdout] 312 | / match mouse_button { [INFO] [stdout] 313 | | MouseButton::Left => { [INFO] [stdout] 314 | | self.pressed_buttons.remove(&Button::Mouse(MouseButton::Left)); [INFO] [stdout] 315 | | self.changed_tiles.clear(); [INFO] [stdout] 316 | | }, [INFO] [stdout] 317 | | _ => {} [INFO] [stdout] 318 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/game.rs:311:27 [INFO] [stdout] | [INFO] [stdout] 311 | Button::Mouse(mouse_button) => { [INFO] [stdout] | ^^^^^^^^^^^^ replace this binding [INFO] [stdout] 312 | match mouse_button { [INFO] [stdout] 313 | MouseButton::Left => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/game.rs:301:31 [INFO] [stdout] | [INFO] [stdout] 301 | Key::C => if self.state == GameState::Pause {self.clear()}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 301 - Key::C => if self.state == GameState::Pause {self.clear()}, [INFO] [stdout] 301 + Key::Cf self.state == GameState::Pause => {self.clear(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/game.rs:312:17 [INFO] [stdout] | [INFO] [stdout] 312 | / match mouse_button { [INFO] [stdout] 313 | | MouseButton::Left => { [INFO] [stdout] 314 | | self.pressed_buttons.remove(&Button::Mouse(MouseButton::Left)); [INFO] [stdout] 315 | | self.changed_tiles.clear(); [INFO] [stdout] 316 | | }, [INFO] [stdout] 317 | | _ => {} [INFO] [stdout] 318 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 312 ~ if mouse_button == MouseButton::Left { [INFO] [stdout] 313 + self.pressed_buttons.remove(&Button::Mouse(MouseButton::Left)); [INFO] [stdout] 314 + self.changed_tiles.clear(); [INFO] [stdout] 315 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.61s [INFO] running `Command { std: "docker" "inspect" "95662e691f551fd0ce2de52c85f132a1ab6f677bc7ba6c05b4251c926a598624", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95662e691f551fd0ce2de52c85f132a1ab6f677bc7ba6c05b4251c926a598624", kill_on_drop: false }` [INFO] [stdout] 95662e691f551fd0ce2de52c85f132a1ab6f677bc7ba6c05b4251c926a598624