[INFO] cloning repository https://github.com/AuraPy/tmprs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AuraPy/tmprs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAuraPy%2Ftmprs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAuraPy%2Ftmprs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 13fdf8ca57423579ee649fec249ab6209766424f [INFO] linting AuraPy/tmprs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAuraPy%2Ftmprs" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] [stderr] Updating files: 70% (7835/11144) Updating files: 71% (7913/11144) Updating files: 72% (8024/11144) Updating files: 73% (8136/11144) Updating files: 74% (8247/11144) Updating files: 75% (8358/11144) Updating files: 76% (8470/11144) Updating files: 77% (8581/11144) Updating files: 78% (8693/11144) Updating files: 79% (8804/11144) Updating files: 80% (8916/11144) Updating files: 81% (9027/11144) Updating files: 82% (9139/11144) Updating files: 83% (9250/11144) Updating files: 84% (9361/11144) Updating files: 85% (9473/11144) Updating files: 86% (9584/11144) Updating files: 87% (9696/11144) Updating files: 88% (9807/11144) Updating files: 89% (9919/11144) Updating files: 90% (10030/11144) Updating files: 91% (10142/11144) Updating files: 92% (10253/11144) Updating files: 93% (10364/11144) Updating files: 94% (10476/11144) Updating files: 94% (10477/11144) Updating files: 95% (10587/11144) Updating files: 96% (10699/11144) Updating files: 97% (10810/11144) Updating files: 98% (10922/11144) Updating files: 99% (11033/11144) Updating files: 100% (11144/11144) Updating files: 100% (11144/11144), done. [INFO] started tweaking git repo https://github.com/AuraPy/tmprs [INFO] finished tweaking git repo https://github.com/AuraPy/tmprs [INFO] tweaked toml for git repo https://github.com/AuraPy/tmprs written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/AuraPy/tmprs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/AuraPy/tmprs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: source [INFO] [stderr] help: source is a valid .cargo/config.toml key [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cc v1.1.14 [INFO] [stderr] Downloaded rodio v0.19.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d95962c3ccce15db22239a5a635a3df52acacd529df2e58e4f3b0aa4a41154a9 [INFO] running `Command { std: "docker" "start" "-a" "d95962c3ccce15db22239a5a635a3df52acacd529df2e58e4f3b0aa4a41154a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d95962c3ccce15db22239a5a635a3df52acacd529df2e58e4f3b0aa4a41154a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d95962c3ccce15db22239a5a635a3df52acacd529df2e58e4f3b0aa4a41154a9", kill_on_drop: false }` [INFO] [stdout] d95962c3ccce15db22239a5a635a3df52acacd529df2e58e4f3b0aa4a41154a9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a33357553ae9121bf59c59fa85d1a1743efdd4b49e77dc313f304a3a9080fe3e [INFO] running `Command { std: "docker" "start" "-a" "a33357553ae9121bf59c59fa85d1a1743efdd4b49e77dc313f304a3a9080fe3e", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: source [INFO] [stderr] help: source is a valid .cargo/config.toml key [INFO] [stderr] Checking bytemuck v1.17.0 [INFO] [stderr] Compiling cpal v0.15.3 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking ogg v0.8.0 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Checking symphonia-core v0.5.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking alsa v0.9.1 [INFO] [stderr] Checking symphonia-metadata v0.5.4 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.4 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking symphonia v0.5.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking rodio v0.19.0 [INFO] [stderr] Checking tmprs v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 144 | if !(repeat.is_none()) && sink.empty() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `repeat.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `files` [INFO] [stdout] --> src/main.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | for i in scroll_start..scroll_end { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 48 - for i in scroll_start..scroll_end { [INFO] [stdout] 48 + for (i, ) in files.iter().enumerate().take(scroll_end).skip(scroll_start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | / if selected_index > 0 { [INFO] [stdout] 70 | | selected_index -= 1; [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 68 ~ KeyCode::Up [INFO] [stdout] 69 ~ if selected_index > 0 => { [INFO] [stdout] 70 | selected_index -= 1; [INFO] [stdout] 71 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 74 | / if selected_index < files.len().saturating_sub(1) { [INFO] [stdout] 75 | | selected_index += 1; [INFO] [stdout] 76 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 73 ~ KeyCode::Down [INFO] [stdout] 74 ~ if selected_index < files.len().saturating_sub(1) => { [INFO] [stdout] 75 | selected_index += 1; [INFO] [stdout] 76 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 79 | / if repeat.is_none() { [INFO] [stdout] 80 | | let file_path = files[selected_index].clone(); [INFO] [stdout] 81 | | match File::open(&file_path) { [INFO] [stdout] 82 | | Ok(file) => { [INFO] [stdout] ... | [INFO] [stdout] 99 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 78 ~ KeyCode::Enter [INFO] [stdout] 79 ~ if repeat.is_none() => { [INFO] [stdout] 80 | let file_path = files[selected_index].clone(); [INFO] [stdout] ... [INFO] [stdout] 98 | } [INFO] [stdout] 99 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/main.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | / if selected_index > 0 { [INFO] [stdout] 70 | | selected_index -= 1; [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________________________^ help: try: `selected_index = selected_index.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/main.rs:117:25 [INFO] [stdout] | [INFO] [stdout] 117 | / if playlist { [INFO] [stdout] 118 | | playlist = false [INFO] [stdout] 119 | | } else { [INFO] [stdout] 120 | | playlist = true [INFO] [stdout] 121 | | } [INFO] [stdout] | |_________________________^ help: you can reduce it to: `playlist = !playlist;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 144 | if !(repeat.is_none()) && sink.empty() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `repeat.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `files` [INFO] [stdout] --> src/main.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | for i in scroll_start..scroll_end { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 48 - for i in scroll_start..scroll_end { [INFO] [stdout] 48 + for (i, ) in files.iter().enumerate().take(scroll_end).skip(scroll_start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | / if selected_index > 0 { [INFO] [stdout] 70 | | selected_index -= 1; [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 68 ~ KeyCode::Up [INFO] [stdout] 69 ~ if selected_index > 0 => { [INFO] [stdout] 70 | selected_index -= 1; [INFO] [stdout] 71 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 74 | / if selected_index < files.len().saturating_sub(1) { [INFO] [stdout] 75 | | selected_index += 1; [INFO] [stdout] 76 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 73 ~ KeyCode::Down [INFO] [stdout] 74 ~ if selected_index < files.len().saturating_sub(1) => { [INFO] [stdout] 75 | selected_index += 1; [INFO] [stdout] 76 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 79 | / if repeat.is_none() { [INFO] [stdout] 80 | | let file_path = files[selected_index].clone(); [INFO] [stdout] 81 | | match File::open(&file_path) { [INFO] [stdout] 82 | | Ok(file) => { [INFO] [stdout] ... | [INFO] [stdout] 99 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 78 ~ KeyCode::Enter [INFO] [stdout] 79 ~ if repeat.is_none() => { [INFO] [stdout] 80 | let file_path = files[selected_index].clone(); [INFO] [stdout] ... [INFO] [stdout] 98 | } [INFO] [stdout] 99 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/main.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | / if selected_index > 0 { [INFO] [stdout] 70 | | selected_index -= 1; [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________________________^ help: try: `selected_index = selected_index.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/main.rs:117:25 [INFO] [stdout] | [INFO] [stdout] 117 | / if playlist { [INFO] [stdout] 118 | | playlist = false [INFO] [stdout] 119 | | } else { [INFO] [stdout] 120 | | playlist = true [INFO] [stdout] 121 | | } [INFO] [stdout] | |_________________________^ help: you can reduce it to: `playlist = !playlist;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.57s [INFO] running `Command { std: "docker" "inspect" "a33357553ae9121bf59c59fa85d1a1743efdd4b49e77dc313f304a3a9080fe3e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a33357553ae9121bf59c59fa85d1a1743efdd4b49e77dc313f304a3a9080fe3e", kill_on_drop: false }` [INFO] [stdout] a33357553ae9121bf59c59fa85d1a1743efdd4b49e77dc313f304a3a9080fe3e