[INFO] cloning repository https://github.com/Astri4-4/audio_player [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Astri4-4/audio_player" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAstri4-4%2Faudio_player", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAstri4-4%2Faudio_player'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e30bee93983b091dd706db10ce9b6aec2c46dfc4 [INFO] linting Astri4-4/audio_player against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAstri4-4%2Faudio_player" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Astri4-4/audio_player [INFO] finished tweaking git repo https://github.com/Astri4-4/audio_player [INFO] tweaked toml for git repo https://github.com/Astri4-4/audio_player written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Astri4-4/audio_player on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Astri4-4/audio_player already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded mp3-duration v0.1.10 [INFO] [stderr] Downloaded wgpu-hal v24.0.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e2e3b3ee4b8851dc9302e7dbfd2b84ed4d5de6fb8c3eb33fa314f230d4380920 [INFO] running `Command { std: "docker" "start" "-a" "e2e3b3ee4b8851dc9302e7dbfd2b84ed4d5de6fb8c3eb33fa314f230d4380920", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e2e3b3ee4b8851dc9302e7dbfd2b84ed4d5de6fb8c3eb33fa314f230d4380920", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e2e3b3ee4b8851dc9302e7dbfd2b84ed4d5de6fb8c3eb33fa314f230d4380920", kill_on_drop: false }` [INFO] [stdout] e2e3b3ee4b8851dc9302e7dbfd2b84ed4d5de6fb8c3eb33fa314f230d4380920 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c2555b580a3f1480ef7c63d8b9f936c1bfe16ea935fe58734b5ebd2403d89333 [INFO] running `Command { std: "docker" "start" "-a" "c2555b580a3f1480ef7c63d8b9f936c1bfe16ea935fe58734b5ebd2403d89333", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.17 [INFO] [stderr] Compiling libc v0.2.170 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking smallvec v1.14.0 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling serde v1.0.218 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling winnow v0.7.3 [INFO] [stderr] Compiling indexmap v2.7.1 [INFO] [stderr] Checking libloading v0.8.6 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling wayland-sys v0.31.6 [INFO] [stderr] Compiling cc v1.2.16 [INFO] [stderr] Compiling proc-macro2 v1.0.94 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling wayland-client v0.31.8 [INFO] [stderr] Checking futures-lite v2.6.0 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling endi v1.1.0 [INFO] [stderr] Compiling quote v1.0.39 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Compiling quick-xml v0.37.2 [INFO] [stderr] Checking litemap v0.7.5 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking event-listener v5.4.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Compiling xml-rs v0.8.25 [INFO] [stderr] Compiling syn v2.0.99 [INFO] [stderr] Compiling log v0.4.26 [INFO] [stderr] Checking event-listener-strategy v0.5.3 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking cursor-icon v1.1.0 [INFO] [stderr] Checking xkeysym v0.2.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking xcursor v0.3.8 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking accesskit v0.17.1 [INFO] [stderr] Checking as-raw-xcb-connection v1.0.1 [INFO] [stderr] Checking x11rb-protocol v0.13.1 [INFO] [stderr] Checking foldhash v0.1.4 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Checking miniz_oxide v0.8.5 [INFO] [stderr] Compiling winit v0.30.9 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking async-executor v1.13.1 [INFO] [stderr] Checking immutable-chunkmap v2.0.6 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking flate2 v1.1.0 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling wayland-backend v0.3.8 [INFO] [stderr] Compiling wayland-scanner v0.31.6 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Checking dpi v0.1.1 [INFO] [stderr] Checking epaint_default_fonts v0.31.0 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking profiling v1.0.16 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling glutin v0.32.2 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling toml_edit v0.22.24 [INFO] [stderr] Checking memmap2 v0.9.5 [INFO] [stderr] Checking accesskit_consumer v0.26.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Compiling glutin-winit v0.5.0 [INFO] [stderr] Compiling cpal v0.15.3 [INFO] [stderr] Checking extended v0.1.0 [INFO] [stderr] Checking home v0.5.11 [INFO] [stderr] Checking tinyvec v1.9.0 [INFO] [stderr] Checking alsa v0.9.1 [INFO] [stderr] Checking owned_ttf_parser v0.25.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking glow v0.16.0 [INFO] [stderr] Checking ab_glyph v0.2.29 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking bytes v1.10.0 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking percentage v0.1.0 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling bytemuck_derive v1.8.1 [INFO] [stderr] Compiling serde_derive v1.0.218 [INFO] [stderr] Compiling enumflags2_derive v0.7.11 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling async-trait v0.1.87 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking bytemuck v1.22.0 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking symphonia-core v0.5.4 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking emath v0.31.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking image v0.25.5 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking mp3-duration v0.1.10 [INFO] [stderr] Checking wayland-protocols v0.32.6 [INFO] [stderr] Checking wayland-cursor v0.31.8 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking ecolor v0.31.0 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking async-io v2.4.0 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking epaint v0.31.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking symphonia-metadata v0.5.4 [INFO] [stderr] Checking symphonia-codec-adpcm v0.5.4 [INFO] [stderr] Checking symphonia-codec-pcm v0.5.4 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking symphonia-utils-xiph v0.5.4 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.4 [INFO] [stderr] Checking symphonia-format-riff v0.5.4 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking symphonia-codec-vorbis v0.5.4 [INFO] [stderr] Checking symphonia-format-ogg v0.5.4 [INFO] [stderr] Checking symphonia-format-mkv v0.5.4 [INFO] [stderr] Checking symphonia-bundle-flac v0.5.4 [INFO] [stderr] Checking egui v0.31.0 [INFO] [stderr] Checking symphonia v0.5.4 [INFO] [stderr] Checking rodio v0.20.1 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Compiling enumflags2 v0.7.11 [INFO] [stderr] Compiling quick-xml v0.30.0 [INFO] [stderr] Compiling zvariant v4.2.0 [INFO] [stderr] Checking egui_glow v0.31.0 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.6 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.6 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Compiling zbus_names v3.0.0 [INFO] [stderr] Checking webbrowser v1.0.3 [INFO] [stderr] Compiling zbus_xml v4.0.0 [INFO] [stderr] Checking arboard v3.4.1 [INFO] [stderr] Compiling zbus-lockstep v0.4.4 [INFO] [stderr] Checking zbus v4.4.0 [INFO] [stderr] Compiling zbus-lockstep-macros v0.4.4 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.2 [INFO] [stderr] Checking atspi-common v0.6.0 [INFO] [stderr] Checking atspi-proxies v0.6.0 [INFO] [stderr] Checking accesskit_atspi_common v0.10.1 [INFO] [stderr] Checking atspi-connection v0.6.0 [INFO] [stderr] Checking atspi v0.22.0 [INFO] [stderr] Checking accesskit_unix v0.13.1 [INFO] [stderr] Checking accesskit_winit v0.23.1 [INFO] [stderr] Checking egui-winit v0.31.0 [INFO] [stderr] Checking eframe v0.31.0 [INFO] [stderr] Checking audioPlayer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/file.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return paths_list [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return paths_list [INFO] [stdout] 13 + paths_list [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/audio.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return result; [INFO] [stdout] 37 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/audio.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return result_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return result_str; [INFO] [stdout] 59 + result_str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/audio.rs:55:25 [INFO] [stdout] | [INFO] [stdout] 55 | result_str.push_str(&audio_len_min.to_string().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `audio_len_min.to_string().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/audio.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | result_str.push_str(":"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result_str.push(':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/audio.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | return result_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return result_str; [INFO] [stdout] 79 + result_str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/audio.rs:75:25 [INFO] [stdout] | [INFO] [stdout] 75 | result_str.push_str(&audio_len_min.to_string().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `audio_len_min.to_string().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/audio.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | result_str.push_str(":"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result_str.push(':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/file.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return paths_list [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return paths_list [INFO] [stdout] 13 + paths_list [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/terminal.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | return input; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return input; [INFO] [stdout] 35 + input [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/audio.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return result; [INFO] [stdout] 37 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/audio.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return result_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return result_str; [INFO] [stdout] 59 + result_str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/audio.rs:55:25 [INFO] [stdout] | [INFO] [stdout] 55 | result_str.push_str(&audio_len_min.to_string().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `audio_len_min.to_string().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/terminal.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | to_print.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `to_print.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/audio.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | result_str.push_str(":"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result_str.push(':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/audio.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | return result_str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return result_str; [INFO] [stdout] 79 + result_str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/audio.rs:75:25 [INFO] [stdout] | [INFO] [stdout] 75 | result_str.push_str(&audio_len_min.to_string().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `audio_len_min.to_string().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/terminal.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | return crossterm::terminal::size().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return crossterm::terminal::size().unwrap(); [INFO] [stdout] 126 + crossterm::terminal::size().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/audio.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | result_str.push_str(":"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result_str.push(':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/terminal.rs:220:5 [INFO] [stdout] | [INFO] [stdout] 220 | return cursor_line; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - return cursor_line; [INFO] [stdout] 220 + cursor_line [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/terminal.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | return input; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return input; [INFO] [stdout] 35 + input [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `writing_cursor_line` is used as a loop counter [INFO] [stdout] --> src/terminal.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | for file in files { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `for (writing_cursor_line, file) in (0_i32..).zip(files.into_iter())` [INFO] [stdout] | [INFO] [stdout] = note: `writing_cursor_line` is of type `i32`, making it ineligible for `Iterator::enumerate` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/terminal.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | to_print.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `to_print.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/terminal.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | to_print.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `to_print.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/terminal.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | / if event::poll(std::time::Duration::from_millis(100)).unwrap() { [INFO] [stdout] 186 | | if let Event::Key(KeyEvent { code, kind, .. }) = event::read().unwrap() { [INFO] [stdout] 187 | | [INFO] [stdout] 188 | | if code == KeyCode::Down && kind == KeyEventKind::Press { [INFO] [stdout] ... | [INFO] [stdout] 206 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 185 ~ if event::poll(std::time::Duration::from_millis(100)).unwrap() [INFO] [stdout] 186 ~ && let Event::Key(KeyEvent { code, kind, .. }) = event::read().unwrap() { [INFO] [stdout] 187 | [INFO] [stdout] ... [INFO] [stdout] 204 | [INFO] [stdout] 205 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/terminal.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | return crossterm::terminal::size().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return crossterm::terminal::size().unwrap(); [INFO] [stdout] 126 + crossterm::terminal::size().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/terminal.rs:193:42 [INFO] [stdout] | [INFO] [stdout] 193 | if cursor_line > 0 as i32 { [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/terminal.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 209 | if action_btn == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `action_btn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/terminal.rs:220:5 [INFO] [stdout] | [INFO] [stdout] 220 | return cursor_line; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - return cursor_line; [INFO] [stdout] 220 + cursor_line [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `writing_cursor_line` is used as a loop counter [INFO] [stdout] --> src/terminal.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | for file in files { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `for (writing_cursor_line, file) in (0_i32..).zip(files.into_iter())` [INFO] [stdout] | [INFO] [stdout] = note: `writing_cursor_line` is of type `i32`, making it ineligible for `Iterator::enumerate` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/terminal.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | to_print.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `to_print.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | / if event::poll(std::time::Duration::from_millis(100)).unwrap() { [INFO] [stdout] 31 | | [INFO] [stdout] 32 | | if let Event::Key(KeyEvent { code, .. }) = event::read().unwrap() { [INFO] [stdout] ... | [INFO] [stdout] 40 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 30 ~ if event::poll(std::time::Duration::from_millis(100)).unwrap() [INFO] [stdout] 31 | [INFO] [stdout] 32 ~ && let Event::Key(KeyEvent { code, .. }) = event::read().unwrap() { [INFO] [stdout] 33 | [INFO] [stdout] ... [INFO] [stdout] 37 | [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | / if let Event::Key(KeyEvent { code, .. }) = event::read().unwrap() { [INFO] [stdout] 33 | | [INFO] [stdout] 34 | | if code == KeyCode::Char('q') { [INFO] [stdout] 35 | | break; [INFO] [stdout] ... | [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 32 ~ if let Event::Key(KeyEvent { code, .. }) = event::read().unwrap() [INFO] [stdout] 33 | [INFO] [stdout] 34 ~ && code == KeyCode::Char('q') { [INFO] [stdout] 35 | break; [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/terminal.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | / if event::poll(std::time::Duration::from_millis(100)).unwrap() { [INFO] [stdout] 186 | | if let Event::Key(KeyEvent { code, kind, .. }) = event::read().unwrap() { [INFO] [stdout] 187 | | [INFO] [stdout] 188 | | if code == KeyCode::Down && kind == KeyEventKind::Press { [INFO] [stdout] ... | [INFO] [stdout] 206 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 185 ~ if event::poll(std::time::Duration::from_millis(100)).unwrap() [INFO] [stdout] 186 ~ && let Event::Key(KeyEvent { code, kind, .. }) = event::read().unwrap() { [INFO] [stdout] 187 | [INFO] [stdout] ... [INFO] [stdout] 204 | [INFO] [stdout] 205 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/terminal.rs:193:42 [INFO] [stdout] | [INFO] [stdout] 193 | if cursor_line > 0 as i32 { [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/terminal.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 209 | if action_btn == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `action_btn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | / if event::poll(std::time::Duration::from_millis(100)).unwrap() { [INFO] [stdout] 31 | | [INFO] [stdout] 32 | | if let Event::Key(KeyEvent { code, .. }) = event::read().unwrap() { [INFO] [stdout] ... | [INFO] [stdout] 40 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 30 ~ if event::poll(std::time::Duration::from_millis(100)).unwrap() [INFO] [stdout] 31 | [INFO] [stdout] 32 ~ && let Event::Key(KeyEvent { code, .. }) = event::read().unwrap() { [INFO] [stdout] 33 | [INFO] [stdout] ... [INFO] [stdout] 37 | [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | / if let Event::Key(KeyEvent { code, .. }) = event::read().unwrap() { [INFO] [stdout] 33 | | [INFO] [stdout] 34 | | if code == KeyCode::Char('q') { [INFO] [stdout] 35 | | break; [INFO] [stdout] ... | [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 32 ~ if let Event::Key(KeyEvent { code, .. }) = event::read().unwrap() [INFO] [stdout] 33 | [INFO] [stdout] 34 ~ && code == KeyCode::Char('q') { [INFO] [stdout] 35 | break; [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 23s [INFO] running `Command { std: "docker" "inspect" "c2555b580a3f1480ef7c63d8b9f936c1bfe16ea935fe58734b5ebd2403d89333", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2555b580a3f1480ef7c63d8b9f936c1bfe16ea935fe58734b5ebd2403d89333", kill_on_drop: false }` [INFO] [stdout] c2555b580a3f1480ef7c63d8b9f936c1bfe16ea935fe58734b5ebd2403d89333