[INFO] cloning repository https://github.com/Astavie/fastnes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Astavie/fastnes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAstavie%2Ffastnes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAstavie%2Ffastnes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0892362b2c6b18710b135de589076ea5a412a17a [INFO] linting Astavie/fastnes against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAstavie%2Ffastnes" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Astavie/fastnes [INFO] finished tweaking git repo https://github.com/Astavie/fastnes [INFO] tweaked toml for git repo https://github.com/Astavie/fastnes written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Astavie/fastnes on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Astavie/fastnes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 20b2737d72955d3806e1fd939790c701c0f53f070c3fdd22eb16f7be7fd51a38 [INFO] running `Command { std: "docker" "start" "-a" "20b2737d72955d3806e1fd939790c701c0f53f070c3fdd22eb16f7be7fd51a38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "20b2737d72955d3806e1fd939790c701c0f53f070c3fdd22eb16f7be7fd51a38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "20b2737d72955d3806e1fd939790c701c0f53f070c3fdd22eb16f7be7fd51a38", kill_on_drop: false }` [INFO] [stdout] 20b2737d72955d3806e1fd939790c701c0f53f070c3fdd22eb16f7be7fd51a38 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3d6349f66dc1557b71ea75a4d277cbfe6af2954bb9baa6d89ee29d3a1572be08 [INFO] running `Command { std: "docker" "start" "-a" "3d6349f66dc1557b71ea75a4d277cbfe6af2954bb9baa6d89ee29d3a1572be08", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.64 [INFO] [stderr] Compiling unicode-ident v1.0.10 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling syn v2.0.25 [INFO] [stderr] Compiling darling_core v0.20.3 [INFO] [stderr] Compiling darling_macro v0.20.3 [INFO] [stderr] Compiling darling v0.20.3 [INFO] [stderr] Compiling enumset_derive v0.8.1 [INFO] [stderr] Checking enumset v1.1.2 [INFO] [stderr] Checking fastnes v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/ppu.rs:263:13 [INFO] [stdout] | [INFO] [stdout] 263 | / *i >= self [INFO] [stdout] 264 | | .vbl_started [INFO] [stdout] 265 | | .filter(|i| cycle < i + 20 * SCANLINE) [INFO] [stdout] 266 | | .unwrap_or(self.next_vbl) [INFO] [stdout] 267 | | - 241 * SCANLINE [INFO] [stdout] 268 | | + 1 [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] help: change it to [INFO] [stdout] | [INFO] [stdout] 263 ~ *i > self [INFO] [stdout] 264 + .vbl_started [INFO] [stdout] 265 + .filter(|i| cycle < i + 20 * SCANLINE) [INFO] [stdout] 266 + .unwrap_or(self.next_vbl) - 241 * SCANLINE [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/ppu.rs:263:13 [INFO] [stdout] | [INFO] [stdout] 263 | / *i >= self [INFO] [stdout] 264 | | .vbl_started [INFO] [stdout] 265 | | .filter(|i| cycle < i + 20 * SCANLINE) [INFO] [stdout] 266 | | .unwrap_or(self.next_vbl) [INFO] [stdout] 267 | | - 241 * SCANLINE [INFO] [stdout] 268 | | + 1 [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] help: change it to [INFO] [stdout] | [INFO] [stdout] 263 ~ *i > self [INFO] [stdout] 264 + .vbl_started [INFO] [stdout] 265 + .filter(|i| cycle < i + 20 * SCANLINE) [INFO] [stdout] 266 + .unwrap_or(self.next_vbl) - 241 * SCANLINE [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/cart.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / pub enum CartridgeEnum { [INFO] [stdout] 42 | | Empty, [INFO] [stdout] | | ----- the second-largest variant carries no data at all [INFO] [stdout] 43 | | $($mapper($mapper),)* [INFO] [stdout] | | ---------------- the largest variant contains at least 2080 bytes [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________^ the entire enum is at least 2080 bytes [INFO] [stdout] ... [INFO] [stdout] 108 | generate_cartridge_enum!(NROM); [INFO] [stdout] | ------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] = note: this warning originates in the macro `generate_cartridge_enum` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 43 - $($mapper($mapper),)* [INFO] [stdout] 43 + $($mapper(Box<$mapper>),)* [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPU` [INFO] [stdout] --> src/cpu.rs:668:5 [INFO] [stdout] | [INFO] [stdout] 668 | / pub fn new() -> Self { [INFO] [stdout] 669 | | CPU { [INFO] [stdout] 670 | | PC: 0, [INFO] [stdout] 671 | | SP: 0, [INFO] [stdout] ... | [INFO] [stdout] 681 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 667 + impl Default for CPU { [INFO] [stdout] 668 + fn default() -> Self { [INFO] [stdout] 669 + Self::new() [INFO] [stdout] 670 + } [INFO] [stdout] 671 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 2048]` which implements the `Copy` trait [INFO] [stdout] --> src/nes.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 26 | ram_internal: self.ram_internal.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.ram_internal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PPUMASK` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:164:6 [INFO] [stdout] | [INFO] [stdout] 164 | enum PPUMASK { [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Ppumask` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DummyPPU` is never constructed [INFO] [stdout] --> src/ppu.rs:35:19 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) struct DummyPPU; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `FastPPU` [INFO] [stdout] --> src/ppu.rs:214:5 [INFO] [stdout] | [INFO] [stdout] 214 | / pub fn new() -> Self { [INFO] [stdout] 215 | | FastPPU { [INFO] [stdout] 216 | | next_vbl: 241 * SCANLINE + 1, [INFO] [stdout] 217 | | next_nmi: None, [INFO] [stdout] ... | [INFO] [stdout] 245 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 213 + impl Default for FastPPU { [INFO] [stdout] 214 + fn default() -> Self { [INFO] [stdout] 215 + Self::new() [INFO] [stdout] 216 + } [INFO] [stdout] 217 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ppu.rs:271:12 [INFO] [stdout] | [INFO] [stdout] 271 | if !self.next_sprite_0.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.next_sprite_0.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/cart.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / pub enum CartridgeEnum { [INFO] [stdout] 42 | | Empty, [INFO] [stdout] | | ----- the second-largest variant carries no data at all [INFO] [stdout] 43 | | $($mapper($mapper),)* [INFO] [stdout] | | ---------------- the largest variant contains at least 2080 bytes [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________^ the entire enum is at least 2080 bytes [INFO] [stdout] ... [INFO] [stdout] 108 | generate_cartridge_enum!(NROM); [INFO] [stdout] | ------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] = note: this warning originates in the macro `generate_cartridge_enum` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 43 - $($mapper($mapper),)* [INFO] [stdout] 43 + $($mapper(Box<$mapper>),)* [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/ppu.rs:426:43 [INFO] [stdout] | [INFO] [stdout] 426 | ... u16::from(7 - u8::from(sprite_x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `u8::from()`: `sprite_x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/ppu.rs:434:52 [INFO] [stdout] | [INFO] [stdout] 434 | ... u16::from(height - 1 - u8::from(sprite_y)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `u8::from()`: `sprite_y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:505:37 [INFO] [stdout] | [INFO] [stdout] 505 | (true, true) => (attribute >> 0) & 0b11, // top left [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider reducing it to: `attribute` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/ppu.rs:648:20 [INFO] [stdout] | [INFO] [stdout] 648 | if addr >= 0x3F00 && addr < 0x3F20 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3F00..0x3F20).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/ppu.rs:718:32 [INFO] [stdout] | [INFO] [stdout] 718 | self.open = if addr >= 0x3F00 && addr < 0x3F20 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3F00..0x3F20).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/lib.rs:250:17 [INFO] [stdout] | [INFO] [stdout] 250 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPU` [INFO] [stdout] --> src/cpu.rs:668:5 [INFO] [stdout] | [INFO] [stdout] 668 | / pub fn new() -> Self { [INFO] [stdout] 669 | | CPU { [INFO] [stdout] 670 | | PC: 0, [INFO] [stdout] 671 | | SP: 0, [INFO] [stdout] ... | [INFO] [stdout] 681 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 667 + impl Default for CPU { [INFO] [stdout] 668 + fn default() -> Self { [INFO] [stdout] 669 + Self::new() [INFO] [stdout] 670 + } [INFO] [stdout] 671 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 2048]` which implements the `Copy` trait [INFO] [stdout] --> src/nes.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 26 | ram_internal: self.ram_internal.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.ram_internal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PPUMASK` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:164:6 [INFO] [stdout] | [INFO] [stdout] 164 | enum PPUMASK { [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Ppumask` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `FastPPU` [INFO] [stdout] --> src/ppu.rs:214:5 [INFO] [stdout] | [INFO] [stdout] 214 | / pub fn new() -> Self { [INFO] [stdout] 215 | | FastPPU { [INFO] [stdout] 216 | | next_vbl: 241 * SCANLINE + 1, [INFO] [stdout] 217 | | next_nmi: None, [INFO] [stdout] ... | [INFO] [stdout] 245 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 213 + impl Default for FastPPU { [INFO] [stdout] 214 + fn default() -> Self { [INFO] [stdout] 215 + Self::new() [INFO] [stdout] 216 + } [INFO] [stdout] 217 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ppu.rs:271:12 [INFO] [stdout] | [INFO] [stdout] 271 | if !self.next_sprite_0.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.next_sprite_0.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/ppu.rs:426:43 [INFO] [stdout] | [INFO] [stdout] 426 | ... u16::from(7 - u8::from(sprite_x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `u8::from()`: `sprite_x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/ppu.rs:434:52 [INFO] [stdout] | [INFO] [stdout] 434 | ... u16::from(height - 1 - u8::from(sprite_y)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `u8::from()`: `sprite_y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:505:37 [INFO] [stdout] | [INFO] [stdout] 505 | (true, true) => (attribute >> 0) & 0b11, // top left [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider reducing it to: `attribute` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/ppu.rs:648:20 [INFO] [stdout] | [INFO] [stdout] 648 | if addr >= 0x3F00 && addr < 0x3F20 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3F00..0x3F20).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/ppu.rs:718:32 [INFO] [stdout] | [INFO] [stdout] 718 | self.open = if addr >= 0x3F00 && addr < 0x3F20 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3F00..0x3F20).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.59s [INFO] running `Command { std: "docker" "inspect" "3d6349f66dc1557b71ea75a4d277cbfe6af2954bb9baa6d89ee29d3a1572be08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d6349f66dc1557b71ea75a4d277cbfe6af2954bb9baa6d89ee29d3a1572be08", kill_on_drop: false }` [INFO] [stdout] 3d6349f66dc1557b71ea75a4d277cbfe6af2954bb9baa6d89ee29d3a1572be08