[INFO] cloning repository https://github.com/AscenderTeam/attp-core [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AscenderTeam/attp-core" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAscenderTeam%2Fattp-core", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAscenderTeam%2Fattp-core'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ab5e514b0dac4df328cf6d5ee6e0945e4687ac53 [INFO] linting AscenderTeam/attp-core against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAscenderTeam%2Fattp-core" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/AscenderTeam/attp-core [INFO] finished tweaking git repo https://github.com/AscenderTeam/attp-core [INFO] tweaked toml for git repo https://github.com/AscenderTeam/attp-core written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/AscenderTeam/attp-core on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/AscenderTeam/attp-core already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pyo3-macros v0.26.0 [INFO] [stderr] Downloaded pyo3-build-config v0.26.0 [INFO] [stderr] Downloaded pyo3-macros-backend v0.26.0 [INFO] [stderr] Downloaded jiff-static v0.2.17 [INFO] [stderr] Downloaded pyo3-ffi v0.26.0 [INFO] [stderr] Downloaded pyo3-async-runtimes v0.26.0 [INFO] [stderr] Downloaded jiff v0.2.17 [INFO] [stderr] Downloaded pyo3 v0.26.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c32f7ec2101e5e4b5b6f2610cf7023bf500ed3a60f82b25c8611a0f284701ade [INFO] running `Command { std: "docker" "start" "-a" "c32f7ec2101e5e4b5b6f2610cf7023bf500ed3a60f82b25c8611a0f284701ade", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c32f7ec2101e5e4b5b6f2610cf7023bf500ed3a60f82b25c8611a0f284701ade", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c32f7ec2101e5e4b5b6f2610cf7023bf500ed3a60f82b25c8611a0f284701ade", kill_on_drop: false }` [INFO] [stdout] c32f7ec2101e5e4b5b6f2610cf7023bf500ed3a60f82b25c8611a0f284701ade [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] db8630df28ed4a430b4d0f8513eb225fd7c46c9c2e1bfa37e5057e4241deb5ab [INFO] running `Command { std: "docker" "start" "-a" "db8630df28ed4a430b4d0f8513eb225fd7c46c9c2e1bfa37e5057e4241deb5ab", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.13.2 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling winnow v0.7.13 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking unindent v0.2.4 [INFO] [stderr] Compiling indoc v2.0.6 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Compiling thiserror v2.0.16 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking jiff v0.2.17 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Compiling pyo3-build-config v0.26.0 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling pyo3-ffi v0.26.0 [INFO] [stderr] Compiling pyo3-macros-backend v0.26.0 [INFO] [stderr] Compiling pyo3 v0.26.0 [INFO] [stderr] Compiling toml_edit v0.22.27 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking env_filter v0.1.4 [INFO] [stderr] Compiling proc-macro-crate v3.3.0 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling thiserror-impl v2.0.16 [INFO] [stderr] Compiling num_enum_derive v0.7.4 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking num_enum v0.7.4 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Compiling pyo3-macros v0.26.0 [INFO] [stderr] Checking pyo3-async-runtimes v0.26.0 [INFO] [stderr] Checking attp-core v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty lines after doc comment [INFO] [stdout] --> src/lib.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / /// ============================================= [INFO] [stdout] 17 | | [INFO] [stdout] 18 | | [INFO] [stdout] | |_^ [INFO] [stdout] 19 | use pyo3::{exceptions::PyRuntimeError, prelude::*}; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty lines are unintentional, remove them [INFO] [stdout] help: if the comment should document the crate use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! ============================================= [INFO] [stdout] 2 ~ //! Ascender AgentHub - ATTP Core [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Copyright (c) 2025 Ascender [INFO] [stdout] 5 ~ //! All rights reserved. [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! This file is part of the Ascender AgentHub project. [INFO] [stdout] 8 ~ //! Unauthorized copying, distribution, or modification [INFO] [stdout] 9 ~ //! of this file, via any medium, is strictly prohibited. [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! This software is proprietary and confidential. [INFO] [stdout] 12 ~ //! Use of this source code is governed by the license [INFO] [stdout] 13 ~ //! agreement provided with the project. [INFO] [stdout] 14 ~ //! [INFO] [stdout] 15 ~ //! Developed by the Ascender AgentHub team. [INFO] [stdout] 16 ~ //! ============================================= [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty lines after doc comment [INFO] [stdout] --> src/config.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / /// ============================================= [INFO] [stdout] 17 | | [INFO] [stdout] 18 | | [INFO] [stdout] | |_^ [INFO] [stdout] 19 | use pyo3::{pyclass, pymethods}; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty lines are unintentional, remove them [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! ============================================= [INFO] [stdout] 2 ~ //! Ascender AgentHub - ATTP Core [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Copyright (c) 2025 Ascender [INFO] [stdout] 5 ~ //! All rights reserved. [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! This file is part of the Ascender AgentHub project. [INFO] [stdout] 8 ~ //! Unauthorized copying, distribution, or modification [INFO] [stdout] 9 ~ //! of this file, via any medium, is strictly prohibited. [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! This software is proprietary and confidential. [INFO] [stdout] 12 ~ //! Use of this source code is governed by the license [INFO] [stdout] 13 ~ //! agreement provided with the project. [INFO] [stdout] 14 ~ //! [INFO] [stdout] 15 ~ //! Developed by the Ascender AgentHub team. [INFO] [stdout] 16 ~ //! ============================================= [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/attp/shared/command.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / /// ============================================= [INFO] [stdout] 17 | | [INFO] [stdout] | |_^ [INFO] [stdout] 18 | use num_enum::{IntoPrimitive, TryFromPrimitive}; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! ============================================= [INFO] [stdout] 2 ~ //! Ascender AgentHub - ATTP Core [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Copyright (c) 2025 Ascender [INFO] [stdout] 5 ~ //! All rights reserved. [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! This file is part of the Ascender AgentHub project. [INFO] [stdout] 8 ~ //! Unauthorized copying, distribution, or modification [INFO] [stdout] 9 ~ //! of this file, via any medium, is strictly prohibited. [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! This software is proprietary and confidential. [INFO] [stdout] 12 ~ //! Use of this source code is governed by the license [INFO] [stdout] 13 ~ //! agreement provided with the project. [INFO] [stdout] 14 ~ //! [INFO] [stdout] 15 ~ //! Developed by the Ascender AgentHub team. [INFO] [stdout] 16 ~ //! ============================================= [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attp/shared/command.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | route_id: route_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `route_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attp/shared/command.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | command_type: command_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attp/shared/command.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | correlation_id: correlation_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `correlation_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attp/shared/command.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | payload: payload, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attp/shared/command.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | version: version [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/attp/shared/errors.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / /// See the project license for terms of use. [INFO] [stdout] 4 | | [INFO] [stdout] | |_^ [INFO] [stdout] 5 | use thiserror::Error; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Ascender AgentHub (c) 2025 [INFO] [stdout] 2 ~ //! Proprietary software. All rights reserved. [INFO] [stdout] 3 ~ //! See the project license for terms of use. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/attp/shared/pyattp_message.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / /// ============================================= [INFO] [stdout] 17 | | [INFO] [stdout] | |_^ [INFO] [stdout] 18 | use pyo3::{pyclass, pymethods}; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! ============================================= [INFO] [stdout] 2 ~ //! Ascender AgentHub - ATTP Core [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Copyright (c) 2025 Ascender [INFO] [stdout] 5 ~ //! All rights reserved. [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! This file is part of the Ascender AgentHub project. [INFO] [stdout] 8 ~ //! Unauthorized copying, distribution, or modification [INFO] [stdout] 9 ~ //! of this file, via any medium, is strictly prohibited. [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! This software is proprietary and confidential. [INFO] [stdout] 12 ~ //! Use of this source code is governed by the license [INFO] [stdout] 13 ~ //! agreement provided with the project. [INFO] [stdout] 14 ~ //! [INFO] [stdout] 15 ~ //! Developed by the Ascender AgentHub team. [INFO] [stdout] 16 ~ //! ============================================= [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/attp/shared/session.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / /// ============================================= [INFO] [stdout] 17 | | [INFO] [stdout] | |_^ [INFO] [stdout] 18 | use std::{sync::Arc}; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! ============================================= [INFO] [stdout] 2 ~ //! Ascender AgentHub - ATTP Core [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Copyright (c) 2025 Ascender [INFO] [stdout] 5 ~ //! All rights reserved. [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! This file is part of the Ascender AgentHub project. [INFO] [stdout] 8 ~ //! Unauthorized copying, distribution, or modification [INFO] [stdout] 9 ~ //! of this file, via any medium, is strictly prohibited. [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! This software is proprietary and confidential. [INFO] [stdout] 12 ~ //! Use of this source code is governed by the license [INFO] [stdout] 13 ~ //! agreement provided with the project. [INFO] [stdout] 14 ~ //! [INFO] [stdout] 15 ~ //! Developed by the Ascender AgentHub team. [INFO] [stdout] 16 ~ //! ============================================= [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/attp/utils.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / /// See the project license for terms of use. [INFO] [stdout] 4 | | [INFO] [stdout] | |_^ [INFO] [stdout] 5 | use crate::attp::shared::errors::DecodeError; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Ascender AgentHub (c) 2025 [INFO] [stdout] 2 ~ //! Proprietary software. All rights reserved. [INFO] [stdout] 3 ~ //! See the project license for terms of use. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/attp/server/transport.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / /// ============================================= [INFO] [stdout] 17 | | [INFO] [stdout] | |_^ [INFO] [stdout] 18 | use pyo3::{ [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! ============================================= [INFO] [stdout] 2 ~ //! Ascender AgentHub - ATTP Core [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Copyright (c) 2025 Ascender [INFO] [stdout] 5 ~ //! All rights reserved. [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! This file is part of the Ascender AgentHub project. [INFO] [stdout] 8 ~ //! Unauthorized copying, distribution, or modification [INFO] [stdout] 9 ~ //! of this file, via any medium, is strictly prohibited. [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! This software is proprietary and confidential. [INFO] [stdout] 12 ~ //! Use of this source code is governed by the license [INFO] [stdout] 13 ~ //! agreement provided with the project. [INFO] [stdout] 14 ~ //! [INFO] [stdout] 15 ~ //! Developed by the Ascender AgentHub team. [INFO] [stdout] 16 ~ //! ============================================= [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty lines after doc comment [INFO] [stdout] --> src/lib.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / /// ============================================= [INFO] [stdout] 17 | | [INFO] [stdout] 18 | | [INFO] [stdout] | |_^ [INFO] [stdout] 19 | use pyo3::{exceptions::PyRuntimeError, prelude::*}; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty lines are unintentional, remove them [INFO] [stdout] help: if the comment should document the crate use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! ============================================= [INFO] [stdout] 2 ~ //! Ascender AgentHub - ATTP Core [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Copyright (c) 2025 Ascender [INFO] [stdout] 5 ~ //! All rights reserved. [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! This file is part of the Ascender AgentHub project. [INFO] [stdout] 8 ~ //! Unauthorized copying, distribution, or modification [INFO] [stdout] 9 ~ //! of this file, via any medium, is strictly prohibited. [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! This software is proprietary and confidential. [INFO] [stdout] 12 ~ //! Use of this source code is governed by the license [INFO] [stdout] 13 ~ //! agreement provided with the project. [INFO] [stdout] 14 ~ //! [INFO] [stdout] 15 ~ //! Developed by the Ascender AgentHub team. [INFO] [stdout] 16 ~ //! ============================================= [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty lines after doc comment [INFO] [stdout] --> src/config.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / /// ============================================= [INFO] [stdout] 17 | | [INFO] [stdout] 18 | | [INFO] [stdout] | |_^ [INFO] [stdout] 19 | use pyo3::{pyclass, pymethods}; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty lines are unintentional, remove them [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! ============================================= [INFO] [stdout] 2 ~ //! Ascender AgentHub - ATTP Core [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Copyright (c) 2025 Ascender [INFO] [stdout] 5 ~ //! All rights reserved. [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! This file is part of the Ascender AgentHub project. [INFO] [stdout] 8 ~ //! Unauthorized copying, distribution, or modification [INFO] [stdout] 9 ~ //! of this file, via any medium, is strictly prohibited. [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! This software is proprietary and confidential. [INFO] [stdout] 12 ~ //! Use of this source code is governed by the license [INFO] [stdout] 13 ~ //! agreement provided with the project. [INFO] [stdout] 14 ~ //! [INFO] [stdout] 15 ~ //! Developed by the Ascender AgentHub team. [INFO] [stdout] 16 ~ //! ============================================= [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/attp/shared/command.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / /// ============================================= [INFO] [stdout] 17 | | [INFO] [stdout] | |_^ [INFO] [stdout] 18 | use num_enum::{IntoPrimitive, TryFromPrimitive}; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! ============================================= [INFO] [stdout] 2 ~ //! Ascender AgentHub - ATTP Core [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Copyright (c) 2025 Ascender [INFO] [stdout] 5 ~ //! All rights reserved. [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! This file is part of the Ascender AgentHub project. [INFO] [stdout] 8 ~ //! Unauthorized copying, distribution, or modification [INFO] [stdout] 9 ~ //! of this file, via any medium, is strictly prohibited. [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! This software is proprietary and confidential. [INFO] [stdout] 12 ~ //! Use of this source code is governed by the license [INFO] [stdout] 13 ~ //! agreement provided with the project. [INFO] [stdout] 14 ~ //! [INFO] [stdout] 15 ~ //! Developed by the Ascender AgentHub team. [INFO] [stdout] 16 ~ //! ============================================= [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attp/shared/command.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | route_id: route_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `route_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attp/shared/command.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | command_type: command_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attp/shared/command.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | correlation_id: correlation_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `correlation_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attp/shared/command.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 118 | payload: payload, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/attp/shared/command.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | version: version [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/attp/shared/errors.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / /// See the project license for terms of use. [INFO] [stdout] 4 | | [INFO] [stdout] | |_^ [INFO] [stdout] 5 | use thiserror::Error; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Ascender AgentHub (c) 2025 [INFO] [stdout] 2 ~ //! Proprietary software. All rights reserved. [INFO] [stdout] 3 ~ //! See the project license for terms of use. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/attp/shared/pyattp_message.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / /// ============================================= [INFO] [stdout] 17 | | [INFO] [stdout] | |_^ [INFO] [stdout] 18 | use pyo3::{pyclass, pymethods}; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! ============================================= [INFO] [stdout] 2 ~ //! Ascender AgentHub - ATTP Core [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Copyright (c) 2025 Ascender [INFO] [stdout] 5 ~ //! All rights reserved. [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! This file is part of the Ascender AgentHub project. [INFO] [stdout] 8 ~ //! Unauthorized copying, distribution, or modification [INFO] [stdout] 9 ~ //! of this file, via any medium, is strictly prohibited. [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! This software is proprietary and confidential. [INFO] [stdout] 12 ~ //! Use of this source code is governed by the license [INFO] [stdout] 13 ~ //! agreement provided with the project. [INFO] [stdout] 14 ~ //! [INFO] [stdout] 15 ~ //! Developed by the Ascender AgentHub team. [INFO] [stdout] 16 ~ //! ============================================= [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/attp/shared/session.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / /// ============================================= [INFO] [stdout] 17 | | [INFO] [stdout] | |_^ [INFO] [stdout] 18 | use std::{sync::Arc}; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! ============================================= [INFO] [stdout] 2 ~ //! Ascender AgentHub - ATTP Core [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Copyright (c) 2025 Ascender [INFO] [stdout] 5 ~ //! All rights reserved. [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! This file is part of the Ascender AgentHub project. [INFO] [stdout] 8 ~ //! Unauthorized copying, distribution, or modification [INFO] [stdout] 9 ~ //! of this file, via any medium, is strictly prohibited. [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! This software is proprietary and confidential. [INFO] [stdout] 12 ~ //! Use of this source code is governed by the license [INFO] [stdout] 13 ~ //! agreement provided with the project. [INFO] [stdout] 14 ~ //! [INFO] [stdout] 15 ~ //! Developed by the Ascender AgentHub team. [INFO] [stdout] 16 ~ //! ============================================= [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/attp/utils.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / /// See the project license for terms of use. [INFO] [stdout] 4 | | [INFO] [stdout] | |_^ [INFO] [stdout] 5 | use crate::attp::shared::errors::DecodeError; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Ascender AgentHub (c) 2025 [INFO] [stdout] 2 ~ //! Proprietary software. All rights reserved. [INFO] [stdout] 3 ~ //! See the project license for terms of use. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/attp/server/transport.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / /// ============================================= [INFO] [stdout] 17 | | [INFO] [stdout] | |_^ [INFO] [stdout] 18 | use pyo3::{ [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! ============================================= [INFO] [stdout] 2 ~ //! Ascender AgentHub - ATTP Core [INFO] [stdout] 3 ~ //! [INFO] [stdout] 4 ~ //! Copyright (c) 2025 Ascender [INFO] [stdout] 5 ~ //! All rights reserved. [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! This file is part of the Ascender AgentHub project. [INFO] [stdout] 8 ~ //! Unauthorized copying, distribution, or modification [INFO] [stdout] 9 ~ //! of this file, via any medium, is strictly prohibited. [INFO] [stdout] 10 ~ //! [INFO] [stdout] 11 ~ //! This software is proprietary and confidential. [INFO] [stdout] 12 ~ //! Use of this source code is governed by the license [INFO] [stdout] 13 ~ //! agreement provided with the project. [INFO] [stdout] 14 ~ //! [INFO] [stdout] 15 ~ //! Developed by the Ascender AgentHub team. [INFO] [stdout] 16 ~ //! ============================================= [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CALL` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | CALL = 0, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Call` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ACK` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | ACK = 1, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Ack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EMIT` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | EMIT = 2, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Emit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ERR` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | ERR = 3, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AUTH` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | AUTH = 4, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Auth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `READY` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | READY = 5, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Ready` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PING` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | PING = 6, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ping` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PONG` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | PONG = 7, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Pong` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DISCONNECT` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | DISCONNECT = 8, [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Disconnect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEFER` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | DEFER = 9, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Defer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STREAMBOS` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | STREAMBOS = 10, [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Streambos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CHUNK` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | CHUNK = 11, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Chunk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STREAMEOS` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | STREAMEOS = 12 [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Streameos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/attp/shared/command.rs:184:17 [INFO] [stdout] | [INFO] [stdout] 184 | / if correlation_id.is_none() { [INFO] [stdout] 185 | | return Err(DecodeError::MissingCorrelation(command_type)); [INFO] [stdout] 186 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 183 ~ AttpCommand::CHUNK [INFO] [stdout] 184 ~ if correlation_id.is_none() => { [INFO] [stdout] 185 | return Err(DecodeError::MissingCorrelation(command_type)); [INFO] [stdout] 186 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `AttpCommand` which implements the `Copy` trait [INFO] [stdout] --> src/attp/shared/command.rs:212:18 [INFO] [stdout] | [INFO] [stdout] 212 | out.push(self.command_type.clone() as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.command_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/attp/shared/session.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | / return Self { [INFO] [stdout] 80 | | tx, [INFO] [stdout] 81 | | reader: Arc::new(Mutex::new(reader)), [INFO] [stdout] 82 | | session_id, [INFO] [stdout] ... | [INFO] [stdout] 90 | | shutdown_tx: None, [INFO] [stdout] 91 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 ~ Self { [INFO] [stdout] 80 + tx, [INFO] [stdout] 81 + reader: Arc::new(Mutex::new(reader)), [INFO] [stdout] 82 + session_id, [INFO] [stdout] 83 + peername, [INFO] [stdout] 84 + limits, [INFO] [stdout] 85 + event_receivers: Arc::new(std::sync::Mutex::new(Vec::new())), [INFO] [stdout] 86 + buf: BytesMut::new(), [INFO] [stdout] 87 + message_writer: None, [INFO] [stdout] 88 + message_reader: None, [INFO] [stdout] 89 + shutdown_rx: None, [INFO] [stdout] 90 + shutdown_tx: None, [INFO] [stdout] 91 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/attp/shared/session.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | return tx; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return tx; [INFO] [stdout] 126 + tx [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/attp/shared/session.rs:167:20 [INFO] [stdout] | [INFO] [stdout] 167 | if !self.message_writer.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.message_writer.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/attp/shared/session.rs:211:24 [INFO] [stdout] | [INFO] [stdout] 211 | if !self.message_writer.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.message_writer.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.message_writer` after checking its variant with `is_none` [INFO] [stdout] --> src/attp/shared/session.rs:173:29 [INFO] [stdout] | [INFO] [stdout] 167 | ... if !self.message_writer.is_none() { [INFO] [stdout] | ----------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 173 | ... let _ = self.message_writer.as_ref().unwrap().send(vec![AttpMessage::new(0u16, 8, None, None, b"01".clone())]).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.message_writer` after checking its variant with `is_none` [INFO] [stdout] --> src/attp/shared/session.rs:212:33 [INFO] [stdout] | [INFO] [stdout] 211 | if !self.message_writer.is_none() { [INFO] [stdout] | ----------------------------- the check is happening here [INFO] [stdout] 212 | let _ = self.message_writer.as_ref().unwrap().send(r).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/attp/shared/session.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 137 | return "Cannot start listener, make sure you initialized shutdown writer by executing Session.start_listening(...)"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return "Cannot start listener, make sure you initialized shutdown writer by executing Session.start_listening(...)"; [INFO] [stdout] 137 + "Cannot start listener, make sure you initialized shutdown writer by executing Session.start_listening(...)" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 2]` which implements the `Copy` trait [INFO] [stdout] --> src/attp/shared/session.rs:148:119 [INFO] [stdout] | [INFO] [stdout] 148 | ...[AttpMessage::new(0u16, 8, None, None, b"01".clone())]).await; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*b"01"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 2]` which implements the `Copy` trait [INFO] [stdout] --> src/attp/shared/session.rs:169:70 [INFO] [stdout] | [INFO] [stdout] 169 | ._send(AttpMessage::new(0u16, 8, None, None, b"01".clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*b"01"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 2]` which implements the `Copy` trait [INFO] [stdout] --> src/attp/shared/session.rs:173:115 [INFO] [stdout] | [INFO] [stdout] 173 | ...[AttpMessage::new(0u16, 8, None, None, b"01".clone())]).await; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*b"01"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 2]` which implements the `Copy` trait [INFO] [stdout] --> src/attp/shared/session.rs:218:70 [INFO] [stdout] | [INFO] [stdout] 218 | ._send(AttpMessage::new(0u16, 3, None, None, b"01".clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*b"01"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 2]` which implements the `Copy` trait [INFO] [stdout] --> src/attp/shared/session.rs:310:84 [INFO] [stdout] | [INFO] [stdout] 310 | let frame = AttpMessage::new(0, AttpCommand::DISCONNECT as u8, None, None, b"01".clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*b"01"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/attp/shared/session.rs:357:22 [INFO] [stdout] | [INFO] [stdout] 357 | .map_err(|e| PyOSError::new_err(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PyOSError::new_err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/attp/shared/session.rs:478:13 [INFO] [stdout] | [INFO] [stdout] 478 | / loop { [INFO] [stdout] 479 | | match receiver_guard.recv().await { [INFO] [stdout] 480 | | Some(received) => { [INFO] [stdout] 481 | | trace!( [INFO] [stdout] ... | [INFO] [stdout] 514 | | } [INFO] [stdout] | |_____________^ help: try: `while let Some(received) = receiver_guard.recv().await { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/attp/shared/session.rs:494:69 [INFO] [stdout] | [INFO] [stdout] 494 | ... PyList::new(py, received.iter().map(|i| PyAttpMessage::from_attp(i))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PyAttpMessage::from_attp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/attp/shared/session.rs:498:33 [INFO] [stdout] | [INFO] [stdout] 498 | / ... if let Ok(awaitable) = [INFO] [stdout] 499 | | ... bound_receiver.call1((py_attp_messages.clone(),)) [INFO] [stdout] 500 | | ... { [INFO] [stdout] 501 | | ... if let Ok(fut) = [INFO] [stdout] ... | [INFO] [stdout] 508 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 499 ~ bound_receiver.call1((py_attp_messages.clone(),)) [INFO] [stdout] 500 ~ && let Ok(fut) = [INFO] [stdout] 501 | pyo3_async_runtimes::tokio::into_future(awaitable) [INFO] [stdout] ... [INFO] [stdout] 505 | }); [INFO] [stdout] 506 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `split.get(0)` [INFO] [stdout] --> src/attp/utils.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | host.push_str(split.get(0).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `split.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u16` which implements the `Copy` trait [INFO] [stdout] --> src/attp/server/transport.rs:71:20 [INFO] [stdout] | [INFO] [stdout] 71 | let port = self.port.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Limits` which implements the `Copy` trait [INFO] [stdout] --> src/attp/server/transport.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 75 | let limits = self.limits.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.limits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/attp/server/transport.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return Ok(()); [INFO] [stdout] 123 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/attp/client/client_session.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return instance; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return instance; [INFO] [stdout] 70 + instance [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/attp/client/client_session.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return tx; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return tx; [INFO] [stdout] 85 + tx [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 2]` which implements the `Copy` trait [INFO] [stdout] --> src/attp/client/client_session.rs:104:63 [INFO] [stdout] | [INFO] [stdout] 104 | ._send(AttpMessage::new(0, 6, None, None, b"01".clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*b"01"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/attp/client/client_session.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | return Some(session); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return Some(session); [INFO] [stdout] 159 + Some(session) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CALL` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | CALL = 0, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Call` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ACK` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | ACK = 1, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Ack` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EMIT` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | EMIT = 2, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Emit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ERR` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | ERR = 3, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AUTH` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | AUTH = 4, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Auth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `READY` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | READY = 5, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Ready` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PING` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | PING = 6, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ping` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PONG` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | PONG = 7, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Pong` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DISCONNECT` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | DISCONNECT = 8, [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Disconnect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEFER` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | DEFER = 9, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Defer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STREAMBOS` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | STREAMBOS = 10, [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Streambos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CHUNK` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | CHUNK = 11, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Chunk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STREAMEOS` contains a capitalized acronym [INFO] [stdout] --> src/attp/shared/command.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | STREAMEOS = 12 [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Streameos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/attp/shared/command.rs:184:17 [INFO] [stdout] | [INFO] [stdout] 184 | / if correlation_id.is_none() { [INFO] [stdout] 185 | | return Err(DecodeError::MissingCorrelation(command_type)); [INFO] [stdout] 186 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 183 ~ AttpCommand::CHUNK [INFO] [stdout] 184 ~ if correlation_id.is_none() => { [INFO] [stdout] 185 | return Err(DecodeError::MissingCorrelation(command_type)); [INFO] [stdout] 186 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `AttpCommand` which implements the `Copy` trait [INFO] [stdout] --> src/attp/shared/command.rs:212:18 [INFO] [stdout] | [INFO] [stdout] 212 | out.push(self.command_type.clone() as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.command_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/attp/shared/session.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | / return Self { [INFO] [stdout] 80 | | tx, [INFO] [stdout] 81 | | reader: Arc::new(Mutex::new(reader)), [INFO] [stdout] 82 | | session_id, [INFO] [stdout] ... | [INFO] [stdout] 90 | | shutdown_tx: None, [INFO] [stdout] 91 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 ~ Self { [INFO] [stdout] 80 + tx, [INFO] [stdout] 81 + reader: Arc::new(Mutex::new(reader)), [INFO] [stdout] 82 + session_id, [INFO] [stdout] 83 + peername, [INFO] [stdout] 84 + limits, [INFO] [stdout] 85 + event_receivers: Arc::new(std::sync::Mutex::new(Vec::new())), [INFO] [stdout] 86 + buf: BytesMut::new(), [INFO] [stdout] 87 + message_writer: None, [INFO] [stdout] 88 + message_reader: None, [INFO] [stdout] 89 + shutdown_rx: None, [INFO] [stdout] 90 + shutdown_tx: None, [INFO] [stdout] 91 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/attp/shared/session.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | return tx; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return tx; [INFO] [stdout] 126 + tx [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/attp/shared/session.rs:167:20 [INFO] [stdout] | [INFO] [stdout] 167 | if !self.message_writer.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.message_writer.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/attp/shared/session.rs:211:24 [INFO] [stdout] | [INFO] [stdout] 211 | if !self.message_writer.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.message_writer.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.message_writer` after checking its variant with `is_none` [INFO] [stdout] --> src/attp/shared/session.rs:173:29 [INFO] [stdout] | [INFO] [stdout] 167 | ... if !self.message_writer.is_none() { [INFO] [stdout] | ----------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 173 | ... let _ = self.message_writer.as_ref().unwrap().send(vec![AttpMessage::new(0u16, 8, None, None, b"01".clone())]).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.message_writer` after checking its variant with `is_none` [INFO] [stdout] --> src/attp/shared/session.rs:212:33 [INFO] [stdout] | [INFO] [stdout] 211 | if !self.message_writer.is_none() { [INFO] [stdout] | ----------------------------- the check is happening here [INFO] [stdout] 212 | let _ = self.message_writer.as_ref().unwrap().send(r).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/attp/shared/session.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 137 | return "Cannot start listener, make sure you initialized shutdown writer by executing Session.start_listening(...)"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return "Cannot start listener, make sure you initialized shutdown writer by executing Session.start_listening(...)"; [INFO] [stdout] 137 + "Cannot start listener, make sure you initialized shutdown writer by executing Session.start_listening(...)" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 2]` which implements the `Copy` trait [INFO] [stdout] --> src/attp/shared/session.rs:148:119 [INFO] [stdout] | [INFO] [stdout] 148 | ...[AttpMessage::new(0u16, 8, None, None, b"01".clone())]).await; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*b"01"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 2]` which implements the `Copy` trait [INFO] [stdout] --> src/attp/shared/session.rs:169:70 [INFO] [stdout] | [INFO] [stdout] 169 | ._send(AttpMessage::new(0u16, 8, None, None, b"01".clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*b"01"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 2]` which implements the `Copy` trait [INFO] [stdout] --> src/attp/shared/session.rs:173:115 [INFO] [stdout] | [INFO] [stdout] 173 | ...[AttpMessage::new(0u16, 8, None, None, b"01".clone())]).await; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*b"01"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 2]` which implements the `Copy` trait [INFO] [stdout] --> src/attp/shared/session.rs:218:70 [INFO] [stdout] | [INFO] [stdout] 218 | ._send(AttpMessage::new(0u16, 3, None, None, b"01".clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*b"01"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 2]` which implements the `Copy` trait [INFO] [stdout] --> src/attp/shared/session.rs:310:84 [INFO] [stdout] | [INFO] [stdout] 310 | let frame = AttpMessage::new(0, AttpCommand::DISCONNECT as u8, None, None, b"01".clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*b"01"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/attp/shared/session.rs:357:22 [INFO] [stdout] | [INFO] [stdout] 357 | .map_err(|e| PyOSError::new_err(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PyOSError::new_err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/attp/shared/session.rs:478:13 [INFO] [stdout] | [INFO] [stdout] 478 | / loop { [INFO] [stdout] 479 | | match receiver_guard.recv().await { [INFO] [stdout] 480 | | Some(received) => { [INFO] [stdout] 481 | | trace!( [INFO] [stdout] ... | [INFO] [stdout] 514 | | } [INFO] [stdout] | |_____________^ help: try: `while let Some(received) = receiver_guard.recv().await { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/attp/shared/session.rs:494:69 [INFO] [stdout] | [INFO] [stdout] 494 | ... PyList::new(py, received.iter().map(|i| PyAttpMessage::from_attp(i))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PyAttpMessage::from_attp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/attp/shared/session.rs:498:33 [INFO] [stdout] | [INFO] [stdout] 498 | / ... if let Ok(awaitable) = [INFO] [stdout] 499 | | ... bound_receiver.call1((py_attp_messages.clone(),)) [INFO] [stdout] 500 | | ... { [INFO] [stdout] 501 | | ... if let Ok(fut) = [INFO] [stdout] ... | [INFO] [stdout] 508 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 499 ~ bound_receiver.call1((py_attp_messages.clone(),)) [INFO] [stdout] 500 ~ && let Ok(fut) = [INFO] [stdout] 501 | pyo3_async_runtimes::tokio::into_future(awaitable) [INFO] [stdout] ... [INFO] [stdout] 505 | }); [INFO] [stdout] 506 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `split.get(0)` [INFO] [stdout] --> src/attp/utils.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | host.push_str(split.get(0).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `split.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u16` which implements the `Copy` trait [INFO] [stdout] --> src/attp/server/transport.rs:71:20 [INFO] [stdout] | [INFO] [stdout] 71 | let port = self.port.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Limits` which implements the `Copy` trait [INFO] [stdout] --> src/attp/server/transport.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 75 | let limits = self.limits.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.limits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/attp/server/transport.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return Ok(()); [INFO] [stdout] 123 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/attp/client/client_session.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return instance; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return instance; [INFO] [stdout] 70 + instance [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/attp/client/client_session.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return tx; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return tx; [INFO] [stdout] 85 + tx [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 2]` which implements the `Copy` trait [INFO] [stdout] --> src/attp/client/client_session.rs:104:63 [INFO] [stdout] | [INFO] [stdout] 104 | ._send(AttpMessage::new(0, 6, None, None, b"01".clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*b"01"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/attp/client/client_session.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | return Some(session); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return Some(session); [INFO] [stdout] 159 + Some(session) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 26.26s [INFO] running `Command { std: "docker" "inspect" "db8630df28ed4a430b4d0f8513eb225fd7c46c9c2e1bfa37e5057e4241deb5ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db8630df28ed4a430b4d0f8513eb225fd7c46c9c2e1bfa37e5057e4241deb5ab", kill_on_drop: false }` [INFO] [stdout] db8630df28ed4a430b4d0f8513eb225fd7c46c9c2e1bfa37e5057e4241deb5ab