[INFO] cloning repository https://github.com/ArquisoftUNAL/habits_ms
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ArquisoftUNAL/habits_ms" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FArquisoftUNAL%2Fhabits_ms", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FArquisoftUNAL%2Fhabits_ms'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 060fefc9bdc650f1c4223f7c28f2ec08359b8ab7
[INFO] linting ArquisoftUNAL/habits_ms against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FArquisoftUNAL%2Fhabits_ms" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/ArquisoftUNAL/habits_ms
[INFO] finished tweaking git repo https://github.com/ArquisoftUNAL/habits_ms
[INFO] tweaked toml for git repo https://github.com/ArquisoftUNAL/habits_ms written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/ArquisoftUNAL/habits_ms on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/ArquisoftUNAL/habits_ms already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded tungstenite v0.18.0
[INFO] [stderr]   Downloaded validator_derive v0.16.0
[INFO] [stderr]   Downloaded multer v2.1.0
[INFO] [stderr]   Downloaded rustls-pemfile v1.0.3
[INFO] [stderr]   Downloaded diesel_table_macro_syntax v0.1.0
[INFO] [stderr]   Downloaded diesel-derive-enum v2.1.0
[INFO] [stderr]   Downloaded serde_spanned v0.6.4
[INFO] [stderr]   Downloaded diesel_migrations v2.1.0
[INFO] [stderr]   Downloaded graphql-introspection-query v0.2.0
[INFO] [stderr]   Downloaded graphql_query_derive v0.13.0
[INFO] [stderr]   Downloaded if_chain v1.0.2
[INFO] [stderr]   Downloaded pq-sys v0.4.8
[INFO] [stderr]   Downloaded scheduled-thread-pool v0.2.7
[INFO] [stderr]   Downloaded bigdecimal v0.4.1
[INFO] [stderr]   Downloaded diesel_derives v2.1.1
[INFO] [stderr]   Downloaded ascii v0.9.3
[INFO] [stderr]   Downloaded tokio-cron-scheduler v0.9.4
[INFO] [stderr]   Downloaded warp v0.3.5
[INFO] [stderr]   Downloaded winnow v0.5.19
[INFO] [stderr]   Downloaded graphql_client_codegen v0.13.0
[INFO] [stderr]   Downloaded reqwest v0.11.20
[INFO] [stderr]   Downloaded fake v2.8.0
[INFO] [stderr]   Downloaded combine v3.8.1
[INFO] [stderr]   Downloaded syn v2.0.31
[INFO] [stderr]   Downloaded serde_json v1.0.106
[INFO] [stderr]   Downloaded graphql_client v0.13.0
[INFO] [stderr]   Downloaded diesel v2.1.1
[INFO] [stderr]   Downloaded cron v0.12.0
[INFO] [stderr]   Downloaded socket2 v0.5.3
[INFO] [stderr]   Downloaded r2d2 v0.8.10
[INFO] [stderr]   Downloaded graphql-parser v0.4.0
[INFO] [stderr]   Downloaded migrations_internals v2.1.0
[INFO] [stderr]   Downloaded migrations_macros v2.1.0
[INFO] [stderr]   Downloaded validator_types v0.16.0
[INFO] [stderr]   Downloaded tokio-tungstenite v0.18.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] d11514d30f64020d9e1a6e0c38be09dbd7f8f78ebff8287dbfc3641ed34853e2
[INFO] running `Command { std: "docker" "start" "-a" "d11514d30f64020d9e1a6e0c38be09dbd7f8f78ebff8287dbfc3641ed34853e2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "d11514d30f64020d9e1a6e0c38be09dbd7f8f78ebff8287dbfc3641ed34853e2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "d11514d30f64020d9e1a6e0c38be09dbd7f8f78ebff8287dbfc3641ed34853e2", kill_on_drop: false }`
[INFO] [stdout] d11514d30f64020d9e1a6e0c38be09dbd7f8f78ebff8287dbfc3641ed34853e2
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] f640f6ae5229edc6b007282d4be890e5c3fb4139ef1422a03b60bf4acbae0ce6
[INFO] running `Command { std: "docker" "start" "-a" "f640f6ae5229edc6b007282d4be890e5c3fb4139ef1422a03b60bf4acbae0ce6", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.147
[INFO] [stderr]    Compiling serde v1.0.188
[INFO] [stderr]     Checking itoa v1.0.9
[INFO] [stderr]     Checking log v0.4.20
[INFO] [stderr]    Compiling syn v2.0.31
[INFO] [stderr]    Compiling num-traits v0.2.16
[INFO] [stderr]    Compiling syn v1.0.109
[INFO] [stderr]     Checking http v0.2.9
[INFO] [stderr]    Compiling pkg-config v0.3.27
[INFO] [stderr]    Compiling futures-task v0.3.28
[INFO] [stderr]    Compiling thiserror v1.0.48
[INFO] [stderr]    Compiling futures-util v0.3.28
[INFO] [stderr]    Compiling memchr v2.6.3
[INFO] [stderr]     Checking tracing-core v0.1.31
[INFO] [stderr]     Checking socket2 v0.5.3
[INFO] [stderr]     Checking mio v0.8.8
[INFO] [stderr]     Checking num_cpus v1.16.0
[INFO] [stderr]     Checking getrandom v0.2.10
[INFO] [stderr]    Compiling cc v1.0.83
[INFO] [stderr]    Compiling serde_json v1.0.106
[INFO] [stderr]     Checking generic-array v0.14.7
[INFO] [stderr]     Checking bitflags v2.4.0
[INFO] [stderr]    Compiling unicase v2.7.0
[INFO] [stderr]    Compiling lock_api v0.4.10
[INFO] [stderr]    Compiling parking_lot_core v0.9.8
[INFO] [stderr]    Compiling openssl v0.10.57
[INFO] [stderr]     Checking url v2.4.1
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]    Compiling num-integer v0.1.45
[INFO] [stderr]    Compiling hashbrown v0.14.3
[INFO] [stderr]     Checking block-buffer v0.10.4
[INFO] [stderr]     Checking crypto-common v0.1.6
[INFO] [stderr]     Checking ryu v1.0.15
[INFO] [stderr]    Compiling void v1.0.2
[INFO] [stderr]     Checking smallvec v1.11.0
[INFO] [stderr]    Compiling native-tls v0.2.11
[INFO] [stderr]    Compiling openssl-sys v0.9.93
[INFO] [stderr]    Compiling unreachable v1.0.0
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking digest v0.10.7
[INFO] [stderr]     Checking http-body v0.4.5
[INFO] [stderr]     Checking socket2 v0.4.9
[INFO] [stderr]    Compiling indexmap v2.1.0
[INFO] [stderr]    Compiling num-bigint v0.4.4
[INFO] [stderr]    Compiling winnow v0.5.19
[INFO] [stderr]    Compiling ascii v0.9.3
[INFO] [stderr]    Compiling either v1.9.0
[INFO] [stderr]    Compiling libm v0.2.7
[INFO] [stderr]     Checking base64 v0.21.4
[INFO] [stderr]     Checking cpufeatures v0.2.9
[INFO] [stderr]    Compiling combine v3.8.1
[INFO] [stderr]     Checking sha1 v0.10.5
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking parking_lot v0.12.1
[INFO] [stderr]    Compiling aho-corasick v1.0.5
[INFO] [stderr]     Checking encoding_rs v0.8.33
[INFO] [stderr]    Compiling bigdecimal v0.4.1
[INFO] [stderr]    Compiling pq-sys v0.4.8
[INFO] [stderr]    Compiling regex-syntax v0.7.5
[INFO] [stderr]    Compiling diesel_table_macro_syntax v0.1.0
[INFO] [stderr]    Compiling mime_guess v2.0.4
[INFO] [stderr]     Checking scheduled-thread-pool v0.2.7
[INFO] [stderr]    Compiling proc-macro-error-attr v1.0.4
[INFO] [stderr]    Compiling multer v2.1.0
[INFO] [stderr]     Checking base64 v0.13.1
[INFO] [stderr]     Checking nom v7.1.3
[INFO] [stderr]    Compiling proc-macro-error v1.0.4
[INFO] [stderr]     Checking r2d2 v0.8.10
[INFO] [stderr]    Compiling validator_types v0.16.0
[INFO] [stderr]     Checking headers-core v0.2.0
[INFO] [stderr]    Compiling if_chain v1.0.2
[INFO] [stderr]     Checking ipnet v2.8.0
[INFO] [stderr]     Checking spin v0.9.8
[INFO] [stderr]    Compiling tokio-cron-scheduler v0.9.4
[INFO] [stderr]    Compiling regex-automata v0.3.8
[INFO] [stderr]     Checking headers v0.3.9
[INFO] [stderr]    Compiling num-derive v0.3.3
[INFO] [stderr]    Compiling serde_derive v1.0.188
[INFO] [stderr]    Compiling tokio-macros v2.1.0
[INFO] [stderr]    Compiling thiserror-impl v1.0.48
[INFO] [stderr]    Compiling tracing-attributes v0.1.26
[INFO] [stderr]    Compiling openssl-macros v0.1.1
[INFO] [stderr]     Checking tokio v1.32.0
[INFO] [stderr]    Compiling pin-project-internal v1.1.3
[INFO] [stderr]    Compiling graphql-parser v0.4.0
[INFO] [stderr]     Checking tracing v0.1.37
[INFO] [stderr]    Compiling diesel_derives v2.1.1
[INFO] [stderr]     Checking tungstenite v0.18.0
[INFO] [stderr]     Checking regex v1.9.5
[INFO] [stderr]     Checking pin-project v1.1.3
[INFO] [stderr]     Checking rustls-pemfile v1.0.3
[INFO] [stderr]     Checking unidecode v0.3.0
[INFO] [stderr]     Checking scoped-tls v1.0.1
[INFO] [stderr]    Compiling diesel-derive-enum v2.1.0
[INFO] [stderr]    Compiling validator_derive v0.16.0
[INFO] [stderr]     Checking tokio-util v0.7.8
[INFO] [stderr]     Checking tokio-native-tls v0.3.1
[INFO] [stderr]     Checking tokio-stream v0.1.14
[INFO] [stderr]     Checking tokio-tungstenite v0.18.0
[INFO] [stderr]     Checking h2 v0.3.21
[INFO] [stderr]    Compiling serde_spanned v0.6.4
[INFO] [stderr]    Compiling toml_datetime v0.6.5
[INFO] [stderr]    Compiling graphql-introspection-query v0.2.0
[INFO] [stderr]     Checking chrono v0.4.30
[INFO] [stderr]    Compiling toml_edit v0.19.15
[INFO] [stderr]     Checking serde_urlencoded v0.7.1
[INFO] [stderr]     Checking uuid v1.4.1
[INFO] [stderr]    Compiling graphql_client_codegen v0.13.0
[INFO] [stderr]     Checking validator v0.16.1
[INFO] [stderr]     Checking diesel v2.1.1
[INFO] [stderr]     Checking cron v0.12.0
[INFO] [stderr]     Checking fake v2.8.0
[INFO] [stderr]     Checking toml v0.7.8
[INFO] [stderr]     Checking migrations_internals v2.1.0
[INFO] [stderr]     Checking hyper v0.14.27
[INFO] [stderr]    Compiling migrations_macros v2.1.0
[INFO] [stderr]    Compiling graphql_query_derive v0.13.0
[INFO] [stderr]     Checking hyper-tls v0.5.0
[INFO] [stderr]     Checking warp v0.3.5
[INFO] [stderr]     Checking reqwest v0.11.20
[INFO] [stderr]     Checking graphql_client v0.13.0
[INFO] [stderr]     Checking diesel_migrations v2.1.0
[INFO] [stderr]     Checking habitus_habits v1.71.1 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused import: `warp::test`
[INFO] [stdout]   --> src/tests.rs:1:5
[INFO] [stdout]    |
[INFO] [stdout]  1 | use warp::test;
[INFO] [stdout]    |     ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: if this is a test module, consider adding a `#[cfg(test)]` to the containing module
[INFO] [stdout]   --> src/main.rs:16:1
[INFO] [stdout]    |
[INFO] [stdout] 16 | mod tests;
[INFO] [stdout]    | ^^^^^^^^^^
[INFO] [stdout]    = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `err`
[INFO] [stdout]   --> src/db.rs:30:19
[INFO] [stdout]    |
[INFO] [stdout] 30 |         .or_else(|err| {
[INFO] [stdout]    |                   ^^^ help: if this is intentional, prefix it with an underscore: `_err`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `err`
[INFO] [stdout]   --> src/db.rs:58:19
[INFO] [stdout]    |
[INFO] [stdout] 58 |         .or_else(|err| {
[INFO] [stdout]    |                   ^^^ help: if this is intentional, prefix it with an underscore: `_err`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `err`
[INFO] [stdout]   --> src/db.rs:97:80
[INFO] [stdout]    |
[INFO] [stdout] 97 |     let connection_read = PgConnection::establish(&database_url_read).or_else(|err| {
[INFO] [stdout]    |                                                                                ^^^ help: if this is intentional, prefix it with an underscore: `_err`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `response`
[INFO] [stdout]   --> src/handlers/category_handler.rs:27:13
[INFO] [stdout]    |
[INFO] [stdout] 27 |         let response = GeneralResponse {
[INFO] [stdout]    |             ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_response`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `authentication`
[INFO] [stdout]   --> src/handlers/category_handler.rs:66:5
[INFO] [stdout]    |
[INFO] [stdout] 66 |     authentication: AuthData,
[INFO] [stdout]    |     ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_authentication`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `authentication`
[INFO] [stdout]   --> src/handlers/category_handler.rs:96:5
[INFO] [stdout]    |
[INFO] [stdout] 96 |     authentication: AuthData,
[INFO] [stdout]    |     ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_authentication`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `authentication`
[INFO] [stdout]    --> src/handlers/category_handler.rs:116:5
[INFO] [stdout]     |
[INFO] [stdout] 116 |     authentication: AuthData,
[INFO] [stdout]     |     ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_authentication`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `get_read_connection_establish` is never used
[INFO] [stdout]   --> src/db.rs:92:8
[INFO] [stdout]    |
[INFO] [stdout] 92 | pub fn get_read_connection_establish() -> Result<PgConnection, Error> {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `include_habits` is never read
[INFO] [stdout]   --> src/models/api/mod.rs:51:9
[INFO] [stdout]    |
[INFO] [stdout] 50 | pub struct DataIncludeParams {
[INFO] [stdout]    |            ----------------- field in this struct
[INFO] [stdout] 51 |     pub include_habits: Option<bool>,
[INFO] [stdout]    |         ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `DataIncludeParams` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/db.rs:21:38
[INFO] [stdout]    |
[INFO] [stdout] 21 |     let database_url_write: String = format!("{}", env::var("DATABASE_URL_WRITE").unwrap());
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `env::var("DATABASE_URL_WRITE").unwrap().to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]    = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
[INFO] [stdout]   --> src/db.rs:26:22
[INFO] [stdout]    |
[INFO] [stdout] 26 |       let pool_write = Pool::builder()
[INFO] [stdout]    |  ______________________^
[INFO] [stdout] 27 | |         .max_size(15)
[INFO] [stdout] 28 | |         .connection_timeout(Duration::from_secs(10))
[INFO] [stdout] 29 | |         .build(manager_write)
[INFO] [stdout] ...  |
[INFO] [stdout] 33 | |             )))
[INFO] [stdout] 34 | |         });
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
[INFO] [stdout]    = note: `#[warn(clippy::bind_instead_of_map)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 26 ~     let pool_write = Pool::builder()
[INFO] [stdout] 27 +         .max_size(15)
[INFO] [stdout] 28 +         .connection_timeout(Duration::from_secs(10))
[INFO] [stdout] 29 +         .build(manager_write).map_err(|err| Error::DBConnectionError2(ConnectionError::BadConnection(
[INFO] [stdout] 30 +                 "No read connection".to_string(),
[INFO] [stdout] 31 ~             )));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/db.rs:49:37
[INFO] [stdout]    |
[INFO] [stdout] 49 |     let database_url_read: String = format!("{}", env::var("DATABASE_URL_READ").unwrap());
[INFO] [stdout]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `env::var("DATABASE_URL_READ").unwrap().to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
[INFO] [stdout]   --> src/db.rs:54:21
[INFO] [stdout]    |
[INFO] [stdout] 54 |       let pool_read = Pool::builder()
[INFO] [stdout]    |  _____________________^
[INFO] [stdout] 55 | |         .max_size(15)
[INFO] [stdout] 56 | |         .connection_timeout(Duration::from_secs(10))
[INFO] [stdout] 57 | |         .build(manager_read)
[INFO] [stdout] ...  |
[INFO] [stdout] 61 | |             )))
[INFO] [stdout] 62 | |         });
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 54 ~     let pool_read = Pool::builder()
[INFO] [stdout] 55 +         .max_size(15)
[INFO] [stdout] 56 +         .connection_timeout(Duration::from_secs(10))
[INFO] [stdout] 57 +         .build(manager_read).map_err(|err| Error::DBConnectionError2(ConnectionError::BadConnection(
[INFO] [stdout] 58 +                 "No read connection".to_string(),
[INFO] [stdout] 59 ~             )));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/db.rs:76:38
[INFO] [stdout]    |
[INFO] [stdout] 76 |     let database_url_write: String = format!("{}", env::var("DATABASE_URL_WRITE").unwrap());
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `env::var("DATABASE_URL_WRITE").unwrap().to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
[INFO] [stdout]   --> src/db.rs:78:28
[INFO] [stdout]    |
[INFO] [stdout] 78 |       let connection_write = PgConnection::establish(&database_url_write).or_else(|err| {
[INFO] [stdout]    |  ____________________________^
[INFO] [stdout] 79 | |         print!("Error connecting to write database: {:?}", err);
[INFO] [stdout] 80 | |         Err(Error::DBConnectionError2(ConnectionError::BadConnection(
[INFO] [stdout] 81 | |             "No write connection".to_string(),
[INFO] [stdout] 82 | |         )))
[INFO] [stdout] 83 | |     });
[INFO] [stdout]    | |______^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
[INFO] [stdout] help: use `map_err` instead
[INFO] [stdout]    |
[INFO] [stdout] 78 ~     let connection_write = PgConnection::establish(&database_url_write).map_err(|err| {
[INFO] [stdout] 79 |         print!("Error connecting to write database: {:?}", err);
[INFO] [stdout] 80 ~         Error::DBConnectionError2(ConnectionError::BadConnection(
[INFO] [stdout] 81 +             "No write connection".to_string(),
[INFO] [stdout] 82 +         ))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/db.rs:95:37
[INFO] [stdout]    |
[INFO] [stdout] 95 |     let database_url_read: String = format!("{}", env::var("DATABASE_URL_READ").unwrap());
[INFO] [stdout]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `env::var("DATABASE_URL_READ").unwrap().to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
[INFO] [stdout]    --> src/db.rs:97:27
[INFO] [stdout]     |
[INFO] [stdout]  97 |       let connection_read = PgConnection::establish(&database_url_read).or_else(|err| {
[INFO] [stdout]     |  ___________________________^
[INFO] [stdout]  98 | |         Err(Error::DBConnectionError2(ConnectionError::BadConnection(
[INFO] [stdout]  99 | |             "No read connection".to_string(),
[INFO] [stdout] 100 | |         )))
[INFO] [stdout] 101 | |     });
[INFO] [stdout]     | |______^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout]  97 ~     let connection_read = PgConnection::establish(&database_url_read).map_err(|err| Error::DBConnectionError2(ConnectionError::BadConnection(
[INFO] [stdout]  98 +             "No read connection".to_string(),
[INFO] [stdout]  99 ~         )));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/error.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 |     ValidationError(ValidationErrors),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout]    = note: `#[warn(clippy::enum_variant_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/error.rs:13:5
[INFO] [stdout]    |
[INFO] [stdout] 13 |     DBConnectionError(#[from] diesel::r2d2::PoolError),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/error.rs:19:5
[INFO] [stdout]    |
[INFO] [stdout] 19 |     QueryError(#[from] diesel::result::Error),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/error.rs:22:5
[INFO] [stdout]    |
[INFO] [stdout] 22 |     DBError(#[from] diesel::r2d2::Error),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/error.rs:25:5
[INFO] [stdout]    |
[INFO] [stdout] 25 |     AuthorizationError(String),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]    --> src/error.rs:127:19
[INFO] [stdout]     |
[INFO] [stdout] 127 |     } else if let Some(_) = err.find::<warp::reject::MethodNotAllowed>() {
[INFO] [stdout]     |            -------^^^^^^^----------------------------------------------- help: try: `if err.find::<warp::reject::MethodNotAllowed>().is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]    --> src/error.rs:135:19
[INFO] [stdout]     |
[INFO] [stdout] 135 |     } else if let Some(_) = err.find::<warp::reject::InvalidQuery>() {
[INFO] [stdout]     |            -------^^^^^^^------------------------------------------- help: try: `if err.find::<warp::reject::InvalidQuery>().is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/error.rs:151:18
[INFO] [stdout]     |
[INFO] [stdout] 151 |         message: message.into(),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^ help: consider removing `.into()`: `message`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]     = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/handlers/category_handler.rs:34:18
[INFO] [stdout]    |
[INFO] [stdout] 34 |         message: format!("Successfully retrieved categories"),
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved categories".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/handlers/category_handler.rs:56:18
[INFO] [stdout]    |
[INFO] [stdout] 56 |         message: format!("Successfully retrieved category"),
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved category".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/handlers/events_handler.rs:41:5
[INFO] [stdout]    |
[INFO] [stdout] 41 |     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 41 -     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout] 41 +     Ok(with_status(json(&response), StatusCode::OK))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/handlers/events_handler.rs:37:18
[INFO] [stdout]    |
[INFO] [stdout] 37 |         message: format!("Successfully retrieved events"),
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved events".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/handlers/events_handler.rs:90:18
[INFO] [stdout]    |
[INFO] [stdout] 90 |         message: format!("Successfully retrieved habit data as calendar events"),
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habit data as calendar events".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/events_handler.rs:129:18
[INFO] [stdout]     |
[INFO] [stdout] 129 |         message: format!("Successfully retrieved habit data as calendar events"),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habit data as calendar events".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `data.collected_at` after checking its variant with `is_some`
[INFO] [stdout]   --> src/handlers/habit_data_handler.rs:63:54
[INFO] [stdout]    |
[INFO] [stdout] 62 |     if last_habit_data.len() > 0 && data.collected_at.is_some() {
[INFO] [stdout]    |                                     --------------------------- the check is happening here
[INFO] [stdout] 63 |         if last_habit_data[0].hab_dat_collected_at > data.collected_at.unwrap() {
[INFO] [stdout]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/handlers/habit_data_handler.rs:62:5
[INFO] [stdout]    |
[INFO] [stdout] 62 | /     if last_habit_data.len() > 0 && data.collected_at.is_some() {
[INFO] [stdout] 63 | |         if last_habit_data[0].hab_dat_collected_at > data.collected_at.unwrap() {
[INFO] [stdout] 64 | |             return Err(warp::reject::custom(Error::BadRequest(
[INFO] [stdout] 65 | |                 "Requested date is before the last habit's data".to_string(),
[INFO] [stdout] ...  |
[INFO] [stdout] 68 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]    = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 62 ~     if last_habit_data.len() > 0 && data.collected_at.is_some()
[INFO] [stdout] 63 ~         && last_habit_data[0].hab_dat_collected_at > data.collected_at.unwrap() {
[INFO] [stdout] 64 |             return Err(warp::reject::custom(Error::BadRequest(
[INFO] [stdout] 65 |                 "Requested date is before the last habit's data".to_string(),
[INFO] [stdout] 66 |             )));
[INFO] [stdout] 67 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/handlers/habit_data_handler.rs:62:8
[INFO] [stdout]    |
[INFO] [stdout] 62 |     if last_habit_data.len() > 0 && data.collected_at.is_some() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!last_habit_data.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_data_handler.rs:220:18
[INFO] [stdout]     |
[INFO] [stdout] 220 |         message: format!("Successfully retrieved habit data"),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habit data".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_data_handler.rs:273:18
[INFO] [stdout]     |
[INFO] [stdout] 273 |         message: format!("Successfully retrieved habit data"),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habit data".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_data_handler.rs:314:18
[INFO] [stdout]     |
[INFO] [stdout] 314 |         message: format!("Successfully retrieved user's habit data"),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved user's habit data".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/handlers/habit_handler.rs:54:18
[INFO] [stdout]    |
[INFO] [stdout] 54 |         message: format!("Habit created successfully"),
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Habit created successfully".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/handlers/habit_handler.rs:206:5
[INFO] [stdout]     |
[INFO] [stdout] 206 |     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 206 -     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout] 206 +     Ok(with_status(json(&response), StatusCode::OK))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_handler.rs:192:22
[INFO] [stdout]     |
[INFO] [stdout] 192 |             message: format!("Successfully retrieved habits & data for user"),
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habits & data for user".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_handler.rs:202:18
[INFO] [stdout]     |
[INFO] [stdout] 202 |         message: format!("Successfully retrieved habits for user"),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habits for user".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/handlers/habit_handler.rs:253:5
[INFO] [stdout]     |
[INFO] [stdout] 253 |     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 253 -     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout] 253 +     Ok(with_status(json(&response), StatusCode::OK))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait
[INFO] [stdout]    --> src/handlers/habit_handler.rs:221:23
[INFO] [stdout]     |
[INFO] [stdout] 221 |     let category_id = id.clone();
[INFO] [stdout]     |                       ^^^^^^^^^^ help: try removing the `clone` call: `id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/handlers/habit_handler.rs:223:5
[INFO] [stdout]     |
[INFO] [stdout] 223 |     let result: Result<Vec<Habit>, Error>;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]     = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `result` here and remove the assignments from the branches
[INFO] [stdout]     |
[INFO] [stdout] 223 ~     
[INFO] [stdout] 224 |
[INFO] [stdout] 225 ~     let result: Result<Vec<Habit>, Error> = if user_id == "admin".to_string() {
[INFO] [stdout] 226 ~         manager.get_all_category_habits(
[INFO] [stdout] 227 |             category_id,
[INFO] [stdout] 228 |             params.habits_page,
[INFO] [stdout] 229 |             params.habits_per_page,
[INFO] [stdout] 230 ~         )
[INFO] [stdout] 231 |     } else {
[INFO] [stdout] 232 ~         manager.get_all_user_category_habits(
[INFO] [stdout] 233 |             user_id,
[INFO] [stdout] ...
[INFO] [stdout] 236 |             params.habits_per_page,
[INFO] [stdout] 237 ~         )
[INFO] [stdout] 238 ~     };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]    --> src/handlers/habit_handler.rs:225:19
[INFO] [stdout]     |
[INFO] [stdout] 225 |     if user_id == "admin".to_string() {
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^ help: try: `"admin"`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]     = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_handler.rs:249:18
[INFO] [stdout]     |
[INFO] [stdout] 249 |         message: format!("Successfully retrieved habits for category"),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habits for category".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/handlers/habit_handler.rs:323:5
[INFO] [stdout]     |
[INFO] [stdout] 323 |     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 323 -     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout] 323 +     Ok(with_status(json(&response), StatusCode::OK))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_handler.rs:310:22
[INFO] [stdout]     |
[INFO] [stdout] 310 |             message: format!("Successfully retrieved habit & recurrences & data"),
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habit & recurrences & data".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_handler.rs:319:18
[INFO] [stdout]     |
[INFO] [stdout] 319 |         message: format!("Successfully retrieved habit"),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habit".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]   --> src/queries/events_queries.rs:76:9
[INFO] [stdout]    |
[INFO] [stdout] 76 |         vec.sort_by(|a, b| b.date.cmp(&a.date));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_sort_by)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 76 -         vec.sort_by(|a, b| b.date.cmp(&a.date));
[INFO] [stdout] 76 +         vec.sort_by_key(|b| std::cmp::Reverse(b.date));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `habit_id` after checking its variant with `is_some`
[INFO] [stdout]    --> src/queries/events_queries.rs:109:51
[INFO] [stdout]     |
[INFO] [stdout] 108 |         if habit_id.is_some() {
[INFO] [stdout]     |         --------------------- help: try: `if let Some(<item>) = habit_id`
[INFO] [stdout] 109 |             query = query.filter(habit::hab_id.eq(habit_id.unwrap()));
[INFO] [stdout]     |                                                   ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/queries/habits_queries.rs:50:9
[INFO] [stdout]    |
[INFO] [stdout] 50 |         let closure_date: NaiveDate;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `closure_date` here and remove the assignments from the branches
[INFO] [stdout]    |
[INFO] [stdout] 50 ~         
[INFO] [stdout] 51 |
[INFO] [stdout] 52 ~         let closure_date: NaiveDate = if HABIT_CREATION_DATE_AS_REFERENCE {
[INFO] [stdout] 53 ~             current_date
[INFO] [stdout] 54 |         } else {
[INFO] [stdout] 55 ~             DateRange::get_next_closest_date(
[INFO] [stdout] 56 |                 data.frequency_type,
[INFO] [stdout] ...
[INFO] [stdout] 60 |                 None,
[INFO] [stdout] 61 ~             )
[INFO] [stdout] 62 ~         };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `i64`
[INFO] [stdout]    --> src/queries/habits_queries.rs:164:20
[INFO] [stdout]     |
[INFO] [stdout] 164 |             .limit(per_page.into())
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `per_page`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `i64`
[INFO] [stdout]    --> src/queries/habits_queries.rs:198:20
[INFO] [stdout]     |
[INFO] [stdout] 198 |             .limit(per_page.into())
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `per_page`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `i64`
[INFO] [stdout]    --> src/queries/habits_queries.rs:234:20
[INFO] [stdout]     |
[INFO] [stdout] 234 |             .limit(per_page.into())
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `per_page`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`)
[INFO] [stdout]   --> src/seeders.rs:65:35
[INFO] [stdout]    |
[INFO] [stdout] 65 |             frequency_type: match (i % 3) as i32 {
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^ help: try: `((i % 3))`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait
[INFO] [stdout]   --> src/seeders.rs:72:23
[INFO] [stdout]    |
[INFO] [stdout] 72 |             category: categories_ids[(i % categories_ids.len() as i32) as usize].clone(),
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `categories_ids[(i % categories_ids.len() as i32) as usize]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait
[INFO] [stdout]    --> src/seeders.rs:103:23
[INFO] [stdout]     |
[INFO] [stdout] 103 |             habit_id: habits_ids[(i % habits_ids.len() as i32) as usize].clone(),
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `habits_ids[(i % habits_ids.len() as i32) as usize]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/services/reminders_service.rs:31:19
[INFO] [stdout]    |
[INFO] [stdout] 31 |             body: format!("Your habit just restarted its period! Remember to do it today!"),
[INFO] [stdout]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Your habit just restarted its period! Remember to do it today!".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/utils/time.rs:77:9
[INFO] [stdout]    |
[INFO] [stdout] 64 | /         let get_next_date = match frequency_type {
[INFO] [stdout] 65 | |             HabFreqTypeEnum::daily => |date: NaiveDate| date + Duration::days(1),
[INFO] [stdout] 66 | |             HabFreqTypeEnum::daily2 => |date: NaiveDate| date + Duration::days(2),
[INFO] [stdout] 67 | |             HabFreqTypeEnum::weekly => |date: NaiveDate| date + Duration::weeks(1),
[INFO] [stdout] ...  |
[INFO] [stdout] 75 | |         };
[INFO] [stdout]    | |__________- unnecessary `let` binding
[INFO] [stdout] 76 |
[INFO] [stdout] 77 |           get_next_date
[INFO] [stdout]    |           ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]    = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 64 ~         
[INFO] [stdout] 65 |
[INFO] [stdout] 66 ~         match frequency_type {
[INFO] [stdout] 67 +             HabFreqTypeEnum::daily => |date: NaiveDate| date + Duration::days(1),
[INFO] [stdout] 68 +             HabFreqTypeEnum::daily2 => |date: NaiveDate| date + Duration::days(2),
[INFO] [stdout] 69 +             HabFreqTypeEnum::weekly => |date: NaiveDate| date + Duration::weeks(1),
[INFO] [stdout] 70 +             HabFreqTypeEnum::weekly2 => |date: NaiveDate| date + Duration::weeks(2),
[INFO] [stdout] 71 +             HabFreqTypeEnum::monthly => {
[INFO] [stdout] 72 +                 |date: NaiveDate| date.checked_add_months(Months::new(1)).unwrap()
[INFO] [stdout] 73 +             }
[INFO] [stdout] 74 +             HabFreqTypeEnum::monthly2 => {
[INFO] [stdout] 75 +                 |date: NaiveDate| date.checked_add_months(Months::new(2)).unwrap()
[INFO] [stdout] 76 +             }
[INFO] [stdout] 77 +         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/utils/time.rs:172:9
[INFO] [stdout]     |
[INFO] [stdout] 112 | /         let new_start_date = match frequency_type {
[INFO] [stdout] 113 | |             HabFreqTypeEnum::daily => start_date + Duration::days(difference.num_days()),
[INFO] [stdout] ...   |
[INFO] [stdout] 170 | |         };
[INFO] [stdout]     | |__________- unnecessary `let` binding
[INFO] [stdout] 171 |
[INFO] [stdout] 172 |           new_start_date
[INFO] [stdout]     |           ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 112 ~         
[INFO] [stdout] 113 |
[INFO] [stdout] 114 ~         match frequency_type {
[INFO] [stdout] 115 +             HabFreqTypeEnum::daily => start_date + Duration::days(difference.num_days()),
[INFO] [stdout] 116 + 
[INFO] [stdout] 117 +             // TODO: Fix this
[INFO] [stdout] 118 +             HabFreqTypeEnum::daily2 => {
[INFO] [stdout] 119 +                 let difference_parity = difference.num_days() % 2;
[INFO] [stdout] 120 + 
[INFO] [stdout] 121 +                 start_date + Duration::days(difference.num_days() + difference_parity)
[INFO] [stdout] 122 +             }
[INFO] [stdout] 123 +             HabFreqTypeEnum::weekly => {
[INFO] [stdout] 124 +                 let offset_days = (reference_day_of_week - start_day_of_week) % 7;
[INFO] [stdout] 125 + 
[INFO] [stdout] 126 +                 start_date + Duration::days(offset_days as i64)
[INFO] [stdout] 127 +             }
[INFO] [stdout] 128 +             HabFreqTypeEnum::weekly2 => {
[INFO] [stdout] 129 +                 let full_weeks_difference_parity = difference.num_weeks() % 2;
[INFO] [stdout] 130 +                 let offset_days = (reference_day_of_week - start_day_of_week) % 7;
[INFO] [stdout] 131 + 
[INFO] [stdout] 132 +                 // Complete a week when difference is odd
[INFO] [stdout] 133 +                 start_date
[INFO] [stdout] 134 +                     + Duration::days(offset_days as i64)
[INFO] [stdout] 135 +                     + Duration::weeks(full_weeks_difference_parity)
[INFO] [stdout] 136 +             }
[INFO] [stdout] 137 +             HabFreqTypeEnum::monthly => {
[INFO] [stdout] 138 +                 if start_day_of_month < reference_day_of_month {
[INFO] [stdout] 139 +                     // Just a fixed days offset is needed
[INFO] [stdout] 140 +                     start_date
[INFO] [stdout] 141 +                         + Duration::days((reference_day_of_month - start_day_of_month) as i64)
[INFO] [stdout] 142 +                 } else {
[INFO] [stdout] 143 +                     // Start day has passed reference day, so we must add a month and then subtract the difference
[INFO] [stdout] 144 +                     // to set the same day of the month
[INFO] [stdout] 145 +                     start_date.checked_add_months(Months::new(1)).unwrap()
[INFO] [stdout] 146 +                         + Duration::days(-((start_day_of_month - reference_day_of_month) as i64))
[INFO] [stdout] 147 +                 }
[INFO] [stdout] 148 +             }
[INFO] [stdout] 149 +             HabFreqTypeEnum::monthly2 => {
[INFO] [stdout] 150 +                 let reference_day_of_month = frequency_data.day();
[INFO] [stdout] 151 +                 let reference_month = frequency_data.month();
[INFO] [stdout] 152 +                 let start_day_of_month = start_date.day();
[INFO] [stdout] 153 +                 let start_month = start_date.month();
[INFO] [stdout] 154 + 
[INFO] [stdout] 155 +                 let month_difference_parity = (reference_month - start_month) % 2;
[INFO] [stdout] 156 + 
[INFO] [stdout] 157 +                 if start_day_of_month < reference_day_of_month {
[INFO] [stdout] 158 +                     // Just a fixed days offset is needed
[INFO] [stdout] 159 +                     start_date
[INFO] [stdout] 160 +                         .checked_sub_months(Months::new(month_difference_parity))
[INFO] [stdout] 161 +                         .unwrap()
[INFO] [stdout] 162 +                         + Duration::days((reference_day_of_month - start_day_of_month) as i64)
[INFO] [stdout] 163 +                 } else {
[INFO] [stdout] 164 +                     // Start day has passed reference day, so we must add a month and then subtract the difference
[INFO] [stdout] 165 +                     // to set the same day of the month
[INFO] [stdout] 166 +                     start_date
[INFO] [stdout] 167 +                         .checked_sub_months(Months::new(month_difference_parity))
[INFO] [stdout] 168 +                         .unwrap()
[INFO] [stdout] 169 +                         + Duration::days(-((start_day_of_month - reference_day_of_month) as i64))
[INFO] [stdout] 170 +                 }
[INFO] [stdout] 171 +             }
[INFO] [stdout] 172 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant redefinition of a binding `frequency_type`
[INFO] [stdout]   --> src/utils/time.rs:85:9
[INFO] [stdout]    |
[INFO] [stdout] 85 |         let frequency_type = frequency_type;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: `frequency_type` is initially defined here
[INFO] [stdout]   --> src/utils/time.rs:81:9
[INFO] [stdout]    |
[INFO] [stdout] 81 |         frequency_type: HabFreqTypeEnum,
[INFO] [stdout]    |         ^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals
[INFO] [stdout]    = note: `#[warn(clippy::redundant_locals)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `sched` after checking its variant with `is_err`
[INFO] [stdout]   --> src/main.rs:80:21
[INFO] [stdout]    |
[INFO] [stdout] 79 |     if !sched.is_err() {
[INFO] [stdout]    |         -------------- the check is happening here
[INFO] [stdout] 80 |         let sched = sched.unwrap();
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `job` after checking its variant with `is_err`
[INFO] [stdout]   --> src/main.rs:97:23
[INFO] [stdout]    |
[INFO] [stdout] 96 |         if !job.is_err() {
[INFO] [stdout]    |             ------------ the check is happening here
[INFO] [stdout] 97 |             let job = job.unwrap();
[INFO] [stdout]    |                       ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:79:8
[INFO] [stdout]    |
[INFO] [stdout] 79 |     if !sched.is_err() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^ help: try: `sched.is_ok()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:96:12
[INFO] [stdout]    |
[INFO] [stdout] 96 |         if !job.is_err() {
[INFO] [stdout]    |            ^^^^^^^^^^^^^ help: try: `job.is_ok()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:100:16
[INFO] [stdout]     |
[INFO] [stdout] 100 |             if !result.is_err() {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/main.rs:58:5
[INFO] [stdout]    |
[INFO] [stdout] 58 | /     if args.len() > 1 {
[INFO] [stdout] 59 | |         if args[1] == "seed" {
[INFO] [stdout] 60 | |             println!("Seeding database");
[INFO] [stdout] ...  |
[INFO] [stdout] 74 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 58 ~     if args.len() > 1
[INFO] [stdout] 59 ~         && args[1] == "seed" {
[INFO] [stdout] 60 |             println!("Seeding database");
[INFO] [stdout] ...
[INFO] [stdout] 72 |             return;
[INFO] [stdout] 73 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:104:24
[INFO] [stdout]     |
[INFO] [stdout] 104 |                     if !result.is_err() {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `err`
[INFO] [stdout]   --> src/db.rs:30:19
[INFO] [stdout]    |
[INFO] [stdout] 30 |         .or_else(|err| {
[INFO] [stdout]    |                   ^^^ help: if this is intentional, prefix it with an underscore: `_err`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `err`
[INFO] [stdout]   --> src/db.rs:58:19
[INFO] [stdout]    |
[INFO] [stdout] 58 |         .or_else(|err| {
[INFO] [stdout]    |                   ^^^ help: if this is intentional, prefix it with an underscore: `_err`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `err`
[INFO] [stdout]   --> src/db.rs:97:80
[INFO] [stdout]    |
[INFO] [stdout] 97 |     let connection_read = PgConnection::establish(&database_url_read).or_else(|err| {
[INFO] [stdout]    |                                                                                ^^^ help: if this is intentional, prefix it with an underscore: `_err`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `response`
[INFO] [stdout]   --> src/handlers/category_handler.rs:27:13
[INFO] [stdout]    |
[INFO] [stdout] 27 |         let response = GeneralResponse {
[INFO] [stdout]    |             ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_response`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `authentication`
[INFO] [stdout]   --> src/handlers/category_handler.rs:66:5
[INFO] [stdout]    |
[INFO] [stdout] 66 |     authentication: AuthData,
[INFO] [stdout]    |     ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_authentication`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `authentication`
[INFO] [stdout]   --> src/handlers/category_handler.rs:96:5
[INFO] [stdout]    |
[INFO] [stdout] 96 |     authentication: AuthData,
[INFO] [stdout]    |     ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_authentication`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `authentication`
[INFO] [stdout]    --> src/handlers/category_handler.rs:116:5
[INFO] [stdout]     |
[INFO] [stdout] 116 |     authentication: AuthData,
[INFO] [stdout]     |     ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_authentication`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `get_read_connection_establish` is never used
[INFO] [stdout]   --> src/db.rs:92:8
[INFO] [stdout]    |
[INFO] [stdout] 92 | pub fn get_read_connection_establish() -> Result<PgConnection, Error> {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `include_habits` is never read
[INFO] [stdout]   --> src/models/api/mod.rs:51:9
[INFO] [stdout]    |
[INFO] [stdout] 50 | pub struct DataIncludeParams {
[INFO] [stdout]    |            ----------------- field in this struct
[INFO] [stdout] 51 |     pub include_habits: Option<bool>,
[INFO] [stdout]    |         ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `DataIncludeParams` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/db.rs:21:38
[INFO] [stdout]    |
[INFO] [stdout] 21 |     let database_url_write: String = format!("{}", env::var("DATABASE_URL_WRITE").unwrap());
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `env::var("DATABASE_URL_WRITE").unwrap().to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]    = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
[INFO] [stdout]   --> src/db.rs:26:22
[INFO] [stdout]    |
[INFO] [stdout] 26 |       let pool_write = Pool::builder()
[INFO] [stdout]    |  ______________________^
[INFO] [stdout] 27 | |         .max_size(15)
[INFO] [stdout] 28 | |         .connection_timeout(Duration::from_secs(10))
[INFO] [stdout] 29 | |         .build(manager_write)
[INFO] [stdout] ...  |
[INFO] [stdout] 33 | |             )))
[INFO] [stdout] 34 | |         });
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
[INFO] [stdout]    = note: `#[warn(clippy::bind_instead_of_map)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 26 ~     let pool_write = Pool::builder()
[INFO] [stdout] 27 +         .max_size(15)
[INFO] [stdout] 28 +         .connection_timeout(Duration::from_secs(10))
[INFO] [stdout] 29 +         .build(manager_write).map_err(|err| Error::DBConnectionError2(ConnectionError::BadConnection(
[INFO] [stdout] 30 +                 "No read connection".to_string(),
[INFO] [stdout] 31 ~             )));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/db.rs:49:37
[INFO] [stdout]    |
[INFO] [stdout] 49 |     let database_url_read: String = format!("{}", env::var("DATABASE_URL_READ").unwrap());
[INFO] [stdout]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `env::var("DATABASE_URL_READ").unwrap().to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
[INFO] [stdout]   --> src/db.rs:54:21
[INFO] [stdout]    |
[INFO] [stdout] 54 |       let pool_read = Pool::builder()
[INFO] [stdout]    |  _____________________^
[INFO] [stdout] 55 | |         .max_size(15)
[INFO] [stdout] 56 | |         .connection_timeout(Duration::from_secs(10))
[INFO] [stdout] 57 | |         .build(manager_read)
[INFO] [stdout] ...  |
[INFO] [stdout] 61 | |             )))
[INFO] [stdout] 62 | |         });
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 54 ~     let pool_read = Pool::builder()
[INFO] [stdout] 55 +         .max_size(15)
[INFO] [stdout] 56 +         .connection_timeout(Duration::from_secs(10))
[INFO] [stdout] 57 +         .build(manager_read).map_err(|err| Error::DBConnectionError2(ConnectionError::BadConnection(
[INFO] [stdout] 58 +                 "No read connection".to_string(),
[INFO] [stdout] 59 ~             )));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/db.rs:76:38
[INFO] [stdout]    |
[INFO] [stdout] 76 |     let database_url_write: String = format!("{}", env::var("DATABASE_URL_WRITE").unwrap());
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `env::var("DATABASE_URL_WRITE").unwrap().to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
[INFO] [stdout]   --> src/db.rs:78:28
[INFO] [stdout]    |
[INFO] [stdout] 78 |       let connection_write = PgConnection::establish(&database_url_write).or_else(|err| {
[INFO] [stdout]    |  ____________________________^
[INFO] [stdout] 79 | |         print!("Error connecting to write database: {:?}", err);
[INFO] [stdout] 80 | |         Err(Error::DBConnectionError2(ConnectionError::BadConnection(
[INFO] [stdout] 81 | |             "No write connection".to_string(),
[INFO] [stdout] 82 | |         )))
[INFO] [stdout] 83 | |     });
[INFO] [stdout]    | |______^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
[INFO] [stdout] help: use `map_err` instead
[INFO] [stdout]    |
[INFO] [stdout] 78 ~     let connection_write = PgConnection::establish(&database_url_write).map_err(|err| {
[INFO] [stdout] 79 |         print!("Error connecting to write database: {:?}", err);
[INFO] [stdout] 80 ~         Error::DBConnectionError2(ConnectionError::BadConnection(
[INFO] [stdout] 81 +             "No write connection".to_string(),
[INFO] [stdout] 82 +         ))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/db.rs:95:37
[INFO] [stdout]    |
[INFO] [stdout] 95 |     let database_url_read: String = format!("{}", env::var("DATABASE_URL_READ").unwrap());
[INFO] [stdout]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `env::var("DATABASE_URL_READ").unwrap().to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
[INFO] [stdout]    --> src/db.rs:97:27
[INFO] [stdout]     |
[INFO] [stdout]  97 |       let connection_read = PgConnection::establish(&database_url_read).or_else(|err| {
[INFO] [stdout]     |  ___________________________^
[INFO] [stdout]  98 | |         Err(Error::DBConnectionError2(ConnectionError::BadConnection(
[INFO] [stdout]  99 | |             "No read connection".to_string(),
[INFO] [stdout] 100 | |         )))
[INFO] [stdout] 101 | |     });
[INFO] [stdout]     | |______^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout]  97 ~     let connection_read = PgConnection::establish(&database_url_read).map_err(|err| Error::DBConnectionError2(ConnectionError::BadConnection(
[INFO] [stdout]  98 +             "No read connection".to_string(),
[INFO] [stdout]  99 ~         )));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/error.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 |     ValidationError(ValidationErrors),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout]    = note: `#[warn(clippy::enum_variant_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/error.rs:13:5
[INFO] [stdout]    |
[INFO] [stdout] 13 |     DBConnectionError(#[from] diesel::r2d2::PoolError),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/error.rs:19:5
[INFO] [stdout]    |
[INFO] [stdout] 19 |     QueryError(#[from] diesel::result::Error),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/error.rs:22:5
[INFO] [stdout]    |
[INFO] [stdout] 22 |     DBError(#[from] diesel::r2d2::Error),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/error.rs:25:5
[INFO] [stdout]    |
[INFO] [stdout] 25 |     AuthorizationError(String),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]    --> src/error.rs:127:19
[INFO] [stdout]     |
[INFO] [stdout] 127 |     } else if let Some(_) = err.find::<warp::reject::MethodNotAllowed>() {
[INFO] [stdout]     |            -------^^^^^^^----------------------------------------------- help: try: `if err.find::<warp::reject::MethodNotAllowed>().is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]    --> src/error.rs:135:19
[INFO] [stdout]     |
[INFO] [stdout] 135 |     } else if let Some(_) = err.find::<warp::reject::InvalidQuery>() {
[INFO] [stdout]     |            -------^^^^^^^------------------------------------------- help: try: `if err.find::<warp::reject::InvalidQuery>().is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/error.rs:151:18
[INFO] [stdout]     |
[INFO] [stdout] 151 |         message: message.into(),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^ help: consider removing `.into()`: `message`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]     = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/handlers/category_handler.rs:34:18
[INFO] [stdout]    |
[INFO] [stdout] 34 |         message: format!("Successfully retrieved categories"),
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved categories".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/handlers/category_handler.rs:56:18
[INFO] [stdout]    |
[INFO] [stdout] 56 |         message: format!("Successfully retrieved category"),
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved category".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/handlers/events_handler.rs:41:5
[INFO] [stdout]    |
[INFO] [stdout] 41 |     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 41 -     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout] 41 +     Ok(with_status(json(&response), StatusCode::OK))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/handlers/events_handler.rs:37:18
[INFO] [stdout]    |
[INFO] [stdout] 37 |         message: format!("Successfully retrieved events"),
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved events".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/handlers/events_handler.rs:90:18
[INFO] [stdout]    |
[INFO] [stdout] 90 |         message: format!("Successfully retrieved habit data as calendar events"),
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habit data as calendar events".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/events_handler.rs:129:18
[INFO] [stdout]     |
[INFO] [stdout] 129 |         message: format!("Successfully retrieved habit data as calendar events"),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habit data as calendar events".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `data.collected_at` after checking its variant with `is_some`
[INFO] [stdout]   --> src/handlers/habit_data_handler.rs:63:54
[INFO] [stdout]    |
[INFO] [stdout] 62 |     if last_habit_data.len() > 0 && data.collected_at.is_some() {
[INFO] [stdout]    |                                     --------------------------- the check is happening here
[INFO] [stdout] 63 |         if last_habit_data[0].hab_dat_collected_at > data.collected_at.unwrap() {
[INFO] [stdout]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/handlers/habit_data_handler.rs:62:5
[INFO] [stdout]    |
[INFO] [stdout] 62 | /     if last_habit_data.len() > 0 && data.collected_at.is_some() {
[INFO] [stdout] 63 | |         if last_habit_data[0].hab_dat_collected_at > data.collected_at.unwrap() {
[INFO] [stdout] 64 | |             return Err(warp::reject::custom(Error::BadRequest(
[INFO] [stdout] 65 | |                 "Requested date is before the last habit's data".to_string(),
[INFO] [stdout] ...  |
[INFO] [stdout] 68 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]    = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 62 ~     if last_habit_data.len() > 0 && data.collected_at.is_some()
[INFO] [stdout] 63 ~         && last_habit_data[0].hab_dat_collected_at > data.collected_at.unwrap() {
[INFO] [stdout] 64 |             return Err(warp::reject::custom(Error::BadRequest(
[INFO] [stdout] 65 |                 "Requested date is before the last habit's data".to_string(),
[INFO] [stdout] 66 |             )));
[INFO] [stdout] 67 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/handlers/habit_data_handler.rs:62:8
[INFO] [stdout]    |
[INFO] [stdout] 62 |     if last_habit_data.len() > 0 && data.collected_at.is_some() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!last_habit_data.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_data_handler.rs:220:18
[INFO] [stdout]     |
[INFO] [stdout] 220 |         message: format!("Successfully retrieved habit data"),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habit data".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_data_handler.rs:273:18
[INFO] [stdout]     |
[INFO] [stdout] 273 |         message: format!("Successfully retrieved habit data"),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habit data".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_data_handler.rs:314:18
[INFO] [stdout]     |
[INFO] [stdout] 314 |         message: format!("Successfully retrieved user's habit data"),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved user's habit data".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/handlers/habit_handler.rs:54:18
[INFO] [stdout]    |
[INFO] [stdout] 54 |         message: format!("Habit created successfully"),
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Habit created successfully".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/handlers/habit_handler.rs:206:5
[INFO] [stdout]     |
[INFO] [stdout] 206 |     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 206 -     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout] 206 +     Ok(with_status(json(&response), StatusCode::OK))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_handler.rs:192:22
[INFO] [stdout]     |
[INFO] [stdout] 192 |             message: format!("Successfully retrieved habits & data for user"),
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habits & data for user".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_handler.rs:202:18
[INFO] [stdout]     |
[INFO] [stdout] 202 |         message: format!("Successfully retrieved habits for user"),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habits for user".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/handlers/habit_handler.rs:253:5
[INFO] [stdout]     |
[INFO] [stdout] 253 |     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 253 -     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout] 253 +     Ok(with_status(json(&response), StatusCode::OK))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait
[INFO] [stdout]    --> src/handlers/habit_handler.rs:221:23
[INFO] [stdout]     |
[INFO] [stdout] 221 |     let category_id = id.clone();
[INFO] [stdout]     |                       ^^^^^^^^^^ help: try removing the `clone` call: `id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/handlers/habit_handler.rs:223:5
[INFO] [stdout]     |
[INFO] [stdout] 223 |     let result: Result<Vec<Habit>, Error>;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]     = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `result` here and remove the assignments from the branches
[INFO] [stdout]     |
[INFO] [stdout] 223 ~     
[INFO] [stdout] 224 |
[INFO] [stdout] 225 ~     let result: Result<Vec<Habit>, Error> = if user_id == "admin".to_string() {
[INFO] [stdout] 226 ~         manager.get_all_category_habits(
[INFO] [stdout] 227 |             category_id,
[INFO] [stdout] 228 |             params.habits_page,
[INFO] [stdout] 229 |             params.habits_per_page,
[INFO] [stdout] 230 ~         )
[INFO] [stdout] 231 |     } else {
[INFO] [stdout] 232 ~         manager.get_all_user_category_habits(
[INFO] [stdout] 233 |             user_id,
[INFO] [stdout] ...
[INFO] [stdout] 236 |             params.habits_per_page,
[INFO] [stdout] 237 ~         )
[INFO] [stdout] 238 ~     };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]    --> src/handlers/habit_handler.rs:225:19
[INFO] [stdout]     |
[INFO] [stdout] 225 |     if user_id == "admin".to_string() {
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^ help: try: `"admin"`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]     = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_handler.rs:249:18
[INFO] [stdout]     |
[INFO] [stdout] 249 |         message: format!("Successfully retrieved habits for category"),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habits for category".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/handlers/habit_handler.rs:323:5
[INFO] [stdout]     |
[INFO] [stdout] 323 |     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 323 -     return Ok(with_status(json(&response), StatusCode::OK));
[INFO] [stdout] 323 +     Ok(with_status(json(&response), StatusCode::OK))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_handler.rs:310:22
[INFO] [stdout]     |
[INFO] [stdout] 310 |             message: format!("Successfully retrieved habit & recurrences & data"),
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habit & recurrences & data".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/handlers/habit_handler.rs:319:18
[INFO] [stdout]     |
[INFO] [stdout] 319 |         message: format!("Successfully retrieved habit"),
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Successfully retrieved habit".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]   --> src/queries/events_queries.rs:76:9
[INFO] [stdout]    |
[INFO] [stdout] 76 |         vec.sort_by(|a, b| b.date.cmp(&a.date));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_sort_by)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 76 -         vec.sort_by(|a, b| b.date.cmp(&a.date));
[INFO] [stdout] 76 +         vec.sort_by_key(|b| std::cmp::Reverse(b.date));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `habit_id` after checking its variant with `is_some`
[INFO] [stdout]    --> src/queries/events_queries.rs:109:51
[INFO] [stdout]     |
[INFO] [stdout] 108 |         if habit_id.is_some() {
[INFO] [stdout]     |         --------------------- help: try: `if let Some(<item>) = habit_id`
[INFO] [stdout] 109 |             query = query.filter(habit::hab_id.eq(habit_id.unwrap()));
[INFO] [stdout]     |                                                   ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/queries/habits_queries.rs:50:9
[INFO] [stdout]    |
[INFO] [stdout] 50 |         let closure_date: NaiveDate;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `closure_date` here and remove the assignments from the branches
[INFO] [stdout]    |
[INFO] [stdout] 50 ~         
[INFO] [stdout] 51 |
[INFO] [stdout] 52 ~         let closure_date: NaiveDate = if HABIT_CREATION_DATE_AS_REFERENCE {
[INFO] [stdout] 53 ~             current_date
[INFO] [stdout] 54 |         } else {
[INFO] [stdout] 55 ~             DateRange::get_next_closest_date(
[INFO] [stdout] 56 |                 data.frequency_type,
[INFO] [stdout] ...
[INFO] [stdout] 60 |                 None,
[INFO] [stdout] 61 ~             )
[INFO] [stdout] 62 ~         };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `i64`
[INFO] [stdout]    --> src/queries/habits_queries.rs:164:20
[INFO] [stdout]     |
[INFO] [stdout] 164 |             .limit(per_page.into())
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `per_page`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `i64`
[INFO] [stdout]    --> src/queries/habits_queries.rs:198:20
[INFO] [stdout]     |
[INFO] [stdout] 198 |             .limit(per_page.into())
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `per_page`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `i64`
[INFO] [stdout]    --> src/queries/habits_queries.rs:234:20
[INFO] [stdout]     |
[INFO] [stdout] 234 |             .limit(per_page.into())
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `per_page`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`)
[INFO] [stdout]   --> src/seeders.rs:65:35
[INFO] [stdout]    |
[INFO] [stdout] 65 |             frequency_type: match (i % 3) as i32 {
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^ help: try: `((i % 3))`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait
[INFO] [stdout]   --> src/seeders.rs:72:23
[INFO] [stdout]    |
[INFO] [stdout] 72 |             category: categories_ids[(i % categories_ids.len() as i32) as usize].clone(),
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `categories_ids[(i % categories_ids.len() as i32) as usize]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait
[INFO] [stdout]    --> src/seeders.rs:103:23
[INFO] [stdout]     |
[INFO] [stdout] 103 |             habit_id: habits_ids[(i % habits_ids.len() as i32) as usize].clone(),
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `habits_ids[(i % habits_ids.len() as i32) as usize]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/services/reminders_service.rs:31:19
[INFO] [stdout]    |
[INFO] [stdout] 31 |             body: format!("Your habit just restarted its period! Remember to do it today!"),
[INFO] [stdout]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Your habit just restarted its period! Remember to do it today!".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]   --> src/utils/time.rs:77:9
[INFO] [stdout]    |
[INFO] [stdout] 64 | /         let get_next_date = match frequency_type {
[INFO] [stdout] 65 | |             HabFreqTypeEnum::daily => |date: NaiveDate| date + Duration::days(1),
[INFO] [stdout] 66 | |             HabFreqTypeEnum::daily2 => |date: NaiveDate| date + Duration::days(2),
[INFO] [stdout] 67 | |             HabFreqTypeEnum::weekly => |date: NaiveDate| date + Duration::weeks(1),
[INFO] [stdout] ...  |
[INFO] [stdout] 75 | |         };
[INFO] [stdout]    | |__________- unnecessary `let` binding
[INFO] [stdout] 76 |
[INFO] [stdout] 77 |           get_next_date
[INFO] [stdout]    |           ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]    = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]    |
[INFO] [stdout] 64 ~         
[INFO] [stdout] 65 |
[INFO] [stdout] 66 ~         match frequency_type {
[INFO] [stdout] 67 +             HabFreqTypeEnum::daily => |date: NaiveDate| date + Duration::days(1),
[INFO] [stdout] 68 +             HabFreqTypeEnum::daily2 => |date: NaiveDate| date + Duration::days(2),
[INFO] [stdout] 69 +             HabFreqTypeEnum::weekly => |date: NaiveDate| date + Duration::weeks(1),
[INFO] [stdout] 70 +             HabFreqTypeEnum::weekly2 => |date: NaiveDate| date + Duration::weeks(2),
[INFO] [stdout] 71 +             HabFreqTypeEnum::monthly => {
[INFO] [stdout] 72 +                 |date: NaiveDate| date.checked_add_months(Months::new(1)).unwrap()
[INFO] [stdout] 73 +             }
[INFO] [stdout] 74 +             HabFreqTypeEnum::monthly2 => {
[INFO] [stdout] 75 +                 |date: NaiveDate| date.checked_add_months(Months::new(2)).unwrap()
[INFO] [stdout] 76 +             }
[INFO] [stdout] 77 +         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/utils/time.rs:172:9
[INFO] [stdout]     |
[INFO] [stdout] 112 | /         let new_start_date = match frequency_type {
[INFO] [stdout] 113 | |             HabFreqTypeEnum::daily => start_date + Duration::days(difference.num_days()),
[INFO] [stdout] ...   |
[INFO] [stdout] 170 | |         };
[INFO] [stdout]     | |__________- unnecessary `let` binding
[INFO] [stdout] 171 |
[INFO] [stdout] 172 |           new_start_date
[INFO] [stdout]     |           ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 112 ~         
[INFO] [stdout] 113 |
[INFO] [stdout] 114 ~         match frequency_type {
[INFO] [stdout] 115 +             HabFreqTypeEnum::daily => start_date + Duration::days(difference.num_days()),
[INFO] [stdout] 116 + 
[INFO] [stdout] 117 +             // TODO: Fix this
[INFO] [stdout] 118 +             HabFreqTypeEnum::daily2 => {
[INFO] [stdout] 119 +                 let difference_parity = difference.num_days() % 2;
[INFO] [stdout] 120 + 
[INFO] [stdout] 121 +                 start_date + Duration::days(difference.num_days() + difference_parity)
[INFO] [stdout] 122 +             }
[INFO] [stdout] 123 +             HabFreqTypeEnum::weekly => {
[INFO] [stdout] 124 +                 let offset_days = (reference_day_of_week - start_day_of_week) % 7;
[INFO] [stdout] 125 + 
[INFO] [stdout] 126 +                 start_date + Duration::days(offset_days as i64)
[INFO] [stdout] 127 +             }
[INFO] [stdout] 128 +             HabFreqTypeEnum::weekly2 => {
[INFO] [stdout] 129 +                 let full_weeks_difference_parity = difference.num_weeks() % 2;
[INFO] [stdout] 130 +                 let offset_days = (reference_day_of_week - start_day_of_week) % 7;
[INFO] [stdout] 131 + 
[INFO] [stdout] 132 +                 // Complete a week when difference is odd
[INFO] [stdout] 133 +                 start_date
[INFO] [stdout] 134 +                     + Duration::days(offset_days as i64)
[INFO] [stdout] 135 +                     + Duration::weeks(full_weeks_difference_parity)
[INFO] [stdout] 136 +             }
[INFO] [stdout] 137 +             HabFreqTypeEnum::monthly => {
[INFO] [stdout] 138 +                 if start_day_of_month < reference_day_of_month {
[INFO] [stdout] 139 +                     // Just a fixed days offset is needed
[INFO] [stdout] 140 +                     start_date
[INFO] [stdout] 141 +                         + Duration::days((reference_day_of_month - start_day_of_month) as i64)
[INFO] [stdout] 142 +                 } else {
[INFO] [stdout] 143 +                     // Start day has passed reference day, so we must add a month and then subtract the difference
[INFO] [stdout] 144 +                     // to set the same day of the month
[INFO] [stdout] 145 +                     start_date.checked_add_months(Months::new(1)).unwrap()
[INFO] [stdout] 146 +                         + Duration::days(-((start_day_of_month - reference_day_of_month) as i64))
[INFO] [stdout] 147 +                 }
[INFO] [stdout] 148 +             }
[INFO] [stdout] 149 +             HabFreqTypeEnum::monthly2 => {
[INFO] [stdout] 150 +                 let reference_day_of_month = frequency_data.day();
[INFO] [stdout] 151 +                 let reference_month = frequency_data.month();
[INFO] [stdout] 152 +                 let start_day_of_month = start_date.day();
[INFO] [stdout] 153 +                 let start_month = start_date.month();
[INFO] [stdout] 154 + 
[INFO] [stdout] 155 +                 let month_difference_parity = (reference_month - start_month) % 2;
[INFO] [stdout] 156 + 
[INFO] [stdout] 157 +                 if start_day_of_month < reference_day_of_month {
[INFO] [stdout] 158 +                     // Just a fixed days offset is needed
[INFO] [stdout] 159 +                     start_date
[INFO] [stdout] 160 +                         .checked_sub_months(Months::new(month_difference_parity))
[INFO] [stdout] 161 +                         .unwrap()
[INFO] [stdout] 162 +                         + Duration::days((reference_day_of_month - start_day_of_month) as i64)
[INFO] [stdout] 163 +                 } else {
[INFO] [stdout] 164 +                     // Start day has passed reference day, so we must add a month and then subtract the difference
[INFO] [stdout] 165 +                     // to set the same day of the month
[INFO] [stdout] 166 +                     start_date
[INFO] [stdout] 167 +                         .checked_sub_months(Months::new(month_difference_parity))
[INFO] [stdout] 168 +                         .unwrap()
[INFO] [stdout] 169 +                         + Duration::days(-((start_day_of_month - reference_day_of_month) as i64))
[INFO] [stdout] 170 +                 }
[INFO] [stdout] 171 +             }
[INFO] [stdout] 172 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant redefinition of a binding `frequency_type`
[INFO] [stdout]   --> src/utils/time.rs:85:9
[INFO] [stdout]    |
[INFO] [stdout] 85 |         let frequency_type = frequency_type;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: `frequency_type` is initially defined here
[INFO] [stdout]   --> src/utils/time.rs:81:9
[INFO] [stdout]    |
[INFO] [stdout] 81 |         frequency_type: HabFreqTypeEnum,
[INFO] [stdout]    |         ^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals
[INFO] [stdout]    = note: `#[warn(clippy::redundant_locals)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `sched` after checking its variant with `is_err`
[INFO] [stdout]   --> src/main.rs:80:21
[INFO] [stdout]    |
[INFO] [stdout] 79 |     if !sched.is_err() {
[INFO] [stdout]    |         -------------- the check is happening here
[INFO] [stdout] 80 |         let sched = sched.unwrap();
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `job` after checking its variant with `is_err`
[INFO] [stdout]   --> src/main.rs:97:23
[INFO] [stdout]    |
[INFO] [stdout] 96 |         if !job.is_err() {
[INFO] [stdout]    |             ------------ the check is happening here
[INFO] [stdout] 97 |             let job = job.unwrap();
[INFO] [stdout]    |                       ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:79:8
[INFO] [stdout]    |
[INFO] [stdout] 79 |     if !sched.is_err() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^ help: try: `sched.is_ok()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:96:12
[INFO] [stdout]    |
[INFO] [stdout] 96 |         if !job.is_err() {
[INFO] [stdout]    |            ^^^^^^^^^^^^^ help: try: `job.is_ok()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:100:16
[INFO] [stdout]     |
[INFO] [stdout] 100 |             if !result.is_err() {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/main.rs:58:5
[INFO] [stdout]    |
[INFO] [stdout] 58 | /     if args.len() > 1 {
[INFO] [stdout] 59 | |         if args[1] == "seed" {
[INFO] [stdout] 60 | |             println!("Seeding database");
[INFO] [stdout] ...  |
[INFO] [stdout] 74 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 58 ~     if args.len() > 1
[INFO] [stdout] 59 ~         && args[1] == "seed" {
[INFO] [stdout] 60 |             println!("Seeding database");
[INFO] [stdout] ...
[INFO] [stdout] 72 |             return;
[INFO] [stdout] 73 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:104:24
[INFO] [stdout]     |
[INFO] [stdout] 104 |                     if !result.is_err() {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 21s
[INFO] running `Command { std: "docker" "inspect" "f640f6ae5229edc6b007282d4be890e5c3fb4139ef1422a03b60bf4acbae0ce6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "f640f6ae5229edc6b007282d4be890e5c3fb4139ef1422a03b60bf4acbae0ce6", kill_on_drop: false }`
[INFO] [stdout] f640f6ae5229edc6b007282d4be890e5c3fb4139ef1422a03b60bf4acbae0ce6