[INFO] cloning repository https://github.com/Arpt-Singh/embedded_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Arpt-Singh/embedded_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FArpt-Singh%2Fembedded_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FArpt-Singh%2Fembedded_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 297ea598ccfb8dfb87ecc3c985cf87d21f10dca2 [INFO] linting Arpt-Singh/embedded_rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FArpt-Singh%2Fembedded_rust" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] [stderr] Updating files: 22% (669/2937) Updating files: 23% (676/2937) Updating files: 24% (705/2937) Updating files: 25% (735/2937) Updating files: 26% (764/2937) Updating files: 27% (793/2937) Updating files: 28% (823/2937) Updating files: 29% (852/2937) Updating files: 30% (882/2937) Updating files: 31% (911/2937) Updating files: 32% (940/2937) Updating files: 33% (970/2937) Updating files: 34% (999/2937) Updating files: 35% (1028/2937) Updating files: 36% (1058/2937) Updating files: 37% (1087/2937) Updating files: 38% (1117/2937) Updating files: 39% (1146/2937) Updating files: 40% (1175/2937) Updating files: 41% (1205/2937) Updating files: 42% (1234/2937) Updating files: 43% (1263/2937) Updating files: 44% (1293/2937) Updating files: 45% (1322/2937) Updating files: 46% (1352/2937) Updating files: 47% (1381/2937) Updating files: 48% (1410/2937) Updating files: 49% (1440/2937) Updating files: 50% (1469/2937) Updating files: 51% (1498/2937) Updating files: 52% (1528/2937) Updating files: 53% (1557/2937) Updating files: 54% (1586/2937) Updating files: 55% (1616/2937) Updating files: 56% (1645/2937) Updating files: 57% (1675/2937) Updating files: 58% (1704/2937) Updating files: 59% (1733/2937) Updating files: 60% (1763/2937) Updating files: 61% (1792/2937) Updating files: 62% (1821/2937) Updating files: 63% (1851/2937) Updating files: 64% (1880/2937) Updating files: 65% (1910/2937) Updating files: 66% (1939/2937) Updating files: 67% (1968/2937) Updating files: 68% (1998/2937) Updating files: 69% (2027/2937) Updating files: 70% (2056/2937) Updating files: 71% (2086/2937) Updating files: 72% (2115/2937) Updating files: 73% (2145/2937) Updating files: 73% (2171/2937) Updating files: 74% (2174/2937) Updating files: 75% (2203/2937) Updating files: 76% (2233/2937) Updating files: 77% (2262/2937) Updating files: 78% (2291/2937) Updating files: 79% (2321/2937) Updating files: 80% (2350/2937) Updating files: 80% (2377/2937) Updating files: 81% (2379/2937) Updating files: 82% (2409/2937) Updating files: 83% (2438/2937) Updating files: 84% (2468/2937) Updating files: 84% (2490/2937) Updating files: 85% (2497/2937) Updating files: 86% (2526/2937) Updating files: 87% (2556/2937) Updating files: 88% (2585/2937) Updating files: 89% (2614/2937) Updating files: 90% (2644/2937) Updating files: 91% (2673/2937) Updating files: 92% (2703/2937) Updating files: 93% (2732/2937) Updating files: 94% (2761/2937) Updating files: 95% (2791/2937) Updating files: 96% (2820/2937) Updating files: 97% (2849/2937) Updating files: 98% (2879/2937) Updating files: 98% (2891/2937) Updating files: 99% (2908/2937) Updating files: 100% (2937/2937) Updating files: 100% (2937/2937), done. [INFO] started tweaking git repo https://github.com/Arpt-Singh/embedded_rust [INFO] finished tweaking git repo https://github.com/Arpt-Singh/embedded_rust [INFO] tweaked toml for git repo https://github.com/Arpt-Singh/embedded_rust written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Arpt-Singh/embedded_rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Arpt-Singh/embedded_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ab5621d8d37bb9565a277089eee43af545bc0b1aea0e2ef51c5ad95f74199116 [INFO] running `Command { std: "docker" "start" "-a" "ab5621d8d37bb9565a277089eee43af545bc0b1aea0e2ef51c5ad95f74199116", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ab5621d8d37bb9565a277089eee43af545bc0b1aea0e2ef51c5ad95f74199116", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab5621d8d37bb9565a277089eee43af545bc0b1aea0e2ef51c5ad95f74199116", kill_on_drop: false }` [INFO] [stdout] ab5621d8d37bb9565a277089eee43af545bc0b1aea0e2ef51c5ad95f74199116 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 604c42cc360a0e3ccfec398b4ffd7bfdf9a573c31f03f0339f88a22569eb92cd [INFO] running `Command { std: "docker" "start" "-a" "604c42cc360a0e3ccfec398b4ffd7bfdf9a573c31f03f0339f88a22569eb92cd", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Checking embedded_rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: type `person` should have an upper camel case name [INFO] [stdout] --> closures.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | struct person{ [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Person` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> mystructs.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / #[allow(dead_code)] [INFO] [stdout] 3 | | [INFO] [stdout] | |_^ [INFO] [stdout] 4 | enum VehicalColor { [INFO] [stdout] | ----------------- the attribute applies to this enum [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the attribute should apply to the parent module use an inner attribute [INFO] [stdout] | [INFO] [stdout] 2 | #![allow(dead_code)] [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `silver` should have an upper camel case name [INFO] [stdout] --> mystructs.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | silver, [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Silver` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `blue` should have an upper camel case name [INFO] [stdout] --> mystructs.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | blue, [INFO] [stdout] | ^^^^ help: convert the identifier to upper camel case: `Blue` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `red` should have an upper camel case name [INFO] [stdout] --> mystructs.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | red, [INFO] [stdout] | ^^^ help: convert the identifier to upper camel case: `Red` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `black` should have an upper camel case name [INFO] [stdout] --> mystructs.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | black, [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case: `Black` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `white` should have an upper camel case name [INFO] [stdout] --> mystructs.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | white, [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `White` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `green` should have an upper camel case name [INFO] [stdout] --> mystructs.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | green [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case: `Green` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `cat` should have an upper camel case name [INFO] [stdout] --> test_traits.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | struct cat {} [INFO] [stdout] | ^^^ help: convert the identifier to upper camel case (notice the capitalization): `Cat` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `tiger` should have an upper camel case name [INFO] [stdout] --> test_traits.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 29 | struct tiger {} [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case: `Tiger` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ops::Sub` [INFO] [stdout] --> mydatetime.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | use std::{ops::Sub, time::{Duration,Instant}}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread::spawn` [INFO] [stdout] --> myscopedthread.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::thread::spawn; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `spawn` [INFO] [stdout] --> mymutex.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | use std::thread::{spawn,scope, sleep}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::myargs` [INFO] [stdout] --> myargs.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::myargs; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `person` should have an upper camel case name [INFO] [stdout] --> closures.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | struct person{ [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Person` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> mystructs.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / #[allow(dead_code)] [INFO] [stdout] 3 | | [INFO] [stdout] | |_^ [INFO] [stdout] 4 | enum VehicalColor { [INFO] [stdout] | ----------------- the attribute applies to this enum [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the attribute should apply to the parent module use an inner attribute [INFO] [stdout] | [INFO] [stdout] 2 | #![allow(dead_code)] [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `silver` should have an upper camel case name [INFO] [stdout] --> mystructs.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | silver, [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Silver` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `blue` should have an upper camel case name [INFO] [stdout] --> mystructs.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | blue, [INFO] [stdout] | ^^^^ help: convert the identifier to upper camel case: `Blue` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `red` should have an upper camel case name [INFO] [stdout] --> mystructs.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | red, [INFO] [stdout] | ^^^ help: convert the identifier to upper camel case: `Red` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `black` should have an upper camel case name [INFO] [stdout] --> mystructs.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | black, [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case: `Black` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `white` should have an upper camel case name [INFO] [stdout] --> mystructs.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | white, [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `White` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `green` should have an upper camel case name [INFO] [stdout] --> mystructs.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | green [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case: `Green` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `cat` should have an upper camel case name [INFO] [stdout] --> test_traits.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | struct cat {} [INFO] [stdout] | ^^^ help: convert the identifier to upper camel case (notice the capitalization): `Cat` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `tiger` should have an upper camel case name [INFO] [stdout] --> test_traits.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 29 | struct tiger {} [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case: `Tiger` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ops::Sub` [INFO] [stdout] --> mydatetime.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | use std::{ops::Sub, time::{Duration,Instant}}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread::spawn` [INFO] [stdout] --> myscopedthread.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::thread::spawn; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `spawn` [INFO] [stdout] --> mymutex.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | use std::thread::{spawn,scope, sleep}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::myargs` [INFO] [stdout] --> myargs.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::myargs; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `opt1` is never read [INFO] [stdout] --> optiontest.rs:2:31 [INFO] [stdout] | [INFO] [stdout] 2 | let mut opt1: Option= None; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `opt1` is never read [INFO] [stdout] --> optiontest.rs:8:31 [INFO] [stdout] | [INFO] [stdout] 8 | let mut opt1:Option = None; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `chartype` is never read [INFO] [stdout] --> optiontest.rs:15:46 [INFO] [stdout] | [INFO] [stdout] 15 | let mut chartype:Option = None; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pet1` [INFO] [stdout] --> test_traits.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | let pet1 = Dog{}; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_pet1` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pet3` [INFO] [stdout] --> test_traits.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | let pet3 = Bear{}; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_pet3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pet4` [INFO] [stdout] --> test_traits.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | let pet4 = tiger{}; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_pet4` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> myiters.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | let mut fruit_list_strings = fruit_list.iter().map(|e| String::from(*e) ); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_foods` [INFO] [stdout] --> myiters.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | let all_foods:Vec<&&str> = aggregate_foods.clone().collect(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_all_foods` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `last_item` [INFO] [stdout] --> myiters.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | let last_item = new_fruits.clone().last(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_item` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `opt1` is never read [INFO] [stdout] --> optiontest.rs:2:31 [INFO] [stdout] | [INFO] [stdout] 2 | let mut opt1: Option= None; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `opt1` is never read [INFO] [stdout] --> optiontest.rs:8:31 [INFO] [stdout] | [INFO] [stdout] 8 | let mut opt1:Option = None; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `chartype` is never read [INFO] [stdout] --> optiontest.rs:15:46 [INFO] [stdout] | [INFO] [stdout] 15 | let mut chartype:Option = None; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> mymutex.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | let mut score = Mutex::new(0u128); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pet1` [INFO] [stdout] --> test_traits.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | let pet1 = Dog{}; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_pet1` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pet3` [INFO] [stdout] --> test_traits.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | let pet3 = Bear{}; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_pet3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pet4` [INFO] [stdout] --> test_traits.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | let pet4 = tiger{}; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_pet4` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> myargs.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | let mut myargs:Vec= args().collect(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `driver_license` [INFO] [stdout] --> main.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | let driver_license = false; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_driver_license` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `drivers_license` [INFO] [stdout] --> main.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | let drivers_license = if age>=16 {true} else {false}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_drivers_license` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `first_name` is never read [INFO] [stdout] --> closures.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 1 | struct person{ [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 2 | first_name:String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `manufacturer`, `model`, and `year` are never read [INFO] [stdout] --> mystructs.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 21 | struct Vehicle { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 22 | manufacturer: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 23 | model: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 24 | year: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Vehicle` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `new_vehical` is never used [INFO] [stdout] --> mystructs.rs:39:4 [INFO] [stdout] | [INFO] [stdout] 39 | fn new_vehical()-> Vehicle { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `first_name` is never read [INFO] [stdout] --> test_traits.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 1 | struct Person { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 2 | first_name: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> helpers.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | return full_name; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return full_name; [INFO] [stdout] 4 + full_name [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> helpers.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | return age+5; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return age+5; [INFO] [stdout] 13 + age+5 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> optiontest.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | return opt1; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return opt1; [INFO] [stdout] 4 + opt1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> optiontest.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | return opt1; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return opt1; [INFO] [stdout] 10 + opt1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> optiontest.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return chartype; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return chartype; [INFO] [stdout] 17 + chartype [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> optiontest.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | / impl ToString for CharaterType{ [INFO] [stdout] 28 | | fn to_string(&self) -> String { [INFO] [stdout] 29 | | match self { [INFO] [stdout] 30 | | CharaterType::Archer => "Archer".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 37 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> myiters.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | let mut fruit_list_strings = fruit_list.iter().map(|e| String::from(*e) ); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_foods` [INFO] [stdout] --> myiters.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | let all_foods:Vec<&&str> = aggregate_foods.clone().collect(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_all_foods` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `last_item` [INFO] [stdout] --> myiters.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | let last_item = new_fruits.clone().last(); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_item` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mystructs.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | return new_vehicle; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return new_vehicle; [INFO] [stdout] 35 + new_vehicle [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mystructs.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return v1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return v1; [INFO] [stdout] 42 + v1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> mymutex.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | let mut score = Mutex::new(0u128); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> myargs.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | let mut myargs:Vec= args().collect(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mystructs.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | return p1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return p1; [INFO] [stdout] 55 + p1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `driver_license` [INFO] [stdout] --> main.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | let driver_license = false; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_driver_license` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> test_traits.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 12 | fn make_sound(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `drivers_license` [INFO] [stdout] --> main.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | let drivers_license = if age>=16 {true} else {false}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_drivers_license` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> test_traits.rs:19:25 [INFO] [stdout] | [INFO] [stdout] 19 | fn make_sound(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `first_name` is never read [INFO] [stdout] --> closures.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 1 | struct person{ [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 2 | first_name:String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> test_traits.rs:25:25 [INFO] [stdout] | [INFO] [stdout] 25 | fn make_sound(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> test_traits.rs:31:25 [INFO] [stdout] | [INFO] [stdout] 31 | fn make_sound(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `manufacturer`, `model`, and `year` are never read [INFO] [stdout] --> mystructs.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 21 | struct Vehicle { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 22 | manufacturer: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 23 | model: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 24 | year: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Vehicle` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `new_vehical` is never used [INFO] [stdout] --> mystructs.rs:39:4 [INFO] [stdout] | [INFO] [stdout] 39 | fn new_vehical()-> Vehicle { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `first_name` is never read [INFO] [stdout] --> test_traits.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 1 | struct Person { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 2 | first_name: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> myvec.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | / let mut my_ints:Vec= Vec::new(); [INFO] [stdout] 3 | | [INFO] [stdout] 4 | | my_ints.push(30); [INFO] [stdout] 5 | | my_ints.push(40); [INFO] [stdout] ... | [INFO] [stdout] 8 | | my_ints.push(70); [INFO] [stdout] 9 | | my_ints.push(80); [INFO] [stdout] | |_____________________^ help: consider using the `vec![]` macro: `let my_ints: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> helpers.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | return full_name; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return full_name; [INFO] [stdout] 4 + full_name [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> myvec.rs:16:47 [INFO] [stdout] | [INFO] [stdout] 16 | println!("first element in Vec is :{:?}",&(&my_ints).as_slice()[0..5]); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `my_ints` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> myhashmap.rs:11:23 [INFO] [stdout] | [INFO] [stdout] 11 | stock_list.remove(&("AAPL".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `"AAPL"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> helpers.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | return age+5; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return age+5; [INFO] [stdout] 13 + age+5 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> myiters.rs:23:76 [INFO] [stdout] | [INFO] [stdout] 23 | let new_fruits = fruit_list_strings.map(|mut e| {{e.push_str("fruit")};return e;}); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - let new_fruits = fruit_list_strings.map(|mut e| {{e.push_str("fruit")};return e;}); [INFO] [stdout] 23 + let new_fruits = fruit_list_strings.map(|mut e| {{e.push_str("fruit")};e}); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary operation [INFO] [stdout] --> myiters.rs:23:54 [INFO] [stdout] | [INFO] [stdout] 23 | let new_fruits = fruit_list_strings.map(|mut e| {{e.push_str("fruit")};return e;}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `e.push_str("fruit");` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stdout] = note: `#[warn(clippy::unnecessary_operation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> myiters.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | let last_item = new_fruits.clone().last(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 - let last_item = new_fruits.clone().last(); [INFO] [stdout] 27 + let last_item = new_fruits.clone().next_back(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> optiontest.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | return opt1; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return opt1; [INFO] [stdout] 4 + opt1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> optiontest.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | return opt1; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return opt1; [INFO] [stdout] 10 + opt1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> optiontest.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return chartype; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return chartype; [INFO] [stdout] 17 + chartype [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> optiontest.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | / impl ToString for CharaterType{ [INFO] [stdout] 28 | | fn to_string(&self) -> String { [INFO] [stdout] 29 | | match self { [INFO] [stdout] 30 | | CharaterType::Archer => "Archer".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 37 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mystructs.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | return new_vehicle; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return new_vehicle; [INFO] [stdout] 35 + new_vehicle [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mystructs.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return v1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return v1; [INFO] [stdout] 42 + v1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mystructs.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | return p1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return p1; [INFO] [stdout] 55 + p1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> test_traits.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 12 | fn make_sound(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> test_traits.rs:19:25 [INFO] [stdout] | [INFO] [stdout] 19 | fn make_sound(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> test_traits.rs:25:25 [INFO] [stdout] | [INFO] [stdout] 25 | fn make_sound(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> test_traits.rs:31:25 [INFO] [stdout] | [INFO] [stdout] 31 | fn make_sound(&self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> myvec.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | / let mut my_ints:Vec= Vec::new(); [INFO] [stdout] 3 | | [INFO] [stdout] 4 | | my_ints.push(30); [INFO] [stdout] 5 | | my_ints.push(40); [INFO] [stdout] ... | [INFO] [stdout] 8 | | my_ints.push(70); [INFO] [stdout] 9 | | my_ints.push(80); [INFO] [stdout] | |_____________________^ help: consider using the `vec![]` macro: `let my_ints: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> myvec.rs:16:47 [INFO] [stdout] | [INFO] [stdout] 16 | println!("first element in Vec is :{:?}",&(&my_ints).as_slice()[0..5]); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `my_ints` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> myhashmap.rs:11:23 [INFO] [stdout] | [INFO] [stdout] 11 | stock_list.remove(&("AAPL".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `"AAPL"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `guard` after checking its variant with `is_ok` [INFO] [stdout] --> mymutex.rs:31:32 [INFO] [stdout] | [INFO] [stdout] 30 | if guard.is_ok() { [INFO] [stdout] | ---------------- help: try: `if let Ok() = guard` [INFO] [stdout] 31 | let mut data = guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> mymutex.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | / _= scope(|s| { [INFO] [stdout] 44 | | s.spawn(myfunc2).join(); [INFO] [stdout] 45 | | s.spawn(myfunc).join(); // thread one is working on mutex [INFO] [stdout] ... | [INFO] [stdout] 48 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 43 - _= scope(|s| { [INFO] [stdout] 43 + scope(|s| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `receive_result` after checking its variant with `is_ok` [INFO] [stdout] --> mympsc.rs:23:47 [INFO] [stdout] | [INFO] [stdout] 22 | if receive_result.is_ok(){ [INFO] [stdout] | ------------------------- help: try: `if let Ok() = receive_result` [INFO] [stdout] 23 | print!("received message: {}",receive_result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> myiters.rs:23:76 [INFO] [stdout] | [INFO] [stdout] 23 | let new_fruits = fruit_list_strings.map(|mut e| {{e.push_str("fruit")};return e;}); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - let new_fruits = fruit_list_strings.map(|mut e| {{e.push_str("fruit")};return e;}); [INFO] [stdout] 23 + let new_fruits = fruit_list_strings.map(|mut e| {{e.push_str("fruit")};e}); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary operation [INFO] [stdout] --> myiters.rs:23:54 [INFO] [stdout] | [INFO] [stdout] 23 | let new_fruits = fruit_list_strings.map(|mut e| {{e.push_str("fruit")};return e;}); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `e.push_str("fruit");` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stdout] = note: `#[warn(clippy::unnecessary_operation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> myfs.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | return a; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return a; [INFO] [stdout] 10 + a [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> myiters.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | let last_item = new_fruits.clone().last(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 - let last_item = new_fruits.clone().last(); [INFO] [stdout] 27 + let last_item = new_fruits.clone().next_back(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> myargs.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 18 | if !parsed_year.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `parsed_year.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> myargs.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return Dog {name,year_born}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Dog {name,year_born}; [INFO] [stdout] 33 + Dog {name,year_born} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> main.rs:118:27 [INFO] [stdout] | [INFO] [stdout] 118 | let drivers_license = if age>=16 {true} else {false}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `age >= 16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> myiters.rs:2:22 [INFO] [stdout] | [INFO] [stdout] 2 | let fruit_list = vec!["strawberry","blueberry","mango","Apple","Orange"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["strawberry","blueberry","mango","Apple","Orange"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> myiters.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 37 | let first_name = vec!["Trevor","Shannon","James","Tasha"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["Trevor","Shannon","James","Tasha"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> myiters.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | let last_name = vec!["Jones","Sullivan","Tanner","Redman"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["Jones","Sullivan","Tanner","Redman"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> mymutex.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | s.spawn(myfunc2).join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 44 | let _ = s.spawn(myfunc2).join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> mymutex.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | s.spawn(myfunc).join(); // thread one is working on mutex [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 45 | let _ = s.spawn(myfunc).join(); // thread one is working on mutex [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> mympsc.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | rx.recv_timeout(Duration::from_millis(300)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 7 | let _ = rx.recv_timeout(Duration::from_millis(300)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> mympsc.rs:46:4 [INFO] [stdout] | [INFO] [stdout] 46 | std::thread::spawn(processor_code).join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 46 | let _ = std::thread::spawn(processor_code).join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `guard` after checking its variant with `is_ok` [INFO] [stdout] --> mymutex.rs:31:32 [INFO] [stdout] | [INFO] [stdout] 30 | if guard.is_ok() { [INFO] [stdout] | ---------------- help: try: `if let Ok() = guard` [INFO] [stdout] 31 | let mut data = guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> mymutex.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | / _= scope(|s| { [INFO] [stdout] 44 | | s.spawn(myfunc2).join(); [INFO] [stdout] 45 | | s.spawn(myfunc).join(); // thread one is working on mutex [INFO] [stdout] ... | [INFO] [stdout] 48 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 43 - _= scope(|s| { [INFO] [stdout] 43 + scope(|s| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `receive_result` after checking its variant with `is_ok` [INFO] [stdout] --> mympsc.rs:23:47 [INFO] [stdout] | [INFO] [stdout] 22 | if receive_result.is_ok(){ [INFO] [stdout] | ------------------------- help: try: `if let Ok() = receive_result` [INFO] [stdout] 23 | print!("received message: {}",receive_result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> myfs.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | return a; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return a; [INFO] [stdout] 10 + a [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> myargs.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 18 | if !parsed_year.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `parsed_year.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> myargs.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return Dog {name,year_born}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Dog {name,year_born}; [INFO] [stdout] 33 + Dog {name,year_born} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> main.rs:118:27 [INFO] [stdout] | [INFO] [stdout] 118 | let drivers_license = if age>=16 {true} else {false}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `age >= 16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> myiters.rs:2:22 [INFO] [stdout] | [INFO] [stdout] 2 | let fruit_list = vec!["strawberry","blueberry","mango","Apple","Orange"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["strawberry","blueberry","mango","Apple","Orange"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> myiters.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 37 | let first_name = vec!["Trevor","Shannon","James","Tasha"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["Trevor","Shannon","James","Tasha"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> myiters.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | let last_name = vec!["Jones","Sullivan","Tanner","Redman"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["Jones","Sullivan","Tanner","Redman"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> mymutex.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | s.spawn(myfunc2).join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 44 | let _ = s.spawn(myfunc2).join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> mymutex.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | s.spawn(myfunc).join(); // thread one is working on mutex [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 45 | let _ = s.spawn(myfunc).join(); // thread one is working on mutex [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> mympsc.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | rx.recv_timeout(Duration::from_millis(300)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 7 | let _ = rx.recv_timeout(Duration::from_millis(300)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> mympsc.rs:46:4 [INFO] [stdout] | [INFO] [stdout] 46 | std::thread::spawn(processor_code).join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 46 | let _ = std::thread::spawn(processor_code).join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.55s [INFO] running `Command { std: "docker" "inspect" "604c42cc360a0e3ccfec398b4ffd7bfdf9a573c31f03f0339f88a22569eb92cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "604c42cc360a0e3ccfec398b4ffd7bfdf9a573c31f03f0339f88a22569eb92cd", kill_on_drop: false }` [INFO] [stdout] 604c42cc360a0e3ccfec398b4ffd7bfdf9a573c31f03f0339f88a22569eb92cd