[INFO] cloning repository https://github.com/Arcadia-Y/LTL-Model-Checker [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Arcadia-Y/LTL-Model-Checker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FArcadia-Y%2FLTL-Model-Checker", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FArcadia-Y%2FLTL-Model-Checker'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 39b7d2405874778b6f0c1343c4334213309b9745 [INFO] linting Arcadia-Y/LTL-Model-Checker against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FArcadia-Y%2FLTL-Model-Checker" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Arcadia-Y/LTL-Model-Checker [INFO] finished tweaking git repo https://github.com/Arcadia-Y/LTL-Model-Checker [INFO] tweaked toml for git repo https://github.com/Arcadia-Y/LTL-Model-Checker written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Arcadia-Y/LTL-Model-Checker on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Arcadia-Y/LTL-Model-Checker already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.38 [INFO] [stderr] Downloaded chumsky v0.10.1 [INFO] [stderr] Downloaded clap_builder v4.5.38 [INFO] [stderr] Downloaded regex-automata v0.3.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3aa9a95de3c468dee2e882c4074a18502af372fda6ad54bc7dc0cf6dedfbb097 [INFO] running `Command { std: "docker" "start" "-a" "3aa9a95de3c468dee2e882c4074a18502af372fda6ad54bc7dc0cf6dedfbb097", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3aa9a95de3c468dee2e882c4074a18502af372fda6ad54bc7dc0cf6dedfbb097", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3aa9a95de3c468dee2e882c4074a18502af372fda6ad54bc7dc0cf6dedfbb097", kill_on_drop: false }` [INFO] [stdout] 3aa9a95de3c468dee2e882c4074a18502af372fda6ad54bc7dc0cf6dedfbb097 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3ea7b267b14460b27c301a604b628b52a2a09d4971e5375e06e958c550141655 [INFO] running `Command { std: "docker" "start" "-a" "3ea7b267b14460b27c301a604b628b52a2a09d4971e5375e06e958c550141655", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.2.19 [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Compiling chumsky v0.10.1 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking unicode-ident v1.0.18 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking clap_builder v4.5.38 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling psm v0.1.25 [INFO] [stderr] Compiling stacker v0.1.20 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking regex-automata v0.3.9 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Checking clap v4.5.38 [INFO] [stderr] Checking ltl-checker v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `CliArgs` [INFO] [stdout] --> src/main.rs:52:83 [INFO] [stdout] | [INFO] [stdout] 52 | use crate::{checker::Checker, ltl::LTLE, parser::{read_ltl, read_ts}, ts::TS, CliArgs}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LTLE` contains a capitalized acronym [INFO] [stdout] --> src/ltl.rs:5:10 [INFO] [stdout] | [INFO] [stdout] 5 | pub enum LTLE { [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ltle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LTL` contains a capitalized acronym [INFO] [stdout] --> src/ltl.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | pub enum LTL { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ltl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/ltl.rs:235:36 [INFO] [stdout] | [INFO] [stdout] 235 | let b_in_y = y.has(&**b); [INFO] [stdout] | ^^^^ help: try: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/ltl.rs:242:34 [INFO] [stdout] | [INFO] [stdout] 242 | let rval = x.has(&**a2) || (x.has(&**a1) && y.has(a)); [INFO] [stdout] | ^^^^^ help: try: `a2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/ltl.rs:242:51 [INFO] [stdout] | [INFO] [stdout] 242 | let rval = x.has(&**a2) || (x.has(&**a1) && y.has(a)); [INFO] [stdout] | ^^^^^ help: try: `a1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GNBA` contains a capitalized acronym [INFO] [stdout] --> src/nba.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct GNBA { [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Gnba` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nba.rs:46:24 [INFO] [stdout] | [INFO] [stdout] 46 | if !(x.has(a) && !x.has(a2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!x.has(a) || x.has(a2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/nba.rs:16:58 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn ltl_to_gnba(phi:<L, clos:&Vec<<L>, elem_sets: &Vec) -> GNBA> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - pub fn ltl_to_gnba(phi:<L, clos:&Vec<<L>, elem_sets: &Vec) -> GNBA> { [INFO] [stdout] 16 + pub fn ltl_to_gnba(phi:<L, clos:&Vec<<L>, elem_sets: &[ElemSet]) -> GNBA> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `elem_sets` [INFO] [stdout] --> src/nba.rs:20:14 [INFO] [stdout] | [INFO] [stdout] 20 | for i in 0..state_num { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 20 - for i in 0..state_num { [INFO] [stdout] 20 + for (i, ) in elem_sets.iter().enumerate().take(state_num) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `elem_sets` [INFO] [stdout] --> src/nba.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 30 | for j in 0..state_num { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 30 - for j in 0..state_num { [INFO] [stdout] 30 + for (j, ) in elem_sets.iter().enumerate().take(state_num) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/nba.rs:32:30 [INFO] [stdout] | [INFO] [stdout] 32 | if step_relation(&clos, x, y) { [INFO] [stdout] | ^^^^^ help: change this to: `clos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/nba.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / match a { [INFO] [stdout] 42 | | LTL::Until(_, a2) => { [INFO] [stdout] 43 | | let mut f = HashSet::new(); [INFO] [stdout] 44 | | for i in 0..state_num { [INFO] [stdout] ... | [INFO] [stdout] 52 | | _ => {} [INFO] [stdout] 53 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 41 ~ if let LTL::Until(_, a2) = a { [INFO] [stdout] 42 + let mut f = HashSet::new(); [INFO] [stdout] 43 + for i in 0..state_num { [INFO] [stdout] 44 + let x = &elem_sets[i]; [INFO] [stdout] 45 + if !(x.has(a) && !x.has(a2)) { [INFO] [stdout] 46 + f.insert(i); [INFO] [stdout] 47 + } [INFO] [stdout] 48 + } [INFO] [stdout] 49 + accept.push(f); [INFO] [stdout] 50 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `elem_sets` [INFO] [stdout] --> src/nba.rs:44:26 [INFO] [stdout] | [INFO] [stdout] 44 | for i in 0..state_num { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 44 - for i in 0..state_num { [INFO] [stdout] 44 + for (i, ) in elem_sets.iter().enumerate().take(state_num) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NBA` contains a capitalized acronym [INFO] [stdout] --> src/nba.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 70 | pub struct NBA { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nba` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/nba.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | let dest: Vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `dest` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 94 ~ [INFO] [stdout] 95 ~ let dest: Vec = if fj.contains(&i) { [INFO] [stdout] 96 ~ ts.iter().map(|x: &usize| *x + (j+1) % k * n).collect() [INFO] [stdout] 97 | } else { [INFO] [stdout] 98 ~ ts.iter().map(|x: &usize| *x + j * n).collect() [INFO] [stdout] 99 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/parser.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 30 | / let binary = unary.clone().foldl( [INFO] [stdout] 31 | | choice(( [INFO] [stdout] 32 | | op2('/', '\\').to(LTLE::And as fn(_, _) -> _), [INFO] [stdout] 33 | | op2('\\', '/').to(LTLE::Or as fn(_, _) -> _), [INFO] [stdout] ... | [INFO] [stdout] 39 | | |lhs, (op, rhs)| op(Box::new(lhs), Box::new(rhs)), [INFO] [stdout] 40 | | ); [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 41 | [INFO] [stdout] 42 | binary [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 30 ~ [INFO] [stdout] 31 | [INFO] [stdout] 32 ~ unary.clone().foldl( [INFO] [stdout] 33 + choice(( [INFO] [stdout] 34 + op2('/', '\\').to(LTLE::And as fn(_, _) -> _), [INFO] [stdout] 35 + op2('\\', '/').to(LTLE::Or as fn(_, _) -> _), [INFO] [stdout] 36 + op2('-', '>').to(LTLE::Impl as fn(_, _) -> _), [INFO] [stdout] 37 + op('U').to(LTLE::Until as fn(_, _) -> _), [INFO] [stdout] 38 + )) [INFO] [stdout] 39 + .then(unary) [INFO] [stdout] 40 + .repeated(), [INFO] [stdout] 41 + |lhs, (op, rhs)| op(Box::new(lhs), Box::new(rhs)), [INFO] [stdout] 42 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/checker.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl CheckerArg { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 14 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/checker.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 41 | impl<'a> Checker<'a> { [INFO] [stdout] | -------------------- associated function in this implementation [INFO] [stdout] 42 | // return a Checker without output [INFO] [stdout] 43 | pub fn new(ts: &'a TS>) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LTLE` contains a capitalized acronym [INFO] [stdout] --> src/ltl.rs:5:10 [INFO] [stdout] | [INFO] [stdout] 5 | pub enum LTLE { [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ltle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LTL` contains a capitalized acronym [INFO] [stdout] --> src/ltl.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | pub enum LTL { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ltl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/parser.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 108 | / let ts = TS { [INFO] [stdout] 109 | | state_num, [INFO] [stdout] 110 | | transition: Rc::new(transition), [INFO] [stdout] 111 | | initial: Rc::new(initial), [INFO] [stdout] 112 | | prop: prop_map, [INFO] [stdout] 113 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 114 | ts [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 108 ~ [INFO] [stdout] 109 ~ TS { [INFO] [stdout] 110 + state_num, [INFO] [stdout] 111 + transition: Rc::new(transition), [INFO] [stdout] 112 + initial: Rc::new(initial), [INFO] [stdout] 113 + prop: prop_map, [INFO] [stdout] 114 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `lines` [INFO] [stdout] --> src/parser.rs:135:14 [INFO] [stdout] | [INFO] [stdout] 135 | for i in 1..a+1 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 135 - for i in 1..a+1 { [INFO] [stdout] 135 + for in lines.iter().skip(1).take(a) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `lines` [INFO] [stdout] --> src/parser.rs:143:14 [INFO] [stdout] | [INFO] [stdout] 143 | for i in a+1..a+b+1 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 143 - for i in a+1..a+b+1 { [INFO] [stdout] 143 + for in lines.iter().take(a+b+1).skip(a+1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NDFS` contains a capitalized acronym [INFO] [stdout] --> src/ndfs.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct NDFS<'a> { [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ndfs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ndfs.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | / if !self.outer_visited[*i] { [INFO] [stdout] 41 | | if self.reachable_cycle(*i) { [INFO] [stdout] 42 | | self.track(*i); [INFO] [stdout] 43 | | return true; [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 40 ~ if !self.outer_visited[*i] [INFO] [stdout] 41 ~ && self.reachable_cycle(*i) { [INFO] [stdout] 42 | self.track(*i); [INFO] [stdout] 43 | return true; [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ndfs.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / if !self.outer_visited[*t] { [INFO] [stdout] 55 | | if self.reachable_cycle(*t) { [INFO] [stdout] 56 | | self.track(*t); [INFO] [stdout] 57 | | return true; [INFO] [stdout] 58 | | } [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 54 ~ if !self.outer_visited[*t] [INFO] [stdout] 55 ~ && self.reachable_cycle(*t) { [INFO] [stdout] 56 | self.track(*t); [INFO] [stdout] 57 | return true; [INFO] [stdout] 58 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ndfs.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | / if !self.inner_visited[*t] { [INFO] [stdout] 82 | | if self.cycle_check(s, *t) { [INFO] [stdout] 83 | | self.track(*t); [INFO] [stdout] 84 | | return true; [INFO] [stdout] 85 | | } [INFO] [stdout] 86 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 81 ~ if !self.inner_visited[*t] [INFO] [stdout] 82 ~ && self.cycle_check(s, *t) { [INFO] [stdout] 83 | self.track(*t); [INFO] [stdout] 84 | return true; [INFO] [stdout] 85 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/ltl.rs:235:36 [INFO] [stdout] | [INFO] [stdout] 235 | let b_in_y = y.has(&**b); [INFO] [stdout] | ^^^^ help: try: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/ltl.rs:242:34 [INFO] [stdout] | [INFO] [stdout] 242 | let rval = x.has(&**a2) || (x.has(&**a1) && y.has(a)); [INFO] [stdout] | ^^^^^ help: try: `a2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/ltl.rs:242:51 [INFO] [stdout] | [INFO] [stdout] 242 | let rval = x.has(&**a2) || (x.has(&**a1) && y.has(a)); [INFO] [stdout] | ^^^^^ help: try: `a1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/checker.rs:54:33 [INFO] [stdout] | [INFO] [stdout] 54 | fn show_trace(&self, trace: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 54 - fn show_trace(&self, trace: &Vec) { [INFO] [stdout] 54 + fn show_trace(&self, trace: &[usize]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GNBA` contains a capitalized acronym [INFO] [stdout] --> src/nba.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct GNBA { [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Gnba` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nba.rs:46:24 [INFO] [stdout] | [INFO] [stdout] 46 | if !(x.has(a) && !x.has(a2)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!x.has(a) || x.has(a2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/nba.rs:16:58 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn ltl_to_gnba(phi:<L, clos:&Vec<<L>, elem_sets: &Vec) -> GNBA> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - pub fn ltl_to_gnba(phi:<L, clos:&Vec<<L>, elem_sets: &Vec) -> GNBA> { [INFO] [stdout] 16 + pub fn ltl_to_gnba(phi:<L, clos:&Vec<<L>, elem_sets: &[ElemSet]) -> GNBA> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `elem_sets` [INFO] [stdout] --> src/nba.rs:20:14 [INFO] [stdout] | [INFO] [stdout] 20 | for i in 0..state_num { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 20 - for i in 0..state_num { [INFO] [stdout] 20 + for (i, ) in elem_sets.iter().enumerate().take(state_num) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `elem_sets` [INFO] [stdout] --> src/nba.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 30 | for j in 0..state_num { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 30 - for j in 0..state_num { [INFO] [stdout] 30 + for (j, ) in elem_sets.iter().enumerate().take(state_num) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/nba.rs:32:30 [INFO] [stdout] | [INFO] [stdout] 32 | if step_relation(&clos, x, y) { [INFO] [stdout] | ^^^^^ help: change this to: `clos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/nba.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / match a { [INFO] [stdout] 42 | | LTL::Until(_, a2) => { [INFO] [stdout] 43 | | let mut f = HashSet::new(); [INFO] [stdout] 44 | | for i in 0..state_num { [INFO] [stdout] ... | [INFO] [stdout] 52 | | _ => {} [INFO] [stdout] 53 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 41 ~ if let LTL::Until(_, a2) = a { [INFO] [stdout] 42 + let mut f = HashSet::new(); [INFO] [stdout] 43 + for i in 0..state_num { [INFO] [stdout] 44 + let x = &elem_sets[i]; [INFO] [stdout] 45 + if !(x.has(a) && !x.has(a2)) { [INFO] [stdout] 46 + f.insert(i); [INFO] [stdout] 47 + } [INFO] [stdout] 48 + } [INFO] [stdout] 49 + accept.push(f); [INFO] [stdout] 50 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `elem_sets` [INFO] [stdout] --> src/nba.rs:44:26 [INFO] [stdout] | [INFO] [stdout] 44 | for i in 0..state_num { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 44 - for i in 0..state_num { [INFO] [stdout] 44 + for (i, ) in elem_sets.iter().enumerate().take(state_num) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NBA` contains a capitalized acronym [INFO] [stdout] --> src/nba.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 70 | pub struct NBA { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nba` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/nba.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | let dest: Vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `dest` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 94 ~ [INFO] [stdout] 95 ~ let dest: Vec = if fj.contains(&i) { [INFO] [stdout] 96 ~ ts.iter().map(|x: &usize| *x + (j+1) % k * n).collect() [INFO] [stdout] 97 | } else { [INFO] [stdout] 98 ~ ts.iter().map(|x: &usize| *x + j * n).collect() [INFO] [stdout] 99 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/parser.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 30 | / let binary = unary.clone().foldl( [INFO] [stdout] 31 | | choice(( [INFO] [stdout] 32 | | op2('/', '\\').to(LTLE::And as fn(_, _) -> _), [INFO] [stdout] 33 | | op2('\\', '/').to(LTLE::Or as fn(_, _) -> _), [INFO] [stdout] ... | [INFO] [stdout] 39 | | |lhs, (op, rhs)| op(Box::new(lhs), Box::new(rhs)), [INFO] [stdout] 40 | | ); [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 41 | [INFO] [stdout] 42 | binary [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 30 ~ [INFO] [stdout] 31 | [INFO] [stdout] 32 ~ unary.clone().foldl( [INFO] [stdout] 33 + choice(( [INFO] [stdout] 34 + op2('/', '\\').to(LTLE::And as fn(_, _) -> _), [INFO] [stdout] 35 + op2('\\', '/').to(LTLE::Or as fn(_, _) -> _), [INFO] [stdout] 36 + op2('-', '>').to(LTLE::Impl as fn(_, _) -> _), [INFO] [stdout] 37 + op('U').to(LTLE::Until as fn(_, _) -> _), [INFO] [stdout] 38 + )) [INFO] [stdout] 39 + .then(unary) [INFO] [stdout] 40 + .repeated(), [INFO] [stdout] 41 + |lhs, (op, rhs)| op(Box::new(lhs), Box::new(rhs)), [INFO] [stdout] 42 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/parser.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 108 | / let ts = TS { [INFO] [stdout] 109 | | state_num, [INFO] [stdout] 110 | | transition: Rc::new(transition), [INFO] [stdout] 111 | | initial: Rc::new(initial), [INFO] [stdout] 112 | | prop: prop_map, [INFO] [stdout] 113 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 114 | ts [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 108 ~ [INFO] [stdout] 109 ~ TS { [INFO] [stdout] 110 + state_num, [INFO] [stdout] 111 + transition: Rc::new(transition), [INFO] [stdout] 112 + initial: Rc::new(initial), [INFO] [stdout] 113 + prop: prop_map, [INFO] [stdout] 114 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `lines` [INFO] [stdout] --> src/parser.rs:135:14 [INFO] [stdout] | [INFO] [stdout] 135 | for i in 1..a+1 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 135 - for i in 1..a+1 { [INFO] [stdout] 135 + for in lines.iter().skip(1).take(a) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `lines` [INFO] [stdout] --> src/parser.rs:143:14 [INFO] [stdout] | [INFO] [stdout] 143 | for i in a+1..a+b+1 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 143 - for i in a+1..a+b+1 { [INFO] [stdout] 143 + for in lines.iter().take(a+b+1).skip(a+1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NDFS` contains a capitalized acronym [INFO] [stdout] --> src/ndfs.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct NDFS<'a> { [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ndfs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ndfs.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | / if !self.outer_visited[*i] { [INFO] [stdout] 41 | | if self.reachable_cycle(*i) { [INFO] [stdout] 42 | | self.track(*i); [INFO] [stdout] 43 | | return true; [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 40 ~ if !self.outer_visited[*i] [INFO] [stdout] 41 ~ && self.reachable_cycle(*i) { [INFO] [stdout] 42 | self.track(*i); [INFO] [stdout] 43 | return true; [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ndfs.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / if !self.outer_visited[*t] { [INFO] [stdout] 55 | | if self.reachable_cycle(*t) { [INFO] [stdout] 56 | | self.track(*t); [INFO] [stdout] 57 | | return true; [INFO] [stdout] 58 | | } [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 54 ~ if !self.outer_visited[*t] [INFO] [stdout] 55 ~ && self.reachable_cycle(*t) { [INFO] [stdout] 56 | self.track(*t); [INFO] [stdout] 57 | return true; [INFO] [stdout] 58 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ndfs.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | / if !self.inner_visited[*t] { [INFO] [stdout] 82 | | if self.cycle_check(s, *t) { [INFO] [stdout] 83 | | self.track(*t); [INFO] [stdout] 84 | | return true; [INFO] [stdout] 85 | | } [INFO] [stdout] 86 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 81 ~ if !self.inner_visited[*t] [INFO] [stdout] 82 ~ && self.cycle_check(s, *t) { [INFO] [stdout] 83 | self.track(*t); [INFO] [stdout] 84 | return true; [INFO] [stdout] 85 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/checker.rs:54:33 [INFO] [stdout] | [INFO] [stdout] 54 | fn show_trace(&self, trace: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 54 - fn show_trace(&self, trace: &Vec) { [INFO] [stdout] 54 + fn show_trace(&self, trace: &[usize]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.39s [INFO] running `Command { std: "docker" "inspect" "3ea7b267b14460b27c301a604b628b52a2a09d4971e5375e06e958c550141655", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ea7b267b14460b27c301a604b628b52a2a09d4971e5375e06e958c550141655", kill_on_drop: false }` [INFO] [stdout] 3ea7b267b14460b27c301a604b628b52a2a09d4971e5375e06e958c550141655