[INFO] cloning repository https://github.com/Arasimnida/windows-process-injection [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Arasimnida/windows-process-injection" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FArasimnida%2Fwindows-process-injection", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FArasimnida%2Fwindows-process-injection'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3f41ed8f98b2a22b6b0e9482578ac4c0c85c0e90 [INFO] linting Arasimnida/windows-process-injection against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FArasimnida%2Fwindows-process-injection" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Arasimnida/windows-process-injection [INFO] finished tweaking git repo https://github.com/Arasimnida/windows-process-injection [INFO] tweaked toml for git repo https://github.com/Arasimnida/windows-process-injection written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Arasimnida/windows-process-injection on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Arasimnida/windows-process-injection already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2024 which implies `resolver = "3"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2024 resolver, specify `workspace.resolver = "3"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9b4673f83820a4021b73e4a3ee6cb738684fd5b7c613b30d8c830fc458f15d67 [INFO] running `Command { std: "docker" "start" "-a" "9b4673f83820a4021b73e4a3ee6cb738684fd5b7c613b30d8c830fc458f15d67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9b4673f83820a4021b73e4a3ee6cb738684fd5b7c613b30d8c830fc458f15d67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b4673f83820a4021b73e4a3ee6cb738684fd5b7c613b30d8c830fc458f15d67", kill_on_drop: false }` [INFO] [stdout] 9b4673f83820a4021b73e4a3ee6cb738684fd5b7c613b30d8c830fc458f15d67 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 89617ab2990ac4ceda26cc248fe1dc468af655604b6ec65e4fc2ecd279837015 [INFO] running `Command { std: "docker" "start" "-a" "89617ab2990ac4ceda26cc248fe1dc468af655604b6ec65e4fc2ecd279837015", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2024 which implies `resolver = "3"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2024 resolver, specify `workspace.resolver = "3"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling windows_x86_64_gnu v0.52.6 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Checking windows-targets v0.52.6 [INFO] [stderr] Checking windows-result v0.1.2 [INFO] [stderr] Compiling windows-implement v0.56.0 [INFO] [stderr] Compiling windows-interface v0.56.0 [INFO] [stderr] Checking windows-core v0.56.0 [INFO] [stderr] Checking windows v0.56.0 [INFO] [stderr] Checking injector v0.1.0 (/opt/rustwide/workdir/injector) [INFO] [stderr] Checking inline_hook_test v0.1.0 (/opt/rustwide/workdir/common/inline_hook_test) [INFO] [stderr] Checking hook_payload v0.1.0 (/opt/rustwide/workdir/common/hook_payload) [INFO] [stderr] Checking payload_messagebox v0.1.0 (/opt/rustwide/workdir/common/payload_messagebox) [INFO] [stderr] Checking inline_hook v0.1.0 (/opt/rustwide/workdir/common/inline_hook) [INFO] [stderr] Checking alertable v0.1.0 (/opt/rustwide/workdir/common/alertable) [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> common/inline_hook/src/inlinehook.rs:53:48 [INFO] [stdout] | [INFO] [stdout] 53 | let hmod = unsafe { GetModuleHandleA(PCSTR(b"kernel32.dll\0".as_ptr())).expect("[!] GetModuleHandleA Failed") }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"kernel32.dll"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] = note: `#[warn(clippy::manual_c_str_literals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> common/inline_hook/src/inlinehook.rs:54:52 [INFO] [stdout] | [INFO] [stdout] 54 | let addr = unsafe { GetProcAddress(hmod, PCSTR(b"CreateFileA\0".as_ptr())).expect("[!] GetProcAddress Failed") as *mut u8 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"CreateFileA"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> common/hook_payload/src/lib.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | PCSTR(b"Hooking succeeded!\0".as_ptr()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"Hooking succeeded!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] = note: `#[warn(clippy::manual_c_str_literals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> common/hook_payload/src/lib.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 25 | PCSTR(b"Malware is illegal and for nerds\0".as_ptr()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"Malware is illegal and for nerds"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> common/hook_payload/src/lib.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | PCSTR(b"Hooking succeeded!\0".as_ptr()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"Hooking succeeded!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] = note: `#[warn(clippy::manual_c_str_literals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> common/hook_payload/src/lib.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 25 | PCSTR(b"Malware is illegal and for nerds\0".as_ptr()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"Malware is illegal and for nerds"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*mut u8` -> `*mut u8`) [INFO] [stdout] --> common/inline_hook/src/inlinehook.rs:74:48 [INFO] [stdout] | [INFO] [stdout] 74 | ptr::copy_nonoverlapping(jmp.as_ptr(), addr as *mut u8, 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*mut u8` -> `*mut u8`) [INFO] [stdout] --> common/inline_hook/src/inlinehook.rs:75:20 [INFO] [stdout] | [INFO] [stdout] 75 | ptr::write((addr.wrapping_add(5)) as *mut u8, 0x90); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(addr.wrapping_add(5))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> common/inline_hook/src/inlinehook.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 110 | / let result = original_fn( [INFO] [stdout] 111 | | lpFileName, [INFO] [stdout] 112 | | dwDesiredAccess, [INFO] [stdout] 113 | | dwShareMode, [INFO] [stdout] ... | [INFO] [stdout] 117 | | hTemplateFile, [INFO] [stdout] 118 | | ); [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 119 | result [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 110 ~ [INFO] [stdout] 111 ~ original_fn( [INFO] [stdout] 112 + lpFileName, [INFO] [stdout] 113 + dwDesiredAccess, [INFO] [stdout] 114 + dwShareMode, [INFO] [stdout] 115 + lpSecurityAttributes, [INFO] [stdout] 116 + dwCreationDisposition, [INFO] [stdout] 117 + dwFlagsAndAttributes, [INFO] [stdout] 118 + hTemplateFile, [INFO] [stdout] 119 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> common/inline_hook/src/inlinehook.rs:102:19 [INFO] [stdout] | [INFO] [stdout] 102 | PCSTR(b"Injection succeeded!\0".as_ptr()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"Injection succeeded!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> common/inline_hook/src/inlinehook.rs:103:19 [INFO] [stdout] | [INFO] [stdout] 103 | PCSTR(b"Hooked using CreateFileA, Malware is still illegal and for nerds.\0".as_ptr()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"Hooked using CreateFileA, Malware is still illegal and for nerds."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> common/inline_hook/src/inlinehook.rs:53:48 [INFO] [stdout] | [INFO] [stdout] 53 | let hmod = unsafe { GetModuleHandleA(PCSTR(b"kernel32.dll\0".as_ptr())).expect("[!] GetModuleHandleA Failed") }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"kernel32.dll"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] = note: `#[warn(clippy::manual_c_str_literals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> common/inline_hook/src/inlinehook.rs:54:52 [INFO] [stdout] | [INFO] [stdout] 54 | let addr = unsafe { GetProcAddress(hmod, PCSTR(b"CreateFileA\0".as_ptr())).expect("[!] GetProcAddress Failed") as *mut u8 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"CreateFileA"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Arch` is never used [INFO] [stdout] --> injector/src/shellcode_injection/sirhijack.rs:43:10 [INFO] [stdout] | [INFO] [stdout] 43 | pub enum Arch { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `full_context_flag` is never used [INFO] [stdout] --> injector/src/shellcode_injection/sirhijack.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 50 | impl Arch { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] 51 | pub fn full_context_flag(self) -> CONTEXT_FLAGS { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `inject` is never used [INFO] [stdout] --> injector/src/shellcode_injection/sirhijack.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn inject(pid: u32) -> windows::core::Result<()> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> injector/src/dll_injection/loadlibrary_createremotethread.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return CloseHandle(h_process) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return CloseHandle(h_process) [INFO] [stdout] 78 + CloseHandle(h_process) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*mut u8` -> `*mut u8`) [INFO] [stdout] --> common/inline_hook/src/inlinehook.rs:74:48 [INFO] [stdout] | [INFO] [stdout] 74 | ptr::copy_nonoverlapping(jmp.as_ptr(), addr as *mut u8, 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*mut u8` -> `*mut u8`) [INFO] [stdout] --> common/inline_hook/src/inlinehook.rs:75:20 [INFO] [stdout] | [INFO] [stdout] 75 | ptr::write((addr.wrapping_add(5)) as *mut u8, 0x90); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(addr.wrapping_add(5))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> injector/src/dll_injection/loadlibrary_createremotethread.rs:57:35 [INFO] [stdout] | [INFO] [stdout] 57 | let kernel32_name = PCSTR(b"kernel32.dll\0".as_ptr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"kernel32.dll"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] = note: `#[warn(clippy::manual_c_str_literals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> injector/src/dll_injection/loadlibrary_createremotethread.rs:58:38 [INFO] [stdout] | [INFO] [stdout] 58 | let loadlibrary_name = PCSTR(b"LoadLibraryA\0".as_ptr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"LoadLibraryA"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> common/inline_hook/src/inlinehook.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 110 | / let result = original_fn( [INFO] [stdout] 111 | | lpFileName, [INFO] [stdout] 112 | | dwDesiredAccess, [INFO] [stdout] 113 | | dwShareMode, [INFO] [stdout] ... | [INFO] [stdout] 117 | | hTemplateFile, [INFO] [stdout] 118 | | ); [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 119 | result [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 110 ~ [INFO] [stdout] 111 ~ original_fn( [INFO] [stdout] 112 + lpFileName, [INFO] [stdout] 113 + dwDesiredAccess, [INFO] [stdout] 114 + dwShareMode, [INFO] [stdout] 115 + lpSecurityAttributes, [INFO] [stdout] 116 + dwCreationDisposition, [INFO] [stdout] 117 + dwFlagsAndAttributes, [INFO] [stdout] 118 + hTemplateFile, [INFO] [stdout] 119 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> common/inline_hook/src/inlinehook.rs:102:19 [INFO] [stdout] | [INFO] [stdout] 102 | PCSTR(b"Injection succeeded!\0".as_ptr()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"Injection succeeded!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> common/inline_hook/src/inlinehook.rs:103:19 [INFO] [stdout] | [INFO] [stdout] 103 | PCSTR(b"Hooked using CreateFileA, Malware is still illegal and for nerds.\0".as_ptr()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"Hooked using CreateFileA, Malware is still illegal and for nerds."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> injector/src/dll_injection/loadlibrary_createremotethread.rs:70:28 [INFO] [stdout] | [INFO] [stdout] 70 | Some(std::mem::transmute(func_ptr)), [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<*const std::ffi::c_void, unsafe extern "system" fn(*mut std::ffi::c_void) -> u32>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> injector/src/dll_injection/queueuserapc.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 109 | if !Thread32Next(snapshot, &mut entry).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Thread32Next(snapshot, &mut entry).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> injector/src/dll_injection/queueuserapc.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return CloseHandle(snapshot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return CloseHandle(snapshot); [INFO] [stdout] 114 + CloseHandle(snapshot) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> injector/src/dll_injection/queueuserapc.rs:68:35 [INFO] [stdout] | [INFO] [stdout] 68 | let kernel32_name = PCSTR(b"kernel32.dll\0".as_ptr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"kernel32.dll"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> injector/src/dll_injection/queueuserapc.rs:69:38 [INFO] [stdout] | [INFO] [stdout] 69 | let loadlibrary_name = PCSTR(b"LoadLibraryA\0".as_ptr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"LoadLibraryA"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> injector/src/dll_injection/queueuserapc.rs:94:44 [INFO] [stdout] | [INFO] [stdout] 94 | ... Some(std::mem::transmute(func_ptr)), [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<*const std::ffi::c_void, unsafe extern "system" fn(usize)>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> injector/src/shellcode_injection/createremotethread.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return CloseHandle(h_process); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return CloseHandle(h_process); [INFO] [stdout] 85 + CloseHandle(h_process) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> injector/src/shellcode_injection/createremotethread.rs:77:28 [INFO] [stdout] | [INFO] [stdout] 77 | Some(std::mem::transmute(alloc_address)), [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<*mut std::ffi::c_void, unsafe extern "system" fn(*mut std::ffi::c_void) -> u32>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> injector/src/shellcode_injection/ntcreatethreadex.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | return CloseHandle(h_process) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return CloseHandle(h_process) [INFO] [stdout] 118 + CloseHandle(h_process) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*mut std::ffi::c_void` -> `*mut std::ffi::c_void`) [INFO] [stdout] --> injector/src/shellcode_injection/ntcreatethreadex.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | remote_addr as *mut c_void, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `remote_addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ARM` contains a capitalized acronym [INFO] [stdout] --> injector/src/shellcode_injection/sirhijack.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | ARM, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Arm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> injector/src/shellcode_injection/sirhijack.rs:142:20 [INFO] [stdout] | [INFO] [stdout] 142 | if !Thread32Next(snapshot, &mut entry).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Thread32Next(snapshot, &mut entry).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> injector/src/hook_user/setwindowshookex.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return UnhookWindowsHookEx(hook) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return UnhookWindowsHookEx(hook) [INFO] [stdout] 45 + UnhookWindowsHookEx(hook) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Arch` is never used [INFO] [stdout] --> injector/src/shellcode_injection/sirhijack.rs:43:10 [INFO] [stdout] | [INFO] [stdout] 43 | pub enum Arch { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `full_context_flag` is never used [INFO] [stdout] --> injector/src/shellcode_injection/sirhijack.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 50 | impl Arch { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] 51 | pub fn full_context_flag(self) -> CONTEXT_FLAGS { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `inject` is never used [INFO] [stdout] --> injector/src/shellcode_injection/sirhijack.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn inject(pid: u32) -> windows::core::Result<()> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> injector/src/dll_injection/loadlibrary_createremotethread.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return CloseHandle(h_process) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return CloseHandle(h_process) [INFO] [stdout] 78 + CloseHandle(h_process) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> injector/src/dll_injection/loadlibrary_createremotethread.rs:57:35 [INFO] [stdout] | [INFO] [stdout] 57 | let kernel32_name = PCSTR(b"kernel32.dll\0".as_ptr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"kernel32.dll"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] = note: `#[warn(clippy::manual_c_str_literals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> injector/src/dll_injection/loadlibrary_createremotethread.rs:58:38 [INFO] [stdout] | [INFO] [stdout] 58 | let loadlibrary_name = PCSTR(b"LoadLibraryA\0".as_ptr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"LoadLibraryA"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> injector/src/dll_injection/loadlibrary_createremotethread.rs:70:28 [INFO] [stdout] | [INFO] [stdout] 70 | Some(std::mem::transmute(func_ptr)), [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<*const std::ffi::c_void, unsafe extern "system" fn(*mut std::ffi::c_void) -> u32>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> injector/src/dll_injection/queueuserapc.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 109 | if !Thread32Next(snapshot, &mut entry).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Thread32Next(snapshot, &mut entry).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> injector/src/dll_injection/queueuserapc.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return CloseHandle(snapshot); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return CloseHandle(snapshot); [INFO] [stdout] 114 + CloseHandle(snapshot) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> injector/src/dll_injection/queueuserapc.rs:68:35 [INFO] [stdout] | [INFO] [stdout] 68 | let kernel32_name = PCSTR(b"kernel32.dll\0".as_ptr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"kernel32.dll"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually constructing a nul-terminated string [INFO] [stdout] --> injector/src/dll_injection/queueuserapc.rs:69:38 [INFO] [stdout] | [INFO] [stdout] 69 | let loadlibrary_name = PCSTR(b"LoadLibraryA\0".as_ptr()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use a `c""` literal: `c"LoadLibraryA"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> injector/src/dll_injection/queueuserapc.rs:94:44 [INFO] [stdout] | [INFO] [stdout] 94 | ... Some(std::mem::transmute(func_ptr)), [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<*const std::ffi::c_void, unsafe extern "system" fn(usize)>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> injector/src/shellcode_injection/createremotethread.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return CloseHandle(h_process); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return CloseHandle(h_process); [INFO] [stdout] 85 + CloseHandle(h_process) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> injector/src/shellcode_injection/createremotethread.rs:77:28 [INFO] [stdout] | [INFO] [stdout] 77 | Some(std::mem::transmute(alloc_address)), [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<*mut std::ffi::c_void, unsafe extern "system" fn(*mut std::ffi::c_void) -> u32>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> injector/src/shellcode_injection/ntcreatethreadex.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | return CloseHandle(h_process) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return CloseHandle(h_process) [INFO] [stdout] 118 + CloseHandle(h_process) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting raw pointers to the same type and constness is unnecessary (`*mut std::ffi::c_void` -> `*mut std::ffi::c_void`) [INFO] [stdout] --> injector/src/shellcode_injection/ntcreatethreadex.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | remote_addr as *mut c_void, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `remote_addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ARM` contains a capitalized acronym [INFO] [stdout] --> injector/src/shellcode_injection/sirhijack.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | ARM, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Arm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> injector/src/shellcode_injection/sirhijack.rs:142:20 [INFO] [stdout] | [INFO] [stdout] 142 | if !Thread32Next(snapshot, &mut entry).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Thread32Next(snapshot, &mut entry).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> injector/src/hook_user/setwindowshookex.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return UnhookWindowsHookEx(hook) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return UnhookWindowsHookEx(hook) [INFO] [stdout] 45 + UnhookWindowsHookEx(hook) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.54s [INFO] running `Command { std: "docker" "inspect" "89617ab2990ac4ceda26cc248fe1dc468af655604b6ec65e4fc2ecd279837015", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "89617ab2990ac4ceda26cc248fe1dc468af655604b6ec65e4fc2ecd279837015", kill_on_drop: false }` [INFO] [stdout] 89617ab2990ac4ceda26cc248fe1dc468af655604b6ec65e4fc2ecd279837015