[INFO] cloning repository https://github.com/Andrew-LC/git-clone [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Andrew-LC/git-clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndrew-LC%2Fgit-clone", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndrew-LC%2Fgit-clone'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1530c02ae67fb42d76dfbb3bc6538f8a1be15490 [INFO] linting Andrew-LC/git-clone against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndrew-LC%2Fgit-clone" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Andrew-LC/git-clone [INFO] finished tweaking git repo https://github.com/Andrew-LC/git-clone [INFO] tweaked toml for git repo https://github.com/Andrew-LC/git-clone written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Andrew-LC/git-clone on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Andrew-LC/git-clone already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.32 [INFO] [stderr] Downloaded is-terminal v0.4.2 [INFO] [stderr] Downloaded tracing-core v0.1.29 [INFO] [stderr] Downloaded anyhow v1.0.59 [INFO] [stderr] Downloaded io-lifetimes v1.0.3 [INFO] [stderr] Downloaded serde v1.0.142 [INFO] [stderr] Downloaded serde_json v1.0.83 [INFO] [stderr] Downloaded reqwest v0.11.13 [INFO] [stderr] Downloaded clap v4.0.32 [INFO] [stderr] Downloaded unicode-normalization v0.1.21 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6613cc1e0e50433bc536353b47d69210098620e376d27637a82cdc631564111a [INFO] running `Command { std: "docker" "start" "-a" "6613cc1e0e50433bc536353b47d69210098620e376d27637a82cdc631564111a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6613cc1e0e50433bc536353b47d69210098620e376d27637a82cdc631564111a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6613cc1e0e50433bc536353b47d69210098620e376d27637a82cdc631564111a", kill_on_drop: false }` [INFO] [stdout] 6613cc1e0e50433bc536353b47d69210098620e376d27637a82cdc631564111a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 104de9d570763166589e8c55264fae459153d53cb023be2beaf40fd84068b563 [INFO] running `Command { std: "docker" "start" "-a" "104de9d570763166589e8c55264fae459153d53cb023be2beaf40fd84068b563", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling parking_lot_core v0.9.6 [INFO] [stderr] Checking bytes v1.3.0 [INFO] [stderr] Compiling tokio v1.24.1 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling generic-array v0.14.6 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling openssl v0.10.41 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Compiling io-lifetimes v1.0.3 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling serde v1.0.142 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling rustix v0.36.6 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling encoding_rs v0.8.31 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking linux-raw-sys v0.1.4 [INFO] [stderr] Compiling serde_json v1.0.83 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling anyhow v1.0.59 [INFO] [stderr] Checking os_str_bytes v6.4.1 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking clap_lex v0.3.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking ipnet v2.5.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.3 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking mio v0.8.5 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking digest v0.10.6 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking sha1 v0.10.5 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking is-terminal v0.4.2 [INFO] [stderr] Compiling openssl-sys v0.9.75 [INFO] [stderr] Compiling ring v0.17.7 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling tokio-macros v1.8.2 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Compiling clap_derive v4.0.21 [INFO] [stderr] Compiling thiserror-impl v1.0.32 [INFO] [stderr] Checking thiserror v1.0.32 [INFO] [stderr] Checking clap v4.0.32 [INFO] [stderr] Checking tokio-util v0.7.4 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking h2 v0.3.15 [INFO] [stderr] Checking hyper v0.14.23 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.13 [INFO] [stderr] Checking git-starter-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/git_object_utils.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | if let Ok(_) = decoder.read_to_string(&mut decompressed) { [INFO] [stdout] | -------^^^^^-------------------------------------------- help: try: `if decoder.read_to_string(&mut decompressed).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/git_object_utils.rs:92:31 [INFO] [stdout] | [INFO] [stdout] 92 | encoder.write_all(&compressed_data.as_bytes())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `compressed_data.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/entry.rs:20:25 [INFO] [stdout] | [INFO] [stdout] 20 | let entries = parse(&tree).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `tree` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/git_object_utils.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | if let Ok(_) = decoder.read_to_string(&mut decompressed) { [INFO] [stdout] | -------^^^^^-------------------------------------------- help: try: `if decoder.read_to_string(&mut decompressed).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/entry.rs:53:52 [INFO] [stdout] | [INFO] [stdout] 53 | let sha: Vec = rest[sep + 1..sep + 21].try_into().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&[u8]` to `Vec` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 53 - let sha: Vec = rest[sep + 1..sep + 21].try_into().unwrap(); [INFO] [stdout] 53 + let sha: Vec = rest[sep + 1..sep + 21].into(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/git_object_utils.rs:92:31 [INFO] [stdout] | [INFO] [stdout] 92 | encoder.write_all(&compressed_data.as_bytes())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `compressed_data.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/entry.rs:106:46 [INFO] [stdout] | [INFO] [stdout] 106 | let (path_hash, _) = Object::hash_object(&path).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/entry.rs:161:30 [INFO] [stdout] | [INFO] [stdout] 161 | fn create_tree_file(entries: &mut Vec) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 161 - fn create_tree_file(entries: &mut Vec) -> Result> { [INFO] [stdout] 161 + fn create_tree_file(entries: &mut [Entry]) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/entry.rs:165:44 [INFO] [stdout] | [INFO] [stdout] 165 | .map(|entry: &Entry| tree_as_bytes(&entry)) [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/entry.rs:185:24 [INFO] [stdout] | [INFO] [stdout] 185 | let sha = hash_sha(&content); [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::vec::Vec` [INFO] [stdout] --> src/entry.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 206 | return Ok(sha.into()); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `sha` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/entry.rs:20:25 [INFO] [stdout] | [INFO] [stdout] 20 | let entries = parse(&tree).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `tree` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/entry.rs:53:52 [INFO] [stdout] | [INFO] [stdout] 53 | let sha: Vec = rest[sep + 1..sep + 21].try_into().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&[u8]` to `Vec` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 53 - let sha: Vec = rest[sep + 1..sep + 21].try_into().unwrap(); [INFO] [stdout] 53 + let sha: Vec = rest[sep + 1..sep + 21].into(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/entry.rs:106:46 [INFO] [stdout] | [INFO] [stdout] 106 | let (path_hash, _) = Object::hash_object(&path).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/entry.rs:161:30 [INFO] [stdout] | [INFO] [stdout] 161 | fn create_tree_file(entries: &mut Vec) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 161 - fn create_tree_file(entries: &mut Vec) -> Result> { [INFO] [stdout] 161 + fn create_tree_file(entries: &mut [Entry]) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/entry.rs:165:44 [INFO] [stdout] | [INFO] [stdout] 165 | .map(|entry: &Entry| tree_as_bytes(&entry)) [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/entry.rs:185:24 [INFO] [stdout] | [INFO] [stdout] 185 | let sha = hash_sha(&content); [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::vec::Vec` [INFO] [stdout] --> src/entry.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 206 | return Ok(sha.into()); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `sha` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:33:33 [INFO] [stdout] | [INFO] [stdout] 33 | entry::ls_tree(&tree_path, !true); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:22:33 [INFO] [stdout] | [INFO] [stdout] 22 | let object = Object::from_sha(&filepath); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.14s [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:28:45 [INFO] [stdout] | [INFO] [stdout] 28 | let (sha, location) = Object::hash_object(&Path::new(filepath)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new(filepath)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | entry::ls_tree(&tree_path, !true); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `tree_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:33:33 [INFO] [stdout] | [INFO] [stdout] 33 | entry::ls_tree(&tree_path, !true); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:22:33 [INFO] [stdout] | [INFO] [stdout] 22 | let object = Object::from_sha(&filepath); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:28:45 [INFO] [stdout] | [INFO] [stdout] 28 | let (sha, location) = Object::hash_object(&Path::new(filepath)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new(filepath)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | entry::ls_tree(&tree_path, !true); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `tree_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: openssl v0.10.41 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "104de9d570763166589e8c55264fae459153d53cb023be2beaf40fd84068b563", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "104de9d570763166589e8c55264fae459153d53cb023be2beaf40fd84068b563", kill_on_drop: false }` [INFO] [stdout] 104de9d570763166589e8c55264fae459153d53cb023be2beaf40fd84068b563