[INFO] cloning repository https://github.com/AndresN17/rust_basics [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AndresN17/rust_basics" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndresN17%2Frust_basics", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndresN17%2Frust_basics'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 518fae7f2e0e96845d98aafcc88a494f10d837bd [INFO] linting AndresN17/rust_basics against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndresN17%2Frust_basics" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/AndresN17/rust_basics [INFO] finished tweaking git repo https://github.com/AndresN17/rust_basics [INFO] tweaked toml for git repo https://github.com/AndresN17/rust_basics written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/AndresN17/rust_basics on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/AndresN17/rust_basics already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d24d58cf06b90a34ba9cfc94bddad36d5b597913ced60672dbe77339802589c9 [INFO] running `Command { std: "docker" "start" "-a" "d24d58cf06b90a34ba9cfc94bddad36d5b597913ced60672dbe77339802589c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d24d58cf06b90a34ba9cfc94bddad36d5b597913ced60672dbe77339802589c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d24d58cf06b90a34ba9cfc94bddad36d5b597913ced60672dbe77339802589c9", kill_on_drop: false }` [INFO] [stdout] d24d58cf06b90a34ba9cfc94bddad36d5b597913ced60672dbe77339802589c9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2460da565f3fb23e8aeb1a3cc882c0a3b073acaffd246802a747e3c5db200f97 [INFO] running `Command { std: "docker" "start" "-a" "2460da565f3fb23e8aeb1a3cc882c0a3b073acaffd246802a747e3c5db200f97", kill_on_drop: false }` [INFO] [stderr] Checking hello_world v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `logical` [INFO] [stdout] --> src/main.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let logical: bool = true; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a_float` [INFO] [stdout] --> src/main.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | let a_float: f64 = 1.0; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_a_float` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a_intefer` [INFO] [stdout] --> src/main.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | let a_intefer = 5i32; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_a_intefer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `default_float` [INFO] [stdout] --> src/main.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | let default_float = 1.0; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_default_float` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `default_integer` [INFO] [stdout] --> src/main.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | let default_integer = 7; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_default_integer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inferred_type` is assigned to, but never used [INFO] [stdout] --> src/main.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | let mut inferred_type = 90; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_inferred_type` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `mutable` is assigned to, but never used [INFO] [stdout] --> src/main.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | let mut mutable = 12; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_mutable` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `inferred_type` is never read [INFO] [stdout] --> src/main.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | inferred_type = 281910i64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `mutable` is never read [INFO] [stdout] --> src/main.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | mutable = 35; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:61:37 [INFO] [stdout] | [INFO] [stdout] 61 | println!("true AND false = {}", true && false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:62:36 [INFO] [stdout] | [INFO] [stdout] 62 | println!("true OR false = {}", true || false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:63:30 [INFO] [stdout] | [INFO] [stdout] 63 | println!("NOT true = {}",!true); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | "Artoria Pendragon", "Saber" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 15 - "{0} is a servant of the class {1}.", [INFO] [stdout] 16 - "Artoria Pendragon", "Saber" [INFO] [stdout] 15 + "Artoria Pendragon is a servant of the class Saber." [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 21 | servant = "Artoria Pendragon", [INFO] [stdout] | ___________________^ [INFO] [stdout] 22 | | class = "Saber" [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 20 - "{servant} is a servant of the class {class}", [INFO] [stdout] 21 - servant = "Artoria Pendragon", [INFO] [stdout] 22 - class = "Saber" [INFO] [stdout] 20 + "Artoria Pendragon is a servant of the class Saber" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `logical` [INFO] [stdout] --> src/main.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let logical: bool = true; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a_float` [INFO] [stdout] --> src/main.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | let a_float: f64 = 1.0; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_a_float` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a_intefer` [INFO] [stdout] --> src/main.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | let a_intefer = 5i32; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_a_intefer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `default_float` [INFO] [stdout] --> src/main.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | let default_float = 1.0; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_default_float` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `default_integer` [INFO] [stdout] --> src/main.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | let default_integer = 7; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_default_integer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `inferred_type` is assigned to, but never used [INFO] [stdout] --> src/main.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | let mut inferred_type = 90; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_inferred_type` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `mutable` is assigned to, but never used [INFO] [stdout] --> src/main.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | let mut mutable = 12; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_mutable` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `inferred_type` is never read [INFO] [stdout] --> src/main.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | inferred_type = 281910i64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `mutable` is never read [INFO] [stdout] --> src/main.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | mutable = 35; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:61:37 [INFO] [stdout] | [INFO] [stdout] 61 | println!("true AND false = {}", true && false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:62:36 [INFO] [stdout] | [INFO] [stdout] 62 | println!("true OR false = {}", true || false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:63:30 [INFO] [stdout] | [INFO] [stdout] 63 | println!("NOT true = {}",!true); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | "Artoria Pendragon", "Saber" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 15 - "{0} is a servant of the class {1}.", [INFO] [stdout] 16 - "Artoria Pendragon", "Saber" [INFO] [stdout] 15 + "Artoria Pendragon is a servant of the class Saber." [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 21 | servant = "Artoria Pendragon", [INFO] [stdout] | ___________________^ [INFO] [stdout] 22 | | class = "Saber" [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 20 - "{servant} is a servant of the class {class}", [INFO] [stdout] 21 - servant = "Artoria Pendragon", [INFO] [stdout] 22 - class = "Saber" [INFO] [stdout] 20 + "Artoria Pendragon is a servant of the class Saber" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.31s [INFO] running `Command { std: "docker" "inspect" "2460da565f3fb23e8aeb1a3cc882c0a3b073acaffd246802a747e3c5db200f97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2460da565f3fb23e8aeb1a3cc882c0a3b073acaffd246802a747e3c5db200f97", kill_on_drop: false }` [INFO] [stdout] 2460da565f3fb23e8aeb1a3cc882c0a3b073acaffd246802a747e3c5db200f97