[INFO] cloning repository https://github.com/AndreaG757/rustil [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AndreaG757/rustil" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndreaG757%2Frustil", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndreaG757%2Frustil'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b4816d3e71d614558bdf79020b1e3997e3630cb1 [INFO] linting AndreaG757/rustil against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndreaG757%2Frustil" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/AndreaG757/rustil [INFO] finished tweaking git repo https://github.com/AndreaG757/rustil [INFO] tweaked toml for git repo https://github.com/AndreaG757/rustil written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/AndreaG757/rustil on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/AndreaG757/rustil already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap_derive v4.3.12 [INFO] [stderr] Downloaded anstyle v1.0.1 [INFO] [stderr] Downloaded errno v0.3.2 [INFO] [stderr] Downloaded colored v2.0.4 [INFO] [stderr] Downloaded anstyle-wincon v1.0.2 [INFO] [stderr] Downloaded clap v4.3.21 [INFO] [stderr] Downloaded cc v1.0.82 [INFO] [stderr] Downloaded clap_builder v4.3.21 [INFO] [stderr] Downloaded rustix v0.38.8 [INFO] [stderr] Downloaded linux-raw-sys v0.4.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 29df70992e3548c5e43ffcbbb7ba9c3d69383293dcb970957dc21b838fd73362 [INFO] running `Command { std: "docker" "start" "-a" "29df70992e3548c5e43ffcbbb7ba9c3d69383293dcb970957dc21b838fd73362", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "29df70992e3548c5e43ffcbbb7ba9c3d69383293dcb970957dc21b838fd73362", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29df70992e3548c5e43ffcbbb7ba9c3d69383293dcb970957dc21b838fd73362", kill_on_drop: false }` [INFO] [stdout] 29df70992e3548c5e43ffcbbb7ba9c3d69383293dcb970957dc21b838fd73362 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cb1077d177b08cea6e35e18ec0deac715ad89e1ed74c9980d2c5d7b72a071335 [INFO] running `Command { std: "docker" "start" "-a" "cb1077d177b08cea6e35e18ec0deac715ad89e1ed74c9980d2c5d7b72a071335", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.8 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Compiling serde v1.0.183 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.15 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking rayon-core v1.11.0 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Compiling syn v2.0.28 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking colored v2.0.4 [INFO] [stderr] Checking clap_builder v4.3.21 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Checking clap v4.3.21 [INFO] [stderr] Checking rustil v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/locate.rs:59:60 [INFO] [stdout] | [INFO] [stdout] 59 | walk_dir_word(&entry.path(), word, &file_types, ¬_included); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `file_types` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/locate.rs:59:73 [INFO] [stdout] | [INFO] [stdout] 59 | walk_dir_word(&entry.path(), word, &file_types, ¬_included); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `not_included` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/locate.rs:65:64 [INFO] [stdout] | [INFO] [stdout] 65 | ... .filter(|ni| !ni.is_empty() && !ni.split_whitespace().next().is_none()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ni.split_whitespace().next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/locate.rs:59:60 [INFO] [stdout] | [INFO] [stdout] 59 | walk_dir_word(&entry.path(), word, &file_types, ¬_included); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `file_types` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/locate.rs:59:73 [INFO] [stdout] | [INFO] [stdout] 59 | walk_dir_word(&entry.path(), word, &file_types, ¬_included); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `not_included` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/locate.rs:67:68 [INFO] [stdout] | [INFO] [stdout] 67 | ... walk_dir_word(&entry.path(), word, &file_types, ¬_included); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `file_types` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/locate.rs:65:64 [INFO] [stdout] | [INFO] [stdout] 65 | ... .filter(|ni| !ni.is_empty() && !ni.split_whitespace().next().is_none()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ni.split_whitespace().next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/locate.rs:67:81 [INFO] [stdout] | [INFO] [stdout] 67 | ... walk_dir_word(&entry.path(), word, &file_types, ¬_included); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `not_included` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/locate.rs:76:56 [INFO] [stdout] | [INFO] [stdout] 76 | ... !ext.is_empty() && !ext.split_whitespace().next().is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ext.split_whitespace().next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/locate.rs:67:68 [INFO] [stdout] | [INFO] [stdout] 67 | ... walk_dir_word(&entry.path(), word, &file_types, ¬_included); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `file_types` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/locate.rs:67:81 [INFO] [stdout] | [INFO] [stdout] 67 | ... walk_dir_word(&entry.path(), word, &file_types, ¬_included); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `not_included` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/locate.rs:76:56 [INFO] [stdout] | [INFO] [stdout] 76 | ... !ext.is_empty() && !ext.split_whitespace().next().is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ext.split_whitespace().next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/locate.rs:144:29 [INFO] [stdout] | [INFO] [stdout] 144 | ... "Found in path:", [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 143 - "{} {}", [INFO] [stdout] 144 - "Found in path:", [INFO] [stdout] 143 + "Found in path: {}", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/commands/locate.rs:144:29 [INFO] [stdout] | [INFO] [stdout] 144 | ... "Found in path:", [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 143 - "{} {}", [INFO] [stdout] 144 - "Found in path:", [INFO] [stdout] 143 + "Found in path: {}", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.24s [INFO] running `Command { std: "docker" "inspect" "cb1077d177b08cea6e35e18ec0deac715ad89e1ed74c9980d2c5d7b72a071335", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb1077d177b08cea6e35e18ec0deac715ad89e1ed74c9980d2c5d7b72a071335", kill_on_drop: false }` [INFO] [stdout] cb1077d177b08cea6e35e18ec0deac715ad89e1ed74c9980d2c5d7b72a071335