[INFO] cloning repository https://github.com/AmrSaber/color-sort-puzzle-solver
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AmrSaber/color-sort-puzzle-solver" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAmrSaber%2Fcolor-sort-puzzle-solver", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAmrSaber%2Fcolor-sort-puzzle-solver'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 93b1a86bb53556fbe295f35725ef6b3ddedef8ec
[INFO] linting AmrSaber/color-sort-puzzle-solver against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAmrSaber%2Fcolor-sort-puzzle-solver" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/AmrSaber/color-sort-puzzle-solver
[INFO] finished tweaking git repo https://github.com/AmrSaber/color-sort-puzzle-solver
[INFO] tweaked toml for git repo https://github.com/AmrSaber/color-sort-puzzle-solver written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/AmrSaber/color-sort-puzzle-solver on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/AmrSaber/color-sort-puzzle-solver already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 17125808abff89e26b97168585de33eb7007dffa371c65039341dc9ce05db001
[INFO] running `Command { std: "docker" "start" "-a" "17125808abff89e26b97168585de33eb7007dffa371c65039341dc9ce05db001", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "17125808abff89e26b97168585de33eb7007dffa371c65039341dc9ce05db001", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "17125808abff89e26b97168585de33eb7007dffa371c65039341dc9ce05db001", kill_on_drop: false }`
[INFO] [stdout] 17125808abff89e26b97168585de33eb7007dffa371c65039341dc9ce05db001
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 0c1a4ec573061bab641dc34aa3db7dc78e412aba13b77ef9340e9d64fb7b81a7
[INFO] running `Command { std: "docker" "start" "-a" "0c1a4ec573061bab641dc34aa3db7dc78e412aba13b77ef9340e9d64fb7b81a7", kill_on_drop: false }`
[INFO] [stderr]     Checking color-sort-solver v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/container.rs:30:9
[INFO] [stdout]    |
[INFO] [stdout] 30 | /         return Ok(Self {
[INFO] [stdout] 31 | |             content,
[INFO] [stdout] 32 | |             capacity,
[INFO] [stdout] 33 | |             constraint,
[INFO] [stdout] 34 | |         });
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 30 ~         Ok(Self {
[INFO] [stdout] 31 +             content,
[INFO] [stdout] 32 +             capacity,
[INFO] [stdout] 33 +             constraint,
[INFO] [stdout] 34 ~         })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/models/container.rs:23:12
[INFO] [stdout]    |
[INFO] [stdout] 23 |         if content.len() > 0 && content.len() > capacity {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/container.rs:38:9
[INFO] [stdout]    |
[INFO] [stdout] 38 |         return self.content.last();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 38 -         return self.content.last();
[INFO] [stdout] 38 +         self.content.last()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/container.rs:42:9
[INFO] [stdout]    |
[INFO] [stdout] 42 |         return self.content.is_empty();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 42 -         return self.content.is_empty();
[INFO] [stdout] 42 +         self.content.is_empty()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/container.rs:46:9
[INFO] [stdout]    |
[INFO] [stdout] 46 |         return self.content.len() == self.capacity;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 46 -         return self.content.len() == self.capacity;
[INFO] [stdout] 46 +         self.content.len() == self.capacity
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/container.rs:51:9
[INFO] [stdout]    |
[INFO] [stdout] 51 |         return self.content.iter().all(|color| color == first);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 51 -         return self.content.iter().all(|color| color == first);
[INFO] [stdout] 51 +         self.content.iter().all(|color| color == first)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/container.rs:80:9
[INFO] [stdout]    |
[INFO] [stdout] 80 |         return self.peek() == other.peek();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 80 -         return self.peek() == other.peek();
[INFO] [stdout] 80 +         self.peek() == other.peek()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/state.rs:15:9
[INFO] [stdout]    |
[INFO] [stdout] 15 | /         return Self {
[INFO] [stdout] 16 | |             containers,
[INFO] [stdout] 17 | |             transitions: Vec::new(),
[INFO] [stdout] 18 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 15 ~         Self {
[INFO] [stdout] 16 +             containers,
[INFO] [stdout] 17 +             transitions: Vec::new(),
[INFO] [stdout] 18 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/state.rs:23:9
[INFO] [stdout]    |
[INFO] [stdout] 23 |         return &self.transitions;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 23 -         return &self.transitions;
[INFO] [stdout] 23 +         &self.transitions
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/state.rs:68:9
[INFO] [stdout]    |
[INFO] [stdout] 68 |         return score;
[INFO] [stdout]    |         ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 68 -         return score;
[INFO] [stdout] 68 +         score
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/state.rs:85:9
[INFO] [stdout]    |
[INFO] [stdout] 85 |         return all_sorted && got_fills && got_empties;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 85 -         return all_sorted && got_fills && got_empties;
[INFO] [stdout] 85 +         all_sorted && got_fills && got_empties
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/models/state.rs:81:22
[INFO] [stdout]    |
[INFO] [stdout] 81 |             .all(|c| !(c.must_empty() && !c.is_empty()));
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!c.must_empty() || c.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/models/state.rs:109:9
[INFO] [stdout]     |
[INFO] [stdout] 109 |         return transitions;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 109 -         return transitions;
[INFO] [stdout] 109 +         transitions
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/models/state.rs:124:9
[INFO] [stdout]     |
[INFO] [stdout] 124 |         return new_state;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 124 -         return new_state;
[INFO] [stdout] 124 +         new_state
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/models/state.rs:165:9
[INFO] [stdout]     |
[INFO] [stdout] 165 |         return None;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 165 -         return None;
[INFO] [stdout] 165 +         None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/transition.rs:13:9
[INFO] [stdout]    |
[INFO] [stdout] 13 | /         return Self {
[INFO] [stdout] 14 | |             pour_from: from,
[INFO] [stdout] 15 | |             pour_into: to,
[INFO] [stdout] 16 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 13 ~         Self {
[INFO] [stdout] 14 +             pour_from: from,
[INFO] [stdout] 15 +             pour_into: to,
[INFO] [stdout] 16 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stdout]   --> src/models/with_score.rs:23:5
[INFO] [stdout]    |
[INFO] [stdout] 23 |     fn ne(&self, other: &Self) -> bool {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stdout]    = note: `#[warn(clippy::partialeq_ne_impl)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type
[INFO] [stdout]   --> src/models/with_score.rs:30:1
[INFO] [stdout]    |
[INFO] [stdout] 30 | / impl<T, S: Ord> PartialOrd for WithScore<T, S> {
[INFO] [stdout] 31 | |     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
[INFO] [stdout] 32 | |         Some(self.score.cmp(&other.score))
[INFO] [stdout] 33 | |     }
[INFO] [stdout] 34 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
[INFO] [stdout]    = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 31 -     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
[INFO] [stdout] 32 -         Some(self.score.cmp(&other.score))
[INFO] [stdout] 33 -     }
[INFO] [stdout] 31 +     fn partial_cmp(&self, other: &Self) -> Option<Ordering> { Some(self.cmp(other)) }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/container.rs:30:9
[INFO] [stdout]    |
[INFO] [stdout] 30 | /         return Ok(Self {
[INFO] [stdout] 31 | |             content,
[INFO] [stdout] 32 | |             capacity,
[INFO] [stdout] 33 | |             constraint,
[INFO] [stdout] 34 | |         });
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 30 ~         Ok(Self {
[INFO] [stdout] 31 +             content,
[INFO] [stdout] 32 +             capacity,
[INFO] [stdout] 33 +             constraint,
[INFO] [stdout] 34 ~         })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/models/container.rs:23:12
[INFO] [stdout]    |
[INFO] [stdout] 23 |         if content.len() > 0 && content.len() > capacity {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/container.rs:38:9
[INFO] [stdout]    |
[INFO] [stdout] 38 |         return self.content.last();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 38 -         return self.content.last();
[INFO] [stdout] 38 +         self.content.last()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/container.rs:42:9
[INFO] [stdout]    |
[INFO] [stdout] 42 |         return self.content.is_empty();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 42 -         return self.content.is_empty();
[INFO] [stdout] 42 +         self.content.is_empty()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/container.rs:46:9
[INFO] [stdout]    |
[INFO] [stdout] 46 |         return self.content.len() == self.capacity;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 46 -         return self.content.len() == self.capacity;
[INFO] [stdout] 46 +         self.content.len() == self.capacity
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/container.rs:51:9
[INFO] [stdout]    |
[INFO] [stdout] 51 |         return self.content.iter().all(|color| color == first);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 51 -         return self.content.iter().all(|color| color == first);
[INFO] [stdout] 51 +         self.content.iter().all(|color| color == first)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/container.rs:80:9
[INFO] [stdout]    |
[INFO] [stdout] 80 |         return self.peek() == other.peek();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 80 -         return self.peek() == other.peek();
[INFO] [stdout] 80 +         self.peek() == other.peek()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/state.rs:15:9
[INFO] [stdout]    |
[INFO] [stdout] 15 | /         return Self {
[INFO] [stdout] 16 | |             containers,
[INFO] [stdout] 17 | |             transitions: Vec::new(),
[INFO] [stdout] 18 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 15 ~         Self {
[INFO] [stdout] 16 +             containers,
[INFO] [stdout] 17 +             transitions: Vec::new(),
[INFO] [stdout] 18 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/state.rs:23:9
[INFO] [stdout]    |
[INFO] [stdout] 23 |         return &self.transitions;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 23 -         return &self.transitions;
[INFO] [stdout] 23 +         &self.transitions
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:191:5
[INFO] [stdout]     |
[INFO] [stdout] 191 |     return Ok(containers);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 191 -     return Ok(containers);
[INFO] [stdout] 191 +     Ok(containers)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary use of `to_owned`
[INFO] [stdout]   --> src/main.rs:54:31
[INFO] [stdout]    |
[INFO] [stdout] 54 |                       content = content
[INFO] [stdout]    |  _______________________________^
[INFO] [stdout] 55 | |                         .trim()
[INFO] [stdout] 56 | |                         .to_owned()
[INFO] [stdout] 57 | |                         .split(' ')
[INFO] [stdout]    | |___________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_to_owned)]` on by default
[INFO] [stdout] help: use
[INFO] [stdout]    |
[INFO] [stdout] 54 ~                     content = content
[INFO] [stdout] 55 +                         .trim().split(' ')
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/main.rs:58:37
[INFO] [stdout]    |
[INFO] [stdout] 58 |                         .filter(|s| *s != "") // Remove any additional spaces within line
[INFO] [stdout]    |                                     ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]    = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/main.rs:64:24
[INFO] [stdout]    |
[INFO] [stdout] 64 |                     if content != "" {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]    --> src/main.rs:113:25
[INFO] [stdout]     |
[INFO] [stdout] 113 |             let first = capacities.first().unwrap().clone();
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*capacities.first().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/state.rs:68:9
[INFO] [stdout]    |
[INFO] [stdout] 68 |         return score;
[INFO] [stdout]    |         ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 68 -         return score;
[INFO] [stdout] 68 +         score
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/state.rs:85:9
[INFO] [stdout]    |
[INFO] [stdout] 85 |         return all_sorted && got_fills && got_empties;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 85 -         return all_sorted && got_fills && got_empties;
[INFO] [stdout] 85 +         all_sorted && got_fills && got_empties
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/models/state.rs:81:22
[INFO] [stdout]    |
[INFO] [stdout] 81 |             .all(|c| !(c.must_empty() && !c.is_empty()));
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!c.must_empty() || c.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/models/state.rs:109:9
[INFO] [stdout]     |
[INFO] [stdout] 109 |         return transitions;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 109 -         return transitions;
[INFO] [stdout] 109 +         transitions
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]    --> src/main.rs:182:30
[INFO] [stdout]     |
[INFO] [stdout] 182 |                 content.push(color_id.clone());
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*color_id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/models/state.rs:124:9
[INFO] [stdout]     |
[INFO] [stdout] 124 |         return new_state;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 124 -         return new_state;
[INFO] [stdout] 124 +         new_state
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/models/state.rs:165:9
[INFO] [stdout]     |
[INFO] [stdout] 165 |         return None;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 165 -         return None;
[INFO] [stdout] 165 +         None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/models/transition.rs:13:9
[INFO] [stdout]    |
[INFO] [stdout] 13 | /         return Self {
[INFO] [stdout] 14 | |             pour_from: from,
[INFO] [stdout] 15 | |             pour_into: to,
[INFO] [stdout] 16 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 13 ~         Self {
[INFO] [stdout] 14 +             pour_from: from,
[INFO] [stdout] 15 +             pour_into: to,
[INFO] [stdout] 16 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: re-implementing `PartialEq::ne` is unnecessary
[INFO] [stdout]   --> src/models/with_score.rs:23:5
[INFO] [stdout]    |
[INFO] [stdout] 23 |     fn ne(&self, other: &Self) -> bool {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
[INFO] [stdout]    = note: `#[warn(clippy::partialeq_ne_impl)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type
[INFO] [stdout]   --> src/models/with_score.rs:30:1
[INFO] [stdout]    |
[INFO] [stdout] 30 | / impl<T, S: Ord> PartialOrd for WithScore<T, S> {
[INFO] [stdout] 31 | |     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
[INFO] [stdout] 32 | |         Some(self.score.cmp(&other.score))
[INFO] [stdout] 33 | |     }
[INFO] [stdout] 34 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
[INFO] [stdout]    = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 31 -     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
[INFO] [stdout] 32 -         Some(self.score.cmp(&other.score))
[INFO] [stdout] 33 -     }
[INFO] [stdout] 31 +     fn partial_cmp(&self, other: &Self) -> Option<Ordering> { Some(self.cmp(other)) }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:191:5
[INFO] [stdout]     |
[INFO] [stdout] 191 |     return Ok(containers);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 191 -     return Ok(containers);
[INFO] [stdout] 191 +     Ok(containers)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary use of `to_owned`
[INFO] [stdout]   --> src/main.rs:54:31
[INFO] [stdout]    |
[INFO] [stdout] 54 |                       content = content
[INFO] [stdout]    |  _______________________________^
[INFO] [stdout] 55 | |                         .trim()
[INFO] [stdout] 56 | |                         .to_owned()
[INFO] [stdout] 57 | |                         .split(' ')
[INFO] [stdout]    | |___________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_to_owned)]` on by default
[INFO] [stdout] help: use
[INFO] [stdout]    |
[INFO] [stdout] 54 ~                     content = content
[INFO] [stdout] 55 +                         .trim().split(' ')
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/main.rs:58:37
[INFO] [stdout]    |
[INFO] [stdout] 58 |                         .filter(|s| *s != "") // Remove any additional spaces within line
[INFO] [stdout]    |                                     ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]    = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/main.rs:64:24
[INFO] [stdout]    |
[INFO] [stdout] 64 |                     if content != "" {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]    --> src/main.rs:113:25
[INFO] [stdout]     |
[INFO] [stdout] 113 |             let first = capacities.first().unwrap().clone();
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*capacities.first().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]    --> src/main.rs:182:30
[INFO] [stdout]     |
[INFO] [stdout] 182 |                 content.push(color_id.clone());
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*color_id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.33s
[INFO] running `Command { std: "docker" "inspect" "0c1a4ec573061bab641dc34aa3db7dc78e412aba13b77ef9340e9d64fb7b81a7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "0c1a4ec573061bab641dc34aa3db7dc78e412aba13b77ef9340e9d64fb7b81a7", kill_on_drop: false }`
[INFO] [stdout] 0c1a4ec573061bab641dc34aa3db7dc78e412aba13b77ef9340e9d64fb7b81a7