[INFO] cloning repository https://github.com/AmbryN/rust-vm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AmbryN/rust-vm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAmbryN%2Frust-vm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAmbryN%2Frust-vm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 991559e74ea318a6c88e3a2cf018d3124ba5f6bd [INFO] linting AmbryN/rust-vm against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAmbryN%2Frust-vm" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/AmbryN/rust-vm [INFO] finished tweaking git repo https://github.com/AmbryN/rust-vm [INFO] tweaked toml for git repo https://github.com/AmbryN/rust-vm written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/AmbryN/rust-vm on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/AmbryN/rust-vm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded env_logger v0.10.0 [INFO] [stderr] Downloaded windows-targets v0.48.3 [INFO] [stderr] Downloaded clap v4.3.22 [INFO] [stderr] Downloaded clap_builder v4.3.22 [INFO] [stderr] Downloaded windows_aarch64_gnullvm v0.48.3 [INFO] [stderr] Downloaded windows_x86_64_gnullvm v0.48.3 [INFO] [stderr] Downloaded windows_x86_64_msvc v0.48.3 [INFO] [stderr] Downloaded windows_i686_msvc v0.48.3 [INFO] [stderr] Downloaded windows_aarch64_msvc v0.48.3 [INFO] [stderr] Downloaded windows_x86_64_gnu v0.48.3 [INFO] [stderr] Downloaded windows_i686_gnu v0.48.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 849b0b006aea7813daa69a4fa8669635bb8fe2e702bd269465b384b865726a3c [INFO] running `Command { std: "docker" "start" "-a" "849b0b006aea7813daa69a4fa8669635bb8fe2e702bd269465b384b865726a3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "849b0b006aea7813daa69a4fa8669635bb8fe2e702bd269465b384b865726a3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "849b0b006aea7813daa69a4fa8669635bb8fe2e702bd269465b384b865726a3c", kill_on_drop: false }` [INFO] [stdout] 849b0b006aea7813daa69a4fa8669635bb8fe2e702bd269465b384b865726a3c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f4198c81a882bf479fa4455a6d0ddea00791fd7fd380cc5551f475cad050f406 [INFO] running `Command { std: "docker" "start" "-a" "f4198c81a882bf479fa4455a6d0ddea00791fd7fd380cc5551f475cad050f406", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.8 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking aho-corasick v1.0.4 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Checking clap_builder v4.3.22 [INFO] [stderr] Checking regex-automata v0.3.6 [INFO] [stderr] Checking regex v1.9.3 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Checking clap v4.3.22 [INFO] [stderr] Checking vm v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/assembler/directive_parsers.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `symbol::SymbolTable` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | symbol::SymbolTable, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::instruction::Opcode` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | use crate::instruction::Opcode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/assembler/label_parsers.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/assembler/opcode_parsers.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/assembler/operand_parsers.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/assembler/program_parsers.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/assembler/register_parsers.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashSet` [INFO] [stdout] --> src/assembler/symbol.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::HashSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IResult` [INFO] [stdout] --> src/assembler.rs:10:25 [INFO] [stdout] | [INFO] [stdout] 10 | use nom::{error::Error, IResult}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arg` and `Subcommand` [INFO] [stdout] --> src/main.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | use clap::{Arg, Parser, Subcommand}; [INFO] [stdout] | ^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `symbol::SymbolTable` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | symbol::SymbolTable, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashSet` [INFO] [stdout] --> src/assembler/symbol.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::HashSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IResult` [INFO] [stdout] --> src/assembler.rs:10:25 [INFO] [stdout] | [INFO] [stdout] 10 | use nom::{error::Error, IResult}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arg` and `Subcommand` [INFO] [stdout] --> src/main.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | use clap::{Arg, Parser, Subcommand}; [INFO] [stdout] | ^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/assembler.rs:215:13 [INFO] [stdout] | [INFO] [stdout] 215 | fn from(value: nom::Err>) -> Self { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `label_usage_parser` is never used [INFO] [stdout] --> src/assembler/label_parsers.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn label_usage_parser(input: &str) -> IResult<&str, Token> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `opcode` is never read [INFO] [stdout] --> src/instruction.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 65 | pub struct Instruction { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 66 | opcode: Opcode, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/assembler/instruction_parsers.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / for operand in &[&self.operand1, &self.operand2, &self.operand3] { [INFO] [stdout] 34 | | if let Some(t) = operand { [INFO] [stdout] 35 | | AssemblerInstruction::extract_operand(t, &mut results); [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/assembler/instruction_parsers.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | / if let Some(t) = operand { [INFO] [stdout] 35 | | AssemblerInstruction::extract_operand(t, &mut results); [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ for t in [&self.operand1, &self.operand2, &self.operand3].iter().copied().flatten() { [INFO] [stdout] 34 + AssemblerInstruction::extract_operand(t, &mut results); [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/assembler/symbol.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / self.symbols [INFO] [stdout] 54 | | .iter_mut() [INFO] [stdout] 55 | | .find(|item| item.name == name) [INFO] [stdout] 56 | | .map(|item| { [INFO] [stdout] 57 | | item.offset = offset; [INFO] [stdout] 58 | | return item; [INFO] [stdout] 59 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 53 ~ if let Some(item) = self.symbols [INFO] [stdout] 54 + .iter_mut() [INFO] [stdout] 55 + .find(|item| item.name == name) { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/symbol.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return item; [INFO] [stdout] 58 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Assembler` [INFO] [stdout] --> src/assembler.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | / pub fn new() -> Assembler { [INFO] [stdout] 56 | | Assembler { [INFO] [stdout] 57 | | phase: AssemblerPhase::First, [INFO] [stdout] 58 | | symbols: SymbolTable::new(), [INFO] [stdout] ... | [INFO] [stdout] 66 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 54 + impl Default for Assembler { [INFO] [stdout] 55 + fn default() -> Self { [INFO] [stdout] 56 + Self::new() [INFO] [stdout] 57 + } [INFO] [stdout] 58 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/assembler.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | / if i.is_label() { [INFO] [stdout] 116 | | if self.current_section.is_some() { [INFO] [stdout] 117 | | if let Some(name) = i.get_label_name() { [INFO] [stdout] 118 | | let symbol = Symbol::new(name, SymbolType::Label, 0); [INFO] [stdout] ... | [INFO] [stdout] 129 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 115 ~ if i.is_label() [INFO] [stdout] 116 ~ && self.current_section.is_some() { [INFO] [stdout] 117 | if let Some(name) = i.get_label_name() { [INFO] [stdout] ... [INFO] [stdout] 127 | } [INFO] [stdout] 128 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler.rs:138:33 [INFO] [stdout] | [INFO] [stdout] 138 | "asciiz" => return self.handle_asciiz(i), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 ~ "asciiz" => self.handle_asciiz(i), [INFO] [stdout] 139 | _ => { [INFO] [stdout] ... [INFO] [stdout] 143 | } [INFO] [stdout] 144 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler.rs:140:25 [INFO] [stdout] | [INFO] [stdout] 140 | / return Err(AssemblerError::UnknownDirectiveFound { [INFO] [stdout] 141 | | directive: directive_name, [INFO] [stdout] 142 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 ~ Err(AssemblerError::UnknownDirectiveFound { [INFO] [stdout] 141 + directive: directive_name, [INFO] [stdout] 142 + }) [INFO] [stdout] 143 | } [INFO] [stdout] 144 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 189 | return Err(AssemblerError::NoStringConstant); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return Err(AssemblerError::NoStringConstant); [INFO] [stdout] 189 + Err(AssemblerError::NoStringConstant) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rest` [INFO] [stdout] --> src/assembler/directive_parsers.rs:68:14 [INFO] [stdout] | [INFO] [stdout] 68 | let (rest, directive) = result.unwrap(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_rest` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/assembler.rs:215:13 [INFO] [stdout] | [INFO] [stdout] 215 | fn from(value: nom::Err>) -> Self { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/assembler/instruction_parsers.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / for operand in &[&self.operand1, &self.operand2, &self.operand3] { [INFO] [stdout] 34 | | if let Some(t) = operand { [INFO] [stdout] 35 | | AssemblerInstruction::extract_operand(t, &mut results); [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/assembler/instruction_parsers.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | / if let Some(t) = operand { [INFO] [stdout] 35 | | AssemblerInstruction::extract_operand(t, &mut results); [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ for t in [&self.operand1, &self.operand2, &self.operand3].iter().copied().flatten() { [INFO] [stdout] 34 + AssemblerInstruction::extract_operand(t, &mut results); [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembler/operand_parsers.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | assert!(!result.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembler/operand_parsers.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | assert!(!result.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/program_parsers.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 43 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 43 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembler/register_parsers.rs:35:17 [INFO] [stdout] | [INFO] [stdout] 35 | assert!(!result.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembler/register_parsers.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | assert!(!result.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/assembler/symbol.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / self.symbols [INFO] [stdout] 54 | | .iter_mut() [INFO] [stdout] 55 | | .find(|item| item.name == name) [INFO] [stdout] 56 | | .map(|item| { [INFO] [stdout] 57 | | item.offset = offset; [INFO] [stdout] 58 | | return item; [INFO] [stdout] 59 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 53 ~ if let Some(item) = self.symbols [INFO] [stdout] 54 + .iter_mut() [INFO] [stdout] 55 + .find(|item| item.name == name) { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/symbol.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return item; [INFO] [stdout] 58 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/symbol.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | assert_eq!(true, v.is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 75 - assert_eq!(true, v.is_some()); [INFO] [stdout] 75 + assert!(v.is_some()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/symbol.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | assert_eq!(v.is_some(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 79 - assert_eq!(v.is_some(), false); [INFO] [stdout] 79 + assert!(!v.is_some()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Assembler` [INFO] [stdout] --> src/assembler.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | / pub fn new() -> Assembler { [INFO] [stdout] 56 | | Assembler { [INFO] [stdout] 57 | | phase: AssemblerPhase::First, [INFO] [stdout] 58 | | symbols: SymbolTable::new(), [INFO] [stdout] ... | [INFO] [stdout] 66 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 54 + impl Default for Assembler { [INFO] [stdout] 55 + fn default() -> Self { [INFO] [stdout] 56 + Self::new() [INFO] [stdout] 57 + } [INFO] [stdout] 58 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/assembler.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | / if i.is_label() { [INFO] [stdout] 116 | | if self.current_section.is_some() { [INFO] [stdout] 117 | | if let Some(name) = i.get_label_name() { [INFO] [stdout] 118 | | let symbol = Symbol::new(name, SymbolType::Label, 0); [INFO] [stdout] ... | [INFO] [stdout] 129 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 115 ~ if i.is_label() [INFO] [stdout] 116 ~ && self.current_section.is_some() { [INFO] [stdout] 117 | if let Some(name) = i.get_label_name() { [INFO] [stdout] ... [INFO] [stdout] 127 | } [INFO] [stdout] 128 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler.rs:138:33 [INFO] [stdout] | [INFO] [stdout] 138 | "asciiz" => return self.handle_asciiz(i), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 ~ "asciiz" => self.handle_asciiz(i), [INFO] [stdout] 139 | _ => { [INFO] [stdout] ... [INFO] [stdout] 143 | } [INFO] [stdout] 144 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler.rs:140:25 [INFO] [stdout] | [INFO] [stdout] 140 | / return Err(AssemblerError::UnknownDirectiveFound { [INFO] [stdout] 141 | | directive: directive_name, [INFO] [stdout] 142 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 ~ Err(AssemblerError::UnknownDirectiveFound { [INFO] [stdout] 141 + directive: directive_name, [INFO] [stdout] 142 + }) [INFO] [stdout] 143 | } [INFO] [stdout] 144 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 189 | return Err(AssemblerError::NoStringConstant); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return Err(AssemblerError::NoStringConstant); [INFO] [stdout] 189 + Err(AssemblerError::NoStringConstant) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.11s [INFO] running `Command { std: "docker" "inspect" "f4198c81a882bf479fa4455a6d0ddea00791fd7fd380cc5551f475cad050f406", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4198c81a882bf479fa4455a6d0ddea00791fd7fd380cc5551f475cad050f406", kill_on_drop: false }` [INFO] [stdout] f4198c81a882bf479fa4455a6d0ddea00791fd7fd380cc5551f475cad050f406