[INFO] cloning repository https://github.com/Amaterasu-OPS/afrodite-auth-service [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Amaterasu-OPS/afrodite-auth-service" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAmaterasu-OPS%2Fafrodite-auth-service", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAmaterasu-OPS%2Fafrodite-auth-service'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f03c4ac42c5bf28f6161572c4a3262e2c6c51083 [INFO] linting Amaterasu-OPS/afrodite-auth-service against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAmaterasu-OPS%2Fafrodite-auth-service" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Amaterasu-OPS/afrodite-auth-service [INFO] finished tweaking git repo https://github.com/Amaterasu-OPS/afrodite-auth-service [INFO] tweaked toml for git repo https://github.com/Amaterasu-OPS/afrodite-auth-service written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Amaterasu-OPS/afrodite-auth-service on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Amaterasu-OPS/afrodite-auth-service already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded env_filter v0.1.4 [INFO] [stderr] Downloaded deadpool-redis v0.22.0 [INFO] [stderr] Downloaded rustls-pki-types v1.13.1 [INFO] [stderr] Downloaded deadpool-runtime v0.1.4 [INFO] [stderr] Downloaded actix-cors v0.7.1 [INFO] [stderr] Downloaded actix-rt v2.11.0 [INFO] [stderr] Downloaded bytestring v1.5.0 [INFO] [stderr] Downloaded actix-server v2.6.0 [INFO] [stderr] Downloaded deadpool v0.12.3 [INFO] [stderr] Downloaded regex-lite v0.1.8 [INFO] [stderr] Downloaded jiff-static v0.2.16 [INFO] [stderr] Downloaded cc v1.2.45 [INFO] [stderr] Downloaded num-bigint-dig v0.8.5 [INFO] [stderr] Downloaded aws-lc-rs v1.15.0 [INFO] [stderr] Downloaded actix-http v3.11.2 [INFO] [stderr] Downloaded actix-web v4.11.0 [INFO] [stderr] Downloaded jiff v0.2.16 [INFO] [stderr] Downloaded aws-lc-sys v0.33.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1108309966fe25b8831bee7551e1ba717ecd8129fcdbaad8d572153dd33f6ccf [INFO] running `Command { std: "docker" "start" "-a" "1108309966fe25b8831bee7551e1ba717ecd8129fcdbaad8d572153dd33f6ccf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1108309966fe25b8831bee7551e1ba717ecd8129fcdbaad8d572153dd33f6ccf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1108309966fe25b8831bee7551e1ba717ecd8129fcdbaad8d572153dd33f6ccf", kill_on_drop: false }` [INFO] [stdout] 1108309966fe25b8831bee7551e1ba717ecd8129fcdbaad8d572153dd33f6ccf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 51aeff88888477bbef5001aa937ceb35e5235fd0c46bb432d0e2269720bb5b58 [INFO] running `Command { std: "docker" "start" "-a" "51aeff88888477bbef5001aa937ceb35e5235fd0c46bb432d0e2269720bb5b58", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling generic-array v0.14.9 [INFO] [stderr] Compiling find-msvc-tools v0.1.4 [INFO] [stderr] Compiling cfg-if v1.0.4 [INFO] [stderr] Compiling icu_properties_data v2.1.1 [INFO] [stderr] Compiling pin-project-lite v0.2.16 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling stable_deref_trait v1.2.1 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling value-bag v1.11.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling log v0.4.28 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling litemap v0.8.1 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling rustix v0.37.28 [INFO] [stderr] Compiling writeable v0.6.2 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Compiling slab v0.4.11 [INFO] [stderr] Compiling futures-lite v2.6.1 [INFO] [stderr] Compiling tracing-core v0.1.34 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Compiling linux-raw-sys v0.11.0 [INFO] [stderr] Compiling event-listener v5.4.1 [INFO] [stderr] Compiling bytes v1.10.1 [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling event-listener-strategy v0.5.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling syn v2.0.110 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking mio v1.1.0 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling atomic-waker v1.1.2 [INFO] [stderr] Compiling async-task v4.7.1 [INFO] [stderr] Compiling event-listener v2.5.3 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling piper v0.2.4 [INFO] [stderr] Compiling async-channel v2.5.0 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Checking indexmap v2.12.0 [INFO] [stderr] Compiling cc v1.2.45 [INFO] [stderr] Compiling lock_api v0.4.14 [INFO] [stderr] Compiling async-executor v1.13.3 [INFO] [stderr] Compiling blocking v1.6.2 [INFO] [stderr] Compiling async-lock v3.4.1 [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling utf8_iter v1.0.4 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Compiling linux-raw-sys v0.3.8 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling fastrand v1.9.0 [INFO] [stderr] Compiling allocator-api2 v0.2.21 [INFO] [stderr] Compiling waker-fn v1.2.0 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Compiling futures-lite v1.13.0 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Compiling tinyvec v1.10.0 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling async-lock v2.8.0 [INFO] [stderr] Compiling async-channel v1.9.0 [INFO] [stderr] Compiling socket2 v0.4.10 [INFO] [stderr] Checking rustls-pki-types v1.13.1 [INFO] [stderr] Compiling kv-log-macro v1.0.7 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling iana-time-zone v0.1.64 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling chrono v0.4.42 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Compiling aws-lc-sys v0.33.0 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling crc v3.3.0 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling unicode-normalization v0.1.25 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling uuid v1.18.1 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling unicode-properties v0.1.4 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Compiling unicode-bidi v0.3.18 [INFO] [stderr] Compiling rustls v0.23.35 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Compiling bytestring v1.5.0 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Checking actix-service v2.0.3 [INFO] [stderr] Compiling whoami v1.6.1 [INFO] [stderr] Compiling home v0.5.12 [INFO] [stderr] Compiling regex-lite v0.1.8 [INFO] [stderr] Checking async-std v1.13.2 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Compiling aws-lc-rs v1.15.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Checking webpki-roots v1.0.4 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking iri-string v0.7.9 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking impl-more v0.1.9 [INFO] [stderr] Compiling yoke v0.8.1 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking env_filter v0.1.4 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling zerovec v0.11.5 [INFO] [stderr] Compiling zerotrie v0.2.3 [INFO] [stderr] Checking pem v3.0.6 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking jiff v0.2.16 [INFO] [stderr] Checking simple_asn1 v0.6.3 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Compiling icu_provider v2.1.1 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Compiling icu_properties v2.1.1 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking actix-router v0.5.3 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking futures-intrusive v0.5.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking sqlx-core v0.8.6 [INFO] [stderr] Checking sqlx-postgres v0.8.6 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking actix-rt v2.11.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking deadpool-runtime v0.1.4 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking actix-server v2.6.0 [INFO] [stderr] Checking deadpool v0.12.3 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking tower-http v0.6.7 [INFO] [stderr] Checking hyper-util v0.1.18 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.12.24 [INFO] [stderr] Checking actix-http v3.11.2 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Checking redis v0.32.7 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking jsonwebtoken v10.2.0 [INFO] [stderr] Checking actix-web v4.11.0 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking actix-cors v0.7.1 [INFO] [stderr] Checking deadpool-redis v0.22.0 [INFO] [stderr] Checking aphrodite-auth-service v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/adapters/api/auth/controllers/authorize.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if !data.session_id.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data.session_id.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/adapters/api/auth/controllers/authorize.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if !data.session_id.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data.session_id.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/adapters/spi/db/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod db; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/adapters/spi/db/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod db; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/adapters/spi/cache/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod cache; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/adapters/spi/gateways/idp.rs:23:63 [INFO] [stdout] | [INFO] [stdout] 23 | .header("X-api-key", std::env::var("IDP_API_KEY").unwrap_or(String::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/adapters/spi/gateways/idp.rs:32:63 [INFO] [stdout] | [INFO] [stdout] 32 | .header("X-api-key", std::env::var("IDP_API_KEY").unwrap_or(String::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/adapters/spi/cache/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod cache; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/adapters/spi/gateways/idp.rs:23:63 [INFO] [stdout] | [INFO] [stdout] 23 | .header("X-api-key", std::env::var("IDP_API_KEY").unwrap_or(String::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/adapters/spi/gateways/idp.rs:32:63 [INFO] [stdout] | [INFO] [stdout] 32 | .header("X-api-key", std::env::var("IDP_API_KEY").unwrap_or(String::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/application/use_cases/auth/par.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | if let Err(_) = conn.set_ex::(request_uri, value, exp) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 60 ~ if conn.set_ex::(request_uri, value, exp) [INFO] [stdout] 61 ~ .await.is_err(){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/application/use_cases/auth/par.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | if let Err(_) = conn.set_ex::(request_uri, value, exp) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 60 ~ if conn.set_ex::(request_uri, value, exp) [INFO] [stdout] 61 ~ .await.is_err(){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/application/use_cases/auth/authorize.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | if let Err(_) = conn.del::(uri.clone()).await { [INFO] [stdout] | -------^^^^^^------------------------------------------------ help: try: `if conn.del::(uri.clone()).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | / if let Err(e) = self.validate_consent(&mut session, arc_data.clone()).await { [INFO] [stdout] 53 | | return Err(e) [INFO] [stdout] 54 | | } [INFO] [stdout] | |_____________^ help: replace it with: `self.validate_consent(&mut session, arc_data.clone()).await?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | / if let Err(e) = self.check_auth_token(arc_data.auth_token.clone().unwrap()).await { [INFO] [stdout] 57 | | return Err(e) [INFO] [stdout] 58 | | } [INFO] [stdout] | |_____________^ help: replace it with: `self.check_auth_token(arc_data.auth_token.clone().unwrap()).await?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:82:16 [INFO] [stdout] | [INFO] [stdout] 82 | if let Err(_) = conn.set_ex::(token.to_string(), value, 60 * 2).await { [INFO] [stdout] | -------^^^^^^---------------------------------------------------------------------------- help: try: `if conn.set_ex::(token.to_string(), value, 60 * 2).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:86:86 [INFO] [stdout] | [INFO] [stdout] 86 | let url = format!("{}?code={}&state={}", session.redirect_uri.unwrap(), token.to_string(), session.state.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/application/use_cases/auth/authorize.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | if let Err(_) = conn.del::(uri.clone()).await { [INFO] [stdout] | -------^^^^^^------------------------------------------------ help: try: `if conn.del::(uri.clone()).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | / if let Err(e) = self.validate_consent(&mut session, arc_data.clone()).await { [INFO] [stdout] 53 | | return Err(e) [INFO] [stdout] 54 | | } [INFO] [stdout] | |_____________^ help: replace it with: `self.validate_consent(&mut session, arc_data.clone()).await?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | / if let Err(e) = self.check_auth_token(arc_data.auth_token.clone().unwrap()).await { [INFO] [stdout] 57 | | return Err(e) [INFO] [stdout] 58 | | } [INFO] [stdout] | |_____________^ help: replace it with: `self.check_auth_token(arc_data.auth_token.clone().unwrap()).await?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:82:16 [INFO] [stdout] | [INFO] [stdout] 82 | if let Err(_) = conn.set_ex::(token.to_string(), value, 60 * 2).await { [INFO] [stdout] | -------^^^^^^---------------------------------------------------------------------------- help: try: `if conn.set_ex::(token.to_string(), value, 60 * 2).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:86:86 [INFO] [stdout] | [INFO] [stdout] 86 | let url = format!("{}?code={}&state={}", session.redirect_uri.unwrap(), token.to_string(), session.state.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | user_id.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 129 | if e == String::from("Consent not found") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"Consent not found"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:157:42 [INFO] [stdout] | [INFO] [stdout] 157 | return Err(ApiError::new(String::from(url), StatusCode::SEE_OTHER)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | / ... if let Ok(e) = self.consent_repository.get(data.consent_id.unwrap()).await { [INFO] [stdout] 168 | | ... if e.user_id.unwrap() != session.user_id.clone().unwrap() || e.client_id.unwrap() != session.client_id.clone().unwrap() { [INFO] [stdout] 169 | | ... return Err(ApiError::new("Invalid consent ID".to_string(), StatusCode::UNPROCESSABLE_ENTITY)) [INFO] [stdout] 170 | | ... } [INFO] [stdout] 171 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 167 ~ if let Ok(e) = self.consent_repository.get(data.consent_id.unwrap()).await [INFO] [stdout] 168 ~ && (e.user_id.unwrap() != session.user_id.clone().unwrap() || e.client_id.unwrap() != session.client_id.clone().unwrap()) { [INFO] [stdout] 169 | return Err(ApiError::new("Invalid consent ID".to_string(), StatusCode::UNPROCESSABLE_ENTITY)) [INFO] [stdout] 170 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:168:38 [INFO] [stdout] | [INFO] [stdout] 168 | if e.user_id.unwrap() != session.user_id.clone().unwrap() || e.client_id.unwrap() != session.client_id.clone().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | user_id.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/application/use_cases/auth/token_authorization_code.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / if let Err(e) = self.validate_request(arc_data.clone()) { [INFO] [stdout] 43 | | return Err(e); [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________^ help: replace it with: `self.validate_request(arc_data.clone())?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 129 | if e == String::from("Consent not found") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"Consent not found"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:157:42 [INFO] [stdout] | [INFO] [stdout] 157 | return Err(ApiError::new(String::from(url), StatusCode::SEE_OTHER)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/application/use_cases/auth/token_authorization_code.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | / if let Err(e) = self.validate_client(arc_data.clone(), repo_session.clone(), repo_client.clone()) { [INFO] [stdout] 78 | | return Err(e); [INFO] [stdout] 79 | | } [INFO] [stdout] | |_________^ help: replace it with: `self.validate_client(arc_data.clone(), repo_session.clone(), repo_client.clone())?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | / ... if let Ok(e) = self.consent_repository.get(data.consent_id.unwrap()).await { [INFO] [stdout] 168 | | ... if e.user_id.unwrap() != session.user_id.clone().unwrap() || e.client_id.unwrap() != session.client_id.clone().unwrap() { [INFO] [stdout] 169 | | ... return Err(ApiError::new("Invalid consent ID".to_string(), StatusCode::UNPROCESSABLE_ENTITY)) [INFO] [stdout] 170 | | ... } [INFO] [stdout] 171 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 167 ~ if let Ok(e) = self.consent_repository.get(data.consent_id.unwrap()).await [INFO] [stdout] 168 ~ && (e.user_id.unwrap() != session.user_id.clone().unwrap() || e.client_id.unwrap() != session.client_id.clone().unwrap()) { [INFO] [stdout] 169 | return Err(ApiError::new("Invalid consent ID".to_string(), StatusCode::UNPROCESSABLE_ENTITY)) [INFO] [stdout] 170 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/token_authorization_code.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | session.user_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/authorize_continue.rs:168:38 [INFO] [stdout] | [INFO] [stdout] 168 | if e.user_id.unwrap() != session.user_id.clone().unwrap() || e.client_id.unwrap() != session.client_id.clone().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/application/use_cases/auth/token_authorization_code.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | if let Err(_) = conn.del::(arc_data.code.clone()).await { [INFO] [stdout] | -------^^^^^^---------------------------------------------------------- help: try: `if conn.del::(arc_data.code.clone()).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/application/use_cases/auth/token_authorization_code.rs:110:16 [INFO] [stdout] | [INFO] [stdout] 110 | if let Err(_) = self.token_repository.insert(OauthToken { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 110 ~ if self.token_repository.insert(OauthToken { [INFO] [stdout] 111 + id: None, [INFO] [stdout] 112 + session_id: Some(session.session_id.clone()), [INFO] [stdout] 113 + access_token: Some(hash_sha256(access_token.clone().as_str())), [INFO] [stdout] 114 + refresh_token: Some(hash_sha256(refresh_token.clone().as_str())), [INFO] [stdout] 115 + refresh_token_expires_at: Some(exp.naive_utc()), [INFO] [stdout] 116 + status: None, [INFO] [stdout] 117 + created_at: None, [INFO] [stdout] 118 + updated_at: None, [INFO] [stdout] 119 ~ }).await.is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/token_authorization_code.rs:112:30 [INFO] [stdout] | [INFO] [stdout] 112 | session_id: Some(session.session_id.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session.session_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/application/use_cases/auth/token_authorization_code.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / if let Err(e) = self.validate_request(arc_data.clone()) { [INFO] [stdout] 43 | | return Err(e); [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________^ help: replace it with: `self.validate_request(arc_data.clone())?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/application/use_cases/auth/token_refresh.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / if let Err(e) = self.validate_request(arc_data.clone()) { [INFO] [stdout] 37 | | return Err(e); [INFO] [stdout] 38 | | } [INFO] [stdout] | |_________^ help: replace it with: `self.validate_request(arc_data.clone())?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/application/use_cases/auth/token_authorization_code.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | / if let Err(e) = self.validate_client(arc_data.clone(), repo_session.clone(), repo_client.clone()) { [INFO] [stdout] 78 | | return Err(e); [INFO] [stdout] 79 | | } [INFO] [stdout] | |_________^ help: replace it with: `self.validate_client(arc_data.clone(), repo_session.clone(), repo_client.clone())?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/token_authorization_code.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | session.user_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/application/use_cases/auth/token_refresh.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / if let Err(e) = self.validate_client(arc_data.clone(), repo_session.clone(), repo_client.clone()) { [INFO] [stdout] 64 | | return Err(e); [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________^ help: replace it with: `self.validate_client(arc_data.clone(), repo_session.clone(), repo_client.clone())?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/application/use_cases/auth/token_authorization_code.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | if let Err(_) = conn.del::(arc_data.code.clone()).await { [INFO] [stdout] | -------^^^^^^---------------------------------------------------------- help: try: `if conn.del::(arc_data.code.clone()).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/token_refresh.rs:68:22 [INFO] [stdout] | [INFO] [stdout] 68 | user_id: repo_session.user_id.clone().unwrap().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `repo_session.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/application/use_cases/auth/token_authorization_code.rs:110:16 [INFO] [stdout] | [INFO] [stdout] 110 | if let Err(_) = self.token_repository.insert(OauthToken { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 110 ~ if self.token_repository.insert(OauthToken { [INFO] [stdout] 111 + id: None, [INFO] [stdout] 112 + session_id: Some(session.session_id.clone()), [INFO] [stdout] 113 + access_token: Some(hash_sha256(access_token.clone().as_str())), [INFO] [stdout] 114 + refresh_token: Some(hash_sha256(refresh_token.clone().as_str())), [INFO] [stdout] 115 + refresh_token_expires_at: Some(exp.naive_utc()), [INFO] [stdout] 116 + status: None, [INFO] [stdout] 117 + created_at: None, [INFO] [stdout] 118 + updated_at: None, [INFO] [stdout] 119 ~ }).await.is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/token_refresh.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | repo_session.user_id.unwrap().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `repo_session.user_id.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/token_authorization_code.rs:112:30 [INFO] [stdout] | [INFO] [stdout] 112 | session_id: Some(session.session_id.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session.session_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/application/use_cases/auth/token_refresh.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | if let Err(_) = self.token_repository.edit(token.id.unwrap(), OauthToken { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 91 ~ if self.token_repository.edit(token.id.unwrap(), OauthToken { [INFO] [stdout] 92 + id: None, [INFO] [stdout] 93 + session_id: None, [INFO] [stdout] 94 + access_token: Some(hash_sha256(access_token.clone().as_str())), [INFO] [stdout] 95 + refresh_token: Some(hash_sha256(refresh_token.clone().as_str())), [INFO] [stdout] 96 + refresh_token_expires_at: Some(exp.naive_utc()), [INFO] [stdout] 97 + status: None, [INFO] [stdout] 98 + created_at: None, [INFO] [stdout] 99 + updated_at: None, [INFO] [stdout] 100 ~ }, vec!["access_token", "refresh_token", "refresh_token_expires_at"]).await.is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/application/use_cases/auth/token_refresh.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / if let Err(e) = self.validate_request(arc_data.clone()) { [INFO] [stdout] 37 | | return Err(e); [INFO] [stdout] 38 | | } [INFO] [stdout] | |_________^ help: replace it with: `self.validate_request(arc_data.clone())?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/application/use_cases/auth/token_refresh.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / if let Err(e) = self.validate_client(arc_data.clone(), repo_session.clone(), repo_client.clone()) { [INFO] [stdout] 64 | | return Err(e); [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________^ help: replace it with: `self.validate_client(arc_data.clone(), repo_session.clone(), repo_client.clone())?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/token_refresh.rs:68:22 [INFO] [stdout] | [INFO] [stdout] 68 | user_id: repo_session.user_id.clone().unwrap().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `repo_session.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/token_refresh.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | repo_session.user_id.unwrap().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `repo_session.user_id.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/application/use_cases/auth/consent_confirm.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | / if let Err(e) = self.check_scopes( [INFO] [stdout] 36 | | client.scopes.clone().unwrap_or_default(), [INFO] [stdout] 37 | | client.mandatory_scopes.clone().unwrap_or_default(), [INFO] [stdout] 38 | | data.scopes.clone() [INFO] [stdout] 39 | | ) { [INFO] [stdout] 40 | | return Err(e); [INFO] [stdout] 41 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 35 ~ self.check_scopes( [INFO] [stdout] 36 + client.scopes.clone().unwrap_or_default(), [INFO] [stdout] 37 + client.mandatory_scopes.clone().unwrap_or_default(), [INFO] [stdout] 38 + data.scopes.clone() [INFO] [stdout] 39 + )?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/application/use_cases/auth/token_refresh.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | if let Err(_) = self.token_repository.edit(token.id.unwrap(), OauthToken { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 91 ~ if self.token_repository.edit(token.id.unwrap(), OauthToken { [INFO] [stdout] 92 + id: None, [INFO] [stdout] 93 + session_id: None, [INFO] [stdout] 94 + access_token: Some(hash_sha256(access_token.clone().as_str())), [INFO] [stdout] 95 + refresh_token: Some(hash_sha256(refresh_token.clone().as_str())), [INFO] [stdout] 96 + refresh_token_expires_at: Some(exp.naive_utc()), [INFO] [stdout] 97 + status: None, [INFO] [stdout] 98 + created_at: None, [INFO] [stdout] 99 + updated_at: None, [INFO] [stdout] 100 ~ }, vec!["access_token", "refresh_token", "refresh_token_expires_at"]).await.is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/consent_confirm.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | user_id: Some(session.user_id.clone().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/consent_confirm.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | session.user_id.clone().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/consent_confirm.rs:70:17 [INFO] [stdout] | [INFO] [stdout] 70 | session.id.clone().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/consent_confirm.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | consent.id.clone().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `consent.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value` after checking its variant with `is_some` [INFO] [stdout] --> src/application/use_cases/auth/userinfo.rs:37:70 [INFO] [stdout] | [INFO] [stdout] 36 | if value.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = value` [INFO] [stdout] 37 | let Ok(result) = serde_json::from_str::(&value.unwrap()) else { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/application/use_cases/auth/consent_confirm.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | / if let Err(e) = self.check_scopes( [INFO] [stdout] 36 | | client.scopes.clone().unwrap_or_default(), [INFO] [stdout] 37 | | client.mandatory_scopes.clone().unwrap_or_default(), [INFO] [stdout] 38 | | data.scopes.clone() [INFO] [stdout] 39 | | ) { [INFO] [stdout] 40 | | return Err(e); [INFO] [stdout] 41 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 35 ~ self.check_scopes( [INFO] [stdout] 36 + client.scopes.clone().unwrap_or_default(), [INFO] [stdout] 37 + client.mandatory_scopes.clone().unwrap_or_default(), [INFO] [stdout] 38 + data.scopes.clone() [INFO] [stdout] 39 + )?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/consent_confirm.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | user_id: Some(session.user_id.clone().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/userinfo.rs:52:59 [INFO] [stdout] | [INFO] [stdout] 52 | let Ok(user) = self.idp_gateway.get_user_by_id_v1(session.user_id.clone().unwrap()).await else { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/application/use_cases/auth/userinfo.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | if let Err(_) = conn.set_ex::(format!("sub:{}", data.sub.clone()), string_result, 60 * 5).await { [INFO] [stdout] | -------^^^^^^------------------------------------------------------------------------------------------------------ help: try: `if conn.set_ex::(format!("sub:{}", data.sub.clone()), string_result, 60 * 5).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/consent_confirm.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | session.user_id.clone().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/consent_confirm.rs:70:17 [INFO] [stdout] | [INFO] [stdout] 70 | session.id.clone().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/consent_confirm.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | consent.id.clone().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `consent.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value` after checking its variant with `is_some` [INFO] [stdout] --> src/application/use_cases/auth/userinfo.rs:37:70 [INFO] [stdout] | [INFO] [stdout] 36 | if value.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = value` [INFO] [stdout] 37 | let Ok(result) = serde_json::from_str::(&value.unwrap()) else { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/application/use_cases/auth/userinfo.rs:52:59 [INFO] [stdout] | [INFO] [stdout] 52 | let Ok(user) = self.idp_gateway.get_user_by_id_v1(session.user_id.clone().unwrap()).await else { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/application/use_cases/auth/userinfo.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | if let Err(_) = conn.set_ex::(format!("sub:{}", data.sub.clone()), string_result, 60 * 5).await { [INFO] [stdout] | -------^^^^^^------------------------------------------------------------------------------------------------------ help: try: `if conn.set_ex::(format!("sub:{}", data.sub.clone()), string_result, 60 * 5).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> src/utils/token.rs:23:14 [INFO] [stdout] | [INFO] [stdout] 23 | sub: user_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/utils/token.rs:24:14 [INFO] [stdout] | [INFO] [stdout] 24 | exp: exp.clone() as usize, [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `exp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/token.rs:48:28 [INFO] [stdout] | [INFO] [stdout] 48 | URL_SAFE_NO_PAD.encode(&buf) [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> src/utils/token.rs:23:14 [INFO] [stdout] | [INFO] [stdout] 23 | sub: user_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/utils/token.rs:24:14 [INFO] [stdout] | [INFO] [stdout] 24 | exp: exp.clone() as usize, [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `exp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/token.rs:48:28 [INFO] [stdout] | [INFO] [stdout] 48 | URL_SAFE_NO_PAD.encode(&buf) [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 10s [INFO] running `Command { std: "docker" "inspect" "51aeff88888477bbef5001aa937ceb35e5235fd0c46bb432d0e2269720bb5b58", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51aeff88888477bbef5001aa937ceb35e5235fd0c46bb432d0e2269720bb5b58", kill_on_drop: false }` [INFO] [stdout] 51aeff88888477bbef5001aa937ceb35e5235fd0c46bb432d0e2269720bb5b58