[INFO] cloning repository https://github.com/AmanTrance/Vox-Arena-backend [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AmanTrance/Vox-Arena-backend" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAmanTrance%2FVox-Arena-backend", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAmanTrance%2FVox-Arena-backend'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 399c08d20782c7addbe0de07e2f9fe72ed2f4365 [INFO] linting AmanTrance/Vox-Arena-backend against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAmanTrance%2FVox-Arena-backend" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/AmanTrance/Vox-Arena-backend [INFO] finished tweaking git repo https://github.com/AmanTrance/Vox-Arena-backend [INFO] tweaked toml for git repo https://github.com/AmanTrance/Vox-Arena-backend written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/AmanTrance/Vox-Arena-backend on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/AmanTrance/Vox-Arena-backend already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded redox_syscall v0.5.4 [INFO] [stderr] Downloaded actix-ws v0.3.0 [INFO] [stderr] Downloaded impl-more v0.1.6 [INFO] [stderr] Downloaded pq-sys v0.6.2 [INFO] [stderr] Downloaded diesel v2.2.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f37b147fb0d9bd433e03950ceb9bcb6d77b35981a7276c3bda66adff9326c690 [INFO] running `Command { std: "docker" "start" "-a" "f37b147fb0d9bd433e03950ceb9bcb6d77b35981a7276c3bda66adff9326c690", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f37b147fb0d9bd433e03950ceb9bcb6d77b35981a7276c3bda66adff9326c690", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f37b147fb0d9bd433e03950ceb9bcb6d77b35981a7276c3bda66adff9326c690", kill_on_drop: false }` [INFO] [stdout] f37b147fb0d9bd433e03950ceb9bcb6d77b35981a7276c3bda66adff9326c690 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 59cbd3e172c38828a34d9a9286998adea9160efd4364a822dc215a7fb05df44b [INFO] running `Command { std: "docker" "start" "-a" "59cbd3e172c38828a34d9a9286998adea9160efd4364a822dc215a7fb05df44b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling tracing-core v0.1.32 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling pin-project-lite v0.2.14 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking actix-service v2.0.2 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling regex-lite v0.1.6 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling bytestring v1.3.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Compiling pq-sys v0.6.2 [INFO] [stderr] Compiling cc v1.1.18 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking impl-more v0.1.6 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking bcrypt v0.15.1 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Checking cookie v0.16.2 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling diesel_table_macro_syntax v0.2.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling dsl_auto_type v0.1.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Compiling diesel_derives v2.2.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking actix-rt v2.10.0 [INFO] [stderr] Checking actix-server v2.5.0 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking diesel v2.2.4 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking actix-http v3.9.0 [INFO] [stderr] Checking actix-web v4.9.0 [INFO] [stderr] Checking actix-ws v0.3.0 [INFO] [stderr] Checking VoxArena v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `put` [INFO] [stdout] --> src/routes/routes.rs:4:28 [INFO] [stdout] | [INFO] [stdout] 4 | use actix_web::{get, post, put, web::{self, Data, Json}, HttpRequest, HttpResponse, Responder}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/socket/ws.rs:34:53 [INFO] [stdout] | [INFO] [stdout] 34 | AggregatedMessage::Text(_) => { () }, [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `put` [INFO] [stdout] --> src/routes/routes.rs:4:28 [INFO] [stdout] | [INFO] [stdout] 4 | use actix_web::{get, post, put, web::{self, Data, Json}, HttpRequest, HttpResponse, Responder}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/socket/ws.rs:34:53 [INFO] [stdout] | [INFO] [stdout] 34 | AggregatedMessage::Text(_) => { () }, [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/routes/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod routes; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/routes/routes.rs:27:16 [INFO] [stdout] | [INFO] [stdout] 27 | if user.0.0.len() > 0 || user.0.1.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!user.0.0.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/routes/routes.rs:27:38 [INFO] [stdout] | [INFO] [stdout] 27 | if user.0.0.len() > 0 || user.0.1.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!user.0.1.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/routes/routes.rs:67:20 [INFO] [stdout] | [INFO] [stdout] 67 | if user_by_email.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `user_by_email.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/routes/routes.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 94 | if user_by_username.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `user_by_username.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/models/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod models; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/routes/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod routes; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/routes/routes.rs:27:16 [INFO] [stdout] | [INFO] [stdout] 27 | if user.0.0.len() > 0 || user.0.1.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!user.0.0.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/routes/routes.rs:27:38 [INFO] [stdout] | [INFO] [stdout] 27 | if user.0.0.len() > 0 || user.0.1.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!user.0.1.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/routes/routes.rs:67:20 [INFO] [stdout] | [INFO] [stdout] 67 | if user_by_email.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `user_by_email.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/routes/routes.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 94 | if user_by_username.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `user_by_username.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/models/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod models; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/socket/ws.rs:48:57 [INFO] [stdout] | [INFO] [stdout] 48 | } else if optional.is_none() && !audio.is_none(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `audio.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be written as a `let` statement [INFO] [stdout] --> src/socket/ws.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | / match msg { [INFO] [stdout] 45 | | Message { optional, audio} => { [INFO] [stdout] 46 | | if optional.is_none() && audio.is_none() { [INFO] [stdout] 47 | | break None [INFO] [stdout] ... | [INFO] [stdout] 56 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using a `let` statement [INFO] [stdout] | [INFO] [stdout] 44 ~ let Message { optional, audio} = msg; [INFO] [stdout] 45 + if optional.is_none() && audio.is_none() { [INFO] [stdout] 46 + break None [INFO] [stdout] 47 + } else if optional.is_none() && !audio.is_none(){ [INFO] [stdout] 48 + session.binary(audio.unwrap()).await.unwrap(); [INFO] [stdout] 49 + } else { [INFO] [stdout] 50 + let (temp_connection_id, temp_room_id) = optional.unwrap(); [INFO] [stdout] 51 + connection_id = Some(temp_connection_id); [INFO] [stdout] 52 + room_id = temp_room_id; [INFO] [stdout] 53 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/socket/manager.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 75 | if self.rooms.len() == 0 || self.rooms[self.rooms.len() - 1_usize].length() == 5 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.rooms.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/socket/manager.rs:90:82 [INFO] [stdout] | [INFO] [stdout] 90 | fn user_disconnect(&mut self, conn_id: ConnectionId, room_id: Option) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/socket/manager.rs:106:21 [INFO] [stdout] | [INFO] [stdout] 106 | None => return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 106 - None => return [INFO] [stdout] 106 + None => () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/socket/manager.rs:96:24 [INFO] [stdout] | [INFO] [stdout] 96 | if (*room).room_id == id { [INFO] [stdout] | ^^^^^^^ help: try: `room` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/socket/manager.rs:112:16 [INFO] [stdout] | [INFO] [stdout] 112 | if (*room).room_id == room_id { [INFO] [stdout] | ^^^^^^^ help: try: `room` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/socket/manager.rs:131:21 [INFO] [stdout] | [INFO] [stdout] 131 | let _ = sender.send(Message { optional: Some(user_data), audio: None }).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 131 - let _ = sender.send(Message { optional: Some(user_data), audio: None }).await.unwrap(); [INFO] [stdout] 131 + sender.send(Message { optional: Some(user_data), audio: None }).await.unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/socket/manager.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 137 | let _ = self.send_message(conn_id, msg, room_id).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 137 - let _ = self.send_message(conn_id, msg, room_id).await.unwrap(); [INFO] [stdout] 137 + self.send_message(conn_id, msg, room_id).await.unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:42:32 [INFO] [stdout] | [INFO] [stdout] 42 | ... if user.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!user.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/socket/ws.rs:48:57 [INFO] [stdout] | [INFO] [stdout] 48 | } else if optional.is_none() && !audio.is_none(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `audio.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be written as a `let` statement [INFO] [stdout] --> src/socket/ws.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | / match msg { [INFO] [stdout] 45 | | Message { optional, audio} => { [INFO] [stdout] 46 | | if optional.is_none() && audio.is_none() { [INFO] [stdout] 47 | | break None [INFO] [stdout] ... | [INFO] [stdout] 56 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using a `let` statement [INFO] [stdout] | [INFO] [stdout] 44 ~ let Message { optional, audio} = msg; [INFO] [stdout] 45 + if optional.is_none() && audio.is_none() { [INFO] [stdout] 46 + break None [INFO] [stdout] 47 + } else if optional.is_none() && !audio.is_none(){ [INFO] [stdout] 48 + session.binary(audio.unwrap()).await.unwrap(); [INFO] [stdout] 49 + } else { [INFO] [stdout] 50 + let (temp_connection_id, temp_room_id) = optional.unwrap(); [INFO] [stdout] 51 + connection_id = Some(temp_connection_id); [INFO] [stdout] 52 + room_id = temp_room_id; [INFO] [stdout] 53 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/socket/manager.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 75 | if self.rooms.len() == 0 || self.rooms[self.rooms.len() - 1_usize].length() == 5 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.rooms.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/socket/manager.rs:90:82 [INFO] [stdout] | [INFO] [stdout] 90 | fn user_disconnect(&mut self, conn_id: ConnectionId, room_id: Option) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/socket/manager.rs:106:21 [INFO] [stdout] | [INFO] [stdout] 106 | None => return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 106 - None => return [INFO] [stdout] 106 + None => () [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/socket/manager.rs:96:24 [INFO] [stdout] | [INFO] [stdout] 96 | if (*room).room_id == id { [INFO] [stdout] | ^^^^^^^ help: try: `room` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/socket/manager.rs:112:16 [INFO] [stdout] | [INFO] [stdout] 112 | if (*room).room_id == room_id { [INFO] [stdout] | ^^^^^^^ help: try: `room` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/socket/manager.rs:131:21 [INFO] [stdout] | [INFO] [stdout] 131 | let _ = sender.send(Message { optional: Some(user_data), audio: None }).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 131 - let _ = sender.send(Message { optional: Some(user_data), audio: None }).await.unwrap(); [INFO] [stdout] 131 + sender.send(Message { optional: Some(user_data), audio: None }).await.unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/socket/manager.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 137 | let _ = self.send_message(conn_id, msg, room_id).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 137 - let _ = self.send_message(conn_id, msg, room_id).await.unwrap(); [INFO] [stdout] 137 + self.send_message(conn_id, msg, room_id).await.unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:42:32 [INFO] [stdout] | [INFO] [stdout] 42 | ... if user.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!user.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 03s [INFO] running `Command { std: "docker" "inspect" "59cbd3e172c38828a34d9a9286998adea9160efd4364a822dc215a7fb05df44b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59cbd3e172c38828a34d9a9286998adea9160efd4364a822dc215a7fb05df44b", kill_on_drop: false }` [INFO] [stdout] 59cbd3e172c38828a34d9a9286998adea9160efd4364a822dc215a7fb05df44b