[INFO] cloning repository https://github.com/Ali-TM-original/RustyBrainF-k [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Ali-TM-original/RustyBrainF-k" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAli-TM-original%2FRustyBrainF-k", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAli-TM-original%2FRustyBrainF-k'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e78b525b7b9bc8d3dd7bb5c757282858d49ee2ff [INFO] linting Ali-TM-original/RustyBrainF-k against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAli-TM-original%2FRustyBrainF-k" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Ali-TM-original/RustyBrainF-k [INFO] finished tweaking git repo https://github.com/Ali-TM-original/RustyBrainF-k [INFO] tweaked toml for git repo https://github.com/Ali-TM-original/RustyBrainF-k written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Ali-TM-original/RustyBrainF-k on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Ali-TM-original/RustyBrainF-k already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 07d17e6bdfba417ff62b842e7ece331494a036641729685826e25cbb69e6b432 [INFO] running `Command { std: "docker" "start" "-a" "07d17e6bdfba417ff62b842e7ece331494a036641729685826e25cbb69e6b432", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "07d17e6bdfba417ff62b842e7ece331494a036641729685826e25cbb69e6b432", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "07d17e6bdfba417ff62b842e7ece331494a036641729685826e25cbb69e6b432", kill_on_drop: false }` [INFO] [stdout] 07d17e6bdfba417ff62b842e7ece331494a036641729685826e25cbb69e6b432 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 75527e7bd84dfa57d88baa4c514e02b761a2b63a72dd9f27e6c13a3cf2c34517 [INFO] running `Command { std: "docker" "start" "-a" "75527e7bd84dfa57d88baa4c514e02b761a2b63a72dd9f27e6c13a3cf2c34517", kill_on_drop: false }` [INFO] [stderr] Checking bfinterpreter v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 21 | if !(self.source.len() > self.pointer){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.source.len() <= self.pointer)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/parse.rs:53:36 [INFO] [stdout] | [INFO] [stdout] 53 | let _bor = (self.pointer.clone()) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.pointer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/parse.rs:64:36 [INFO] [stdout] | [INFO] [stdout] 64 | let _bor = (self.pointer.clone()) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.pointer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parse.rs:101:16 [INFO] [stdout] | [INFO] [stdout] 101 | if char_.to_owned() == '['{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `*char_` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parse.rs:103:22 [INFO] [stdout] | [INFO] [stdout] 103 | }else if char_.to_owned() == ']'{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `*char_` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 21 | if !(self.source.len() > self.pointer){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.source.len() <= self.pointer)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/parse.rs:53:36 [INFO] [stdout] | [INFO] [stdout] 53 | let _bor = (self.pointer.clone()) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.pointer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/parse.rs:64:36 [INFO] [stdout] | [INFO] [stdout] 64 | let _bor = (self.pointer.clone()) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.pointer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parse.rs:101:16 [INFO] [stdout] | [INFO] [stdout] 101 | if char_.to_owned() == '['{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `*char_` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parse.rs:103:22 [INFO] [stdout] | [INFO] [stdout] 103 | }else if char_.to_owned() == ']'{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `*char_` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.20s [INFO] running `Command { std: "docker" "inspect" "75527e7bd84dfa57d88baa4c514e02b761a2b63a72dd9f27e6c13a3cf2c34517", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75527e7bd84dfa57d88baa4c514e02b761a2b63a72dd9f27e6c13a3cf2c34517", kill_on_drop: false }` [INFO] [stdout] 75527e7bd84dfa57d88baa4c514e02b761a2b63a72dd9f27e6c13a3cf2c34517