[INFO] cloning repository https://github.com/AlfonsoJan/SBSGenerator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AlfonsoJan/SBSGenerator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlfonsoJan%2FSBSGenerator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlfonsoJan%2FSBSGenerator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 86f119236e4fb374c3d9bbca9b7f09afeaf605d5 [INFO] linting AlfonsoJan/SBSGenerator against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlfonsoJan%2FSBSGenerator" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/AlfonsoJan/SBSGenerator [INFO] finished tweaking git repo https://github.com/AlfonsoJan/SBSGenerator [INFO] tweaked toml for git repo https://github.com/AlfonsoJan/SBSGenerator written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/AlfonsoJan/SBSGenerator on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/AlfonsoJan/SBSGenerator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pyo3-macros v0.20.2 [INFO] [stderr] Downloaded pyo3-macros-backend v0.20.2 [INFO] [stderr] Downloaded pyo3-ffi v0.20.2 [INFO] [stderr] Downloaded pyo3-build-config v0.20.2 [INFO] [stderr] Downloaded matrixmultiply v0.3.8 [INFO] [stderr] Downloaded numpy v0.20.0 [INFO] [stderr] Downloaded pyo3 v0.20.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cd3142e7aba26aa3c01a223c92d9d76e539248f325e2639d1820a6eb239a9bdb [INFO] running `Command { std: "docker" "start" "-a" "cd3142e7aba26aa3c01a223c92d9d76e539248f325e2639d1820a6eb239a9bdb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd3142e7aba26aa3c01a223c92d9d76e539248f325e2639d1820a6eb239a9bdb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd3142e7aba26aa3c01a223c92d9d76e539248f325e2639d1820a6eb239a9bdb", kill_on_drop: false }` [INFO] [stdout] cd3142e7aba26aa3c01a223c92d9d76e539248f325e2639d1820a6eb239a9bdb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9984bd8c9a9edb34ecddf8280b4e8b842f00cd49c63f15ca5a0ab55652e7e125 [INFO] running `Command { std: "docker" "start" "-a" "9984bd8c9a9edb34ecddf8280b4e8b842f00cd49c63f15ca5a0ab55652e7e125", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.12.13 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking unindent v0.2.3 [INFO] [stderr] Compiling indoc v2.0.4 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Compiling pyo3-build-config v0.20.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling pyo3-ffi v0.20.2 [INFO] [stderr] Compiling pyo3 v0.20.2 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Compiling pyo3-macros-backend v0.20.2 [INFO] [stderr] Compiling pyo3-macros v0.20.2 [INFO] [stderr] Checking numpy v0.20.0 [INFO] [stderr] Checking sbsgenerator v1.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:161:15 [INFO] [stdout] | [INFO] [stdout] 161 | all_data: &mut Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 161 - all_data: &mut Vec>, [INFO] [stdout] 161 + all_data: &mut [Vec], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/lib.rs:197:8 [INFO] [stdout] | [INFO] [stdout] 197 | if processed % n == 0 || processed == total { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `processed.is_multiple_of(n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:213:31 [INFO] [stdout] | [INFO] [stdout] 213 | fn process_vcf_data(all_data: &Vec>) -> HashMap>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 213 - fn process_vcf_data(all_data: &Vec>) -> HashMap>> { [INFO] [stdout] 213 + fn process_vcf_data(all_data: &[Vec]) -> HashMap>> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:285:40 [INFO] [stdout] | [INFO] [stdout] 285 | let translate_complement = !(translated_alternate == alternate_allele); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(translated_alternate != alternate_allele)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/lib.rs:179:27 [INFO] [stdout] | [INFO] [stdout] 179 | all_data[index] = vec![row[0].clone(), new_mutation_type] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[row[0].clone(), new_mutation_type]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/lib.rs:246:23 [INFO] [stdout] | [INFO] [stdout] 246 | let nucleotides = vec!["A", "C", "G", "T"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["A", "C", "G", "T"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:161:15 [INFO] [stdout] | [INFO] [stdout] 161 | all_data: &mut Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 161 - all_data: &mut Vec>, [INFO] [stdout] 161 + all_data: &mut [Vec], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/lib.rs:197:8 [INFO] [stdout] | [INFO] [stdout] 197 | if processed % n == 0 || processed == total { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `processed.is_multiple_of(n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:213:31 [INFO] [stdout] | [INFO] [stdout] 213 | fn process_vcf_data(all_data: &Vec>) -> HashMap>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 213 - fn process_vcf_data(all_data: &Vec>) -> HashMap>> { [INFO] [stdout] 213 + fn process_vcf_data(all_data: &[Vec]) -> HashMap>> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:285:40 [INFO] [stdout] | [INFO] [stdout] 285 | let translate_complement = !(translated_alternate == alternate_allele); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(translated_alternate != alternate_allele)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/lib.rs:179:27 [INFO] [stdout] | [INFO] [stdout] 179 | all_data[index] = vec![row[0].clone(), new_mutation_type] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[row[0].clone(), new_mutation_type]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/lib.rs:246:23 [INFO] [stdout] | [INFO] [stdout] 246 | let nucleotides = vec!["A", "C", "G", "T"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["A", "C", "G", "T"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.07s [INFO] running `Command { std: "docker" "inspect" "9984bd8c9a9edb34ecddf8280b4e8b842f00cd49c63f15ca5a0ab55652e7e125", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9984bd8c9a9edb34ecddf8280b4e8b842f00cd49c63f15ca5a0ab55652e7e125", kill_on_drop: false }` [INFO] [stdout] 9984bd8c9a9edb34ecddf8280b4e8b842f00cd49c63f15ca5a0ab55652e7e125