[INFO] cloning repository https://github.com/AlexandreGerault/svg-text-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AlexandreGerault/svg-text-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlexandreGerault%2Fsvg-text-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlexandreGerault%2Fsvg-text-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e75ceb98309f804727693a16c3ab4c44a2a31ee4 [INFO] linting AlexandreGerault/svg-text-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlexandreGerault%2Fsvg-text-rs" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/AlexandreGerault/svg-text-rs [INFO] finished tweaking git repo https://github.com/AlexandreGerault/svg-text-rs [INFO] tweaked toml for git repo https://github.com/AlexandreGerault/svg-text-rs written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/AlexandreGerault/svg-text-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/AlexandreGerault/svg-text-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded utf8-width v0.1.6 [INFO] [stderr] Downloaded roxmltree v0.13.1 [INFO] [stderr] Downloaded html-escape v0.2.12 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ab3d951fa4fed23637912c351a9e77ffb5c8ef37b216a7bcca9d7e642ddddc89 [INFO] running `Command { std: "docker" "start" "-a" "ab3d951fa4fed23637912c351a9e77ffb5c8ef37b216a7bcca9d7e642ddddc89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ab3d951fa4fed23637912c351a9e77ffb5c8ef37b216a7bcca9d7e642ddddc89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab3d951fa4fed23637912c351a9e77ffb5c8ef37b216a7bcca9d7e642ddddc89", kill_on_drop: false }` [INFO] [stdout] ab3d951fa4fed23637912c351a9e77ffb5c8ef37b216a7bcca9d7e642ddddc89 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2ea453ed00fef50b966d5cd1703bfe814606afc0e0281e98782fd0783c76e48f [INFO] running `Command { std: "docker" "start" "-a" "2ea453ed00fef50b966d5cd1703bfe814606afc0e0281e98782fd0783c76e48f", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking utf8-width v0.1.6 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking xmlparser v0.13.5 [INFO] [stderr] Checking html-escape v0.2.12 [INFO] [stderr] Checking roxmltree v0.13.1 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking regex v1.7.0 [INFO] [stderr] Checking svg-text-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `html_escape::decode_html_entities` [INFO] [stdout] --> src/svg/font.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use html_escape::decode_html_entities; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/svg/font.rs:108:21 [INFO] [stdout] | [INFO] [stdout] 108 | horizontal_advance_x: horizontal_advance_x, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `horizontal_advance_x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `html_escape::decode_html_entities` [INFO] [stdout] --> src/svg/font.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use html_escape::decode_html_entities; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/svg/font.rs:108:21 [INFO] [stdout] | [INFO] [stdout] 108 | horizontal_advance_x: horizontal_advance_x, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `horizontal_advance_x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/svg/font.rs:221:28 [INFO] [stdout] | [INFO] [stdout] 221 | const ARIAL_SVG_FONT: &'static str = include_str!("../../fixtures/arial.svg"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `horizontal_advance_x`, `units_per_em`, `ascent`, and `descent` are never read [INFO] [stdout] --> src/svg/font.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct Font { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 23 | horizontal_advance_x: f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 24 | units_per_em: f64, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 25 | ascent: f64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 26 | descent: f64, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Bounds` [INFO] [stdout] --> src/svg/bounds.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Self { [INFO] [stdout] 12 | | Bounds { [INFO] [stdout] 13 | | x1: 0.0, [INFO] [stdout] 14 | | y1: 0.0, [INFO] [stdout] ... | [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for Bounds { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/svg/font.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 74 | if !n.attribute("unicode").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `n.attribute("unicode").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/svg/font.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 78 | if !n.attribute("d").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `n.attribute("d").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/svg/font.rs:109:27 [INFO] [stdout] | [INFO] [stdout] 109 | path: String::from(path), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/svg/font.rs:177:19 [INFO] [stdout] | [INFO] [stdout] 177 | path: String::from(self.glyphs[0].path.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.glyphs[0].path.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Bounds` [INFO] [stdout] --> src/svg/bounds.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Self { [INFO] [stdout] 12 | | Bounds { [INFO] [stdout] 13 | | x1: 0.0, [INFO] [stdout] 14 | | y1: 0.0, [INFO] [stdout] ... | [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for Bounds { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/svg/font.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 74 | if !n.attribute("unicode").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `n.attribute("unicode").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/svg/font.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 78 | if !n.attribute("d").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `n.attribute("d").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/svg/font.rs:109:27 [INFO] [stdout] | [INFO] [stdout] 109 | path: String::from(path), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/svg/font.rs:177:19 [INFO] [stdout] | [INFO] [stdout] 177 | path: String::from(self.glyphs[0].path.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.glyphs[0].path.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/svg/path.rs:172:16 [INFO] [stdout] | [INFO] [stdout] 172 | if let Err(_) = path { [INFO] [stdout] | -------^^^^^^------- help: try: `if path.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.86s [INFO] running `Command { std: "docker" "inspect" "2ea453ed00fef50b966d5cd1703bfe814606afc0e0281e98782fd0783c76e48f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ea453ed00fef50b966d5cd1703bfe814606afc0e0281e98782fd0783c76e48f", kill_on_drop: false }` [INFO] [stdout] 2ea453ed00fef50b966d5cd1703bfe814606afc0e0281e98782fd0783c76e48f