[INFO] cloning repository https://github.com/AlessandroBregoli/rgclass [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AlessandroBregoli/rgclass" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlessandroBregoli%2Frgclass", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlessandroBregoli%2Frgclass'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2945ba42d809e552bc5330e269f76bea3b582f68 [INFO] linting AlessandroBregoli/rgclass against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlessandroBregoli%2Frgclass" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/AlessandroBregoli/rgclass [INFO] finished tweaking git repo https://github.com/AlessandroBregoli/rgclass [INFO] tweaked toml for git repo https://github.com/AlessandroBregoli/rgclass written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/AlessandroBregoli/rgclass on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/AlessandroBregoli/rgclass already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dirs-sys v0.3.6 [INFO] [stderr] Downloaded ndarray-rand v0.14.0 [INFO] [stderr] Downloaded lax v0.2.0 [INFO] [stderr] Downloaded linfa-trees v0.5.0 [INFO] [stderr] Downloaded redox_syscall v0.2.10 [INFO] [stderr] Downloaded rand_distr v0.4.2 [INFO] [stderr] Downloaded rayon-core v1.9.1 [INFO] [stderr] Downloaded libm v0.2.1 [INFO] [stderr] Downloaded crossbeam-channel v0.5.1 [INFO] [stderr] Downloaded syn v1.0.80 [INFO] [stderr] Downloaded rayon v1.5.1 [INFO] [stderr] Downloaded linfa v0.5.0 [INFO] [stderr] Downloaded serde_json v1.0.68 [INFO] [stderr] Downloaded rand v0.8.4 [INFO] [stderr] Downloaded ndarray-linalg v0.14.1 [INFO] [stderr] Downloaded matrixmultiply v0.3.1 [INFO] [stderr] Downloaded regex v1.5.4 [INFO] [stderr] Downloaded ndarray v0.15.3 [INFO] [stderr] Downloaded crossbeam-epoch v0.9.5 [INFO] [stderr] Downloaded crossbeam-utils v0.8.5 [INFO] [stderr] Downloaded proc-macro2 v1.0.30 [INFO] [stderr] Downloaded bstr v0.2.17 [INFO] [stderr] Downloaded quote v1.0.10 [INFO] [stderr] Downloaded lapack-sys v0.12.1 [INFO] [stderr] Downloaded lapack v0.18.0 [INFO] [stderr] Downloaded crossbeam-deque v0.8.1 [INFO] [stderr] Downloaded num-complex v0.4.0 [INFO] [stderr] Downloaded ppv-lite86 v0.2.15 [INFO] [stderr] Downloaded getrandom v0.2.3 [INFO] [stderr] Downloaded memoffset v0.6.4 [INFO] [stderr] Downloaded serde_derive v1.0.130 [INFO] [stderr] Downloaded serde v1.0.130 [INFO] [stderr] Downloaded dirs v3.0.2 [INFO] [stderr] Downloaded openblas-build v0.1.1 [INFO] [stderr] Downloaded libc v0.2.105 [INFO] [stderr] Downloaded rand_hc v0.3.1 [INFO] [stderr] Downloaded openblas-src v0.10.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 955d40ccadabd12e36c430d3c68dab26760da6ec173ae1a0887b819d59dbed90 [INFO] running `Command { std: "docker" "start" "-a" "955d40ccadabd12e36c430d3c68dab26760da6ec173ae1a0887b819d59dbed90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "955d40ccadabd12e36c430d3c68dab26760da6ec173ae1a0887b819d59dbed90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "955d40ccadabd12e36c430d3c68dab26760da6ec173ae1a0887b819d59dbed90", kill_on_drop: false }` [INFO] [stdout] 955d40ccadabd12e36c430d3c68dab26760da6ec173ae1a0887b819d59dbed90 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c2e336c26fc952159b1852b7a860207d1010e4a1af037cc0610de5d809695b7f [INFO] running `Command { std: "docker" "start" "-a" "c2e336c26fc952159b1852b7a860207d1010e4a1af037cc0610de5d809695b7f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.105 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.30 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.80 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling libm v0.2.1 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling walkdir v2.3.2 [INFO] [stderr] Checking matrixmultiply v0.3.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling linfa v0.5.0 [INFO] [stderr] Compiling serde_json v1.0.68 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Compiling dirs-sys v0.3.6 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Compiling dirs v3.0.2 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking cblas-sys v0.1.4 [INFO] [stderr] Checking lapack-sys v0.12.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking rand_distr v0.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling thiserror v1.0.30 [INFO] [stderr] Compiling openblas-build v0.1.1 [INFO] [stderr] Compiling openblas-src v0.10.4 [INFO] [stderr] Checking num-complex v0.4.0 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking ndarray v0.15.3 [INFO] [stderr] Checking cauchy v0.4.0 [INFO] [stderr] Checking lapack v0.18.0 [INFO] [stderr] Checking ndarray-rand v0.14.0 [INFO] [stderr] Checking linfa-trees v0.5.0 [INFO] [stderr] Checking lax v0.2.0 [INFO] [stderr] Checking ndarray-linalg v0.14.1 [INFO] [stderr] Checking rgclass v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use std; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use linfa; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use linfa_trees; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json` [INFO] [stdout] --> src/lib.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use std; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use linfa; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use linfa_trees; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json` [INFO] [stdout] --> src/lib.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:27:26 [INFO] [stdout] | [INFO] [stdout] 27 | let e: Array1 = e.iter().filter(|&x| *x > 0.0).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `e.iter().filter(|&x| *x > 0.0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:33:47 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn adj_matrices_to_features(adj_matrices: &Vec>, features: usize) -> Array2{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 33 - pub fn adj_matrices_to_features(adj_matrices: &Vec>, features: usize) -> Array2{ [INFO] [stdout] 33 + pub fn adj_matrices_to_features(adj_matrices: &[Array2], features: usize) -> Array2{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/lib.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | return (dataset.iter().map(|(_,v)| v.clone()).collect(), Some(graph_class)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dataset.values().map(|v| v.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/lib.rs:114:6 [INFO] [stdout] | [INFO] [stdout] 114 | (dataset.iter().map(|(_,v)| v.clone()).collect(), None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dataset.values().map(|v| v.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/lib.rs:120:31 [INFO] [stdout] | [INFO] [stdout] 120 | dataset.cross_validate(k, &vec![model], |prediction, truth| Ok(prediction.confusion_matrix(truth).unwrap().accuracy())).unwrap(... [INFO] [stdout] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[model]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `adj_matrix_to_Laplacian` should have a snake case name [INFO] [stdout] --> src/lib.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn adj_matrix_to_Laplacian(adj_matrix: &Array2) -> Array2 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `adj_matrix_to_laplacian` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `D_1_2` should have a snake case name [INFO] [stdout] --> src/lib.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | let D_1_2 = Array::eye( d_1_2.len()) * &d_1_2; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `d_1_2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/lib.rs:27:26 [INFO] [stdout] | [INFO] [stdout] 27 | let e: Array1 = e.iter().filter(|&x| *x > 0.0).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `e.iter().filter(|&x| *x > 0.0).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:33:47 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn adj_matrices_to_features(adj_matrices: &Vec>, features: usize) -> Array2{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 33 - pub fn adj_matrices_to_features(adj_matrices: &Vec>, features: usize) -> Array2{ [INFO] [stdout] 33 + pub fn adj_matrices_to_features(adj_matrices: &[Array2], features: usize) -> Array2{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/lib.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | return (dataset.iter().map(|(_,v)| v.clone()).collect(), Some(graph_class)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dataset.values().map(|v| v.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/lib.rs:114:6 [INFO] [stdout] | [INFO] [stdout] 114 | (dataset.iter().map(|(_,v)| v.clone()).collect(), None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dataset.values().map(|v| v.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/lib.rs:120:31 [INFO] [stdout] | [INFO] [stdout] 120 | dataset.cross_validate(k, &vec![model], |prediction, truth| Ok(prediction.confusion_matrix(truth).unwrap().accuracy())).unwrap(... [INFO] [stdout] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[model]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `adj_matrix_to_Laplacian` should have a snake case name [INFO] [stdout] --> src/lib.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn adj_matrix_to_Laplacian(adj_matrix: &Array2) -> Array2 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `adj_matrix_to_laplacian` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `D_1_2` should have a snake case name [INFO] [stdout] --> src/lib.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | let D_1_2 = Array::eye( d_1_2.len()) * &d_1_2; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `d_1_2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_adj_matrix_to_Laplacian` should have a snake case name [INFO] [stdout] --> src/lib.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 129 | fn test_adj_matrix_to_Laplacian(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `test_adj_matrix_to_laplacian` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/lib.rs:241:13 [INFO] [stdout] | [INFO] [stdout] 241 | let X = adj_matrices_to_features(&adj_matrices, 4); [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use linfa_trees; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use linfa; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use log; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use linfa_trees; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use linfa; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use log; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:95:25 [INFO] [stdout] | [INFO] [stdout] 95 | let max_depth = match cross_validate.value_of("max_depth") { [INFO] [stdout] | _________________________^ [INFO] [stdout] 96 | | Some(x) => Some(x.parse::().unwrap()), [INFO] [stdout] 97 | | None => None [INFO] [stdout] 98 | | }; [INFO] [stdout] | |_________^ help: try: `cross_validate.value_of("max_depth").map(|x| x.parse::().unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:100:32 [INFO] [stdout] | [INFO] [stdout] 100 | let min_weight_split = match cross_validate.value_of("min_weight_split") { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 101 | | Some(x) => Some(x.parse::().unwrap()), [INFO] [stdout] 102 | | None => None [INFO] [stdout] 103 | | }; [INFO] [stdout] | |_________^ help: try: `cross_validate.value_of("min_weight_split").map(|x| x.parse::().unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:105:31 [INFO] [stdout] | [INFO] [stdout] 105 | let min_weight_leaf = match cross_validate.value_of("min_weight_leaf") { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 106 | | Some(x) => Some(x.parse::().unwrap()), [INFO] [stdout] 107 | | None => None [INFO] [stdout] 108 | | }; [INFO] [stdout] | |_________^ help: try: `cross_validate.value_of("min_weight_leaf").map(|x| x.parse::().unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/main.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | let X = adj_matrices_to_features(&adj_matricres, n_features); [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:95:25 [INFO] [stdout] | [INFO] [stdout] 95 | let max_depth = match cross_validate.value_of("max_depth") { [INFO] [stdout] | _________________________^ [INFO] [stdout] 96 | | Some(x) => Some(x.parse::().unwrap()), [INFO] [stdout] 97 | | None => None [INFO] [stdout] 98 | | }; [INFO] [stdout] | |_________^ help: try: `cross_validate.value_of("max_depth").map(|x| x.parse::().unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:100:32 [INFO] [stdout] | [INFO] [stdout] 100 | let min_weight_split = match cross_validate.value_of("min_weight_split") { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 101 | | Some(x) => Some(x.parse::().unwrap()), [INFO] [stdout] 102 | | None => None [INFO] [stdout] 103 | | }; [INFO] [stdout] | |_________^ help: try: `cross_validate.value_of("min_weight_split").map(|x| x.parse::().unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:105:31 [INFO] [stdout] | [INFO] [stdout] 105 | let min_weight_leaf = match cross_validate.value_of("min_weight_leaf") { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 106 | | Some(x) => Some(x.parse::().unwrap()), [INFO] [stdout] 107 | | None => None [INFO] [stdout] 108 | | }; [INFO] [stdout] | |_________^ help: try: `cross_validate.value_of("min_weight_leaf").map(|x| x.parse::().unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/main.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | let X = adj_matrices_to_features(&adj_matricres, n_features); [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5m 27s [INFO] running `Command { std: "docker" "inspect" "c2e336c26fc952159b1852b7a860207d1010e4a1af037cc0610de5d809695b7f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2e336c26fc952159b1852b7a860207d1010e4a1af037cc0610de5d809695b7f", kill_on_drop: false }` [INFO] [stdout] c2e336c26fc952159b1852b7a860207d1010e4a1af037cc0610de5d809695b7f