[INFO] cloning repository https://github.com/AlephTX/aleph-tx [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AlephTX/aleph-tx" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlephTX%2Faleph-tx", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlephTX%2Faleph-tx'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3bb21c3e111021a32890b5a69f6726c1011d9f3f [INFO] linting AlephTX/aleph-tx against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlephTX%2Faleph-tx" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/AlephTX/aleph-tx [INFO] finished tweaking git repo https://github.com/AlephTX/aleph-tx [INFO] tweaked toml for git repo https://github.com/AlephTX/aleph-tx written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/AlephTX/aleph-tx on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/AlephTX/aleph-tx already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded starknet-crypto v0.8.1 [INFO] [stderr] Downloaded starknet-curve v0.6.0 [INFO] [stderr] Downloaded core_affinity v0.8.3 [INFO] [stderr] Downloaded toml_parser v1.0.8+spec-1.1.0 [INFO] [stderr] Downloaded rkyv_derive v0.7.46 [INFO] [stderr] Downloaded native-tls v0.2.15 [INFO] [stderr] Downloaded starknet-types-core v0.2.4 [INFO] [stderr] Downloaded lambdaworks-crypto v0.13.0 [INFO] [stderr] Downloaded rkyv v0.7.46 [INFO] [stderr] Downloaded lambdaworks-math v0.13.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] af1b6401daae110c2f6e633b4248d6498d2ee3c95febe84601aaf6983a4c51a1 [INFO] running `Command { std: "docker" "start" "-a" "af1b6401daae110c2f6e633b4248d6498d2ee3c95febe84601aaf6983a4c51a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "af1b6401daae110c2f6e633b4248d6498d2ee3c95febe84601aaf6983a4c51a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af1b6401daae110c2f6e633b4248d6498d2ee3c95febe84601aaf6983a4c51a1", kill_on_drop: false }` [INFO] [stdout] af1b6401daae110c2f6e633b4248d6498d2ee3c95febe84601aaf6983a4c51a1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5102bc09a3aa08992e3037ba8fc48910f973ece0204655bc06c45c81bb121374 [INFO] running `Command { std: "docker" "start" "-a" "5102bc09a3aa08992e3037ba8fc48910f973ece0204655bc06c45c81bb121374", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.23 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking keccak v0.1.6 [INFO] [stderr] Compiling native-tls v0.2.15 [INFO] [stderr] Compiling unicase v2.9.0 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling getrandom v0.4.1 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking rand_core v0.10.0 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling anyhow v1.0.101 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling rust_decimal v1.40.0 [INFO] [stderr] Checking cpufeatures v0.3.0 [INFO] [stderr] Checking chacha20 v0.10.0 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ff v0.13.1 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Compiling aleph-tx v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking flume v0.11.1 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking core_affinity v0.8.3 [INFO] [stderr] Checking rand v0.10.0 [INFO] [stderr] Checking memmap2 v0.9.10 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking lambdaworks-math v0.13.0 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Compiling syn v2.0.115 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking k256 v0.13.4 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking lambdaworks-crypto v0.13.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking starknet-types-core v0.2.4 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking starknet-curve v0.6.0 [INFO] [stderr] Checking starknet-crypto v0.8.1 [INFO] [stderr] Checking openssl v0.10.75 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/order_tracker.rs:553:21 [INFO] [stdout] | [INFO] [stdout] 553 | / if order.created_at.elapsed() >= PENDING_CREATE_RECONCILE_GRACE { [INFO] [stdout] 554 | | stale_ids.push((*coi, OrderLifecycle::Rejected)); [INFO] [stdout] 555 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 552 ~ (OrderLifecycle::PendingCreate, None) [INFO] [stdout] 553 ~ if order.created_at.elapsed() >= PENDING_CREATE_RECONCILE_GRACE => { [INFO] [stdout] 554 | stale_ids.push((*coi, OrderLifecycle::Rejected)); [INFO] [stdout] 555 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/order_tracker.rs:558:21 [INFO] [stdout] | [INFO] [stdout] 558 | / if order.last_update.elapsed() >= PENDING_CANCEL_RECONCILE_GRACE { [INFO] [stdout] 559 | | order.lifecycle = if order.filled_size > 1e-12 { [INFO] [stdout] 560 | | OrderLifecycle::PartiallyFilled [INFO] [stdout] 561 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 564 | | order.last_update = now; [INFO] [stdout] 565 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 557 ~ (OrderLifecycle::PendingCancel, Some(_)) [INFO] [stdout] 558 ~ if order.last_update.elapsed() >= PENDING_CANCEL_RECONCILE_GRACE => { [INFO] [stdout] 559 | order.lifecycle = if order.filled_size > 1e-12 { [INFO] [stdout] ... [INFO] [stdout] 564 | order.last_update = now; [INFO] [stdout] 565 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/order_tracker.rs:553:21 [INFO] [stdout] | [INFO] [stdout] 553 | / if order.created_at.elapsed() >= PENDING_CREATE_RECONCILE_GRACE { [INFO] [stdout] 554 | | stale_ids.push((*coi, OrderLifecycle::Rejected)); [INFO] [stdout] 555 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 552 ~ (OrderLifecycle::PendingCreate, None) [INFO] [stdout] 553 ~ if order.created_at.elapsed() >= PENDING_CREATE_RECONCILE_GRACE => { [INFO] [stdout] 554 | stale_ids.push((*coi, OrderLifecycle::Rejected)); [INFO] [stdout] 555 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/order_tracker.rs:558:21 [INFO] [stdout] | [INFO] [stdout] 558 | / if order.last_update.elapsed() >= PENDING_CANCEL_RECONCILE_GRACE { [INFO] [stdout] 559 | | order.lifecycle = if order.filled_size > 1e-12 { [INFO] [stdout] 560 | | OrderLifecycle::PartiallyFilled [INFO] [stdout] 561 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 564 | | order.last_update = now; [INFO] [stdout] 565 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 557 ~ (OrderLifecycle::PendingCancel, Some(_)) [INFO] [stdout] 558 ~ if order.last_update.elapsed() >= PENDING_CANCEL_RECONCILE_GRACE => { [INFO] [stdout] 559 | order.lifecycle = if order.filled_size > 1e-12 { [INFO] [stdout] ... [INFO] [stdout] 564 | order.last_update = now; [INFO] [stdout] 565 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/strategy/inventory_neutral_mm/components.rs:504:1 [INFO] [stdout] | [INFO] [stdout] 504 | / pub(super) fn decide_quote_cycle( [INFO] [stdout] 505 | | config: &InventoryNeutralMMConfig, [INFO] [stdout] 506 | | target: QuoteTarget, [INFO] [stdout] 507 | | mid: f64, [INFO] [stdout] ... | [INFO] [stdout] 512 | | inventory_urgency_threshold: f64, [INFO] [stdout] 513 | | ) -> QuoteCycleDecision { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/strategy/inventory_neutral_mm/execution.rs:59:1 [INFO] [stdout] | [INFO] [stdout] 59 | / pub(super) fn build_side_execution_plan( [INFO] [stdout] 60 | | config: &InventoryNeutralMMConfig, [INFO] [stdout] 61 | | active_orders: &[ActiveOrder], [INFO] [stdout] 62 | | order_type: OrderType, [INFO] [stdout] ... | [INFO] [stdout] 68 | | max_replacements_per_cycle: usize, [INFO] [stdout] 69 | | ) -> SideExecutionPlan { [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/strategy/inventory_neutral_mm/execution.rs:214:5 [INFO] [stdout] | [INFO] [stdout] 214 | / (bid_has_cancel && !bid_has_place && !ask_has_cancel && !ask_has_place) [INFO] [stdout] 215 | | || (ask_has_cancel && !ask_has_place && !bid_has_cancel && !bid_has_place) [INFO] [stdout] | |__________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 214 - (bid_has_cancel && !bid_has_place && !ask_has_cancel && !ask_has_place) [INFO] [stdout] 215 - || (ask_has_cancel && !ask_has_place && !bid_has_cancel && !bid_has_place) [INFO] [stdout] 214 + !(bid_has_place || ask_has_place || bid_has_cancel && ask_has_cancel || !bid_has_cancel && !ask_has_cancel) [INFO] [stdout] | [INFO] [stdout] 214 - (bid_has_cancel && !bid_has_place && !ask_has_cancel && !ask_has_place) [INFO] [stdout] 215 - || (ask_has_cancel && !ask_has_place && !bid_has_cancel && !bid_has_place) [INFO] [stdout] 214 + (ask_has_cancel || bid_has_cancel) && (!ask_has_cancel || !bid_has_cancel) && !ask_has_place && !bid_has_place [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/strategy/inventory_neutral_mm/housekeeping.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | / pub(super) fn sync_telemetry_snapshot( [INFO] [stdout] 12 | | telemetry: &mut TelemetryCollector, [INFO] [stdout] 13 | | account_stats: &AccountStats, [INFO] [stdout] 14 | | risk: &RiskSnapshot, [INFO] [stdout] ... | [INFO] [stdout] 19 | | tracker_effective_position: f64, [INFO] [stdout] 20 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/strategy/inventory_neutral_mm/pricing.rs:60:1 [INFO] [stdout] | [INFO] [stdout] 60 | / pub(super) fn anchor_quotes_to_touch( [INFO] [stdout] 61 | | raw_bid: f64, [INFO] [stdout] 62 | | raw_ask: f64, [INFO] [stdout] 63 | | bid_touch: f64, [INFO] [stdout] ... | [INFO] [stdout] 68 | | max_touch_offset_bps: f64, [INFO] [stdout] 69 | | ) -> (f64, f64) { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/strategy/inventory_neutral_mm.rs:795:13 [INFO] [stdout] | [INFO] [stdout] 795 | / if let Some(market_state) = self.fetch_market_state().await { [INFO] [stdout] 796 | | if let Some(mid) = cleanup_reference_mid( [INFO] [stdout] 797 | | &market_state.bbo, [INFO] [stdout] 798 | | self.config.tick_size, [INFO] [stdout] ... | [INFO] [stdout] 803 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 795 ~ if let Some(market_state) = self.fetch_market_state().await [INFO] [stdout] 796 ~ && let Some(mid) = cleanup_reference_mid( [INFO] [stdout] 797 | &market_state.bbo, [INFO] [stdout] ... [INFO] [stdout] 801 | return Some(mid); [INFO] [stdout] 802 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/strategy/inventory_neutral_mm/components.rs:504:1 [INFO] [stdout] | [INFO] [stdout] 504 | / pub(super) fn decide_quote_cycle( [INFO] [stdout] 505 | | config: &InventoryNeutralMMConfig, [INFO] [stdout] 506 | | target: QuoteTarget, [INFO] [stdout] 507 | | mid: f64, [INFO] [stdout] ... | [INFO] [stdout] 512 | | inventory_urgency_threshold: f64, [INFO] [stdout] 513 | | ) -> QuoteCycleDecision { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/strategy/inventory_neutral_mm/execution.rs:59:1 [INFO] [stdout] | [INFO] [stdout] 59 | / pub(super) fn build_side_execution_plan( [INFO] [stdout] 60 | | config: &InventoryNeutralMMConfig, [INFO] [stdout] 61 | | active_orders: &[ActiveOrder], [INFO] [stdout] 62 | | order_type: OrderType, [INFO] [stdout] ... | [INFO] [stdout] 68 | | max_replacements_per_cycle: usize, [INFO] [stdout] 69 | | ) -> SideExecutionPlan { [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/strategy/inventory_neutral_mm/execution.rs:214:5 [INFO] [stdout] | [INFO] [stdout] 214 | / (bid_has_cancel && !bid_has_place && !ask_has_cancel && !ask_has_place) [INFO] [stdout] 215 | | || (ask_has_cancel && !ask_has_place && !bid_has_cancel && !bid_has_place) [INFO] [stdout] | |__________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 214 - (bid_has_cancel && !bid_has_place && !ask_has_cancel && !ask_has_place) [INFO] [stdout] 215 - || (ask_has_cancel && !ask_has_place && !bid_has_cancel && !bid_has_place) [INFO] [stdout] 214 + !(bid_has_place || ask_has_place || bid_has_cancel && ask_has_cancel || !bid_has_cancel && !ask_has_cancel) [INFO] [stdout] | [INFO] [stdout] 214 - (bid_has_cancel && !bid_has_place && !ask_has_cancel && !ask_has_place) [INFO] [stdout] 215 - || (ask_has_cancel && !ask_has_place && !bid_has_cancel && !bid_has_place) [INFO] [stdout] 214 + (ask_has_cancel || bid_has_cancel) && (!ask_has_cancel || !bid_has_cancel) && !ask_has_place && !bid_has_place [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/strategy/inventory_neutral_mm/execution.rs:326:17 [INFO] [stdout] | [INFO] [stdout] 326 | assert!(plan.to_place.len() >= 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!plan.to_place.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/strategy/inventory_neutral_mm/housekeeping.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | / pub(super) fn sync_telemetry_snapshot( [INFO] [stdout] 12 | | telemetry: &mut TelemetryCollector, [INFO] [stdout] 13 | | account_stats: &AccountStats, [INFO] [stdout] 14 | | risk: &RiskSnapshot, [INFO] [stdout] ... | [INFO] [stdout] 19 | | tracker_effective_position: f64, [INFO] [stdout] 20 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/strategy/inventory_neutral_mm/pricing.rs:60:1 [INFO] [stdout] | [INFO] [stdout] 60 | / pub(super) fn anchor_quotes_to_touch( [INFO] [stdout] 61 | | raw_bid: f64, [INFO] [stdout] 62 | | raw_ask: f64, [INFO] [stdout] 63 | | bid_touch: f64, [INFO] [stdout] ... | [INFO] [stdout] 68 | | max_touch_offset_bps: f64, [INFO] [stdout] 69 | | ) -> (f64, f64) { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/strategy/inventory_neutral_mm.rs:795:13 [INFO] [stdout] | [INFO] [stdout] 795 | / if let Some(market_state) = self.fetch_market_state().await { [INFO] [stdout] 796 | | if let Some(mid) = cleanup_reference_mid( [INFO] [stdout] 797 | | &market_state.bbo, [INFO] [stdout] 798 | | self.config.tick_size, [INFO] [stdout] ... | [INFO] [stdout] 803 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 795 ~ if let Some(market_state) = self.fetch_market_state().await [INFO] [stdout] 796 ~ && let Some(mid) = cleanup_reference_mid( [INFO] [stdout] 797 | &market_state.bbo, [INFO] [stdout] ... [INFO] [stdout] 801 | return Some(mid); [INFO] [stdout] 802 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 50.08s [INFO] running `Command { std: "docker" "inspect" "5102bc09a3aa08992e3037ba8fc48910f973ece0204655bc06c45c81bb121374", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5102bc09a3aa08992e3037ba8fc48910f973ece0204655bc06c45c81bb121374", kill_on_drop: false }` [INFO] [stdout] 5102bc09a3aa08992e3037ba8fc48910f973ece0204655bc06c45c81bb121374