[INFO] cloning repository https://github.com/Alef-Keuffer/rust-state-machine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Alef-Keuffer/rust-state-machine" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlef-Keuffer%2Frust-state-machine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlef-Keuffer%2Frust-state-machine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 363bff64a407bf33a024dcb5458aaafad777006a [INFO] linting Alef-Keuffer/rust-state-machine against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlef-Keuffer%2Frust-state-machine" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-0-tc1/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/Alef-Keuffer/rust-state-machine [INFO] finished tweaking git repo https://github.com/Alef-Keuffer/rust-state-machine [INFO] tweaked toml for git repo https://github.com/Alef-Keuffer/rust-state-machine written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Alef-Keuffer/rust-state-machine on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Alef-Keuffer/rust-state-machine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 34f7cd96a5e256a539df44a1539b66e18d613d7b490d43ad84051940ba992cc9 [INFO] running `Command { std: "docker" "start" "-a" "34f7cd96a5e256a539df44a1539b66e18d613d7b490d43ad84051940ba992cc9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "34f7cd96a5e256a539df44a1539b66e18d613d7b490d43ad84051940ba992cc9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34f7cd96a5e256a539df44a1539b66e18d613d7b490d43ad84051940ba992cc9", kill_on_drop: false }` [INFO] [stdout] 34f7cd96a5e256a539df44a1539b66e18d613d7b490d43ad84051940ba992cc9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ffe24581474d5e76575a0d846f413a3a570c575970977613260e9b06e351c408 [INFO] running `Command { std: "docker" "start" "-a" "ffe24581474d5e76575a0d846f413a3a570c575970977613260e9b06e351c408", kill_on_drop: false }` [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking rust-state-machine v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/balances.rs:47:43 [INFO] [stdout] | [INFO] [stdout] 47 | let caller_balance = self.balance(&caller); [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/balances.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | let to_balance = self.balance(&to); [INFO] [stdout] | ^^^ help: change this to: `to` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/balances.rs:47:43 [INFO] [stdout] | [INFO] [stdout] 47 | let caller_balance = self.balance(&caller); [INFO] [stdout] | ^^^^^^^ help: change this to: `caller` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/balances.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | let to_balance = self.balance(&to); [INFO] [stdout] | ^^^ help: change this to: `to` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/balances.rs:114:17 [INFO] [stdout] | [INFO] [stdout] 114 | assert!(!t3.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `t3.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/balances.rs:98:32 [INFO] [stdout] | [INFO] [stdout] 98 | let bob_init_balance = std::u128::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 98 - let bob_init_balance = std::u128::MAX; [INFO] [stdout] 98 + let bob_init_balance = u128::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.37s [INFO] running `Command { std: "docker" "inspect" "ffe24581474d5e76575a0d846f413a3a570c575970977613260e9b06e351c408", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ffe24581474d5e76575a0d846f413a3a570c575970977613260e9b06e351c408", kill_on_drop: false }` [INFO] [stdout] ffe24581474d5e76575a0d846f413a3a570c575970977613260e9b06e351c408