[INFO] cloning repository https://github.com/Akshat-Somvanshi/rustdb [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Akshat-Somvanshi/rustdb" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAkshat-Somvanshi%2Frustdb", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAkshat-Somvanshi%2Frustdb'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 35a11d911da6d35f2f7a0aefc44cf92be141312b [INFO] linting Akshat-Somvanshi/rustdb against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAkshat-Somvanshi%2Frustdb" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Akshat-Somvanshi/rustdb [INFO] finished tweaking git repo https://github.com/Akshat-Somvanshi/rustdb [INFO] tweaked toml for git repo https://github.com/Akshat-Somvanshi/rustdb written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Akshat-Somvanshi/rustdb on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Akshat-Somvanshi/rustdb already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d391e7846dc2defca91611dc4d8f655c1a1ca3c475efa4943bdd4612baeaa8ce [INFO] running `Command { std: "docker" "start" "-a" "d391e7846dc2defca91611dc4d8f655c1a1ca3c475efa4943bdd4612baeaa8ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d391e7846dc2defca91611dc4d8f655c1a1ca3c475efa4943bdd4612baeaa8ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d391e7846dc2defca91611dc4d8f655c1a1ca3c475efa4943bdd4612baeaa8ce", kill_on_drop: false }` [INFO] [stdout] d391e7846dc2defca91611dc4d8f655c1a1ca3c475efa4943bdd4612baeaa8ce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a3a7ee9a687947ec9cacc99f6959d9a7e42b4140862b7a0aaf8fa61443e60983 [INFO] running `Command { std: "docker" "start" "-a" "a3a7ee9a687947ec9cacc99f6959d9a7e42b4140862b7a0aaf8fa61443e60983", kill_on_drop: false }` [INFO] [stderr] Checking rustdb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::clone` [INFO] [stdout] --> src/B_tree.rs:633:9 [INFO] [stdout] | [INFO] [stdout] 633 | use std::clone; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `end` is never read [INFO] [stdout] --> src/B_tree.rs:221:26 [INFO] [stdout] | [INFO] [stdout] 221 | let mut end: usize = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BNode` [INFO] [stdout] --> src/B_tree.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn new() -> BNode { [INFO] [stdout] 22 | | let bnode = BNode { [INFO] [stdout] 23 | | data: vec![0; BTREE_PAGE_SIZE], [INFO] [stdout] 24 | | }; [INFO] [stdout] 25 | | return bnode; [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for BNode { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return bnode; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return bnode; [INFO] [stdout] 25 + bnode [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return u16::from_ne_bytes(self.data[..2].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return u16::from_ne_bytes(self.data[..2].try_into().unwrap()); [INFO] [stdout] 28 + u16::from_ne_bytes(self.data[..2].try_into().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return u16::from_ne_bytes(self.data[2..4].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return u16::from_ne_bytes(self.data[2..4].try_into().unwrap()); [INFO] [stdout] 31 + u16::from_ne_bytes(self.data[2..4].try_into().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return u64::from_ne_bytes(self.data[position..position + 8].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return u64::from_ne_bytes(self.data[position..position + 8].try_into().unwrap()); [INFO] [stdout] 40 + u64::from_ne_bytes(self.data[position..position + 8].try_into().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | return HEADER + 8 * self.nkeys() + 2 * (index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return HEADER + 8 * self.nkeys() + 2 * (index); [INFO] [stdout] 51 + HEADER + 8 * self.nkeys() + 2 * (index) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | return HEADER + 8 * self.nkeys(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return HEADER + 8 * self.nkeys(); [INFO] [stdout] 53 + HEADER + 8 * self.nkeys() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / return u16::from_ne_bytes( [INFO] [stdout] 60 | | self.data[offset_position..offset_position + 2] [INFO] [stdout] 61 | | .try_into() [INFO] [stdout] 62 | | .unwrap(), [INFO] [stdout] 63 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 ~ u16::from_ne_bytes( [INFO] [stdout] 60 + self.data[offset_position..offset_position + 2] [INFO] [stdout] 61 + .try_into() [INFO] [stdout] 62 + .unwrap(), [INFO] [stdout] 63 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return HEADER + self.nkeys() * 2 + self.nkeys() * 8 + self.get_offset(index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return HEADER + self.nkeys() * 2 + self.nkeys() * 8 + self.get_offset(index); [INFO] [stdout] 78 + HEADER + self.nkeys() * 2 + self.nkeys() * 8 + self.get_offset(index) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return self.data[key_pos + 4..key_pos + 4 + klen].to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return self.data[key_pos + 4..key_pos + 4 + klen].to_vec(); [INFO] [stdout] 86 + self.data[key_pos + 4..key_pos + 4 + klen].to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | return self.data[key_pos + 4 + klen..key_pos + 4 + klen + vlen].to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return self.data[key_pos + 4 + klen..key_pos + 4 + klen + vlen].to_vec(); [INFO] [stdout] 94 + self.data[key_pos + 4 + klen..key_pos + 4 + klen + vlen].to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | return last_index_containing_value as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return last_index_containing_value as u16; [INFO] [stdout] 101 + last_index_containing_value as u16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | return found; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return found; [INFO] [stdout] 123 + found [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/B_tree.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `end` is never read [INFO] [stdout] --> src/B_tree.rs:221:26 [INFO] [stdout] | [INFO] [stdout] 221 | let mut end: usize = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:264:5 [INFO] [stdout] | [INFO] [stdout] 264 | return pointer as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 264 - return pointer as u64; [INFO] [stdout] 264 + pointer as u64 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 272 | return BNode { data: result }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 272 - return BNode { data: result }; [INFO] [stdout] 272 + BNode { data: result } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BTree` [INFO] [stdout] --> src/B_tree.rs:276:5 [INFO] [stdout] | [INFO] [stdout] 276 | / pub fn new() -> BTree { [INFO] [stdout] 277 | | return BTree { root: 0 }; [INFO] [stdout] 278 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 275 + impl Default for BTree { [INFO] [stdout] 276 + fn default() -> Self { [INFO] [stdout] 277 + Self::new() [INFO] [stdout] 278 + } [INFO] [stdout] 279 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 277 | return BTree { root: 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - return BTree { root: 0 }; [INFO] [stdout] 277 + BTree { root: 0 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/B_tree.rs:294:13 [INFO] [stdout] | [INFO] [stdout] 294 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 329 | return new; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 329 - return new; [INFO] [stdout] 329 + new [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:354:13 [INFO] [stdout] | [INFO] [stdout] 354 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 353 - self.root = new(root); [INFO] [stdout] 354 - return; [INFO] [stdout] 353 + self.root = new(root); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/B_tree.rs:346:17 [INFO] [stdout] | [INFO] [stdout] 346 | assert!(key.len() != 0 && key.len() <= BTREE_MAX_KEY_SIZE); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!key.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/B_tree.rs:369:21 [INFO] [stdout] | [INFO] [stdout] 369 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/B_tree.rs:415:20 [INFO] [stdout] | [INFO] [stdout] 415 | if !(key.cmp(&node.get_key(index)) == Ordering::Equal) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(key.cmp(&node.get_key(index)) != Ordering::Equal)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:421:17 [INFO] [stdout] | [INFO] [stdout] 421 | return new_node; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 421 - return new_node; [INFO] [stdout] 421 + new_node [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:425:17 [INFO] [stdout] | [INFO] [stdout] 425 | return self.node_delete(node, index, key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 425 - return self.node_delete(node, index, key); [INFO] [stdout] 425 + self.node_delete(node, index, key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:428:17 [INFO] [stdout] | [INFO] [stdout] 428 | return BNode::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 428 - return BNode::new(); [INFO] [stdout] 428 + BNode::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:449:9 [INFO] [stdout] | [INFO] [stdout] 449 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 449 - return true; [INFO] [stdout] 449 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/B_tree.rs:433:17 [INFO] [stdout] | [INFO] [stdout] 433 | assert!(key.len() != 0 && key.len() <= BTREE_MAX_KEY_SIZE); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!key.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/B_tree.rs:439:12 [INFO] [stdout] | [INFO] [stdout] 439 | if updated_node.data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `updated_node.data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:485:9 [INFO] [stdout] | [INFO] [stdout] 485 | return new_node; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 485 - return new_node; [INFO] [stdout] 485 + new_node [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/B_tree.rs:455:12 [INFO] [stdout] | [INFO] [stdout] 455 | if updated_node.data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `updated_node.data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `found` [INFO] [stdout] --> src/B_tree.rs:749:14 [INFO] [stdout] | [INFO] [stdout] 749 | let (found, index, node) = tree.search(&new_key); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_found` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/B_tree.rs:483:58 [INFO] [stdout] | [INFO] [stdout] 483 | self.node_replace_kidN(&mut new_node, index, &node, vec![updated_node]); [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/B_tree.rs:804:13 [INFO] [stdout] | [INFO] [stdout] 804 | let index = root_node.lookup_key(&nkey); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:542:9 [INFO] [stdout] | [INFO] [stdout] 542 | return (0, BNode::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 542 - return (0, BNode::new()); [INFO] [stdout] 542 + (0, BNode::new()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `found` [INFO] [stdout] --> src/B_tree.rs:809:14 [INFO] [stdout] | [INFO] [stdout] 809 | let (found, index, node) = tree.search(&vec![3, 53, 2]); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_found` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:555:17 [INFO] [stdout] | [INFO] [stdout] 555 | return (found, index, root_node); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 555 - return (found, index, root_node); [INFO] [stdout] 555 + (found, index, root_node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BNode` [INFO] [stdout] --> src/B_tree.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn new() -> BNode { [INFO] [stdout] 22 | | let bnode = BNode { [INFO] [stdout] 23 | | data: vec![0; BTREE_PAGE_SIZE], [INFO] [stdout] 24 | | }; [INFO] [stdout] 25 | | return bnode; [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for BNode { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return bnode; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return bnode; [INFO] [stdout] 25 + bnode [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return u16::from_ne_bytes(self.data[..2].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return u16::from_ne_bytes(self.data[..2].try_into().unwrap()); [INFO] [stdout] 28 + u16::from_ne_bytes(self.data[..2].try_into().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:567:17 [INFO] [stdout] | [INFO] [stdout] 567 | return (found, index, node); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 567 - return (found, index, node); [INFO] [stdout] 567 + (found, index, node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:570:17 [INFO] [stdout] | [INFO] [stdout] 570 | return (false, 0, BNode::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 570 - return (false, 0, BNode::new()); [INFO] [stdout] 570 + (false, 0, BNode::new()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/B_tree.rs:547:42 [INFO] [stdout] | [INFO] [stdout] 547 | let index = root_node.lookup_key(&key); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return u16::from_ne_bytes(self.data[2..4].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return u16::from_ne_bytes(self.data[2..4].try_into().unwrap()); [INFO] [stdout] 31 + u16::from_ne_bytes(self.data[2..4].try_into().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return u64::from_ne_bytes(self.data[position..position + 8].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return u64::from_ne_bytes(self.data[position..position + 8].try_into().unwrap()); [INFO] [stdout] 40 + u64::from_ne_bytes(self.data[position..position + 8].try_into().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/B_tree.rs:552:49 [INFO] [stdout] | [INFO] [stdout] 552 | if root_node.get_key(index).cmp(&key) == Ordering::Equal { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/B_tree.rs:560:49 [INFO] [stdout] | [INFO] [stdout] 560 | let index = node.lookup_key(&key); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/B_tree.rs:563:45 [INFO] [stdout] | [INFO] [stdout] 563 | let index = node.lookup_key(&key); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/B_tree.rs:564:44 [INFO] [stdout] | [INFO] [stdout] 564 | if node.get_key(index).cmp(&key) == Ordering::Equal { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | return HEADER + 8 * self.nkeys() + 2 * (index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return HEADER + 8 * self.nkeys() + 2 * (index); [INFO] [stdout] 51 + HEADER + 8 * self.nkeys() + 2 * (index) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:605:9 [INFO] [stdout] | [INFO] [stdout] 605 | return vec![modified_node]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 605 - return vec![modified_node]; [INFO] [stdout] 605 + vec![modified_node] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:620:13 [INFO] [stdout] | [INFO] [stdout] 620 | return vec![modified_node, right_node]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 620 - return vec![modified_node, right_node]; [INFO] [stdout] 620 + vec![modified_node, right_node] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:625:13 [INFO] [stdout] | [INFO] [stdout] 625 | return vec![extreme_left_node, middle_node, right_node]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 625 - return vec![extreme_left_node, middle_node, right_node]; [INFO] [stdout] 625 + vec![extreme_left_node, middle_node, right_node] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | return HEADER + 8 * self.nkeys(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return HEADER + 8 * self.nkeys(); [INFO] [stdout] 53 + HEADER + 8 * self.nkeys() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `B_tree` should have a snake case name [INFO] [stdout] --> src/lib.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod B_tree; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `b_tree` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / return u16::from_ne_bytes( [INFO] [stdout] 60 | | self.data[offset_position..offset_position + 2] [INFO] [stdout] 61 | | .try_into() [INFO] [stdout] 62 | | .unwrap(), [INFO] [stdout] 63 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 ~ u16::from_ne_bytes( [INFO] [stdout] 60 + self.data[offset_position..offset_position + 2] [INFO] [stdout] 61 + .try_into() [INFO] [stdout] 62 + .unwrap(), [INFO] [stdout] 63 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return HEADER + self.nkeys() * 2 + self.nkeys() * 8 + self.get_offset(index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return HEADER + self.nkeys() * 2 + self.nkeys() * 8 + self.get_offset(index); [INFO] [stdout] 78 + HEADER + self.nkeys() * 2 + self.nkeys() * 8 + self.get_offset(index) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return self.data[key_pos + 4..key_pos + 4 + klen].to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return self.data[key_pos + 4..key_pos + 4 + klen].to_vec(); [INFO] [stdout] 86 + self.data[key_pos + 4..key_pos + 4 + klen].to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | return self.data[key_pos + 4 + klen..key_pos + 4 + klen + vlen].to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return self.data[key_pos + 4 + klen..key_pos + 4 + klen + vlen].to_vec(); [INFO] [stdout] 94 + self.data[key_pos + 4 + klen..key_pos + 4 + klen + vlen].to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | return last_index_containing_value as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return last_index_containing_value as u16; [INFO] [stdout] 101 + last_index_containing_value as u16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | return found; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return found; [INFO] [stdout] 123 + found [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/B_tree.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::boxed::Box::::into_raw` that must be used [INFO] [stdout] --> src/B_tree.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 271 | Box::into_raw(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the pointer will leak memory [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 271 | let _ = Box::into_raw(data); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `node_replace_kidN` should have a snake case name [INFO] [stdout] --> src/B_tree.rs:279:12 [INFO] [stdout] | [INFO] [stdout] 279 | pub fn node_replace_kidN( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `node_replace_kid_n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:264:5 [INFO] [stdout] | [INFO] [stdout] 264 | return pointer as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 264 - return pointer as u64; [INFO] [stdout] 264 + pointer as u64 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 272 | return BNode { data: result }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 272 - return BNode { data: result }; [INFO] [stdout] 272 + BNode { data: result } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BTree` [INFO] [stdout] --> src/B_tree.rs:276:5 [INFO] [stdout] | [INFO] [stdout] 276 | / pub fn new() -> BTree { [INFO] [stdout] 277 | | return BTree { root: 0 }; [INFO] [stdout] 278 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 275 + impl Default for BTree { [INFO] [stdout] 276 + fn default() -> Self { [INFO] [stdout] 277 + Self::new() [INFO] [stdout] 278 + } [INFO] [stdout] 279 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 277 | return BTree { root: 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - return BTree { root: 0 }; [INFO] [stdout] 277 + BTree { root: 0 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/B_tree.rs:294:13 [INFO] [stdout] | [INFO] [stdout] 294 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 329 | return new; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 329 - return new; [INFO] [stdout] 329 + new [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:354:13 [INFO] [stdout] | [INFO] [stdout] 354 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 353 - self.root = new(root); [INFO] [stdout] 354 - return; [INFO] [stdout] 353 + self.root = new(root); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/B_tree.rs:346:17 [INFO] [stdout] | [INFO] [stdout] 346 | assert!(key.len() != 0 && key.len() <= BTREE_MAX_KEY_SIZE); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!key.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/B_tree.rs:369:21 [INFO] [stdout] | [INFO] [stdout] 369 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/B_tree.rs:415:20 [INFO] [stdout] | [INFO] [stdout] 415 | if !(key.cmp(&node.get_key(index)) == Ordering::Equal) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(key.cmp(&node.get_key(index)) != Ordering::Equal)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:421:17 [INFO] [stdout] | [INFO] [stdout] 421 | return new_node; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 421 - return new_node; [INFO] [stdout] 421 + new_node [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:425:17 [INFO] [stdout] | [INFO] [stdout] 425 | return self.node_delete(node, index, key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 425 - return self.node_delete(node, index, key); [INFO] [stdout] 425 + self.node_delete(node, index, key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:428:17 [INFO] [stdout] | [INFO] [stdout] 428 | return BNode::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 428 - return BNode::new(); [INFO] [stdout] 428 + BNode::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:449:9 [INFO] [stdout] | [INFO] [stdout] 449 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 449 - return true; [INFO] [stdout] 449 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/B_tree.rs:433:17 [INFO] [stdout] | [INFO] [stdout] 433 | assert!(key.len() != 0 && key.len() <= BTREE_MAX_KEY_SIZE); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!key.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/B_tree.rs:439:12 [INFO] [stdout] | [INFO] [stdout] 439 | if updated_node.data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `updated_node.data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:485:9 [INFO] [stdout] | [INFO] [stdout] 485 | return new_node; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 485 - return new_node; [INFO] [stdout] 485 + new_node [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/B_tree.rs:455:12 [INFO] [stdout] | [INFO] [stdout] 455 | if updated_node.data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `updated_node.data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/B_tree.rs:483:58 [INFO] [stdout] | [INFO] [stdout] 483 | self.node_replace_kidN(&mut new_node, index, &node, vec![updated_node]); [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:542:9 [INFO] [stdout] | [INFO] [stdout] 542 | return (0, BNode::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 542 - return (0, BNode::new()); [INFO] [stdout] 542 + (0, BNode::new()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:555:17 [INFO] [stdout] | [INFO] [stdout] 555 | return (found, index, root_node); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 555 - return (found, index, root_node); [INFO] [stdout] 555 + (found, index, root_node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:567:17 [INFO] [stdout] | [INFO] [stdout] 567 | return (found, index, node); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 567 - return (found, index, node); [INFO] [stdout] 567 + (found, index, node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:570:17 [INFO] [stdout] | [INFO] [stdout] 570 | return (false, 0, BNode::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 570 - return (false, 0, BNode::new()); [INFO] [stdout] 570 + (false, 0, BNode::new()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/B_tree.rs:547:42 [INFO] [stdout] | [INFO] [stdout] 547 | let index = root_node.lookup_key(&key); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/B_tree.rs:552:49 [INFO] [stdout] | [INFO] [stdout] 552 | if root_node.get_key(index).cmp(&key) == Ordering::Equal { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/B_tree.rs:560:49 [INFO] [stdout] | [INFO] [stdout] 560 | let index = node.lookup_key(&key); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/B_tree.rs:563:45 [INFO] [stdout] | [INFO] [stdout] 563 | let index = node.lookup_key(&key); [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/B_tree.rs:564:44 [INFO] [stdout] | [INFO] [stdout] 564 | if node.get_key(index).cmp(&key) == Ordering::Equal { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:605:9 [INFO] [stdout] | [INFO] [stdout] 605 | return vec![modified_node]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 605 - return vec![modified_node]; [INFO] [stdout] 605 + vec![modified_node] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:620:13 [INFO] [stdout] | [INFO] [stdout] 620 | return vec![modified_node, right_node]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 620 - return vec![modified_node, right_node]; [INFO] [stdout] 620 + vec![modified_node, right_node] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/B_tree.rs:625:13 [INFO] [stdout] | [INFO] [stdout] 625 | return vec![extreme_left_node, middle_node, right_node]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 625 - return vec![extreme_left_node, middle_node, right_node]; [INFO] [stdout] 625 + vec![extreme_left_node, middle_node, right_node] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BNODE_LEAF`, `BNode`, `BTree`, `get`, `new`, and `node_append_range` [INFO] [stdout] --> src/main.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | use rustdb::B_tree::{get, new, node_append_range, BNode, BTree, BNODE_LEAF}; [INFO] [stdout] | ^^^ ^^^ ^^^^^^^^^^^^^^^^^ ^^^^^ ^^^^^ ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/B_tree.rs:679:28 [INFO] [stdout] | [INFO] [stdout] 679 | let temp_pointer = pointer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pointer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `B_tree` should have a snake case name [INFO] [stdout] --> src/lib.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod B_tree; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `b_tree` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BNODE_LEAF`, `BNode`, `BTree`, `get`, `new`, and `node_append_range` [INFO] [stdout] --> src/main.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | use rustdb::B_tree::{get, new, node_append_range, BNode, BTree, BNODE_LEAF}; [INFO] [stdout] | ^^^ ^^^ ^^^^^^^^^^^^^^^^^ ^^^^^ ^^^^^ ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::boxed::Box::::into_raw` that must be used [INFO] [stdout] --> src/B_tree.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 271 | Box::into_raw(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the pointer will leak memory [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 271 | let _ = Box::into_raw(data); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `node_replace_kidN` should have a snake case name [INFO] [stdout] --> src/B_tree.rs:279:12 [INFO] [stdout] | [INFO] [stdout] 279 | pub fn node_replace_kidN( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `node_replace_kid_n` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.44s [INFO] running `Command { std: "docker" "inspect" "a3a7ee9a687947ec9cacc99f6959d9a7e42b4140862b7a0aaf8fa61443e60983", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a3a7ee9a687947ec9cacc99f6959d9a7e42b4140862b7a0aaf8fa61443e60983", kill_on_drop: false }` [INFO] [stdout] a3a7ee9a687947ec9cacc99f6959d9a7e42b4140862b7a0aaf8fa61443e60983