[INFO] cloning repository https://github.com/AkalUstat/adventofcode_2023 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AkalUstat/adventofcode_2023" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAkalUstat%2Fadventofcode_2023", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAkalUstat%2Fadventofcode_2023'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8448a8c6ad20f0723772ae42c965852ea510aa04 [INFO] linting AkalUstat/adventofcode_2023 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAkalUstat%2Fadventofcode_2023" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/AkalUstat/adventofcode_2023 [INFO] finished tweaking git repo https://github.com/AkalUstat/adventofcode_2023 [INFO] tweaked toml for git repo https://github.com/AkalUstat/adventofcode_2023 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/AkalUstat/adventofcode_2023 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/AkalUstat/adventofcode_2023 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded strum_macros v0.25.3 [INFO] [stderr] Downloaded fancy-regex v0.12.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0bdb4504cb73c60fb22da5f3538067c642dcf6db537b536c71212eb110099103 [INFO] running `Command { std: "docker" "start" "-a" "0bdb4504cb73c60fb22da5f3538067c642dcf6db537b536c71212eb110099103", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0bdb4504cb73c60fb22da5f3538067c642dcf6db537b536c71212eb110099103", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0bdb4504cb73c60fb22da5f3538067c642dcf6db537b536c71212eb110099103", kill_on_drop: false }` [INFO] [stdout] 0bdb4504cb73c60fb22da5f3538067c642dcf6db537b536c71212eb110099103 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b0cc0ac4d62dad0e448fce4fa01adfa08c9d23585ec6d63a38d53e61e2eb1235 [INFO] running `Command { std: "docker" "start" "-a" "b0cc0ac4d62dad0e448fce4fa01adfa08c9d23585ec6d63a38d53e61e2eb1235", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking fancy-regex v0.12.0 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Checking adventofcode_2023 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | let reader = BufReader::new(file); [INFO] [stdout] | ---------------------------------- unnecessary `let` binding [INFO] [stdout] 7 | reader [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 6 ~ [INFO] [stdout] 7 ~ BufReader::new(file) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/lib.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 15 | .filter(|s| s != &"") [INFO] [stdout] | ^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | let reader = BufReader::new(file); [INFO] [stdout] | ---------------------------------- unnecessary `let` binding [INFO] [stdout] 7 | reader [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 6 ~ [INFO] [stdout] 7 ~ BufReader::new(file) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/lib.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 15 | .filter(|s| s != &"") [INFO] [stdout] | ^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day9.rs:11:24 [INFO] [stdout] | [INFO] [stdout] 11 | fn differentiate(func: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - fn differentiate(func: &Vec) -> Vec { [INFO] [stdout] 11 + fn differentiate(func: &[isize]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day9.rs:39:34 [INFO] [stdout] | [INFO] [stdout] 39 | current_derivative = &derivates.last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `derivates.last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day9.rs:74:34 [INFO] [stdout] | [INFO] [stdout] 74 | current_derivative = &derivates.last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `derivates.last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day9.rs:11:24 [INFO] [stdout] | [INFO] [stdout] 11 | fn differentiate(func: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - fn differentiate(func: &Vec) -> Vec { [INFO] [stdout] 11 + fn differentiate(func: &[isize]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day9.rs:39:34 [INFO] [stdout] | [INFO] [stdout] 39 | current_derivative = &derivates.last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `derivates.last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day9.rs:74:34 [INFO] [stdout] | [INFO] [stdout] 74 | current_derivative = &derivates.last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `derivates.last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/bin/day10.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/bin/day4.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | (*self).count += value; [INFO] [stdout] | ^^^^^^^ help: try: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day8.rs:70:40 [INFO] [stdout] | [INFO] [stdout] 70 | let starting_location: &Location = &map.iter().find(|pos| pos.position == "AAA").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `map.iter().find(|pos| pos.position == "AAA").unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day8.rs:106:20 [INFO] [stdout] | [INFO] [stdout] 106 | fn get_path(lines: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 106 - fn get_path(lines: &Vec) -> Vec { [INFO] [stdout] 106 + fn get_path(lines: &[String]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day8.rs:114:19 [INFO] [stdout] | [INFO] [stdout] 114 | fn get_map(lines: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 114 - fn get_map(lines: &Vec) -> Vec { [INFO] [stdout] 114 + fn get_map(lines: &[String]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day8.rs:125:11 [INFO] [stdout] | [INFO] [stdout] 125 | path: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 125 - path: &Vec, [INFO] [stdout] 125 + path: &[Movement], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day8.rs:126:10 [INFO] [stdout] | [INFO] [stdout] 126 | map: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 126 - map: &Vec, [INFO] [stdout] 126 + map: &[Location], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day8.rs:140:36 [INFO] [stdout] | [INFO] [stdout] 140 | current_position = &map [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 141 | | .iter() [INFO] [stdout] 142 | | .find(|pos| pos.position == *next_position) [INFO] [stdout] 143 | | .unwrap(); [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 140 ~ current_position = map [INFO] [stdout] 141 + .iter() [INFO] [stdout] 142 + .find(|pos| pos.position == *next_position) [INFO] [stdout] 143 ~ .unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day8.rs:147:36 [INFO] [stdout] | [INFO] [stdout] 147 | current_position = &map [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 148 | | .iter() [INFO] [stdout] 149 | | .find(|pos| pos.position == *next_position) [INFO] [stdout] 150 | | .unwrap(); [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 147 ~ current_position = map [INFO] [stdout] 148 + .iter() [INFO] [stdout] 149 + .find(|pos| pos.position == *next_position) [INFO] [stdout] 150 ~ .unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day8.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | return num2; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 181 - return num2; [INFO] [stdout] 181 + num2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bin/day2.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 32 | / if vec[0].parse::().unwrap() > max_red { [INFO] [stdout] 33 | | continue 'outer; [INFO] [stdout] 34 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 31 ~ "red" [INFO] [stdout] 32 ~ if vec[0].parse::().unwrap() > max_red => { [INFO] [stdout] 33 | continue 'outer; [INFO] [stdout] 34 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bin/day2.rs:37:25 [INFO] [stdout] | [INFO] [stdout] 37 | / if vec[0].parse::().unwrap() > max_blue { [INFO] [stdout] 38 | | continue 'outer; [INFO] [stdout] 39 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ "blue" [INFO] [stdout] 37 ~ if vec[0].parse::().unwrap() > max_blue => { [INFO] [stdout] 38 | continue 'outer; [INFO] [stdout] 39 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bin/day2.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 42 | / if vec[0].parse::().unwrap() > max_green { [INFO] [stdout] 43 | | continue 'outer; [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 41 ~ "green" [INFO] [stdout] 42 ~ if vec[0].parse::().unwrap() > max_green => { [INFO] [stdout] 43 | continue 'outer; [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/bin/day4.rs:82:28 [INFO] [stdout] | [INFO] [stdout] 82 | .increment(card.borrow().count * 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `card.borrow().count` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/bin/day4.rs:88:10 [INFO] [stdout] | [INFO] [stdout] 88 | .fold(0, |acc, value| acc + value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/bin/day4.rs:85:33 [INFO] [stdout] | [INFO] [stdout] 85 | many_scratches_collector += cards [INFO] [stdout] | _________________________________^ [INFO] [stdout] 86 | | .iter() [INFO] [stdout] 87 | | .map(|(_key, value)| value.borrow().count) [INFO] [stdout] | |__________________________________________________^ help: try: `cards.values().map(|value| value.borrow().count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/bin/day4.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | (*self).count += value; [INFO] [stdout] | ^^^^^^^ help: try: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/bin/day4.rs:82:28 [INFO] [stdout] | [INFO] [stdout] 82 | .increment(card.borrow().count * 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `card.borrow().count` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/bin/day4.rs:88:10 [INFO] [stdout] | [INFO] [stdout] 88 | .fold(0, |acc, value| acc + value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/bin/day4.rs:85:33 [INFO] [stdout] | [INFO] [stdout] 85 | many_scratches_collector += cards [INFO] [stdout] | _________________________________^ [INFO] [stdout] 86 | | .iter() [INFO] [stdout] 87 | | .map(|(_key, value)| value.borrow().count) [INFO] [stdout] | |__________________________________________________^ help: try: `cards.values().map(|value| value.borrow().count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/day10.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | let mut checker_queue: VecDeque = VecDeque::new(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `checker_queue` [INFO] [stdout] --> src/bin/day10.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | let mut checker_queue: VecDeque = VecDeque::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_checker_queue` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `I` and `A` are never constructed [INFO] [stdout] --> src/bin/day10.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 7 | enum Dir { [INFO] [stdout] | --- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 12 | I, [INFO] [stdout] | ^ [INFO] [stdout] 13 | A, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Dir` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `connect` is never used [INFO] [stdout] --> src/bin/day10.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 20 | impl Connection { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 27 | fn connect(&mut self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/bin/day10.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 79 | impl Pipe { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 89 | pub fn new(x: usize, y: usize, pipe_type: PipeType) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part_two` is never used [INFO] [stdout] --> src/bin/day10.rs:237:4 [INFO] [stdout] | [INFO] [stdout] 237 | fn part_two() {} [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day10.rs:110:20 [INFO] [stdout] | [INFO] [stdout] 110 | if !(character == '.') && !(character == 'S') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(character != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day10.rs:110:43 [INFO] [stdout] | [INFO] [stdout] 110 | if !(character == '.') && !(character == 'S') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(character != 'S')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day10.rs:97:49 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn get_nearby(x: usize, y: usize, grid: &Vec>) -> [Option; 4] { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 97 - pub fn get_nearby(x: usize, y: usize, grid: &Vec>) -> [Option; 4] { [INFO] [stdout] 97 + pub fn get_nearby(x: usize, y: usize, grid: &[Vec]) -> [Option; 4] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/bin/day10.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:190:13 [INFO] [stdout] | [INFO] [stdout] 190 | return Ordering::Greater; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 190 - return Ordering::Greater; [INFO] [stdout] 190 + Ordering::Greater [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:192:13 [INFO] [stdout] | [INFO] [stdout] 192 | return Ordering::Less; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 - return Ordering::Less; [INFO] [stdout] 192 + Ordering::Less [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:204:13 [INFO] [stdout] | [INFO] [stdout] 204 | return Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return Ordering::Equal; [INFO] [stdout] 204 + Ordering::Equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day8.rs:70:40 [INFO] [stdout] | [INFO] [stdout] 70 | let starting_location: &Location = &map.iter().find(|pos| pos.position == "AAA").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `map.iter().find(|pos| pos.position == "AAA").unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/bin/day7.rs:212:10 [INFO] [stdout] | [INFO] [stdout] 212 | .fold(0, |acc, val| acc + val) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day8.rs:106:20 [INFO] [stdout] | [INFO] [stdout] 106 | fn get_path(lines: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 106 - fn get_path(lines: &Vec) -> Vec { [INFO] [stdout] 106 + fn get_path(lines: &[String]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day8.rs:114:19 [INFO] [stdout] | [INFO] [stdout] 114 | fn get_map(lines: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 114 - fn get_map(lines: &Vec) -> Vec { [INFO] [stdout] 114 + fn get_map(lines: &[String]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day8.rs:125:11 [INFO] [stdout] | [INFO] [stdout] 125 | path: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 125 - path: &Vec, [INFO] [stdout] 125 + path: &[Movement], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day8.rs:126:10 [INFO] [stdout] | [INFO] [stdout] 126 | map: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 126 - map: &Vec, [INFO] [stdout] 126 + map: &[Location], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day8.rs:140:36 [INFO] [stdout] | [INFO] [stdout] 140 | current_position = &map [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 141 | | .iter() [INFO] [stdout] 142 | | .find(|pos| pos.position == *next_position) [INFO] [stdout] 143 | | .unwrap(); [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 140 ~ current_position = map [INFO] [stdout] 141 + .iter() [INFO] [stdout] 142 + .find(|pos| pos.position == *next_position) [INFO] [stdout] 143 ~ .unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day8.rs:147:36 [INFO] [stdout] | [INFO] [stdout] 147 | current_position = &map [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 148 | | .iter() [INFO] [stdout] 149 | | .find(|pos| pos.position == *next_position) [INFO] [stdout] 150 | | .unwrap(); [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 147 ~ current_position = map [INFO] [stdout] 148 + .iter() [INFO] [stdout] 149 + .find(|pos| pos.position == *next_position) [INFO] [stdout] 150 ~ .unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day8.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | return num2; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 181 - return num2; [INFO] [stdout] 181 + num2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:286:17 [INFO] [stdout] | [INFO] [stdout] 286 | return Ordering::Greater; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 286 - return Ordering::Greater; [INFO] [stdout] 286 + Ordering::Greater [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | return Ordering::Less; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 288 - return Ordering::Less; [INFO] [stdout] 288 + Ordering::Less [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:291:21 [INFO] [stdout] | [INFO] [stdout] 291 | return Ordering::Greater; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return Ordering::Greater; [INFO] [stdout] 291 + Ordering::Greater [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:293:21 [INFO] [stdout] | [INFO] [stdout] 293 | return Ordering::Less; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 293 - return Ordering::Less; [INFO] [stdout] 293 + Ordering::Less [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:295:21 [INFO] [stdout] | [INFO] [stdout] 295 | return Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - return Ordering::Equal; [INFO] [stdout] 295 + Ordering::Equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PatternID` [INFO] [stdout] --> src/bin/day1.rs:5:33 [INFO] [stdout] | [INFO] [stdout] 5 | use aho_corasick::{AhoCorasick, PatternID}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PatternID` [INFO] [stdout] --> src/bin/day1.rs:5:33 [INFO] [stdout] | [INFO] [stdout] 5 | use aho_corasick::{AhoCorasick, PatternID}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/day1.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | let mut lines_iter = reader.lines().map(|l| l.unwrap()); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:468:13 [INFO] [stdout] | [INFO] [stdout] 468 | return Ordering::Greater; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 468 - return Ordering::Greater; [INFO] [stdout] 468 + Ordering::Greater [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:470:13 [INFO] [stdout] | [INFO] [stdout] 470 | return Ordering::Less; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 470 - return Ordering::Less; [INFO] [stdout] 470 + Ordering::Less [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:482:13 [INFO] [stdout] | [INFO] [stdout] 482 | return Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 482 - return Ordering::Equal; [INFO] [stdout] 482 + Ordering::Equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/bin/day7.rs:492:10 [INFO] [stdout] | [INFO] [stdout] 492 | .fold(0, |acc, val| acc + val) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/day1.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | let mut lines_iter = reader.lines().map(|l| l.unwrap()); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `total_lines` [INFO] [stdout] --> src/bin/day5.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | let total_lines = lines.len(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_total_lines` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bin/day2.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 32 | / if vec[0].parse::().unwrap() > max_red { [INFO] [stdout] 33 | | continue 'outer; [INFO] [stdout] 34 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 31 ~ "red" [INFO] [stdout] 32 ~ if vec[0].parse::().unwrap() > max_red => { [INFO] [stdout] 33 | continue 'outer; [INFO] [stdout] 34 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bin/day2.rs:37:25 [INFO] [stdout] | [INFO] [stdout] 37 | / if vec[0].parse::().unwrap() > max_blue { [INFO] [stdout] 38 | | continue 'outer; [INFO] [stdout] 39 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ "blue" [INFO] [stdout] 37 ~ if vec[0].parse::().unwrap() > max_blue => { [INFO] [stdout] 38 | continue 'outer; [INFO] [stdout] 39 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bin/day2.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 42 | / if vec[0].parse::().unwrap() > max_green { [INFO] [stdout] 43 | | continue 'outer; [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 41 ~ "green" [INFO] [stdout] 42 ~ if vec[0].parse::().unwrap() > max_green => { [INFO] [stdout] 43 | continue 'outer; [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/bin/day5.rs:27:27 [INFO] [stdout] | [INFO] [stdout] 27 | let mut lowest_seed = std::usize::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 27 - let mut lowest_seed = std::usize::MAX; [INFO] [stdout] 27 + let mut lowest_seed = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/day10.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | let mut checker_queue: VecDeque = VecDeque::new(); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `checker_queue` [INFO] [stdout] --> src/bin/day10.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | let mut checker_queue: VecDeque = VecDeque::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_checker_queue` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day5.rs:81:44 [INFO] [stdout] | [INFO] [stdout] 81 | let final_loc = seed_to_loc_mapper(&seed, &blocks); [INFO] [stdout] | ^^^^^ help: change this to: `seed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `I` and `A` are never constructed [INFO] [stdout] --> src/bin/day10.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 7 | enum Dir { [INFO] [stdout] | --- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 12 | I, [INFO] [stdout] | ^ [INFO] [stdout] 13 | A, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Dir` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `connect` is never used [INFO] [stdout] --> src/bin/day10.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 20 | impl Connection { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 27 | fn connect(&mut self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/bin/day10.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 79 | impl Pipe { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 89 | pub fn new(x: usize, y: usize, pipe_type: PipeType) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part_two` is never used [INFO] [stdout] --> src/bin/day10.rs:237:4 [INFO] [stdout] | [INFO] [stdout] 237 | fn part_two() {} [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bin/day5.rs:95:15 [INFO] [stdout] | [INFO] [stdout] 95 | while seed_ranges.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!seed_ranges.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day5.rs:142:47 [INFO] [stdout] | [INFO] [stdout] 142 | fn seed_to_loc_mapper(seed: &usize, mappings: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 142 - fn seed_to_loc_mapper(seed: &usize, mappings: &Vec) -> usize { [INFO] [stdout] 142 + fn seed_to_loc_mapper(seed: &usize, mappings: &[Block]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bin/day5.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | / match found_val { [INFO] [stdout] 150 | | Some(x) => { [INFO] [stdout] 151 | | let dest_value = x.dest_start + (calculated_value - x.src_start); [INFO] [stdout] 152 | | calculated_value = dest_value; [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | None => {} [INFO] [stdout] 155 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 149 ~ if let Some(x) = found_val { [INFO] [stdout] 150 + let dest_value = x.dest_start + (calculated_value - x.src_start); [INFO] [stdout] 151 + calculated_value = dest_value; [INFO] [stdout] 152 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day10.rs:110:20 [INFO] [stdout] | [INFO] [stdout] 110 | if !(character == '.') && !(character == 'S') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(character != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day10.rs:110:43 [INFO] [stdout] | [INFO] [stdout] 110 | if !(character == '.') && !(character == 'S') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(character != 'S')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day10.rs:97:49 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn get_nearby(x: usize, y: usize, grid: &Vec>) -> [Option; 4] { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 97 - pub fn get_nearby(x: usize, y: usize, grid: &Vec>) -> [Option; 4] { [INFO] [stdout] 97 + pub fn get_nearby(x: usize, y: usize, grid: &[Vec]) -> [Option; 4] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:190:13 [INFO] [stdout] | [INFO] [stdout] 190 | return Ordering::Greater; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 190 - return Ordering::Greater; [INFO] [stdout] 190 + Ordering::Greater [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:192:13 [INFO] [stdout] | [INFO] [stdout] 192 | return Ordering::Less; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 - return Ordering::Less; [INFO] [stdout] 192 + Ordering::Less [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:204:13 [INFO] [stdout] | [INFO] [stdout] 204 | return Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return Ordering::Equal; [INFO] [stdout] 204 + Ordering::Equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/bin/day7.rs:212:10 [INFO] [stdout] | [INFO] [stdout] 212 | .fold(0, |acc, val| acc + val) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:286:17 [INFO] [stdout] | [INFO] [stdout] 286 | return Ordering::Greater; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 286 - return Ordering::Greater; [INFO] [stdout] 286 + Ordering::Greater [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | return Ordering::Less; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 288 - return Ordering::Less; [INFO] [stdout] 288 + Ordering::Less [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:291:21 [INFO] [stdout] | [INFO] [stdout] 291 | return Ordering::Greater; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return Ordering::Greater; [INFO] [stdout] 291 + Ordering::Greater [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:293:21 [INFO] [stdout] | [INFO] [stdout] 293 | return Ordering::Less; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 293 - return Ordering::Less; [INFO] [stdout] 293 + Ordering::Less [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:295:21 [INFO] [stdout] | [INFO] [stdout] 295 | return Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - return Ordering::Equal; [INFO] [stdout] 295 + Ordering::Equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:468:13 [INFO] [stdout] | [INFO] [stdout] 468 | return Ordering::Greater; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 468 - return Ordering::Greater; [INFO] [stdout] 468 + Ordering::Greater [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:470:13 [INFO] [stdout] | [INFO] [stdout] 470 | return Ordering::Less; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 470 - return Ordering::Less; [INFO] [stdout] 470 + Ordering::Less [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day7.rs:482:13 [INFO] [stdout] | [INFO] [stdout] 482 | return Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 482 - return Ordering::Equal; [INFO] [stdout] 482 + Ordering::Equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/bin/day7.rs:492:10 [INFO] [stdout] | [INFO] [stdout] 492 | .fold(0, |acc, val| acc + val) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `total_lines` [INFO] [stdout] --> src/bin/day5.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | let total_lines = lines.len(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_total_lines` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/bin/day5.rs:27:27 [INFO] [stdout] | [INFO] [stdout] 27 | let mut lowest_seed = std::usize::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 27 - let mut lowest_seed = std::usize::MAX; [INFO] [stdout] 27 + let mut lowest_seed = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/day5.rs:81:44 [INFO] [stdout] | [INFO] [stdout] 81 | let final_loc = seed_to_loc_mapper(&seed, &blocks); [INFO] [stdout] | ^^^^^ help: change this to: `seed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bin/day5.rs:95:15 [INFO] [stdout] | [INFO] [stdout] 95 | while seed_ranges.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!seed_ranges.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/day5.rs:142:47 [INFO] [stdout] | [INFO] [stdout] 142 | fn seed_to_loc_mapper(seed: &usize, mappings: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 142 - fn seed_to_loc_mapper(seed: &usize, mappings: &Vec) -> usize { [INFO] [stdout] 142 + fn seed_to_loc_mapper(seed: &usize, mappings: &[Block]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bin/day5.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | / match found_val { [INFO] [stdout] 150 | | Some(x) => { [INFO] [stdout] 151 | | let dest_value = x.dest_start + (calculated_value - x.src_start); [INFO] [stdout] 152 | | calculated_value = dest_value; [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | None => {} [INFO] [stdout] 155 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 149 ~ if let Some(x) = found_val { [INFO] [stdout] 150 + let dest_value = x.dest_start + (calculated_value - x.src_start); [INFO] [stdout] 151 + calculated_value = dest_value; [INFO] [stdout] 152 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.18s [INFO] running `Command { std: "docker" "inspect" "b0cc0ac4d62dad0e448fce4fa01adfa08c9d23585ec6d63a38d53e61e2eb1235", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0cc0ac4d62dad0e448fce4fa01adfa08c9d23585ec6d63a38d53e61e2eb1235", kill_on_drop: false }` [INFO] [stdout] b0cc0ac4d62dad0e448fce4fa01adfa08c9d23585ec6d63a38d53e61e2eb1235