[INFO] cloning repository https://github.com/Airbag65/rustport [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Airbag65/rustport" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAirbag65%2Frustport", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAirbag65%2Frustport'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9d01f1b18d1f4d68ee8f688e97e66e77104d4ec5 [INFO] linting Airbag65/rustport against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAirbag65%2Frustport" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Airbag65/rustport [INFO] finished tweaking git repo https://github.com/Airbag65/rustport [INFO] tweaked toml for git repo https://github.com/Airbag65/rustport written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Airbag65/rustport on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Airbag65/rustport already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded scanpw v1.0.0 [INFO] [stderr] Downloaded color-print v0.3.7 [INFO] [stderr] Downloaded zmij v1.0.17 [INFO] [stderr] Downloaded color-print-proc-macro v0.3.7 [INFO] [stderr] Downloaded piper v0.2.5 [INFO] [stderr] Downloaded pkcs1 v0.4.1 [INFO] [stderr] Downloaded pem-rfc7468 v0.6.0 [INFO] [stderr] Downloaded rsa_ext v0.1.2 [INFO] [stderr] Downloaded reqwest v0.13.1 [INFO] [stderr] Downloaded cc v1.2.54 [INFO] [stderr] Downloaded crossterm v0.26.1 [INFO] [stderr] Downloaded zerocopy-derive v0.8.34 [INFO] [stderr] Downloaded moxcms v0.7.11 [INFO] [stderr] Downloaded webpki-root-certs v1.0.5 [INFO] [stderr] Downloaded zerocopy v0.8.34 [INFO] [stderr] Downloaded aws-lc-rs v1.15.4 [INFO] [stderr] Downloaded aws-lc-sys v0.37.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8adf3fbc668222158b29e9d166518e001e2073718d8698ce4d29f50dcee5bb05 [INFO] running `Command { std: "docker" "start" "-a" "8adf3fbc668222158b29e9d166518e001e2073718d8698ce4d29f50dcee5bb05", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8adf3fbc668222158b29e9d166518e001e2073718d8698ce4d29f50dcee5bb05", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8adf3fbc668222158b29e9d166518e001e2073718d8698ce4d29f50dcee5bb05", kill_on_drop: false }` [INFO] [stdout] 8adf3fbc668222158b29e9d166518e001e2073718d8698ce4d29f50dcee5bb05 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 74528933b2d50052ce64d45d53ebcd4ee3d32bdfb291632c4a81746a2cb14890 [INFO] running `Command { std: "docker" "start" "-a" "74528933b2d50052ce64d45d53ebcd4ee3d32bdfb291632c4a81746a2cb14890", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Compiling find-msvc-tools v0.1.8 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Checking base64ct v1.8.3 [INFO] [stderr] Compiling libm v0.2.16 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling aws-lc-rs v1.15.4 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking writeable v0.6.2 [INFO] [stderr] Checking litemap v0.8.1 [INFO] [stderr] Compiling cc v1.2.54 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Compiling zerocopy v0.8.34 [INFO] [stderr] Checking parking v2.2.1 [INFO] [stderr] Checking slab v0.4.11 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Compiling aws-lc-sys v0.37.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking pem-rfc7468 v0.6.0 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling pkg-config v0.3.32 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking der v0.6.1 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling num-bigint-dig v0.8.6 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking spki v0.6.0 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Compiling zmij v1.0.17 [INFO] [stderr] Checking openssl-probe v0.2.1 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Checking pxfm v0.1.28 [INFO] [stderr] Checking png v0.18.1 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking pkcs8 v0.9.0 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking winnow v0.7.15 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking iri-string v0.7.10 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Checking toml_parser v1.0.9+spec-1.1.0 [INFO] [stderr] Compiling color-print-proc-macro v0.3.7 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking pkcs1 v0.4.1 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Checking toml_datetime v1.0.0+spec-1.1.0 [INFO] [stderr] Checking serde_spanned v1.0.4 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking toml_writer v1.0.6+spec-1.1.0 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking rsa_ext v0.1.2 [INFO] [stderr] Checking async-process v2.5.0 [INFO] [stderr] Checking toml v1.0.6+spec-1.1.0 [INFO] [stderr] Checking rsa v0.9.10 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking scanpw v1.0.0 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking color-print v0.3.7 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.13.1 [INFO] [stderr] Checking rp v1.2.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `thread` [INFO] [stdout] --> src/cmd/update.rs:1:50 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{env, fs, path::PathBuf, process::exit, thread}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/net/login.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | email: email, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/net/login.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | password: password, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thread` [INFO] [stdout] --> src/cmd/update.rs:1:50 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{env, fs, path::PathBuf, process::exit, thread}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/net/login.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | email: email, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/net/login.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | password: password, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cmd/add.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 39 - let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] 39 + std::io::stdout().flush().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cmd/add.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 42 - let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] 42 + std::io::stdout().flush().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cmd/add.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 47 - let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] 47 + std::io::stdout().flush().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cmd/add.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 50 - let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] 50 + std::io::stdout().flush().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `str::repeat` using iterators [INFO] [stdout] --> src/cmd/add.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 66 | / std::iter::repeat("*") [INFO] [stdout] 67 | | .take(password.len() - 2) [INFO] [stdout] 68 | | .collect::(), [INFO] [stdout] | |____________________________________________^ help: try: `"*".repeat(password.len() - 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_str_repeat [INFO] [stdout] = note: `#[warn(clippy::manual_str_repeat)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/cmd/add.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 66 | / std::iter::repeat("*") [INFO] [stdout] 67 | | .take(password.len() - 2) [INFO] [stdout] | |_________________________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n("*", password.len() - 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Result::unwrap_or` [INFO] [stdout] --> src/cmd/add.rs:73:39 [INFO] [stdout] | [INFO] [stdout] 73 | let status: u16 = match nm.add_password(&host_name, &password).await { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 74 | | Ok(code) => code, [INFO] [stdout] 75 | | Err(_) => 500, [INFO] [stdout] 76 | | }; [INFO] [stdout] | |_____________________^ help: replace with: `nm.add_password(&host_name, &password).await.unwrap_or(500)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `str::repeat` using iterators [INFO] [stdout] --> src/cmd/edit.rs:54:21 [INFO] [stdout] | [INFO] [stdout] 54 | / std::iter::repeat("*") [INFO] [stdout] 55 | | .take(new_password.len() - 2) [INFO] [stdout] 56 | | .collect::(), [INFO] [stdout] | |____________________________________________^ help: try: `"*".repeat(new_password.len() - 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_str_repeat [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/cmd/edit.rs:54:21 [INFO] [stdout] | [INFO] [stdout] 54 | / std::iter::repeat("*") [INFO] [stdout] 55 | | .take(new_password.len() - 2) [INFO] [stdout] | |_____________________________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n("*", new_password.len() - 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cmd/help.rs:13:40 [INFO] [stdout] | [INFO] [stdout] 13 | println!("{:<30} {}", " init", "Choose IP address to target"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 13 - println!("{:<30} {}", " init", "Choose IP address to target"); [INFO] [stdout] 13 + println!("{:<30} Choose IP address to target", " init"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cmd/help.rs:34:39 [INFO] [stdout] | [INFO] [stdout] 34 | println!("{:<30} {}", " add", "Add a new password"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 34 - println!("{:<30} {}", " add", "Add a new password"); [INFO] [stdout] 34 + println!("{:<30} Add a new password", " add"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cmd/help.rs:37:44 [INFO] [stdout] | [INFO] [stdout] 37 | " get [-h --host] ", "Retrieve the password for the specified hostname" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 ~ "{:<30} Retrieve the password for the specified hostname", [INFO] [stdout] 37 ~ " get [-h --host] " [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cmd/help.rs:56:45 [INFO] [stdout] | [INFO] [stdout] 56 | " edit [-h --host] ", "Edit the password for the specified hostname" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 55 ~ "{:<30} Edit the password for the specified hostname", [INFO] [stdout] 56 ~ " edit [-h --host] " [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cmd/login.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 44 | / let _ = match save_pem_string(&res.pem_string) { [INFO] [stdout] 45 | | Ok(_) => {} [INFO] [stdout] 46 | | Err(e) => eprintln!("Error {:?}", e), [INFO] [stdout] 47 | | }; [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 44 - let _ = match save_pem_string(&res.pem_string) { [INFO] [stdout] 44 + match save_pem_string(&res.pem_string) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cmd/login.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 48 | / let _ = match save_local_auth( [INFO] [stdout] 49 | | &res.name, [INFO] [stdout] 50 | | &res.surname, [INFO] [stdout] 51 | | &res.email, [INFO] [stdout] ... | [INFO] [stdout] 61 | | Err(_) => eprintln!("Something went wrong!"), [INFO] [stdout] 62 | | }; [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 48 - let _ = match save_local_auth( [INFO] [stdout] 48 + match save_local_auth( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/cmd/rsacc.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | if token != "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!token.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/cmd/status.rs:18:26 [INFO] [stdout] | [INFO] [stdout] 18 | let local_info = match get_local_information() { [INFO] [stdout] | __________________________^ [INFO] [stdout] 19 | | Ok(info) => info, [INFO] [stdout] 20 | | Err(e) => return Err(e), [INFO] [stdout] 21 | | }; [INFO] [stdout] | |_________^ help: try instead: `get_local_information()?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd/update.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | if !git_pull.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `git_pull.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/cmd/update.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | / match fs::copy( [INFO] [stdout] 53 | | String::from(&config.global.source_path) + "/target/release/rp", [INFO] [stdout] 54 | | String::from(&home_str) + "/.cargo/bin/rp", [INFO] [stdout] 55 | | ) { [INFO] [stdout] 56 | | Ok(_) => {} [INFO] [stdout] 57 | | Err(_) => {} [INFO] [stdout] 58 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 52 ~ if let Ok(_) = fs::copy( [INFO] [stdout] 53 + String::from(&config.global.source_path) + "/target/release/rp", [INFO] [stdout] 54 + String::from(&home_str) + "/.cargo/bin/rp", [INFO] [stdout] 55 ~ ) {}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/cmd/update.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / match fs::copy( [INFO] [stdout] 60 | | String::from(&config.global.source_path) + "/target/release/rp", [INFO] [stdout] 61 | | String::from(&home_str) + "/.cargo/bin/rustport", [INFO] [stdout] 62 | | ) { [INFO] [stdout] 63 | | Ok(_) => {} [INFO] [stdout] 64 | | Err(_) => {} [INFO] [stdout] 65 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 59 ~ if let Ok(_) = fs::copy( [INFO] [stdout] 60 + String::from(&config.global.source_path) + "/target/release/rp", [INFO] [stdout] 61 + String::from(&home_str) + "/.cargo/bin/rustport", [INFO] [stdout] 62 ~ ) {}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:43:28 [INFO] [stdout] | [INFO] [stdout] 43 | "status" | "st" => return Some(Box::new(StatusCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 ~ "status" | "st" => Some(Box::new(StatusCommand)), [INFO] [stdout] 44 | "login" | "lo" => return Some(Box::new(LoginCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:44:27 [INFO] [stdout] | [INFO] [stdout] 44 | "login" | "lo" => return Some(Box::new(LoginCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 ~ "login" | "lo" => Some(Box::new(LoginCommand)), [INFO] [stdout] 45 | "init" => return Some(Box::new(InitCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 45 | "init" => return Some(Box::new(InitCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 ~ "init" => Some(Box::new(InitCommand)), [INFO] [stdout] 46 | "signout" | "so" => return Some(Box::new(LogoutCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:46:29 [INFO] [stdout] | [INFO] [stdout] 46 | "signout" | "so" => return Some(Box::new(LogoutCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 ~ "signout" | "so" => Some(Box::new(LogoutCommand)), [INFO] [stdout] 47 | "register" | "reg" => return Some(Box::new(RegisterCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:47:31 [INFO] [stdout] | [INFO] [stdout] 47 | "register" | "reg" => return Some(Box::new(RegisterCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 ~ "register" | "reg" => Some(Box::new(RegisterCommand)), [INFO] [stdout] 48 | "signup" => return Some(Box::new(RegisterCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 48 | "signup" => return Some(Box::new(RegisterCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 ~ "signup" => Some(Box::new(RegisterCommand)), [INFO] [stdout] 49 | "ls" | "list" => return Some(Box::new(LsCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:49:26 [INFO] [stdout] | [INFO] [stdout] 49 | "ls" | "list" => return Some(Box::new(LsCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 ~ "ls" | "list" => Some(Box::new(LsCommand)), [INFO] [stdout] 50 | "get" => { [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ None [INFO] [stdout] 62 | } [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 63 | "add" => return Some(Box::new(AddCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 ~ "add" => Some(Box::new(AddCommand)), [INFO] [stdout] 64 | "help" | "h" => return Some(Box::new(HelpCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:64:25 [INFO] [stdout] | [INFO] [stdout] 64 | "help" | "h" => return Some(Box::new(HelpCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 ~ "help" | "h" => Some(Box::new(HelpCommand)), [INFO] [stdout] 65 | "rm" | "remove" => { [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 ~ None [INFO] [stdout] 83 | } [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 ~ None [INFO] [stdout] 96 | } [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:97:38 [INFO] [stdout] | [INFO] [stdout] 97 | "rsacc" | "reset_account" => return Some(Box::new(ResetAccountCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 ~ "rsacc" | "reset_account" => Some(Box::new(ResetAccountCommand)), [INFO] [stdout] 98 | "generate" | "gen" => return Some(Box::new(GenerateCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:98:31 [INFO] [stdout] | [INFO] [stdout] 98 | "generate" | "gen" => return Some(Box::new(GenerateCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 ~ "generate" | "gen" => Some(Box::new(GenerateCommand)), [INFO] [stdout] 99 | "version" | "v" => return Some(Box::new(VersionCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:99:28 [INFO] [stdout] | [INFO] [stdout] 99 | "version" | "v" => return Some(Box::new(VersionCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 ~ "version" | "v" => Some(Box::new(VersionCommand)), [INFO] [stdout] 100 | "update" => return Some(Box::new(UpdateCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | "update" => return Some(Box::new(UpdateCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 ~ "update" => Some(Box::new(UpdateCommand)), [INFO] [stdout] 101 | _ => { [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 ~ None [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/cmd.rs:41:26 [INFO] [stdout] | [INFO] [stdout] 41 | let command_string = String::from(argument[1].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `argument[1].clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/net/add.rs:36:23 [INFO] [stdout] | [INFO] [stdout] 36 | password: String::from(enc_password), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `enc_password` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/net/remove.rs:48:38 [INFO] [stdout] | [INFO] [stdout] 48 | .header("Authorization", String::from(format!("Bearer {}", token))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Bearer {}", token)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/net/signup.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | if name == "" || surname == "" || email == "" || password == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/net/signup.rs:33:26 [INFO] [stdout] | [INFO] [stdout] 33 | if name == "" || surname == "" || email == "" || password == "" { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `surname.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/net/signup.rs:33:43 [INFO] [stdout] | [INFO] [stdout] 33 | if name == "" || surname == "" || email == "" || password == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `email.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/net/signup.rs:33:58 [INFO] [stdout] | [INFO] [stdout] 33 | if name == "" || surname == "" || email == "" || password == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `password.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/net/singout.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | if email == "".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `reqwest::Client` [INFO] [stdout] --> src/net.rs:24:27 [INFO] [stdout] | [INFO] [stdout] 24 | Ok(client) => reqwest::Client::from(client), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `reqwest::Client::from()`: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/utilities/file.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 23 | let f = fs::File::create(full_path)?; [INFO] [stdout] | ------------------------------------- unnecessary `let` binding [INFO] [stdout] 24 | f [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 23 ~ [INFO] [stdout] 24 ~ fs::File::create(full_path)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/utilities.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 23 - let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] 23 + std::io::stdout().flush().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `str::repeat` using iterators [INFO] [stdout] --> src/utilities.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / std::iter::repeat("-") [INFO] [stdout] 65 | | .take(content.len()) [INFO] [stdout] 66 | | .collect::() [INFO] [stdout] | |________________________________^ help: try: `"-".repeat(content.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_str_repeat [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/utilities.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / std::iter::repeat("-") [INFO] [stdout] 65 | | .take(content.len()) [INFO] [stdout] | |________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n("-", content.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `str::repeat` using iterators [INFO] [stdout] --> src/utilities.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | / std::iter::repeat("-") [INFO] [stdout] 76 | | .take(content.len()) [INFO] [stdout] 77 | | .collect::() [INFO] [stdout] | |________________________________^ help: try: `"-".repeat(content.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_str_repeat [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/utilities.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | / std::iter::repeat("-") [INFO] [stdout] 76 | | .take(content.len()) [INFO] [stdout] | |________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n("-", content.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/utilities.rs:91:33 [INFO] [stdout] | [INFO] [stdout] 91 | if choice == "y".to_owned() { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 92 | | true [INFO] [stdout] 93 | | } else if choice != "n".to_owned() && default_yes { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/utilities.rs:93:55 [INFO] [stdout] | [INFO] [stdout] 93 | } else if choice != "n".to_owned() && default_yes { [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 94 | | true [INFO] [stdout] 95 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/utilities.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 91 | if choice == "y".to_owned() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `"y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/utilities.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | } else if choice != "n".to_owned() && default_yes { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | true [INFO] [stdout] 95 | | } else { [INFO] [stdout] 96 | | false [INFO] [stdout] 97 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `{ choice != "n".to_owned() && default_yes }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/utilities.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 93 | } else if choice != "n".to_owned() && default_yes { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `"n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/utilities.rs:130:53 [INFO] [stdout] | [INFO] [stdout] 130 | 1 => result += String::from(select_char(String::from(alpha.to_uppercase()))).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `alpha.to_uppercase()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/utilities.rs:131:28 [INFO] [stdout] | [INFO] [stdout] 131 | 2 => result += String::from(select_random_digit()).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `select_random_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/utilities.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | String::from(result) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utilities.rs:152:30 [INFO] [stdout] | [INFO] [stdout] 152 | result += capitalize(&part).as_str(); [INFO] [stdout] | ^^^^^ help: change this to: `part` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/utilities.rs:176:26 [INFO] [stdout] | [INFO] [stdout] 176 | let is_snake: bool = match snake_re.captures(&host_name) { [INFO] [stdout] | __________________________^ [INFO] [stdout] 177 | | Some(_) => true, [INFO] [stdout] 178 | | None => false, [INFO] [stdout] 179 | | }; [INFO] [stdout] | |_____^ help: try: `snake_re.captures(&host_name).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/utilities.rs:182:35 [INFO] [stdout] | [INFO] [stdout] 182 | return convert_snake_case(String::from(host_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `host_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/utilities.rs:185:26 [INFO] [stdout] | [INFO] [stdout] 185 | let is_camel: bool = match camel_re.captures(&host_name) { [INFO] [stdout] | __________________________^ [INFO] [stdout] 186 | | Some(_) => true, [INFO] [stdout] 187 | | None => false, [INFO] [stdout] 188 | | }; [INFO] [stdout] | |_____^ help: try: `camel_re.captures(&host_name).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/utilities.rs:191:35 [INFO] [stdout] | [INFO] [stdout] 191 | return convert_camel_case(String::from(host_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `host_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cmd/add.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 39 - let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] 39 + std::io::stdout().flush().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cmd/add.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 42 - let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] 42 + std::io::stdout().flush().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cmd/add.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 47 - let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] 47 + std::io::stdout().flush().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cmd/add.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 50 - let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] 50 + std::io::stdout().flush().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `str::repeat` using iterators [INFO] [stdout] --> src/cmd/add.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 66 | / std::iter::repeat("*") [INFO] [stdout] 67 | | .take(password.len() - 2) [INFO] [stdout] 68 | | .collect::(), [INFO] [stdout] | |____________________________________________^ help: try: `"*".repeat(password.len() - 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_str_repeat [INFO] [stdout] = note: `#[warn(clippy::manual_str_repeat)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/cmd/add.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 66 | / std::iter::repeat("*") [INFO] [stdout] 67 | | .take(password.len() - 2) [INFO] [stdout] | |_________________________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n("*", password.len() - 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Result::unwrap_or` [INFO] [stdout] --> src/cmd/add.rs:73:39 [INFO] [stdout] | [INFO] [stdout] 73 | let status: u16 = match nm.add_password(&host_name, &password).await { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 74 | | Ok(code) => code, [INFO] [stdout] 75 | | Err(_) => 500, [INFO] [stdout] 76 | | }; [INFO] [stdout] | |_____________________^ help: replace with: `nm.add_password(&host_name, &password).await.unwrap_or(500)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `str::repeat` using iterators [INFO] [stdout] --> src/cmd/edit.rs:54:21 [INFO] [stdout] | [INFO] [stdout] 54 | / std::iter::repeat("*") [INFO] [stdout] 55 | | .take(new_password.len() - 2) [INFO] [stdout] 56 | | .collect::(), [INFO] [stdout] | |____________________________________________^ help: try: `"*".repeat(new_password.len() - 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_str_repeat [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/cmd/edit.rs:54:21 [INFO] [stdout] | [INFO] [stdout] 54 | / std::iter::repeat("*") [INFO] [stdout] 55 | | .take(new_password.len() - 2) [INFO] [stdout] | |_____________________________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n("*", new_password.len() - 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cmd/help.rs:13:40 [INFO] [stdout] | [INFO] [stdout] 13 | println!("{:<30} {}", " init", "Choose IP address to target"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 13 - println!("{:<30} {}", " init", "Choose IP address to target"); [INFO] [stdout] 13 + println!("{:<30} Choose IP address to target", " init"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cmd/help.rs:34:39 [INFO] [stdout] | [INFO] [stdout] 34 | println!("{:<30} {}", " add", "Add a new password"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 34 - println!("{:<30} {}", " add", "Add a new password"); [INFO] [stdout] 34 + println!("{:<30} Add a new password", " add"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cmd/help.rs:37:44 [INFO] [stdout] | [INFO] [stdout] 37 | " get [-h --host] ", "Retrieve the password for the specified hostname" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 ~ "{:<30} Retrieve the password for the specified hostname", [INFO] [stdout] 37 ~ " get [-h --host] " [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cmd/help.rs:56:45 [INFO] [stdout] | [INFO] [stdout] 56 | " edit [-h --host] ", "Edit the password for the specified hostname" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 55 ~ "{:<30} Edit the password for the specified hostname", [INFO] [stdout] 56 ~ " edit [-h --host] " [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cmd/login.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 44 | / let _ = match save_pem_string(&res.pem_string) { [INFO] [stdout] 45 | | Ok(_) => {} [INFO] [stdout] 46 | | Err(e) => eprintln!("Error {:?}", e), [INFO] [stdout] 47 | | }; [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 44 - let _ = match save_pem_string(&res.pem_string) { [INFO] [stdout] 44 + match save_pem_string(&res.pem_string) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cmd/login.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 48 | / let _ = match save_local_auth( [INFO] [stdout] 49 | | &res.name, [INFO] [stdout] 50 | | &res.surname, [INFO] [stdout] 51 | | &res.email, [INFO] [stdout] ... | [INFO] [stdout] 61 | | Err(_) => eprintln!("Something went wrong!"), [INFO] [stdout] 62 | | }; [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 48 - let _ = match save_local_auth( [INFO] [stdout] 48 + match save_local_auth( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/cmd/rsacc.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | if token != "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!token.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/cmd/status.rs:18:26 [INFO] [stdout] | [INFO] [stdout] 18 | let local_info = match get_local_information() { [INFO] [stdout] | __________________________^ [INFO] [stdout] 19 | | Ok(info) => info, [INFO] [stdout] 20 | | Err(e) => return Err(e), [INFO] [stdout] 21 | | }; [INFO] [stdout] | |_________^ help: try instead: `get_local_information()?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd/update.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | if !git_pull.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `git_pull.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/cmd/update.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | / match fs::copy( [INFO] [stdout] 53 | | String::from(&config.global.source_path) + "/target/release/rp", [INFO] [stdout] 54 | | String::from(&home_str) + "/.cargo/bin/rp", [INFO] [stdout] 55 | | ) { [INFO] [stdout] 56 | | Ok(_) => {} [INFO] [stdout] 57 | | Err(_) => {} [INFO] [stdout] 58 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 52 ~ if let Ok(_) = fs::copy( [INFO] [stdout] 53 + String::from(&config.global.source_path) + "/target/release/rp", [INFO] [stdout] 54 + String::from(&home_str) + "/.cargo/bin/rp", [INFO] [stdout] 55 ~ ) {}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/cmd/update.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / match fs::copy( [INFO] [stdout] 60 | | String::from(&config.global.source_path) + "/target/release/rp", [INFO] [stdout] 61 | | String::from(&home_str) + "/.cargo/bin/rustport", [INFO] [stdout] 62 | | ) { [INFO] [stdout] 63 | | Ok(_) => {} [INFO] [stdout] 64 | | Err(_) => {} [INFO] [stdout] 65 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 59 ~ if let Ok(_) = fs::copy( [INFO] [stdout] 60 + String::from(&config.global.source_path) + "/target/release/rp", [INFO] [stdout] 61 + String::from(&home_str) + "/.cargo/bin/rustport", [INFO] [stdout] 62 ~ ) {}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:43:28 [INFO] [stdout] | [INFO] [stdout] 43 | "status" | "st" => return Some(Box::new(StatusCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 ~ "status" | "st" => Some(Box::new(StatusCommand)), [INFO] [stdout] 44 | "login" | "lo" => return Some(Box::new(LoginCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:44:27 [INFO] [stdout] | [INFO] [stdout] 44 | "login" | "lo" => return Some(Box::new(LoginCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 ~ "login" | "lo" => Some(Box::new(LoginCommand)), [INFO] [stdout] 45 | "init" => return Some(Box::new(InitCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 45 | "init" => return Some(Box::new(InitCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 ~ "init" => Some(Box::new(InitCommand)), [INFO] [stdout] 46 | "signout" | "so" => return Some(Box::new(LogoutCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:46:29 [INFO] [stdout] | [INFO] [stdout] 46 | "signout" | "so" => return Some(Box::new(LogoutCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 ~ "signout" | "so" => Some(Box::new(LogoutCommand)), [INFO] [stdout] 47 | "register" | "reg" => return Some(Box::new(RegisterCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:47:31 [INFO] [stdout] | [INFO] [stdout] 47 | "register" | "reg" => return Some(Box::new(RegisterCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 ~ "register" | "reg" => Some(Box::new(RegisterCommand)), [INFO] [stdout] 48 | "signup" => return Some(Box::new(RegisterCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 48 | "signup" => return Some(Box::new(RegisterCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 ~ "signup" => Some(Box::new(RegisterCommand)), [INFO] [stdout] 49 | "ls" | "list" => return Some(Box::new(LsCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:49:26 [INFO] [stdout] | [INFO] [stdout] 49 | "ls" | "list" => return Some(Box::new(LsCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 ~ "ls" | "list" => Some(Box::new(LsCommand)), [INFO] [stdout] 50 | "get" => { [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ None [INFO] [stdout] 62 | } [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 63 | "add" => return Some(Box::new(AddCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 ~ "add" => Some(Box::new(AddCommand)), [INFO] [stdout] 64 | "help" | "h" => return Some(Box::new(HelpCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:64:25 [INFO] [stdout] | [INFO] [stdout] 64 | "help" | "h" => return Some(Box::new(HelpCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 ~ "help" | "h" => Some(Box::new(HelpCommand)), [INFO] [stdout] 65 | "rm" | "remove" => { [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 ~ None [INFO] [stdout] 83 | } [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 ~ None [INFO] [stdout] 96 | } [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:97:38 [INFO] [stdout] | [INFO] [stdout] 97 | "rsacc" | "reset_account" => return Some(Box::new(ResetAccountCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 ~ "rsacc" | "reset_account" => Some(Box::new(ResetAccountCommand)), [INFO] [stdout] 98 | "generate" | "gen" => return Some(Box::new(GenerateCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:98:31 [INFO] [stdout] | [INFO] [stdout] 98 | "generate" | "gen" => return Some(Box::new(GenerateCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 ~ "generate" | "gen" => Some(Box::new(GenerateCommand)), [INFO] [stdout] 99 | "version" | "v" => return Some(Box::new(VersionCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:99:28 [INFO] [stdout] | [INFO] [stdout] 99 | "version" | "v" => return Some(Box::new(VersionCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 ~ "version" | "v" => Some(Box::new(VersionCommand)), [INFO] [stdout] 100 | "update" => return Some(Box::new(UpdateCommand)), [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | "update" => return Some(Box::new(UpdateCommand)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 ~ "update" => Some(Box::new(UpdateCommand)), [INFO] [stdout] 101 | _ => { [INFO] [stdout] ... [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 ~ None [INFO] [stdout] 104 | } [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/cmd.rs:41:26 [INFO] [stdout] | [INFO] [stdout] 41 | let command_string = String::from(argument[1].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `argument[1].clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/net/add.rs:36:23 [INFO] [stdout] | [INFO] [stdout] 36 | password: String::from(enc_password), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `enc_password` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/net/remove.rs:48:38 [INFO] [stdout] | [INFO] [stdout] 48 | .header("Authorization", String::from(format!("Bearer {}", token))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Bearer {}", token)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/net/signup.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | if name == "" || surname == "" || email == "" || password == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/net/signup.rs:33:26 [INFO] [stdout] | [INFO] [stdout] 33 | if name == "" || surname == "" || email == "" || password == "" { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `surname.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/net/signup.rs:33:43 [INFO] [stdout] | [INFO] [stdout] 33 | if name == "" || surname == "" || email == "" || password == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `email.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/net/signup.rs:33:58 [INFO] [stdout] | [INFO] [stdout] 33 | if name == "" || surname == "" || email == "" || password == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `password.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/net/singout.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | if email == "".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `reqwest::Client` [INFO] [stdout] --> src/net.rs:24:27 [INFO] [stdout] | [INFO] [stdout] 24 | Ok(client) => reqwest::Client::from(client), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `reqwest::Client::from()`: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/utilities/file.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 23 | let f = fs::File::create(full_path)?; [INFO] [stdout] | ------------------------------------- unnecessary `let` binding [INFO] [stdout] 24 | f [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 23 ~ [INFO] [stdout] 24 ~ fs::File::create(full_path)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/utilities.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 23 - let _ = std::io::stdout().flush().unwrap(); [INFO] [stdout] 23 + std::io::stdout().flush().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `str::repeat` using iterators [INFO] [stdout] --> src/utilities.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / std::iter::repeat("-") [INFO] [stdout] 65 | | .take(content.len()) [INFO] [stdout] 66 | | .collect::() [INFO] [stdout] | |________________________________^ help: try: `"-".repeat(content.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_str_repeat [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/utilities.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / std::iter::repeat("-") [INFO] [stdout] 65 | | .take(content.len()) [INFO] [stdout] | |________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n("-", content.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `str::repeat` using iterators [INFO] [stdout] --> src/utilities.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | / std::iter::repeat("-") [INFO] [stdout] 76 | | .take(content.len()) [INFO] [stdout] 77 | | .collect::() [INFO] [stdout] | |________________________________^ help: try: `"-".repeat(content.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_str_repeat [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/utilities.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | / std::iter::repeat("-") [INFO] [stdout] 76 | | .take(content.len()) [INFO] [stdout] | |________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n("-", content.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/utilities.rs:91:33 [INFO] [stdout] | [INFO] [stdout] 91 | if choice == "y".to_owned() { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 92 | | true [INFO] [stdout] 93 | | } else if choice != "n".to_owned() && default_yes { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/utilities.rs:93:55 [INFO] [stdout] | [INFO] [stdout] 93 | } else if choice != "n".to_owned() && default_yes { [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 94 | | true [INFO] [stdout] 95 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/utilities.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 91 | if choice == "y".to_owned() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `"y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/utilities.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | } else if choice != "n".to_owned() && default_yes { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | true [INFO] [stdout] 95 | | } else { [INFO] [stdout] 96 | | false [INFO] [stdout] 97 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `{ choice != "n".to_owned() && default_yes }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/utilities.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 93 | } else if choice != "n".to_owned() && default_yes { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `"n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/utilities.rs:130:53 [INFO] [stdout] | [INFO] [stdout] 130 | 1 => result += String::from(select_char(String::from(alpha.to_uppercase()))).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `alpha.to_uppercase()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/utilities.rs:131:28 [INFO] [stdout] | [INFO] [stdout] 131 | 2 => result += String::from(select_random_digit()).as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `select_random_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/utilities.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | String::from(result) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utilities.rs:152:30 [INFO] [stdout] | [INFO] [stdout] 152 | result += capitalize(&part).as_str(); [INFO] [stdout] | ^^^^^ help: change this to: `part` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/utilities.rs:176:26 [INFO] [stdout] | [INFO] [stdout] 176 | let is_snake: bool = match snake_re.captures(&host_name) { [INFO] [stdout] | __________________________^ [INFO] [stdout] 177 | | Some(_) => true, [INFO] [stdout] 178 | | None => false, [INFO] [stdout] 179 | | }; [INFO] [stdout] | |_____^ help: try: `snake_re.captures(&host_name).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/utilities.rs:182:35 [INFO] [stdout] | [INFO] [stdout] 182 | return convert_snake_case(String::from(host_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `host_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/utilities.rs:185:26 [INFO] [stdout] | [INFO] [stdout] 185 | let is_camel: bool = match camel_re.captures(&host_name) { [INFO] [stdout] | __________________________^ [INFO] [stdout] 186 | | Some(_) => true, [INFO] [stdout] 187 | | None => false, [INFO] [stdout] 188 | | }; [INFO] [stdout] | |_____^ help: try: `camel_re.captures(&host_name).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/utilities.rs:191:35 [INFO] [stdout] | [INFO] [stdout] 191 | return convert_camel_case(String::from(host_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `host_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 58s [INFO] running `Command { std: "docker" "inspect" "74528933b2d50052ce64d45d53ebcd4ee3d32bdfb291632c4a81746a2cb14890", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "74528933b2d50052ce64d45d53ebcd4ee3d32bdfb291632c4a81746a2cb14890", kill_on_drop: false }` [INFO] [stdout] 74528933b2d50052ce64d45d53ebcd4ee3d32bdfb291632c4a81746a2cb14890