[INFO] cloning repository https://github.com/AZULIRURROZ/correctortcswm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AZULIRURROZ/correctortcswm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAZULIRURROZ%2Fcorrectortcswm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAZULIRURROZ%2Fcorrectortcswm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b4d0a0b54cd390e24f56b6e18025828e2f932c59 [INFO] linting AZULIRURROZ/correctortcswm against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAZULIRURROZ%2Fcorrectortcswm" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/AZULIRURROZ/correctortcswm [INFO] finished tweaking git repo https://github.com/AZULIRURROZ/correctortcswm [INFO] tweaked toml for git repo https://github.com/AZULIRURROZ/correctortcswm written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/AZULIRURROZ/correctortcswm on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/AZULIRURROZ/correctortcswm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded unicode-ident v1.0.16 [INFO] [stderr] Downloaded cc v1.2.14 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6373f8b65064e8c8d016e61686dc7263c1828503dc97479e54132b7f8e70a4b1 [INFO] running `Command { std: "docker" "start" "-a" "6373f8b65064e8c8d016e61686dc7263c1828503dc97479e54132b7f8e70a4b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6373f8b65064e8c8d016e61686dc7263c1828503dc97479e54132b7f8e70a4b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6373f8b65064e8c8d016e61686dc7263c1828503dc97479e54132b7f8e70a4b1", kill_on_drop: false }` [INFO] [stdout] 6373f8b65064e8c8d016e61686dc7263c1828503dc97479e54132b7f8e70a4b1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 65ef1822277a8b9badb6e953d47953dd4e1b1f93a7ef751b661fd278e9d6778a [INFO] running `Command { std: "docker" "start" "-a" "65ef1822277a8b9badb6e953d47953dd4e1b1f93a7ef751b661fd278e9d6778a", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking correctortcswm v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / if tmp_args.len()>1{ [INFO] [stdout] 10 | | if tmp_args.get(1).unwrap().contains("%"){ [INFO] [stdout] 11 | | tmp_result = tmp_args.get(1).unwrap().to_string(); [INFO] [stdout] 12 | | tmp_args.remove(1); [INFO] [stdout] 13 | | } [INFO] [stdout] 14 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 9 ~ if tmp_args.len()>1 [INFO] [stdout] 10 ~ && tmp_args.get(1).unwrap().contains("%"){ [INFO] [stdout] 11 | tmp_result = tmp_args.get(1).unwrap().to_string(); [INFO] [stdout] 12 | tmp_args.remove(1); [INFO] [stdout] 13 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / if tmp_args.len()>1{ [INFO] [stdout] 10 | | if tmp_args.get(1).unwrap().contains("%"){ [INFO] [stdout] 11 | | tmp_result = tmp_args.get(1).unwrap().to_string(); [INFO] [stdout] 12 | | tmp_args.remove(1); [INFO] [stdout] 13 | | } [INFO] [stdout] 14 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 9 ~ if tmp_args.len()>1 [INFO] [stdout] 10 ~ && tmp_args.get(1).unwrap().contains("%"){ [INFO] [stdout] 11 | tmp_result = tmp_args.get(1).unwrap().to_string(); [INFO] [stdout] 12 | tmp_args.remove(1); [INFO] [stdout] 13 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `tmp_args` [INFO] [stdout] --> src/main.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | for i in 1..tmp_args.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 15 - for i in 1..tmp_args.len() { [INFO] [stdout] 15 + for in tmp_args.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `tmp_args` [INFO] [stdout] --> src/main.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | for i in 1..tmp_args.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 15 - for i in 1..tmp_args.len() { [INFO] [stdout] 15 + for in tmp_args.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 29 | if !reg_date_url.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `reg_date_url.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 29 | if !reg_date_url.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `reg_date_url.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | } else if !reg_date_txt.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `reg_date_txt.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | } else if !reg_date_txt.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `reg_date_txt.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 39 | if !reg_title.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `reg_title.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 39 | if !reg_title.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `reg_title.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `reg_date_url` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:30:30 [INFO] [stdout] | [INFO] [stdout] 29 | if !reg_date_url.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 30 | let tmp_match_date = reg_date_url.unwrap().get(1).unwrap().as_str().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `reg_date_url` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:30:30 [INFO] [stdout] | [INFO] [stdout] 29 | if !reg_date_url.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 30 | let tmp_match_date = reg_date_url.unwrap().get(1).unwrap().as_str().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `reg_title` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:40:52 [INFO] [stdout] | [INFO] [stdout] 39 | if !reg_title.is_none() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] 40 | let tmp_match_title: regex::Captures<'_> = reg_title.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `reg_title` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:40:52 [INFO] [stdout] | [INFO] [stdout] 39 | if !reg_title.is_none() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] 40 | let tmp_match_title: regex::Captures<'_> = reg_title.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/main.rs:50:26 [INFO] [stdout] | [INFO] [stdout] 50 | let tmp_last: &str = fun_route.split('/').last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 50 - let tmp_last: &str = fun_route.split('/').last().unwrap(); [INFO] [stdout] 50 + let tmp_last: &str = fun_route.split('/').next_back().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/main.rs:50:26 [INFO] [stdout] | [INFO] [stdout] 50 | let tmp_last: &str = fun_route.split('/').last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 50 - let tmp_last: &str = fun_route.split('/').last().unwrap(); [INFO] [stdout] 50 + let tmp_last: &str = fun_route.split('/').next_back().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.08s [INFO] running `Command { std: "docker" "inspect" "65ef1822277a8b9badb6e953d47953dd4e1b1f93a7ef751b661fd278e9d6778a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "65ef1822277a8b9badb6e953d47953dd4e1b1f93a7ef751b661fd278e9d6778a", kill_on_drop: false }` [INFO] [stdout] 65ef1822277a8b9badb6e953d47953dd4e1b1f93a7ef751b661fd278e9d6778a