[INFO] cloning repository https://github.com/ARelaxedScholar/RustiestLinearAlgebra [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ARelaxedScholar/RustiestLinearAlgebra" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FARelaxedScholar%2FRustiestLinearAlgebra", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FARelaxedScholar%2FRustiestLinearAlgebra'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5e5f790d354c6faf70bd331e38546ef33d00181d [INFO] linting ARelaxedScholar/RustiestLinearAlgebra against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FARelaxedScholar%2FRustiestLinearAlgebra" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ARelaxedScholar/RustiestLinearAlgebra [INFO] finished tweaking git repo https://github.com/ARelaxedScholar/RustiestLinearAlgebra [INFO] tweaked toml for git repo https://github.com/ARelaxedScholar/RustiestLinearAlgebra written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ARelaxedScholar/RustiestLinearAlgebra on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ARelaxedScholar/RustiestLinearAlgebra already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 449f6744f899ab7093bc9113b7fcec261900946259436e1441063b68d3f0e326 [INFO] running `Command { std: "docker" "start" "-a" "449f6744f899ab7093bc9113b7fcec261900946259436e1441063b68d3f0e326", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "449f6744f899ab7093bc9113b7fcec261900946259436e1441063b68d3f0e326", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "449f6744f899ab7093bc9113b7fcec261900946259436e1441063b68d3f0e326", kill_on_drop: false }` [INFO] [stdout] 449f6744f899ab7093bc9113b7fcec261900946259436e1441063b68d3f0e326 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b77b0c5ddfbad528400731bbc328ce96a9e941b01691315a7c64751a598ad2c6 [INFO] running `Command { std: "docker" "start" "-a" "b77b0c5ddfbad528400731bbc328ce96a9e941b01691315a7c64751a598ad2c6", kill_on_drop: false }` [INFO] [stderr] Checking rustiest_linear_algebra v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/linear_algebra_number/mod.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | / /// ``` [INFO] [stdout] 95 | | [INFO] [stdout] | |_^ [INFO] [stdout] 96 | pub fn is_nan(&self) -> bool { [INFO] [stdout] | ------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/linear_algebra_number/mod.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | / /// ``` [INFO] [stdout] 95 | | [INFO] [stdout] | |_^ [INFO] [stdout] 96 | pub fn is_nan(&self) -> bool { [INFO] [stdout] | ------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Vector` is never constructed [INFO] [stdout] --> src/vector/mod.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct Vector{ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Vector` is never constructed [INFO] [stdout] --> src/vector/mod.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct Vector{ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/linear_algebra_number/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | !(((*some_integer).abs()) > MAX_EXACT_INT) // The max is also the minimum, since f64 in IEEE754 is signed magnitude. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((*some_integer).abs()) <= MAX_EXACT_INT)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/linear_algebra_number/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | !(((*some_integer).abs()) > MAX_EXACT_INT) // The max is also the minimum, since f64 in IEEE754 is signed magnitude. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((*some_integer).abs()) <= MAX_EXACT_INT)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/linear_algebra_number/mod.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | / match self{ [INFO] [stdout] 98 | | NaN => true, [INFO] [stdout] 99 | | _ => false [INFO] [stdout] 100 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 97 - match self{ [INFO] [stdout] 98 - NaN => true, [INFO] [stdout] 99 - _ => false [INFO] [stdout] 100 - } [INFO] [stdout] 97 + matches!(self, NaN) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/linear_algebra_number/mod.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | / match self{ [INFO] [stdout] 98 | | NaN => true, [INFO] [stdout] 99 | | _ => false [INFO] [stdout] 100 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 97 - match self{ [INFO] [stdout] 98 - NaN => true, [INFO] [stdout] 99 - _ => false [INFO] [stdout] 100 - } [INFO] [stdout] 97 + matches!(self, NaN) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `f64` [INFO] [stdout] --> src/linear_algebra_number/mod.rs:344:25 [INFO] [stdout] | [INFO] [stdout] 344 | (f64::from(value_self.trunc())) == (*other as f64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `f64::from()`: `value_self.trunc()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `f64` [INFO] [stdout] --> src/linear_algebra_number/mod.rs:344:25 [INFO] [stdout] | [INFO] [stdout] 344 | (f64::from(value_self.trunc())) == (*other as f64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `f64::from()`: `value_self.trunc()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/linear_algebra_number/mod.rs:365:1 [INFO] [stdout] | [INFO] [stdout] 365 | / impl PartialOrd for LinAlgNumber { [INFO] [stdout] 366 | | fn partial_cmp(&self, other: &LinAlgNumber) -> Option { [INFO] [stdout] 367 | | match (self, other) { [INFO] [stdout] 368 | | (Float64(value_self), Float64(value_other)) => value_self.partial_cmp(value_other), [INFO] [stdout] ... | [INFO] [stdout] 382 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 366 - fn partial_cmp(&self, other: &LinAlgNumber) -> Option { [INFO] [stdout] 367 - match (self, other) { [INFO] [stdout] 368 - (Float64(value_self), Float64(value_other)) => value_self.partial_cmp(value_other), [INFO] [stdout] 369 - (Float32(value_self), Float32(value_other)) => { [INFO] [stdout] 370 - (f64::from(*value_self)).partial_cmp(&f64::from(*value_other)) [INFO] [stdout] 371 - } [INFO] [stdout] 372 - (Float64(value_self), Float32(value_other)) => { [INFO] [stdout] 373 - value_self.partial_cmp(&f64::from(*value_other)) [INFO] [stdout] 374 - } [INFO] [stdout] 375 - (Float32(value_self), Float64(value_other)) => { [INFO] [stdout] 376 - (f64::from(*value_self)).partial_cmp(value_other) [INFO] [stdout] 377 - } [INFO] [stdout] 378 - (NaN, _) => None, [INFO] [stdout] 379 - (_, NaN) => None, [INFO] [stdout] 380 - } [INFO] [stdout] 381 - } [INFO] [stdout] 366 + fn partial_cmp(&self, other: &LinAlgNumber) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/linear_algebra_number/mod.rs:365:1 [INFO] [stdout] | [INFO] [stdout] 365 | / impl PartialOrd for LinAlgNumber { [INFO] [stdout] 366 | | fn partial_cmp(&self, other: &LinAlgNumber) -> Option { [INFO] [stdout] 367 | | match (self, other) { [INFO] [stdout] 368 | | (Float64(value_self), Float64(value_other)) => value_self.partial_cmp(value_other), [INFO] [stdout] ... | [INFO] [stdout] 382 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 366 - fn partial_cmp(&self, other: &LinAlgNumber) -> Option { [INFO] [stdout] 367 - match (self, other) { [INFO] [stdout] 368 - (Float64(value_self), Float64(value_other)) => value_self.partial_cmp(value_other), [INFO] [stdout] 369 - (Float32(value_self), Float32(value_other)) => { [INFO] [stdout] 370 - (f64::from(*value_self)).partial_cmp(&f64::from(*value_other)) [INFO] [stdout] 371 - } [INFO] [stdout] 372 - (Float64(value_self), Float32(value_other)) => { [INFO] [stdout] 373 - value_self.partial_cmp(&f64::from(*value_other)) [INFO] [stdout] 374 - } [INFO] [stdout] 375 - (Float32(value_self), Float64(value_other)) => { [INFO] [stdout] 376 - (f64::from(*value_self)).partial_cmp(value_other) [INFO] [stdout] 377 - } [INFO] [stdout] 378 - (NaN, _) => None, [INFO] [stdout] 379 - (_, NaN) => None, [INFO] [stdout] 380 - } [INFO] [stdout] 381 - } [INFO] [stdout] 366 + fn partial_cmp(&self, other: &LinAlgNumber) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s [INFO] running `Command { std: "docker" "inspect" "b77b0c5ddfbad528400731bbc328ce96a9e941b01691315a7c64751a598ad2c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b77b0c5ddfbad528400731bbc328ce96a9e941b01691315a7c64751a598ad2c6", kill_on_drop: false }` [INFO] [stdout] b77b0c5ddfbad528400731bbc328ce96a9e941b01691315a7c64751a598ad2c6