[INFO] cloning repository https://github.com/A6GibKm/gir-checker [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/A6GibKm/gir-checker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FA6GibKm%2Fgir-checker", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FA6GibKm%2Fgir-checker'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c81a06814aceb9eb898bd620dd24371ad8b55615 [INFO] linting A6GibKm/gir-checker against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FA6GibKm%2Fgir-checker" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/A6GibKm/gir-checker [INFO] finished tweaking git repo https://github.com/A6GibKm/gir-checker [INFO] tweaked toml for git repo https://github.com/A6GibKm/gir-checker written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/A6GibKm/gir-checker on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/A6GibKm/gir-checker already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/bilelmoussaoui/gir-parser` [INFO] [stderr] Updating git repository `https://github.com/ImJeremyHe/xmlserde` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.7 [INFO] [stderr] Downloaded clap_builder v4.5.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7bc542194a2b7e1f60ddd9b13d16e535182eeb3e4c9f10f2198efad310dfea88 [INFO] running `Command { std: "docker" "start" "-a" "7bc542194a2b7e1f60ddd9b13d16e535182eeb3e4c9f10f2198efad310dfea88", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7bc542194a2b7e1f60ddd9b13d16e535182eeb3e4c9f10f2198efad310dfea88", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7bc542194a2b7e1f60ddd9b13d16e535182eeb3e4c9f10f2198efad310dfea88", kill_on_drop: false }` [INFO] [stdout] 7bc542194a2b7e1f60ddd9b13d16e535182eeb3e4c9f10f2198efad310dfea88 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6423c6c234eccb6c58aa7e915b4dbc232e6a2b2e4bcfb86e423500716a14c57b [INFO] running `Command { std: "docker" "start" "-a" "6423c6c234eccb6c58aa7e915b4dbc232e6a2b2e4bcfb86e423500716a14c57b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling xmlserde_derives v0.9.0 (https://github.com/ImJeremyHe/xmlserde#3c2e2bc2) [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking quick-xml v0.32.0 [INFO] [stderr] Checking xmlserde v0.9.0 (https://github.com/ImJeremyHe/xmlserde#3c2e2bc2) [INFO] [stderr] Checking gir-parser v0.1.0 (https://github.com/bilelmoussaoui/gir-parser#ce655cb4) [INFO] [stderr] Checking gir-checker v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait `NewTrait` is never used [INFO] [stdout] --> src/parameter.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | trait NewTrait: gir_parser::prelude::FunctionLike + gir_parser::prelude::Info {} [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `class` and `parent` are never read [INFO] [stdout] --> src/parameter.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct ParameterChecker<'a> { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 10 | class: &'a Class, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 11 | parameter: &'a Parameter, [INFO] [stdout] 12 | parent: &'a dyn FunctionLike, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/property.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 48 | if !method.get_property().is_some_and(|g| g == getter) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `method.get_property().is_none_or(|g| g != getter)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/property.rs:72:24 [INFO] [stdout] | [INFO] [stdout] 72 | if !method.set_property().is_some_and(|s| s == setter) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `method.set_property().is_none_or(|s| s != setter)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/warning.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | / impl PartialOrd for Warning { [INFO] [stdout] 31 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 32 | | Some(self.severity.cmp(&other.severity)) [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 31 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 32 - Some(self.severity.cmp(&other.severity)) [INFO] [stdout] 33 - } [INFO] [stdout] 31 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `NewTrait` is never used [INFO] [stdout] --> src/parameter.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | trait NewTrait: gir_parser::prelude::FunctionLike + gir_parser::prelude::Info {} [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `class` and `parent` are never read [INFO] [stdout] --> src/parameter.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct ParameterChecker<'a> { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 10 | class: &'a Class, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 11 | parameter: &'a Parameter, [INFO] [stdout] 12 | parent: &'a dyn FunctionLike, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/property.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 48 | if !method.get_property().is_some_and(|g| g == getter) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `method.get_property().is_none_or(|g| g != getter)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/property.rs:72:24 [INFO] [stdout] | [INFO] [stdout] 72 | if !method.set_property().is_some_and(|s| s == setter) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `method.set_property().is_none_or(|s| s != setter)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/warning.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | / impl PartialOrd for Warning { [INFO] [stdout] 31 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 32 | | Some(self.severity.cmp(&other.severity)) [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 31 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 32 - Some(self.severity.cmp(&other.severity)) [INFO] [stdout] 33 - } [INFO] [stdout] 31 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.42s [INFO] running `Command { std: "docker" "inspect" "6423c6c234eccb6c58aa7e915b4dbc232e6a2b2e4bcfb86e423500716a14c57b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6423c6c234eccb6c58aa7e915b4dbc232e6a2b2e4bcfb86e423500716a14c57b", kill_on_drop: false }` [INFO] [stdout] 6423c6c234eccb6c58aa7e915b4dbc232e6a2b2e4bcfb86e423500716a14c57b