[INFO] cloning repository https://github.com/5imonk/sdo-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/5imonk/sdo-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F5imonk%2Fsdo-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F5imonk%2Fsdo-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bb7117f6a9d643e29e2ae197f240eec6f28d084d [INFO] linting 5imonk/sdo-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F5imonk%2Fsdo-rust" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/5imonk/sdo-rust [INFO] finished tweaking git repo https://github.com/5imonk/sdo-rust [INFO] tweaked toml for git repo https://github.com/5imonk/sdo-rust written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/5imonk/sdo-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/5imonk/sdo-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pyo3-macros v0.21.2 [INFO] [stderr] Downloaded pyo3-build-config v0.21.2 [INFO] [stderr] Downloaded zmij v1.0.14 [INFO] [stderr] Downloaded pyo3-ffi v0.21.2 [INFO] [stderr] Downloaded numpy v0.21.0 [INFO] [stderr] Downloaded pyo3-macros-backend v0.21.2 [INFO] [stderr] Downloaded pyo3 v0.21.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] da210df77842b4a9e8d259e5adddee5242f283ea9dc79bec9a66d4181e11f5e0 [INFO] running `Command { std: "docker" "start" "-a" "da210df77842b4a9e8d259e5adddee5242f283ea9dc79bec9a66d4181e11f5e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "da210df77842b4a9e8d259e5adddee5242f283ea9dc79bec9a66d4181e11f5e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "da210df77842b4a9e8d259e5adddee5242f283ea9dc79bec9a66d4181e11f5e0", kill_on_drop: false }` [INFO] [stdout] da210df77842b4a9e8d259e5adddee5242f283ea9dc79bec9a66d4181e11f5e0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 932ea445383aabb8e38aff670f1b4ea877043dcac4720320ff473d5874724a45 [INFO] running `Command { std: "docker" "start" "-a" "932ea445383aabb8e38aff670f1b4ea877043dcac4720320ff473d5874724a45", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.104 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling zmij v1.0.14 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling matrixmultiply v0.3.10 [INFO] [stderr] Compiling portable-atomic v1.13.0 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Compiling indoc v2.0.7 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking unindent v0.2.4 [INFO] [stderr] Checking clap_lex v0.7.7 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Compiling pyo3-build-config v0.21.2 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling syn v2.0.112 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Compiling pyo3-ffi v0.21.2 [INFO] [stderr] Compiling pyo3 v0.21.2 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling pyo3-macros-backend v0.21.2 [INFO] [stderr] Compiling zerocopy-derive v0.8.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling pyo3-macros v0.21.2 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking numpy v0.21.0 [INFO] [stderr] Checking sdo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/obset.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | distance_metric: distance_metric, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `distance_metric` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/obset.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | minkowski_p: minkowski_p, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `minkowski_p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/obset.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | distance_metric: distance_metric, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `distance_metric` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/obset.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | minkowski_p: minkowski_p, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `minkowski_p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sdostream_impl.rs:316:17 [INFO] [stdout] | [INFO] [stdout] 316 | time: time, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sdostream_impl.rs:316:17 [INFO] [stdout] | [INFO] [stdout] 316 | time: time, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/obset.rs:496:9 [INFO] [stdout] | [INFO] [stdout] 496 | /// Uses heaps for O(k log k) per point instead of O(k²). [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 496 | /// Uses heaps for O(k log k) per point instead of O(k²). [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.map(..)` [INFO] [stdout] --> src/obset_clust.rs:126:14 [INFO] [stdout] | [INFO] [stdout] 126 | .filter_map(|(cluster_idx, cluster_set)| { [INFO] [stdout] | ______________^ [INFO] [stdout] 127 | | // Berechne normalisierte Cluster-Scores für alle Observer im Cluster [INFO] [stdout] 128 | | let label_scores = self.get_normalized_cluster_scores( [INFO] [stdout] 129 | | &cluster_set.iter().cloned().collect::>(), [INFO] [stdout] ... | [INFO] [stdout] 147 | | Some((cluster_idx, max_score, candidate_label)) [INFO] [stdout] 148 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual saturating arithmetic [INFO] [stdout] --> src/obset_clust.rs:178:31 [INFO] [stdout] | [INFO] [stdout] 178 | self.last_label = connected_components.len().checked_sub(1).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `saturating_sub`: `connected_components.len().saturating_sub(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic [INFO] [stdout] = note: `#[warn(clippy::manual_saturating_arithmetic)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/obset_clust.rs:334:19 [INFO] [stdout] | [INFO] [stdout] 334 | clusters: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 334 - clusters: &Vec>, [INFO] [stdout] 334 + clusters: &[HashSet], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/obset_strcl.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn learn_clustering_time( [INFO] [stdout] 9 | | &mut self, [INFO] [stdout] 10 | | chi: usize, [INFO] [stdout] 11 | | zeta: f64, [INFO] [stdout] ... | [INFO] [stdout] 16 | | batch_age: f64, [INFO] [stdout] 17 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/obset_strcl.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 47 | clusters: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 47 - clusters: &Vec>, [INFO] [stdout] 47 + clusters: &[HashSet], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/sdo_impl.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 37 | / let instance = Self { [INFO] [stdout] 38 | | observers: ObserverSet::new(distance_metric, minkowski_p), [INFO] [stdout] 39 | | rho, [INFO] [stdout] 40 | | x, [INFO] [stdout] 41 | | k, [INFO] [stdout] 42 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 43 | instance [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 37 ~ [INFO] [stdout] 38 ~ Self { [INFO] [stdout] 39 + observers: ObserverSet::new(distance_metric, minkowski_p), [INFO] [stdout] 40 + rho, [INFO] [stdout] 41 + x, [INFO] [stdout] 42 + k, [INFO] [stdout] 43 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/obset.rs:496:9 [INFO] [stdout] | [INFO] [stdout] 496 | /// Uses heaps for O(k log k) per point instead of O(k²). [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 496 | /// Uses heaps for O(k log k) per point instead of O(k²). [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sdoclust_impl.rs:132:10 [INFO] [stdout] | [INFO] [stdout] 132 | ) -> PyResult<(Py>, Vec, Vec)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.map(..)` [INFO] [stdout] --> src/obset_clust.rs:126:14 [INFO] [stdout] | [INFO] [stdout] 126 | .filter_map(|(cluster_idx, cluster_set)| { [INFO] [stdout] | ______________^ [INFO] [stdout] 127 | | // Berechne normalisierte Cluster-Scores für alle Observer im Cluster [INFO] [stdout] 128 | | let label_scores = self.get_normalized_cluster_scores( [INFO] [stdout] 129 | | &cluster_set.iter().cloned().collect::>(), [INFO] [stdout] ... | [INFO] [stdout] 147 | | Some((cluster_idx, max_score, candidate_label)) [INFO] [stdout] 148 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual saturating arithmetic [INFO] [stdout] --> src/obset_clust.rs:178:31 [INFO] [stdout] | [INFO] [stdout] 178 | self.last_label = connected_components.len().checked_sub(1).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `saturating_sub`: `connected_components.len().saturating_sub(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic [INFO] [stdout] = note: `#[warn(clippy::manual_saturating_arithmetic)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/obset_clust.rs:334:19 [INFO] [stdout] | [INFO] [stdout] 334 | clusters: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 334 - clusters: &Vec>, [INFO] [stdout] 334 + clusters: &[HashSet], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/obset_strcl.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn learn_clustering_time( [INFO] [stdout] 9 | | &mut self, [INFO] [stdout] 10 | | chi: usize, [INFO] [stdout] 11 | | zeta: f64, [INFO] [stdout] ... | [INFO] [stdout] 16 | | batch_age: f64, [INFO] [stdout] 17 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/obset_strcl.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 47 | clusters: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 47 - clusters: &Vec>, [INFO] [stdout] 47 + clusters: &[HashSet], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/sdoclust_impl.rs:315:40 [INFO] [stdout] | [INFO] [stdout] 315 | pub fn predict_impl(&self, points: &Vec>, learn: Option) -> Vec<(i32, f64)> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 315 - pub fn predict_impl(&self, points: &Vec>, learn: Option) -> Vec<(i32, f64)> { [INFO] [stdout] 315 + pub fn predict_impl(&self, points: &[Vec], learn: Option) -> Vec<(i32, f64)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sdostrcl_impl.rs:128:10 [INFO] [stdout] | [INFO] [stdout] 128 | ) -> PyResult<(Py>, Vec, Vec)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/sdo_impl.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 37 | / let instance = Self { [INFO] [stdout] 38 | | observers: ObserverSet::new(distance_metric, minkowski_p), [INFO] [stdout] 39 | | rho, [INFO] [stdout] 40 | | x, [INFO] [stdout] 41 | | k, [INFO] [stdout] 42 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 43 | instance [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 37 ~ [INFO] [stdout] 38 ~ Self { [INFO] [stdout] 39 + observers: ObserverSet::new(distance_metric, minkowski_p), [INFO] [stdout] 40 + rho, [INFO] [stdout] 41 + x, [INFO] [stdout] 42 + k, [INFO] [stdout] 43 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/sdostrcl_impl.rs:177:42 [INFO] [stdout] | [INFO] [stdout] 177 | pub fn learn_point(&mut self, point: &Vec, time: f64) -> (i32, f64) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 177 - pub fn learn_point(&mut self, point: &Vec, time: f64) -> (i32, f64) { [INFO] [stdout] 177 + pub fn learn_point(&mut self, point: &[f64], time: f64) -> (i32, f64) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref.map(...)` does nothing [INFO] [stdout] --> src/sdostrcl_impl.rs:300:31 [INFO] [stdout] | [INFO] [stdout] 300 | .filter_map(|opt| opt.as_ref().map(|v| v.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `opt.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/sdostrcl_impl.rs:342:18 [INFO] [stdout] | [INFO] [stdout] 342 | .zip(predicted_labels.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 342 - .zip(predicted_labels.into_iter()) [INFO] [stdout] 342 + .zip(predicted_labels) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/sdostrcl_impl.rs:400:5 [INFO] [stdout] | [INFO] [stdout] 400 | / pub fn new_for_benchmark( [INFO] [stdout] 401 | | k: usize, [INFO] [stdout] 402 | | t_fading: f64, [INFO] [stdout] 403 | | t_sampling: f64, [INFO] [stdout] ... | [INFO] [stdout] 410 | | dimension: usize, [INFO] [stdout] 411 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sdoclust_impl.rs:132:10 [INFO] [stdout] | [INFO] [stdout] 132 | ) -> PyResult<(Py>, Vec, Vec)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sdostream_impl.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 89 | if !data.is_some() && !dimension.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `data.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sdostream_impl.rs:89:31 [INFO] [stdout] | [INFO] [stdout] 89 | if !data.is_some() && !dimension.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `dimension.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sdostream_impl.rs:232:10 [INFO] [stdout] | [INFO] [stdout] 232 | ) -> PyResult, f64, f64, f64, bool, Option)>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/sdoclust_impl.rs:315:40 [INFO] [stdout] | [INFO] [stdout] 315 | pub fn predict_impl(&self, points: &Vec>, learn: Option) -> Vec<(i32, f64)> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 315 - pub fn predict_impl(&self, points: &Vec>, learn: Option) -> Vec<(i32, f64)> { [INFO] [stdout] 315 + pub fn predict_impl(&self, points: &[Vec], learn: Option) -> Vec<(i32, f64)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sdostrcl_impl.rs:128:10 [INFO] [stdout] | [INFO] [stdout] 128 | ) -> PyResult<(Py>, Vec, Vec)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/sdostream_impl.rs:343:16 [INFO] [stdout] | [INFO] [stdout] 343 | point: &Vec, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 343 - point: &Vec, [INFO] [stdout] 343 + point: &[f64], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref.map(...)` does nothing [INFO] [stdout] --> src/sdostream_impl.rs:448:31 [INFO] [stdout] | [INFO] [stdout] 448 | .filter_map(|opt| opt.as_ref().map(|v| v.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `opt.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/sdostream_impl.rs:469:18 [INFO] [stdout] | [INFO] [stdout] 469 | .zip(final_all_neighbors_batch.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 469 - .zip(final_all_neighbors_batch.into_iter()) [INFO] [stdout] 469 + .zip(final_all_neighbors_batch) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/sdostream_impl.rs:586:16 [INFO] [stdout] | [INFO] [stdout] 586 | point: &Vec, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 586 - point: &Vec, [INFO] [stdout] 586 + point: &[f64], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/sdostrcl_impl.rs:177:42 [INFO] [stdout] | [INFO] [stdout] 177 | pub fn learn_point(&mut self, point: &Vec, time: f64) -> (i32, f64) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 177 - pub fn learn_point(&mut self, point: &Vec, time: f64) -> (i32, f64) { [INFO] [stdout] 177 + pub fn learn_point(&mut self, point: &[f64], time: f64) -> (i32, f64) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref.map(...)` does nothing [INFO] [stdout] --> src/sdostrcl_impl.rs:300:31 [INFO] [stdout] | [INFO] [stdout] 300 | .filter_map(|opt| opt.as_ref().map(|v| v.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `opt.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:178:31 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn compute_median(values: &Vec) -> f64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 178 ~ pub fn compute_median(values: &[f64]) -> f64 { [INFO] [stdout] 179 ~ let mut sorted_values = values.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/utils.rs:182:8 [INFO] [stdout] | [INFO] [stdout] 182 | if len % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `len.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/sdostrcl_impl.rs:342:18 [INFO] [stdout] | [INFO] [stdout] 342 | .zip(predicted_labels.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 342 - .zip(predicted_labels.into_iter()) [INFO] [stdout] 342 + .zip(predicted_labels) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/sdostrcl_impl.rs:400:5 [INFO] [stdout] | [INFO] [stdout] 400 | / pub fn new_for_benchmark( [INFO] [stdout] 401 | | k: usize, [INFO] [stdout] 402 | | t_fading: f64, [INFO] [stdout] 403 | | t_sampling: f64, [INFO] [stdout] ... | [INFO] [stdout] 410 | | dimension: usize, [INFO] [stdout] 411 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sdostream_impl.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 89 | if !data.is_some() && !dimension.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `data.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sdostream_impl.rs:89:31 [INFO] [stdout] | [INFO] [stdout] 89 | if !data.is_some() && !dimension.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `dimension.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sdostream_impl.rs:232:10 [INFO] [stdout] | [INFO] [stdout] 232 | ) -> PyResult, f64, f64, f64, bool, Option)>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/sdostream_impl.rs:343:16 [INFO] [stdout] | [INFO] [stdout] 343 | point: &Vec, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 343 - point: &Vec, [INFO] [stdout] 343 + point: &[f64], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref.map(...)` does nothing [INFO] [stdout] --> src/sdostream_impl.rs:448:31 [INFO] [stdout] | [INFO] [stdout] 448 | .filter_map(|opt| opt.as_ref().map(|v| v.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `opt.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/sdostream_impl.rs:469:18 [INFO] [stdout] | [INFO] [stdout] 469 | .zip(final_all_neighbors_batch.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 469 - .zip(final_all_neighbors_batch.into_iter()) [INFO] [stdout] 469 + .zip(final_all_neighbors_batch) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/sdostream_impl.rs:586:16 [INFO] [stdout] | [INFO] [stdout] 586 | point: &Vec, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 586 - point: &Vec, [INFO] [stdout] 586 + point: &[f64], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:178:31 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn compute_median(values: &Vec) -> f64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 178 ~ pub fn compute_median(values: &[f64]) -> f64 { [INFO] [stdout] 179 ~ let mut sorted_values = values.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/utils.rs:182:8 [INFO] [stdout] | [INFO] [stdout] 182 | if len % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `len.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/distance_simd.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 93 | let obs1 = vec![0.0, 0.0, 0.0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0.0, 0.0, 0.0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/distance_simd.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 94 | let obs2 = vec![1.0, 2.0, 3.0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[1.0, 2.0, 3.0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/distance_simd.rs:95:20 [INFO] [stdout] | [INFO] [stdout] 95 | let obs3 = vec![2.0, 4.0, 6.0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[2.0, 4.0, 6.0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.22s [INFO] running `Command { std: "docker" "inspect" "932ea445383aabb8e38aff670f1b4ea877043dcac4720320ff473d5874724a45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "932ea445383aabb8e38aff670f1b4ea877043dcac4720320ff473d5874724a45", kill_on_drop: false }` [INFO] [stdout] 932ea445383aabb8e38aff670f1b4ea877043dcac4720320ff473d5874724a45