[INFO] cloning repository https://github.com/5DPixel/MicroCVM-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/5DPixel/MicroCVM-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F5DPixel%2FMicroCVM-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F5DPixel%2FMicroCVM-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e35226ce58c2e3a5e663602a706ab1b2e54d1934 [INFO] linting 5DPixel/MicroCVM-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F5DPixel%2FMicroCVM-rs" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/5DPixel/MicroCVM-rs [INFO] finished tweaking git repo https://github.com/5DPixel/MicroCVM-rs [INFO] tweaked toml for git repo https://github.com/5DPixel/MicroCVM-rs written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/5DPixel/MicroCVM-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/5DPixel/MicroCVM-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded proc-macro-crate v3.3.0 [INFO] [stderr] Downloaded gethostname v0.4.3 [INFO] [stderr] Downloaded cursor-icon v1.1.0 [INFO] [stderr] Downloaded profiling v1.0.16 [INFO] [stderr] Downloaded ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Downloaded wayland-sys v0.31.6 [INFO] [stderr] Downloaded page_size v0.5.0 [INFO] [stderr] Downloaded wayland-cursor v0.31.8 [INFO] [stderr] Downloaded wayland-scanner v0.31.6 [INFO] [stderr] Downloaded rusttype v0.9.3 [INFO] [stderr] Downloaded wayland-protocols-wlr v0.3.6 [INFO] [stderr] Downloaded ab_glyph v0.2.29 [INFO] [stderr] Downloaded clap v4.5.38 [INFO] [stderr] Downloaded xml-rs v0.8.26 [INFO] [stderr] Downloaded fuser v0.13.0 [INFO] [stderr] Downloaded widestring v1.2.0 [INFO] [stderr] Downloaded itertools v0.11.0 [INFO] [stderr] Downloaded ttf-parser v0.15.2 [INFO] [stderr] Downloaded owned_ttf_parser v0.15.2 [INFO] [stderr] Downloaded clap_builder v4.5.38 [INFO] [stderr] Downloaded winnow v0.7.6 [INFO] [stderr] Downloaded owned_ttf_parser v0.25.0 [INFO] [stderr] Downloaded wayland-protocols v0.32.6 [INFO] [stderr] Downloaded quick-xml v0.37.4 [INFO] [stderr] Downloaded x11rb v0.13.1 [INFO] [stderr] Downloaded toml_edit v0.22.24 [INFO] [stderr] Downloaded cc v1.2.19 [INFO] [stderr] Downloaded wayland-backend v0.3.8 [INFO] [stderr] Downloaded wayland-client v0.31.8 [INFO] [stderr] Downloaded wayland-protocols-plasma v0.3.6 [INFO] [stderr] Downloaded zerocopy v0.6.6 [INFO] [stderr] Downloaded cdfs v0.2.3 [INFO] [stderr] Downloaded pixels v0.15.0 [INFO] [stderr] Downloaded memmap2 v0.9.5 [INFO] [stderr] Downloaded x11rb-protocol v0.13.1 [INFO] [stderr] Downloaded winit v0.30.9 [INFO] [stderr] Downloaded zerocopy-derive v0.6.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3bc71e688fdf243c1c6b0448e7ed3aa0da3e3f1b8fff7e68d281631a92ca2979 [INFO] running `Command { std: "docker" "start" "-a" "3bc71e688fdf243c1c6b0448e7ed3aa0da3e3f1b8fff7e68d281631a92ca2979", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3bc71e688fdf243c1c6b0448e7ed3aa0da3e3f1b8fff7e68d281631a92ca2979", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bc71e688fdf243c1c6b0448e7ed3aa0da3e3f1b8fff7e68d281631a92ca2979", kill_on_drop: false }` [INFO] [stdout] 3bc71e688fdf243c1c6b0448e7ed3aa0da3e3f1b8fff7e68d281631a92ca2979 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 637d21847f641c0f090e89411a2f0e9a8231999f66121f20b50b07ed38c5e660 [INFO] running `Command { std: "docker" "start" "-a" "637d21847f641c0f090e89411a2f0e9a8231999f66121f20b50b07ed38c5e660", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.94 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling libc v0.2.171 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking libloading v0.8.6 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling wayland-sys v0.31.6 [INFO] [stderr] Compiling cc v1.2.19 [INFO] [stderr] Compiling wayland-client v0.31.8 [INFO] [stderr] Compiling quick-xml v0.37.4 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking bytemuck v1.22.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Compiling ash v0.37.3+1.3.251 [INFO] [stderr] Compiling khronos-egl v6.0.0 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking allocator-api2 v0.2.21 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking gpu-descriptor-types v0.1.2 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Compiling wgpu-hal v0.19.5 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking hexf-parse v0.2.1 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking unicode-xid v0.2.6 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking wgpu-types v0.19.2 [INFO] [stderr] Compiling wgpu-core v0.19.4 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Checking cursor-icon v1.1.0 [INFO] [stderr] Checking profiling v1.0.16 [INFO] [stderr] Compiling time-core v0.1.4 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Checking renderdoc-sys v1.1.0 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking glow v0.13.1 [INFO] [stderr] Checking xcursor v0.3.8 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling wayland-scanner v0.31.6 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking memmap2 v0.9.5 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling time-macros v0.2.22 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling wgpu v0.19.4 [INFO] [stderr] Compiling fuser v0.13.0 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling anyhow v1.0.98 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling winit v0.30.9 [INFO] [stderr] Checking wide v0.7.32 [INFO] [stderr] Checking clap_builder v4.5.38 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking gpu-descriptor v0.2.4 [INFO] [stderr] Checking page_size v0.5.0 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling wayland-backend v0.3.8 [INFO] [stderr] Checking ttf-parser v0.15.2 [INFO] [stderr] Checking x11rb-protocol v0.13.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking dpi v0.1.1 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking owned_ttf_parser v0.25.0 [INFO] [stderr] Checking ab_glyph v0.2.29 [INFO] [stderr] Checking pollster v0.3.0 [INFO] [stderr] Checking ultraviolet v0.9.2 [INFO] [stderr] Checking owned_ttf_parser v0.15.2 [INFO] [stderr] Checking rusttype v0.9.3 [INFO] [stderr] Checking simple_logger v4.3.3 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling zerocopy-derive v0.6.6 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Checking zerocopy v0.6.6 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking naga v0.19.2 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking clap v4.5.38 [INFO] [stderr] Checking cdfs v0.2.3 [INFO] [stderr] Checking wayland-protocols v0.32.6 [INFO] [stderr] Checking wayland-cursor v0.31.8 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.6 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.6 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking pixels v0.15.0 [INFO] [stderr] Checking microcvm-rs v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constant `STACK_SIZE` is never used [INFO] [stdout] --> src/cpu.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const STACK_SIZE: usize = 0x8000; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `HEAP_OFFSET` is never used [INFO] [stdout] --> src/cpu.rs:24:7 [INFO] [stdout] | [INFO] [stdout] 24 | const HEAP_OFFSET: usize = STACK_OFFSET + STACK_SIZE; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `STACK_SIZE` is never used [INFO] [stdout] --> src/cpu.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const STACK_SIZE: usize = 0x8000; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `HEAP_SIZE` is never used [INFO] [stdout] --> src/cpu.rs:25:7 [INFO] [stdout] | [INFO] [stdout] 25 | const HEAP_SIZE: usize = MEM_TOTAL - HEAP_OFFSET; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `HEAP_OFFSET` is never used [INFO] [stdout] --> src/cpu.rs:24:7 [INFO] [stdout] | [INFO] [stdout] 24 | const HEAP_OFFSET: usize = STACK_OFFSET + STACK_SIZE; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `HEAP_SIZE` is never used [INFO] [stdout] --> src/cpu.rs:25:7 [INFO] [stdout] | [INFO] [stdout] 25 | const HEAP_SIZE: usize = MEM_TOTAL - HEAP_OFFSET; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:266:36 [INFO] [stdout] | [INFO] [stdout] 266 | self.registers[Register::index(reg) as usize] += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(reg)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:272:37 [INFO] [stdout] | [INFO] [stdout] 272 | let dst_index = Register::index(dst) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:266:36 [INFO] [stdout] | [INFO] [stdout] 266 | self.registers[Register::index(reg) as usize] += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(reg)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:272:37 [INFO] [stdout] | [INFO] [stdout] 272 | let dst_index = Register::index(dst) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:279:45 [INFO] [stdout] | [INFO] [stdout] 279 | ... let src_index = Register::index(src) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(src)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:279:45 [INFO] [stdout] | [INFO] [stdout] 279 | ... let src_index = Register::index(src) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(src)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:291:37 [INFO] [stdout] | [INFO] [stdout] 291 | let dst_index = Register::index(dst) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:291:37 [INFO] [stdout] | [INFO] [stdout] 291 | let dst_index = Register::index(dst) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:298:45 [INFO] [stdout] | [INFO] [stdout] 298 | ... let src_index = Register::index(src) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(src)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:298:45 [INFO] [stdout] | [INFO] [stdout] 298 | ... let src_index = Register::index(src) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(src)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:311:37 [INFO] [stdout] | [INFO] [stdout] 311 | let dst_index = Register::index(dst) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:311:37 [INFO] [stdout] | [INFO] [stdout] 311 | let dst_index = Register::index(dst) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:318:45 [INFO] [stdout] | [INFO] [stdout] 318 | ... let src_index = Register::index(src) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(src)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:318:45 [INFO] [stdout] | [INFO] [stdout] 318 | ... let src_index = Register::index(src) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(src)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:332:36 [INFO] [stdout] | [INFO] [stdout] 332 | self.registers[Register::index(dst) as usize] /= imm; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:332:36 [INFO] [stdout] | [INFO] [stdout] 332 | self.registers[Register::index(dst) as usize] /= imm; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:340:36 [INFO] [stdout] | [INFO] [stdout] 340 | self.registers[Register::index(dst) as usize] *= imm; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:346:37 [INFO] [stdout] | [INFO] [stdout] 346 | let dst_index = Register::index(dst) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:340:36 [INFO] [stdout] | [INFO] [stdout] 340 | self.registers[Register::index(dst) as usize] *= imm; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:346:37 [INFO] [stdout] | [INFO] [stdout] 346 | let dst_index = Register::index(dst) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:353:45 [INFO] [stdout] | [INFO] [stdout] 353 | ... let src_index = Register::index(src) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(src)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:353:45 [INFO] [stdout] | [INFO] [stdout] 353 | ... let src_index = Register::index(src) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(src)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:371:40 [INFO] [stdout] | [INFO] [stdout] 371 | self.registers[Register::index(src) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(src)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:371:40 [INFO] [stdout] | [INFO] [stdout] 371 | self.registers[Register::index(src) as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(src)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cpu.rs:392:17 [INFO] [stdout] | [INFO] [stdout] 392 | / if let Some(OpcodeArgument::Immediate(target)) = opcode.arg1 { [INFO] [stdout] 393 | | if self.get_flag(FLAG_ZERO) == true { [INFO] [stdout] 394 | | self.pc = target; [INFO] [stdout] 395 | | } [INFO] [stdout] 396 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 392 ~ if let Some(OpcodeArgument::Immediate(target)) = opcode.arg1 [INFO] [stdout] 393 ~ && self.get_flag(FLAG_ZERO) == true { [INFO] [stdout] 394 | self.pc = target; [INFO] [stdout] 395 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cpu.rs:393:24 [INFO] [stdout] | [INFO] [stdout] 393 | if self.get_flag(FLAG_ZERO) == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.get_flag(FLAG_ZERO)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cpu.rs:400:17 [INFO] [stdout] | [INFO] [stdout] 400 | / if let Some(OpcodeArgument::Immediate(target)) = opcode.arg1 { [INFO] [stdout] 401 | | if self.get_flag(FLAG_ZERO) == false { [INFO] [stdout] 402 | | self.pc = target; [INFO] [stdout] 403 | | } [INFO] [stdout] 404 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 400 ~ if let Some(OpcodeArgument::Immediate(target)) = opcode.arg1 [INFO] [stdout] 401 ~ && self.get_flag(FLAG_ZERO) == false { [INFO] [stdout] 402 | self.pc = target; [INFO] [stdout] 403 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cpu.rs:392:17 [INFO] [stdout] | [INFO] [stdout] 392 | / if let Some(OpcodeArgument::Immediate(target)) = opcode.arg1 { [INFO] [stdout] 393 | | if self.get_flag(FLAG_ZERO) == true { [INFO] [stdout] 394 | | self.pc = target; [INFO] [stdout] 395 | | } [INFO] [stdout] 396 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 392 ~ if let Some(OpcodeArgument::Immediate(target)) = opcode.arg1 [INFO] [stdout] 393 ~ && self.get_flag(FLAG_ZERO) == true { [INFO] [stdout] 394 | self.pc = target; [INFO] [stdout] 395 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/cpu.rs:401:24 [INFO] [stdout] | [INFO] [stdout] 401 | if self.get_flag(FLAG_ZERO) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.get_flag(FLAG_ZERO)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cpu.rs:393:24 [INFO] [stdout] | [INFO] [stdout] 393 | if self.get_flag(FLAG_ZERO) == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.get_flag(FLAG_ZERO)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cpu.rs:410:25 [INFO] [stdout] | [INFO] [stdout] 410 | let _ = super::screen::DrawCommand::clear_screen(self); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 410 - let _ = super::screen::DrawCommand::clear_screen(self); [INFO] [stdout] 410 + super::screen::DrawCommand::clear_screen(self); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cpu.rs:400:17 [INFO] [stdout] | [INFO] [stdout] 400 | / if let Some(OpcodeArgument::Immediate(target)) = opcode.arg1 { [INFO] [stdout] 401 | | if self.get_flag(FLAG_ZERO) == false { [INFO] [stdout] 402 | | self.pc = target; [INFO] [stdout] 403 | | } [INFO] [stdout] 404 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 400 ~ if let Some(OpcodeArgument::Immediate(target)) = opcode.arg1 [INFO] [stdout] 401 ~ && self.get_flag(FLAG_ZERO) == false { [INFO] [stdout] 402 | self.pc = target; [INFO] [stdout] 403 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/cpu.rs:401:24 [INFO] [stdout] | [INFO] [stdout] 401 | if self.get_flag(FLAG_ZERO) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.get_flag(FLAG_ZERO)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:414:44 [INFO] [stdout] | [INFO] [stdout] 414 | ... self.registers[Register::index(Register::V0) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:415:44 [INFO] [stdout] | [INFO] [stdout] 415 | ... self.registers[Register::index(Register::V1) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cpu.rs:410:25 [INFO] [stdout] | [INFO] [stdout] 410 | let _ = super::screen::DrawCommand::clear_screen(self); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 410 - let _ = super::screen::DrawCommand::clear_screen(self); [INFO] [stdout] 410 + super::screen::DrawCommand::clear_screen(self); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:416:44 [INFO] [stdout] | [INFO] [stdout] 416 | ... self.registers[Register::index(Register::V2) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cpu.rs:418:25 [INFO] [stdout] | [INFO] [stdout] 418 | let _ = super::screen::DrawCommand::fill_screen(self, color); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 418 - let _ = super::screen::DrawCommand::fill_screen(self, color); [INFO] [stdout] 418 + super::screen::DrawCommand::fill_screen(self, color); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:414:44 [INFO] [stdout] | [INFO] [stdout] 414 | ... self.registers[Register::index(Register::V0) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:415:44 [INFO] [stdout] | [INFO] [stdout] 415 | ... self.registers[Register::index(Register::V1) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:422:44 [INFO] [stdout] | [INFO] [stdout] 422 | ... self.registers[Register::index(Register::V0) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:416:44 [INFO] [stdout] | [INFO] [stdout] 416 | ... self.registers[Register::index(Register::V2) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:423:44 [INFO] [stdout] | [INFO] [stdout] 423 | ... self.registers[Register::index(Register::V1) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cpu.rs:418:25 [INFO] [stdout] | [INFO] [stdout] 418 | let _ = super::screen::DrawCommand::fill_screen(self, color); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 418 - let _ = super::screen::DrawCommand::fill_screen(self, color); [INFO] [stdout] 418 + super::screen::DrawCommand::fill_screen(self, color); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:424:44 [INFO] [stdout] | [INFO] [stdout] 424 | ... self.registers[Register::index(Register::V2) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:427:44 [INFO] [stdout] | [INFO] [stdout] 427 | ... self.registers[Register::index(Register::V4) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:422:44 [INFO] [stdout] | [INFO] [stdout] 422 | ... self.registers[Register::index(Register::V0) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:428:44 [INFO] [stdout] | [INFO] [stdout] 428 | ... self.registers[Register::index(Register::V5) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:423:44 [INFO] [stdout] | [INFO] [stdout] 423 | ... self.registers[Register::index(Register::V1) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:424:44 [INFO] [stdout] | [INFO] [stdout] 424 | ... self.registers[Register::index(Register::V2) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:431:44 [INFO] [stdout] | [INFO] [stdout] 431 | ... self.registers[Register::index(Register::V6) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:432:44 [INFO] [stdout] | [INFO] [stdout] 432 | ... self.registers[Register::index(Register::V7) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:427:44 [INFO] [stdout] | [INFO] [stdout] 427 | ... self.registers[Register::index(Register::V4) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:435:44 [INFO] [stdout] | [INFO] [stdout] 435 | ... self.registers[Register::index(Register::V3) as usize] as isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:428:44 [INFO] [stdout] | [INFO] [stdout] 428 | ... self.registers[Register::index(Register::V5) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cpu.rs:436:25 [INFO] [stdout] | [INFO] [stdout] 436 | / let _ = super::screen::DrawCommand::draw_line( [INFO] [stdout] 437 | | self, color, line_start, line_end, thickness, [INFO] [stdout] 438 | | ); [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 436 - let _ = super::screen::DrawCommand::draw_line( [INFO] [stdout] 436 + super::screen::DrawCommand::draw_line( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:431:44 [INFO] [stdout] | [INFO] [stdout] 431 | ... self.registers[Register::index(Register::V6) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:432:44 [INFO] [stdout] | [INFO] [stdout] 432 | ... self.registers[Register::index(Register::V7) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:442:44 [INFO] [stdout] | [INFO] [stdout] 442 | ... self.registers[Register::index(Register::V4) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:435:44 [INFO] [stdout] | [INFO] [stdout] 435 | ... self.registers[Register::index(Register::V3) as usize] as isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:443:44 [INFO] [stdout] | [INFO] [stdout] 443 | ... self.registers[Register::index(Register::V5) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cpu.rs:436:25 [INFO] [stdout] | [INFO] [stdout] 436 | / let _ = super::screen::DrawCommand::draw_line( [INFO] [stdout] 437 | | self, color, line_start, line_end, thickness, [INFO] [stdout] 438 | | ); [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 436 - let _ = super::screen::DrawCommand::draw_line( [INFO] [stdout] 436 + super::screen::DrawCommand::draw_line( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cpu.rs:447:25 [INFO] [stdout] | [INFO] [stdout] 447 | let _ = super::screen::DrawCommand::draw_bmp(self, &bmp_bytes, point); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 447 - let _ = super::screen::DrawCommand::draw_bmp(self, &bmp_bytes, point); [INFO] [stdout] 447 + super::screen::DrawCommand::draw_bmp(self, &bmp_bytes, point); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:442:44 [INFO] [stdout] | [INFO] [stdout] 442 | ... self.registers[Register::index(Register::V4) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:451:44 [INFO] [stdout] | [INFO] [stdout] 451 | ... self.registers[Register::index(Register::V0) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:443:44 [INFO] [stdout] | [INFO] [stdout] 443 | ... self.registers[Register::index(Register::V5) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:452:44 [INFO] [stdout] | [INFO] [stdout] 452 | ... self.registers[Register::index(Register::V1) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cpu.rs:447:25 [INFO] [stdout] | [INFO] [stdout] 447 | let _ = super::screen::DrawCommand::draw_bmp(self, &bmp_bytes, point); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 447 - let _ = super::screen::DrawCommand::draw_bmp(self, &bmp_bytes, point); [INFO] [stdout] 447 + super::screen::DrawCommand::draw_bmp(self, &bmp_bytes, point); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:453:44 [INFO] [stdout] | [INFO] [stdout] 453 | ... self.registers[Register::index(Register::V2) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:456:44 [INFO] [stdout] | [INFO] [stdout] 456 | ... self.registers[Register::index(Register::V4) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:451:44 [INFO] [stdout] | [INFO] [stdout] 451 | ... self.registers[Register::index(Register::V0) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:457:44 [INFO] [stdout] | [INFO] [stdout] 457 | ... self.registers[Register::index(Register::V5) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:452:44 [INFO] [stdout] | [INFO] [stdout] 452 | ... self.registers[Register::index(Register::V1) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:459:51 [INFO] [stdout] | [INFO] [stdout] 459 | let size = self.registers[Register::index(Register::V6) as usize] as isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:453:44 [INFO] [stdout] | [INFO] [stdout] 453 | ... self.registers[Register::index(Register::V2) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cpu.rs:460:25 [INFO] [stdout] | [INFO] [stdout] 460 | let _ = DrawCommand::fill_rect(self, color, center, size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 460 - let _ = DrawCommand::fill_rect(self, color, center, size); [INFO] [stdout] 460 + DrawCommand::fill_rect(self, color, center, size); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:456:44 [INFO] [stdout] | [INFO] [stdout] 456 | ... self.registers[Register::index(Register::V4) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:464:44 [INFO] [stdout] | [INFO] [stdout] 464 | ... self.registers[Register::index(Register::V0) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:457:44 [INFO] [stdout] | [INFO] [stdout] 457 | ... self.registers[Register::index(Register::V5) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:465:44 [INFO] [stdout] | [INFO] [stdout] 465 | ... self.registers[Register::index(Register::V1) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:459:51 [INFO] [stdout] | [INFO] [stdout] 459 | let size = self.registers[Register::index(Register::V6) as usize] as isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:466:44 [INFO] [stdout] | [INFO] [stdout] 466 | ... self.registers[Register::index(Register::V2) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cpu.rs:460:25 [INFO] [stdout] | [INFO] [stdout] 460 | let _ = DrawCommand::fill_rect(self, color, center, size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 460 - let _ = DrawCommand::fill_rect(self, color, center, size); [INFO] [stdout] 460 + DrawCommand::fill_rect(self, color, center, size); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:469:44 [INFO] [stdout] | [INFO] [stdout] 469 | ... self.registers[Register::index(Register::V8) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:464:44 [INFO] [stdout] | [INFO] [stdout] 464 | ... self.registers[Register::index(Register::V0) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:470:44 [INFO] [stdout] | [INFO] [stdout] 470 | ... self.registers[Register::index(Register::V9) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V9)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:465:44 [INFO] [stdout] | [INFO] [stdout] 465 | ... self.registers[Register::index(Register::V1) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:473:44 [INFO] [stdout] | [INFO] [stdout] 473 | ... self.registers[Register::index(Register::V10) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:466:44 [INFO] [stdout] | [INFO] [stdout] 466 | ... self.registers[Register::index(Register::V2) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:474:44 [INFO] [stdout] | [INFO] [stdout] 474 | ... self.registers[Register::index(Register::V11) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V11)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:469:44 [INFO] [stdout] | [INFO] [stdout] 469 | ... self.registers[Register::index(Register::V8) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:477:44 [INFO] [stdout] | [INFO] [stdout] 477 | ... self.registers[Register::index(Register::V12) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V12)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:470:44 [INFO] [stdout] | [INFO] [stdout] 470 | ... self.registers[Register::index(Register::V9) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V9)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:478:44 [INFO] [stdout] | [INFO] [stdout] 478 | ... self.registers[Register::index(Register::V13) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V13)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:473:44 [INFO] [stdout] | [INFO] [stdout] 473 | ... self.registers[Register::index(Register::V10) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:481:44 [INFO] [stdout] | [INFO] [stdout] 481 | ... self.registers[Register::index(Register::V14) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V14)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:474:44 [INFO] [stdout] | [INFO] [stdout] 474 | ... self.registers[Register::index(Register::V11) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V11)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:482:44 [INFO] [stdout] | [INFO] [stdout] 482 | ... self.registers[Register::index(Register::V15) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V15)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cpu.rs:484:25 [INFO] [stdout] | [INFO] [stdout] 484 | let _ = DrawCommand::fill_quad(self, color, p1, p2, p3, p4); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 484 - let _ = DrawCommand::fill_quad(self, color, p1, p2, p3, p4); [INFO] [stdout] 484 + DrawCommand::fill_quad(self, color, p1, p2, p3, p4); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:477:44 [INFO] [stdout] | [INFO] [stdout] 477 | ... self.registers[Register::index(Register::V12) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V12)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:478:44 [INFO] [stdout] | [INFO] [stdout] 478 | ... self.registers[Register::index(Register::V13) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V13)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:487:56 [INFO] [stdout] | [INFO] [stdout] 487 | let character = self.registers[Register::index(Register::V3) as usize] as u8 as char; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:481:44 [INFO] [stdout] | [INFO] [stdout] 481 | ... self.registers[Register::index(Register::V14) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V14)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:489:44 [INFO] [stdout] | [INFO] [stdout] 489 | ... self.registers[Register::index(Register::V4) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:482:44 [INFO] [stdout] | [INFO] [stdout] 482 | ... self.registers[Register::index(Register::V15) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V15)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:490:44 [INFO] [stdout] | [INFO] [stdout] 490 | ... self.registers[Register::index(Register::V5) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cpu.rs:484:25 [INFO] [stdout] | [INFO] [stdout] 484 | let _ = DrawCommand::fill_quad(self, color, p1, p2, p3, p4); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 484 - let _ = DrawCommand::fill_quad(self, color, p1, p2, p3, p4); [INFO] [stdout] 484 + DrawCommand::fill_quad(self, color, p1, p2, p3, p4); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:493:44 [INFO] [stdout] | [INFO] [stdout] 493 | ... self.registers[Register::index(Register::V0) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:494:44 [INFO] [stdout] | [INFO] [stdout] 494 | ... self.registers[Register::index(Register::V1) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:487:56 [INFO] [stdout] | [INFO] [stdout] 487 | let character = self.registers[Register::index(Register::V3) as usize] as u8 as char; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:495:44 [INFO] [stdout] | [INFO] [stdout] 495 | ... self.registers[Register::index(Register::V2) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:489:44 [INFO] [stdout] | [INFO] [stdout] 489 | ... self.registers[Register::index(Register::V4) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cpu.rs:497:25 [INFO] [stdout] | [INFO] [stdout] 497 | let _ = DrawCommand::draw_character(self, character, character_position, character_color); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 497 - let _ = DrawCommand::draw_character(self, character, character_position, character_color); [INFO] [stdout] 497 + DrawCommand::draw_character(self, character, character_position, character_color); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:490:44 [INFO] [stdout] | [INFO] [stdout] 490 | ... self.registers[Register::index(Register::V5) as usize] as isize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:493:44 [INFO] [stdout] | [INFO] [stdout] 493 | ... self.registers[Register::index(Register::V0) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:494:44 [INFO] [stdout] | [INFO] [stdout] 494 | ... self.registers[Register::index(Register::V1) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:516:36 [INFO] [stdout] | [INFO] [stdout] 516 | self.registers[Register::index(target) as usize] = value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(target)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:495:44 [INFO] [stdout] | [INFO] [stdout] 495 | ... self.registers[Register::index(Register::V2) as usize] as u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(Register::V2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:522:37 [INFO] [stdout] | [INFO] [stdout] 522 | let dst_index = Register::index(dst) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/cpu.rs:497:25 [INFO] [stdout] | [INFO] [stdout] 497 | let _ = DrawCommand::draw_character(self, character, character_position, character_color); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 497 - let _ = DrawCommand::draw_character(self, character, character_position, character_color); [INFO] [stdout] 497 + DrawCommand::draw_character(self, character, character_position, character_color); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:535:45 [INFO] [stdout] | [INFO] [stdout] 535 | ... let src_index = Register::index(src) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(src)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:516:36 [INFO] [stdout] | [INFO] [stdout] 516 | self.registers[Register::index(target) as usize] = value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(target)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/cpu.rs:538:43 [INFO] [stdout] | [INFO] [stdout] 538 | ... let byte = if addr % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `addr.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:522:37 [INFO] [stdout] | [INFO] [stdout] 522 | let dst_index = Register::index(dst) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(dst)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/cpu.rs:535:45 [INFO] [stdout] | [INFO] [stdout] 535 | ... let src_index = Register::index(src) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Register::index(src)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/cpu.rs:538:43 [INFO] [stdout] | [INFO] [stdout] 538 | ... let byte = if addr % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `addr.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:646:24 [INFO] [stdout] | [INFO] [stdout] 646 | invalid => return Err(InvalidOpcode(invalid)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 646 - invalid => return Err(InvalidOpcode(invalid)), [INFO] [stdout] 646 + invalid => Err(InvalidOpcode(invalid)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:681:24 [INFO] [stdout] | [INFO] [stdout] 681 | invalid => return Err(InvalidOpcodeString(invalid.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 681 - invalid => return Err(InvalidOpcodeString(invalid.to_string())), [INFO] [stdout] 681 + invalid => Err(InvalidOpcodeString(invalid.to_string())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:646:24 [INFO] [stdout] | [INFO] [stdout] 646 | invalid => return Err(InvalidOpcode(invalid)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 646 - invalid => return Err(InvalidOpcode(invalid)), [INFO] [stdout] 646 + invalid => Err(InvalidOpcode(invalid)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:681:24 [INFO] [stdout] | [INFO] [stdout] 681 | invalid => return Err(InvalidOpcodeString(invalid.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 681 - invalid => return Err(InvalidOpcodeString(invalid.to_string())), [INFO] [stdout] 681 + invalid => Err(InvalidOpcodeString(invalid.to_string())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:774:24 [INFO] [stdout] | [INFO] [stdout] 774 | invalid => return Err(InvalidFunctionCall(invalid)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 774 - invalid => return Err(InvalidFunctionCall(invalid)), [INFO] [stdout] 774 + invalid => Err(InvalidFunctionCall(invalid)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:774:24 [INFO] [stdout] | [INFO] [stdout] 774 | invalid => return Err(InvalidFunctionCall(invalid)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 774 - invalid => return Err(InvalidFunctionCall(invalid)), [INFO] [stdout] 774 + invalid => Err(InvalidFunctionCall(invalid)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/render.rs:56:35 [INFO] [stdout] | [INFO] [stdout] 56 | cpu.registers[cpu::Register::index(cpu::Register::K0) as usize] = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cpu::Register::index(cpu::Register::K0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/render.rs:59:35 [INFO] [stdout] | [INFO] [stdout] 59 | cpu.registers[cpu::Register::index(cpu::Register::K0) as usize] = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cpu::Register::index(cpu::Register::K0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/render.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 85 | if !(byte_index + 3 < frame.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(byte_index + 3 >= frame.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`isize` -> `isize`) [INFO] [stdout] --> src/screen.rs:18:24 [INFO] [stdout] | [INFO] [stdout] 18 | coordinate.y * (width as isize) + coordinate.x [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/render.rs:56:35 [INFO] [stdout] | [INFO] [stdout] 56 | cpu.registers[cpu::Register::index(cpu::Register::K0) as usize] = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cpu::Register::index(cpu::Register::K0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/render.rs:59:35 [INFO] [stdout] | [INFO] [stdout] 59 | cpu.registers[cpu::Register::index(cpu::Register::K0) as usize] = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cpu::Register::index(cpu::Register::K0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/render.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 85 | if !(byte_index + 3 < frame.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(byte_index + 3 >= frame.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/screen.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 99 | let pitch = ((width * 3 + 3) / 4) * 4; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(width * 3).div_ceil(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`isize` -> `isize`) [INFO] [stdout] --> src/screen.rs:18:24 [INFO] [stdout] | [INFO] [stdout] 18 | coordinate.y * (width as isize) + coordinate.x [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/screen.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 99 | let pitch = ((width * 3 + 3) / 4) * 4; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(width * 3).div_ceil(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 25.79s [INFO] running `Command { std: "docker" "inspect" "637d21847f641c0f090e89411a2f0e9a8231999f66121f20b50b07ed38c5e660", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "637d21847f641c0f090e89411a2f0e9a8231999f66121f20b50b07ed38c5e660", kill_on_drop: false }` [INFO] [stdout] 637d21847f641c0f090e89411a2f0e9a8231999f66121f20b50b07ed38c5e660