[INFO] cloning repository https://github.com/5DPixel/Lumen [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/5DPixel/Lumen" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F5DPixel%2FLumen", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F5DPixel%2FLumen'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bd1b1284eb7bb3027b04a64dd3216bdb3c345670 [INFO] linting 5DPixel/Lumen against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F5DPixel%2FLumen" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/5DPixel/Lumen [INFO] finished tweaking git repo https://github.com/5DPixel/Lumen [INFO] tweaked toml for git repo https://github.com/5DPixel/Lumen written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/5DPixel/Lumen on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/5DPixel/Lumen already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded imgui-winit-support v0.12.0 [INFO] [stderr] Downloaded tobj v3.2.5 [INFO] [stderr] Downloaded chlorine v1.0.13 [INFO] [stderr] Downloaded imgui-wgpu v0.25.0 [INFO] [stderr] Downloaded cgmath v0.18.0 [INFO] [stderr] Downloaded imgui v0.12.0 [INFO] [stderr] Downloaded imgui-sys v0.12.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 87dfcf6a88a42a51a209f0b514f451da6d23a094674f0e03166a285302fe9363 [INFO] running `Command { std: "docker" "start" "-a" "87dfcf6a88a42a51a209f0b514f451da6d23a094674f0e03166a285302fe9363", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "87dfcf6a88a42a51a209f0b514f451da6d23a094674f0e03166a285302fe9363", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87dfcf6a88a42a51a209f0b514f451da6d23a094674f0e03166a285302fe9363", kill_on_drop: false }` [INFO] [stdout] 87dfcf6a88a42a51a209f0b514f451da6d23a094674f0e03166a285302fe9363 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d2947444346d70e04f9c4724ae1420b822c7caf05746e2ad4004f896f2a220ad [INFO] running `Command { std: "docker" "start" "-a" "d2947444346d70e04f9c4724ae1420b822c7caf05746e2ad4004f896f2a220ad", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking libloading v0.8.7 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Compiling wayland-sys v0.31.6 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling wayland-client v0.31.10 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling rustversion v1.0.21 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Checking hashbrown v0.15.3 [INFO] [stderr] Compiling cc v1.2.24 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling naga v25.0.1 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Compiling ash v0.38.0+1.3.281 [INFO] [stderr] Compiling khronos-egl v6.0.0 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Checking codespan-reporting v0.12.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking bit-set v0.8.0 [INFO] [stderr] Compiling wgpu-hal v25.0.2 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking unicode-ident v1.0.18 [INFO] [stderr] Checking hexf-parse v0.2.1 [INFO] [stderr] Compiling wayland-scanner v0.31.6 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Checking cursor-icon v1.1.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.18.1 [INFO] [stderr] Checking renderdoc-sys v1.1.0 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking profiling v1.0.16 [INFO] [stderr] Checking xcursor v0.3.8 [INFO] [stderr] Checking glow v0.16.0 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Compiling zerocopy v0.8.25 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling wgpu-core v25.0.2 [INFO] [stderr] Compiling wayland-backend v0.3.10 [INFO] [stderr] Compiling imgui-sys v0.12.0 [INFO] [stderr] Compiling zstd-sys v2.0.15+zstd.1.5.7 [INFO] [stderr] Checking memmap2 v0.9.5 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking mint v0.5.9 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Checking chlorine v1.0.13 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling bytemuck_derive v1.9.3 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking bytemuck v1.23.0 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking owned_ttf_parser v0.25.0 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Checking ab_glyph v0.2.29 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Compiling winit v0.29.15 [INFO] [stderr] Compiling wgpu v25.0.2 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking as-raw-xcb-connection v1.0.1 [INFO] [stderr] Checking x11rb-protocol v0.13.1 [INFO] [stderr] Checking flate2 v1.1.1 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling anyhow v1.0.98 [INFO] [stderr] Compiling glob v0.3.2 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking gpu-descriptor v0.3.2 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking wgpu-types v25.0.0 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Checking imgui v0.12.0 [INFO] [stderr] Compiling cgmath v0.18.0 [INFO] [stderr] Compiling vulkan-engine v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Checking humantime v2.2.0 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Checking tobj v3.2.5 [INFO] [stderr] Checking calloop v0.12.4 [INFO] [stderr] Checking pollster v0.3.0 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking wayland-protocols v0.31.2 [INFO] [stderr] Checking calloop-wayland-source v0.2.0 [INFO] [stderr] Checking wayland-cursor v0.31.10 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking wayland-protocols-wlr v0.2.0 [INFO] [stderr] Checking wayland-protocols-plasma v0.2.0 [INFO] [stderr] Checking wgpu-core-deps-windows-linux-android v25.0.0 [INFO] [stderr] Checking sctk-adwaita v0.8.3 [INFO] [stderr] Checking imgui-winit-support v0.12.0 [INFO] [stderr] Checking imgui-wgpu v0.25.0 [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/renderer/window.rs:307:66 [INFO] [stdout] | [INFO] [stdout] 307 | resource: wgpu::BindingResource::TextureView(&sky_texture.view()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `sky_texture.view()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/renderer/window.rs:307:66 [INFO] [stdout] | [INFO] [stdout] 307 | resource: wgpu::BindingResource::TextureView(&sky_texture.view()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `sky_texture.view()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/renderer/window.rs:384:13 [INFO] [stdout] | [INFO] [stdout] 384 | &window, [INFO] [stdout] | ^^^^^^^ help: change this to: `window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/renderer/window.rs:384:13 [INFO] [stdout] | [INFO] [stdout] 384 | &window, [INFO] [stdout] | ^^^^^^^ help: change this to: `window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/renderer/window.rs:454:9 [INFO] [stdout] | [INFO] [stdout] 454 | &self.window [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `self.window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/renderer/window.rs:454:9 [INFO] [stdout] | [INFO] [stdout] 454 | &self.window [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `self.window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/renderer/window.rs:634:38 [INFO] [stdout] | [INFO] [stdout] 634 | self.platform.prepare_render(&ui, self.window); [INFO] [stdout] | ^^^ help: change this to: `ui` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/window.rs:691:18 [INFO] [stdout] | [INFO] [stdout] 691 | } => if state.right_mouse_pressed { [INFO] [stdout] | __________________^ [INFO] [stdout] 692 | | state.camera_controller.process_mouse(delta.0, delta.1) [INFO] [stdout] 693 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 691 ~ }f state.right_mouse_pressed => { [INFO] [stdout] 692 ~ state.camera_controller.process_mouse(delta.0, delta.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/renderer/window.rs:634:38 [INFO] [stdout] | [INFO] [stdout] 634 | self.platform.prepare_render(&ui, self.window); [INFO] [stdout] | ^^^ help: change this to: `ui` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/window.rs:691:18 [INFO] [stdout] | [INFO] [stdout] 691 | } => if state.right_mouse_pressed { [INFO] [stdout] | __________________^ [INFO] [stdout] 692 | | state.camera_controller.process_mouse(delta.0, delta.1) [INFO] [stdout] 693 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 691 ~ }f state.right_mouse_pressed => { [INFO] [stdout] 692 ~ state.camera_controller.process_mouse(delta.0, delta.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/renderer/texture.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | pub fn create_2d(device: &wgpu::Device, width: u32, height: u32, format: wgpu::TextureFormat, mip_level_count: u32, usage: wgpu::TextureUsages, mag_filter: wgpu::FilterMode, label: Option<&str>) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/renderer/texture.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | pub fn create_2d(device: &wgpu::Device, width: u32, height: u32, format: wgpu::TextureFormat, mip_level_count: u32, usage: wgpu::TextureUsages, mag_filter: wgpu::FilterMode, label: Option<&str>) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CameraUniform` [INFO] [stdout] --> src/renderer/camera.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | / pub fn new() -> Self { [INFO] [stdout] 93 | | use cgmath::SquareMatrix; [INFO] [stdout] 94 | | Self { [INFO] [stdout] 95 | | view_position: [0.0; 4], [INFO] [stdout] ... | [INFO] [stdout] 101 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 91 + impl Default for CameraUniform { [INFO] [stdout] 92 + fn default() -> Self { [INFO] [stdout] 93 + Self::new() [INFO] [stdout] 94 + } [INFO] [stdout] 95 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CameraUniform` [INFO] [stdout] --> src/renderer/camera.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | / pub fn new() -> Self { [INFO] [stdout] 93 | | use cgmath::SquareMatrix; [INFO] [stdout] 94 | | Self { [INFO] [stdout] 95 | | view_position: [0.0; 4], [INFO] [stdout] ... | [INFO] [stdout] 101 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 91 + impl Default for CameraUniform { [INFO] [stdout] 92 + fn default() -> Self { [INFO] [stdout] 93 + Self::new() [INFO] [stdout] 94 + } [INFO] [stdout] 95 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/renderer/hdr.rs:137:23 [INFO] [stdout] | [INFO] [stdout] 137 | view: &output, [INFO] [stdout] | ^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/renderer/hdr.rs:137:23 [INFO] [stdout] | [INFO] [stdout] 137 | view: &output, [INFO] [stdout] | ^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EntityManager` [INFO] [stdout] --> src/ecs/entity.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / pub fn new() -> Self { [INFO] [stdout] 21 | | Self { [INFO] [stdout] 22 | | next_id: 0, [INFO] [stdout] 23 | | recycled: Vec::new(), [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 19 + impl Default for EntityManager { [INFO] [stdout] 20 + fn default() -> Self { [INFO] [stdout] 21 + Self::new() [INFO] [stdout] 22 + } [INFO] [stdout] 23 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EntityManager` [INFO] [stdout] --> src/ecs/entity.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / pub fn new() -> Self { [INFO] [stdout] 21 | | Self { [INFO] [stdout] 22 | | next_id: 0, [INFO] [stdout] 23 | | recycled: Vec::new(), [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 19 + impl Default for EntityManager { [INFO] [stdout] 20 + fn default() -> Self { [INFO] [stdout] 21 + Self::new() [INFO] [stdout] 22 + } [INFO] [stdout] 23 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `World` [INFO] [stdout] --> src/ecs/world.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self { [INFO] [stdout] 21 | | entity_manager: EntityManager::new(), [INFO] [stdout] 22 | | components: HashMap::new(), [INFO] [stdout] 23 | | } [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for World { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `World` [INFO] [stdout] --> src/ecs/world.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self { [INFO] [stdout] 21 | | entity_manager: EntityManager::new(), [INFO] [stdout] 22 | | components: HashMap::new(), [INFO] [stdout] 23 | | } [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for World { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/ecs/world.rs:88:46 [INFO] [stdout] | [INFO] [stdout] 88 | for (_type_id, component_storage) in &self.components { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 88 - for (_type_id, component_storage) in &self.components { [INFO] [stdout] 88 + for component_storage in self.components.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/ecs/world.rs:88:46 [INFO] [stdout] | [INFO] [stdout] 88 | for (_type_id, component_storage) in &self.components { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 88 - for (_type_id, component_storage) in &self.components { [INFO] [stdout] 88 + for component_storage in self.components.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resources.rs:321:13 [INFO] [stdout] | [INFO] [stdout] 321 | &bytemuck::cast_slice(&pixels), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `bytemuck::cast_slice(&pixels)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/resources.rs:366:30 [INFO] [stdout] | [INFO] [stdout] 366 | let num_workgroups = (dst_size + 15) / 16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `dst_size.div_ceil(16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resources.rs:321:13 [INFO] [stdout] | [INFO] [stdout] 321 | &bytemuck::cast_slice(&pixels), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `bytemuck::cast_slice(&pixels)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/resources.rs:366:30 [INFO] [stdout] | [INFO] [stdout] 366 | let num_workgroups = (dst_size + 15) / 16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `dst_size.div_ceil(16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 49.36s [INFO] running `Command { std: "docker" "inspect" "d2947444346d70e04f9c4724ae1420b822c7caf05746e2ad4004f896f2a220ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2947444346d70e04f9c4724ae1420b822c7caf05746e2ad4004f896f2a220ad", kill_on_drop: false }` [INFO] [stdout] d2947444346d70e04f9c4724ae1420b822c7caf05746e2ad4004f896f2a220ad