[INFO] cloning repository https://github.com/42ByteLabs/patch-release-me [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/42ByteLabs/patch-release-me" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F42ByteLabs%2Fpatch-release-me", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F42ByteLabs%2Fpatch-release-me'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 08e6f358a6d2be5e7e9468704382c84d7dc5e03a [INFO] linting 42ByteLabs/patch-release-me against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F42ByteLabs%2Fpatch-release-me" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/42ByteLabs/patch-release-me [INFO] finished tweaking git repo https://github.com/42ByteLabs/patch-release-me [INFO] tweaked toml for git repo https://github.com/42ByteLabs/patch-release-me written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/42ByteLabs/patch-release-me on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/42ByteLabs/patch-release-me already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dialoguer v0.12.0 [INFO] [stderr] Downloaded console v0.16.3 [INFO] [stderr] Downloaded serde_yaml v0.9.34+deprecated [INFO] [stderr] Downloaded unsafe-libyaml v0.2.11 [INFO] [stderr] Downloaded jiff-static v0.2.20 [INFO] [stderr] Downloaded indicatif v0.18.4 [INFO] [stderr] Downloaded jiff v0.2.20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a642e564de037b90339827c43b6597a23d6ebb20796b16b1d07396d28a37b5f3 [INFO] running `Command { std: "docker" "start" "-a" "a642e564de037b90339827c43b6597a23d6ebb20796b16b1d07396d28a37b5f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a642e564de037b90339827c43b6597a23d6ebb20796b16b1d07396d28a37b5f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a642e564de037b90339827c43b6597a23d6ebb20796b16b1d07396d28a37b5f3", kill_on_drop: false }` [INFO] [stdout] a642e564de037b90339827c43b6597a23d6ebb20796b16b1d07396d28a37b5f3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9bd68ed47e44bfa08fc95f174325d23b98f8b4e3ff46a12d3ba6522f2ca821ad [INFO] running `Command { std: "docker" "start" "-a" "9bd68ed47e44bfa08fc95f174325d23b98f8b4e3ff46a12d3ba6522f2ca821ad", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking regex-syntax v0.8.9 [INFO] [stderr] Compiling getrandom v0.4.1 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking anstyle-parse v1.0.0 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Compiling portable-atomic v1.13.1 [INFO] [stderr] Checking unicode-width v0.2.2 [INFO] [stderr] Checking anstream v1.0.0 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking clap_builder v4.6.0 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking console v0.16.3 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking tempfile v3.25.0 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Checking shell-words v1.1.1 [INFO] [stderr] Checking jiff v0.2.20 [INFO] [stderr] Checking ryu v1.0.23 [INFO] [stderr] Checking unit-prefix v0.5.2 [INFO] [stderr] Checking dialoguer v0.12.0 [INFO] [stderr] Checking indicatif v0.18.4 [INFO] [stderr] Checking semver v1.0.27 [INFO] [stderr] Checking glob v0.3.3 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking env_filter v1.0.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling clap_derive v4.6.0 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stderr] Checking clap v4.6.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking patch-release-me v0.6.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/config.rs:125:23 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn load(root: &PathBuf, path: &PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 125 - pub fn load(root: &PathBuf, path: &PathBuf) -> Result { [INFO] [stdout] 125 + pub fn load(root: &Path, path: &PathBuf) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/config.rs:125:23 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn load(root: &PathBuf, path: &PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 125 - pub fn load(root: &PathBuf, path: &PathBuf) -> Result { [INFO] [stdout] 125 + pub fn load(root: &Path, path: &PathBuf) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/defaults.rs:20:41 [INFO] [stdout] | [INFO] [stdout] 20 | Ok(serde_yaml::from_str::(&DEFAULTS)?) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `DEFAULTS` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interactive.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if !config.version.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.version.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern takes a reference on something that is being dereferenced [INFO] [stdout] --> src/interactive.rs:111:30 [INFO] [stdout] | [INFO] [stdout] 111 | .filter_map(|(i, &ref lang)| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&ref` part [INFO] [stdout] | [INFO] [stdout] 111 - .filter_map(|(i, &ref lang)| { [INFO] [stdout] 111 + .filter_map(|(i, lang)| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/defaults.rs:20:41 [INFO] [stdout] | [INFO] [stdout] 20 | Ok(serde_yaml::from_str::(&DEFAULTS)?) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `DEFAULTS` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/interactive.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if !config.version.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.version.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern takes a reference on something that is being dereferenced [INFO] [stdout] --> src/interactive.rs:111:30 [INFO] [stdout] | [INFO] [stdout] 111 | .filter_map(|(i, &ref lang)| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&ref` part [INFO] [stdout] | [INFO] [stdout] 111 - .filter_map(|(i, &ref lang)| { [INFO] [stdout] 111 + .filter_map(|(i, lang)| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.23s [INFO] running `Command { std: "docker" "inspect" "9bd68ed47e44bfa08fc95f174325d23b98f8b4e3ff46a12d3ba6522f2ca821ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9bd68ed47e44bfa08fc95f174325d23b98f8b4e3ff46a12d3ba6522f2ca821ad", kill_on_drop: false }` [INFO] [stdout] 9bd68ed47e44bfa08fc95f174325d23b98f8b4e3ff46a12d3ba6522f2ca821ad