[INFO] cloning repository https://github.com/403access/file_indexer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/403access/file_indexer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F403access%2Ffile_indexer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F403access%2Ffile_indexer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6d27a4b15ba455e50c84646b60ee7ff3b93b5090 [INFO] linting 403access/file_indexer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F403access%2Ffile_indexer" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/403access/file_indexer [INFO] finished tweaking git repo https://github.com/403access/file_indexer [INFO] tweaked toml for git repo https://github.com/403access/file_indexer written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/403access/file_indexer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/403access/file_indexer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded signal-hook-mio v0.2.4 [INFO] [stderr] Downloaded signal-hook-registry v1.4.5 [INFO] [stderr] Downloaded newline-converter v0.3.0 [INFO] [stderr] Downloaded windows-targets v0.53.2 [INFO] [stderr] Downloaded anstyle-query v1.1.3 [INFO] [stderr] Downloaded unit-prefix v0.5.1 [INFO] [stderr] Downloaded anstyle-wincon v3.0.9 [INFO] [stderr] Downloaded redox_syscall v0.5.13 [INFO] [stderr] Downloaded anstyle v1.0.11 [INFO] [stderr] Downloaded anstream v0.6.19 [INFO] [stderr] Downloaded clap_derive v4.5.32 [INFO] [stderr] Downloaded console v0.16.0 [INFO] [stderr] Downloaded clap v4.5.39 [INFO] [stderr] Downloaded crossterm v0.25.0 [INFO] [stderr] Downloaded rusqlite v0.31.0 [INFO] [stderr] Downloaded indicatif v0.18.0 [INFO] [stderr] Downloaded inquire v0.7.5 [INFO] [stderr] Downloaded clap_builder v4.5.39 [INFO] [stderr] Downloaded libsqlite3-sys v0.28.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dd1b16c8d988bc3288293a523be67f4c255bb1e0b1aa9dff346f6502d98e45ef [INFO] running `Command { std: "docker" "start" "-a" "dd1b16c8d988bc3288293a523be67f4c255bb1e0b1aa9dff346f6502d98e45ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dd1b16c8d988bc3288293a523be67f4c255bb1e0b1aa9dff346f6502d98e45ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd1b16c8d988bc3288293a523be67f4c255bb1e0b1aa9dff346f6502d98e45ef", kill_on_drop: false }` [INFO] [stdout] dd1b16c8d988bc3288293a523be67f4c255bb1e0b1aa9dff346f6502d98e45ef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 46dc3e8135eb32ee456de78576c46ee01b69a991a8e1d9eddd02da11a6dca8dc [INFO] running `Command { std: "docker" "start" "-a" "46dc3e8135eb32ee456de78576c46ee01b69a991a8e1d9eddd02da11a6dca8dc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Compiling zerocopy v0.8.25 [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking unit-prefix v0.5.1 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking dyn-clone v1.0.19 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking clap_builder v4.5.39 [INFO] [stderr] Checking newline-converter v0.3.0 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking console v0.16.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking indicatif v0.18.0 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking inquire v0.7.5 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Checking clap v4.5.39 [INFO] [stderr] Checking file_indexer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `pb` [INFO] [stdout] --> src/commands/command_exit.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn command_exit(pb: &ProgressBar) -> io::Result { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_pb` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pb` [INFO] [stdout] --> src/commands/command_exit.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn command_exit(pb: &ProgressBar) -> io::Result { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_pb` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pb` [INFO] [stdout] --> src/commands/command_index_files.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn command_index_files(pb: &ProgressBar) -> io::Result { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_pb` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pb` [INFO] [stdout] --> src/commands/command_index_files.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn command_index_files(pb: &ProgressBar) -> io::Result { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_pb` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pb` [INFO] [stdout] --> src/commands/command_init_db.rs:7:24 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn command_init_db(pb: &ProgressBar) -> io::Result { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_pb` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pb` [INFO] [stdout] --> src/commands/command_init_db.rs:7:24 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn command_init_db(pb: &ProgressBar) -> io::Result { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_pb` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/file_entry/convert.rs:161:22 [INFO] [stdout] | [INFO] [stdout] 161 | .map_err(|_| std::io::Error::new(std::io::ErrorKind::Other, "Failed to get file metadata"))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 161 - .map_err(|_| std::io::Error::new(std::io::ErrorKind::Other, "Failed to get file metadata"))? [INFO] [stdout] 161 + .map_err(|_| std::io::Error::other("Failed to get file metadata"))? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/file_entry/convert.rs:161:22 [INFO] [stdout] | [INFO] [stdout] 161 | .map_err(|_| std::io::Error::new(std::io::ErrorKind::Other, "Failed to get file metadata"))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 161 - .map_err(|_| std::io::Error::new(std::io::ErrorKind::Other, "Failed to get file metadata"))? [INFO] [stdout] 161 + .map_err(|_| std::io::Error::other("Failed to get file metadata"))? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/file_entry/convert.rs:173:28 [INFO] [stdout] | [INFO] [stdout] 173 | return Err(std::io::Error::new( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 174 | | std::io::ErrorKind::Other, [INFO] [stdout] 175 | | "Failed to read file", [INFO] [stdout] 176 | | )) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 173 ~ return Err(std::io::Error::other( [INFO] [stdout] 174 ~ "Failed to read file", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/file_entry/convert.rs:173:28 [INFO] [stdout] | [INFO] [stdout] 173 | return Err(std::io::Error::new( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 174 | | std::io::ErrorKind::Other, [INFO] [stdout] 175 | | "Failed to read file", [INFO] [stdout] 176 | | )) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 173 ~ return Err(std::io::Error::other( [INFO] [stdout] 174 ~ "Failed to read file", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/file_entry/convert.rs:183:17 [INFO] [stdout] | [INFO] [stdout] 183 | std::io::Error::new(std::io::ErrorKind::Other, "Failed to seek in file") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 183 - std::io::Error::new(std::io::ErrorKind::Other, "Failed to seek in file") [INFO] [stdout] 183 + std::io::Error::other("Failed to seek in file") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/file_entry/convert.rs:183:17 [INFO] [stdout] | [INFO] [stdout] 183 | std::io::Error::new(std::io::ErrorKind::Other, "Failed to seek in file") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 183 - std::io::Error::new(std::io::ErrorKind::Other, "Failed to seek in file") [INFO] [stdout] 183 + std::io::Error::other("Failed to seek in file") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/file_entry/convert.rs:189:32 [INFO] [stdout] | [INFO] [stdout] 189 | return Err(std::io::Error::new( [INFO] [stdout] | ________________________________^ [INFO] [stdout] 190 | | std::io::ErrorKind::Other, [INFO] [stdout] 191 | | "Failed to read file", [INFO] [stdout] 192 | | )) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 189 ~ return Err(std::io::Error::other( [INFO] [stdout] 190 ~ "Failed to read file", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/file_entry/convert.rs:189:32 [INFO] [stdout] | [INFO] [stdout] 189 | return Err(std::io::Error::new( [INFO] [stdout] | ________________________________^ [INFO] [stdout] 190 | | std::io::ErrorKind::Other, [INFO] [stdout] 191 | | "Failed to read file", [INFO] [stdout] 192 | | )) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 189 ~ return Err(std::io::Error::other( [INFO] [stdout] 190 ~ "Failed to read file", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/file_entry/sort.rs:9:61 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn sort_dir_entries(sort_order: SortOrder, dir_entries: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 9 - pub fn sort_dir_entries(sort_order: SortOrder, dir_entries: &mut Vec) { [INFO] [stdout] 9 + pub fn sort_dir_entries(sort_order: SortOrder, dir_entries: &mut [FileEntry]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/file_entry/sort.rs:9:61 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn sort_dir_entries(sort_order: SortOrder, dir_entries: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 9 - pub fn sort_dir_entries(sort_order: SortOrder, dir_entries: &mut Vec) { [INFO] [stdout] 9 + pub fn sort_dir_entries(sort_order: SortOrder, dir_entries: &mut [FileEntry]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/file_entry/sort.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | dir_entries.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 18 - dir_entries.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 18 + dir_entries.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/file_entry/sort.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | dir_entries.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 18 - dir_entries.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 18 + dir_entries.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/index_files/_command.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | if !fs::metadata(trimmed_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(trimmed_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/index_files/_command.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | if !fs::metadata(trimmed_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(trimmed_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/search_files/try_get_dir_entries.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | / if let Err(e) = check_input(path) { [INFO] [stdout] 25 | | return Err(e); [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ help: replace it with: `check_input(path)?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/search_files/try_get_dir_entries.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | / if let Err(e) = check_input(path) { [INFO] [stdout] 25 | | return Err(e); [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ help: replace it with: `check_input(path)?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/search_files/try_get_dir_entries.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | io::Error::new(io::ErrorKind::Other, "Failed to read directory") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 47 - io::Error::new(io::ErrorKind::Other, "Failed to read directory") [INFO] [stdout] 47 + io::Error::other("Failed to read directory") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/search_files/try_get_dir_entries.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | io::Error::new(io::ErrorKind::Other, "Failed to read directory") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 47 - io::Error::new(io::ErrorKind::Other, "Failed to read directory") [INFO] [stdout] 47 + io::Error::other("Failed to read directory") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/search_files/try_get_dir_entries.rs:60:36 [INFO] [stdout] | [INFO] [stdout] 60 | return Err(io::Error::new( [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 61 | | io::ErrorKind::Other, [INFO] [stdout] 62 | | "Failed to convert directory entry", [INFO] [stdout] 63 | | )); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 60 ~ return Err(io::Error::other( [INFO] [stdout] 61 ~ "Failed to convert directory entry", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/search_files/try_get_dir_entries.rs:60:36 [INFO] [stdout] | [INFO] [stdout] 60 | return Err(io::Error::new( [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 61 | | io::ErrorKind::Other, [INFO] [stdout] 62 | | "Failed to convert directory entry", [INFO] [stdout] 63 | | )); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 60 ~ return Err(io::Error::other( [INFO] [stdout] 61 ~ "Failed to convert directory entry", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/search_files/try_get_dir_entries.rs:69:28 [INFO] [stdout] | [INFO] [stdout] 69 | return Err(io::Error::new( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 70 | | io::ErrorKind::Other, [INFO] [stdout] 71 | | "Failed to read directory entry", [INFO] [stdout] 72 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 69 ~ return Err(io::Error::other( [INFO] [stdout] 70 ~ "Failed to read directory entry", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/search_files/try_get_dir_entries.rs:69:28 [INFO] [stdout] | [INFO] [stdout] 69 | return Err(io::Error::new( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 70 | | io::ErrorKind::Other, [INFO] [stdout] 71 | | "Failed to read directory entry", [INFO] [stdout] 72 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 69 ~ return Err(io::Error::other( [INFO] [stdout] 70 ~ "Failed to read directory entry", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `file_names_table_result` after checking its variant with `is_err` [INFO] [stdout] --> src/sql/database.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 18 | if file_names_table_result.is_err() { [INFO] [stdout] | ----------------------------------- help: try: `if let Err() = file_names_table_result` [INFO] [stdout] ... [INFO] [stdout] 23 | return Err(file_names_table_result.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `files_table_result` after checking its variant with `is_err` [INFO] [stdout] --> src/sql/database.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 43 | if files_table_result.is_err() { [INFO] [stdout] | ------------------------------ help: try: `if let Err() = files_table_result` [INFO] [stdout] 44 | eprintln!("Failed to create 'files' table: {:?}", files_table_result); [INFO] [stdout] 45 | return Err(files_table_result.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `indexes_result` after checking its variant with `is_err` [INFO] [stdout] --> src/sql/database.rs:60:20 [INFO] [stdout] | [INFO] [stdout] 58 | if indexes_result.is_err() { [INFO] [stdout] | -------------------------- help: try: `if let Err() = indexes_result` [INFO] [stdout] 59 | eprintln!("Failed to create indexes: {:?}", indexes_result); [INFO] [stdout] 60 | return Err(indexes_result.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sql/database.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return Ok(()); [INFO] [stdout] 63 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `file_names_table_result` after checking its variant with `is_err` [INFO] [stdout] --> src/sql/database.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 18 | if file_names_table_result.is_err() { [INFO] [stdout] | ----------------------------------- help: try: `if let Err() = file_names_table_result` [INFO] [stdout] ... [INFO] [stdout] 23 | return Err(file_names_table_result.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `files_table_result` after checking its variant with `is_err` [INFO] [stdout] --> src/sql/database.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 43 | if files_table_result.is_err() { [INFO] [stdout] | ------------------------------ help: try: `if let Err() = files_table_result` [INFO] [stdout] 44 | eprintln!("Failed to create 'files' table: {:?}", files_table_result); [INFO] [stdout] 45 | return Err(files_table_result.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `indexes_result` after checking its variant with `is_err` [INFO] [stdout] --> src/sql/database.rs:60:20 [INFO] [stdout] | [INFO] [stdout] 58 | if indexes_result.is_err() { [INFO] [stdout] | -------------------------- help: try: `if let Err() = indexes_result` [INFO] [stdout] 59 | eprintln!("Failed to create indexes: {:?}", indexes_result); [INFO] [stdout] 60 | return Err(indexes_result.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sql/database.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return Ok(()); [INFO] [stdout] 63 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/sql/search.rs:47:31 [INFO] [stdout] | [INFO] [stdout] 47 | PatternKind::Exact => format!("{}", name), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/sql/search.rs:47:31 [INFO] [stdout] | [INFO] [stdout] 47 | PatternKind::Exact => format!("{}", name), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/services/search_service.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return Ok(entries); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ Ok(entries) [INFO] [stdout] 41 | } [INFO] [stdout] ... [INFO] [stdout] 45 | } [INFO] [stdout] 46 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/services/search_service.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 ~ Err(io::Error::new(io::ErrorKind::Other, e.to_string())) [INFO] [stdout] 45 | } [INFO] [stdout] 46 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/services/search_service.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return Ok(entries); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ Ok(entries) [INFO] [stdout] 41 | } [INFO] [stdout] ... [INFO] [stdout] 45 | } [INFO] [stdout] 46 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/services/search_service.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 ~ Err(io::Error::new(io::ErrorKind::Other, e.to_string())) [INFO] [stdout] 45 | } [INFO] [stdout] 46 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/services/search_service.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 18 - io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] 18 + io::Error::other(e.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/services/search_service.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 18 - io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] 18 + io::Error::other(e.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/services/search_service.rs:26:24 [INFO] [stdout] | [INFO] [stdout] 26 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 26 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 26 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/services/search_service.rs:26:24 [INFO] [stdout] | [INFO] [stdout] 26 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 26 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 26 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/services/search_service.rs:44:24 [INFO] [stdout] | [INFO] [stdout] 44 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 44 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 44 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/services/search_service.rs:44:24 [INFO] [stdout] | [INFO] [stdout] 44 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 44 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 44 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/commands/commands_loop.rs:33:32 [INFO] [stdout] | [INFO] [stdout] 33 | None => pb.println("[error] Command not found.".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"[error] Command not found."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/commands/commands_loop.rs:33:32 [INFO] [stdout] | [INFO] [stdout] 33 | None => pb.println("[error] Command not found.".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"[error] Command not found."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/commands/commands_progress_bar.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return pb; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return pb; [INFO] [stdout] 18 + pb [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/commands/commands_progress_bar.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return pb; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return pb; [INFO] [stdout] 18 + pb [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_index_files.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 44 - io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] 44 + io::Error::other(e.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_index_files.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 44 - io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] 44 + io::Error::other(e.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_index_files.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 60 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 60 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 60 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_index_files.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 60 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 60 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 60 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_index_files.rs:78:32 [INFO] [stdout] | [INFO] [stdout] 78 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 78 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 78 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_index_files.rs:78:32 [INFO] [stdout] | [INFO] [stdout] 78 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 78 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 78 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_index_files.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 85 - io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] 85 + io::Error::other(e.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_index_files.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 85 - io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] 85 + io::Error::other(e.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/commands/command_index_files.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | return Ok(directories); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - return Ok(directories); [INFO] [stdout] 160 + Ok(directories) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/command_index_files.rs:106:45 [INFO] [stdout] | [INFO] [stdout] 106 | let entries = match try_get_dir_entries(&path, None) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/commands/command_index_files.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | return Ok(directories); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - return Ok(directories); [INFO] [stdout] 160 + Ok(directories) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/command_index_files.rs:106:45 [INFO] [stdout] | [INFO] [stdout] 106 | let entries = match try_get_dir_entries(&path, None) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_index_files.rs:114:24 [INFO] [stdout] | [INFO] [stdout] 114 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 114 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 114 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_index_files.rs:114:24 [INFO] [stdout] | [INFO] [stdout] 114 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 114 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 114 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/command_index_files.rs:125:27 [INFO] [stdout] | [INFO] [stdout] 125 | match insert_file(&transaction, &entry, file_name_id.unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/command_index_files.rs:125:27 [INFO] [stdout] | [INFO] [stdout] 125 | match insert_file(&transaction, &entry, file_name_id.unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_index_files.rs:133:28 [INFO] [stdout] | [INFO] [stdout] 133 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 133 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 133 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_index_files.rs:133:28 [INFO] [stdout] | [INFO] [stdout] 133 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 133 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 133 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/commands/command_index_files.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 192 | return Ok(inserted_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 - return Ok(inserted_id); [INFO] [stdout] 192 + Ok(inserted_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/commands/command_index_files.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 192 | return Ok(inserted_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 - return Ok(inserted_id); [INFO] [stdout] 192 + Ok(inserted_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/command_index_files.rs:183:46 [INFO] [stdout] | [INFO] [stdout] 183 | let inserted_id = match insert_file_name(&transaction, &file_name) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/command_index_files.rs:183:46 [INFO] [stdout] | [INFO] [stdout] 183 | let inserted_id = match insert_file_name(&transaction, &file_name) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/command_index_files.rs:183:60 [INFO] [stdout] | [INFO] [stdout] 183 | let inserted_id = match insert_file_name(&transaction, &file_name) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/command_index_files.rs:183:60 [INFO] [stdout] | [INFO] [stdout] 183 | let inserted_id = match insert_file_name(&transaction, &file_name) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_index_files.rs:188:24 [INFO] [stdout] | [INFO] [stdout] 188 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 188 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 188 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_index_files.rs:188:24 [INFO] [stdout] | [INFO] [stdout] 188 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 188 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 188 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `init_db_result` after checking its variant with `is_err` [INFO] [stdout] --> src/commands/command_init_db.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 35 | if init_db_result.is_err() { [INFO] [stdout] | -------------------------- help: try: `if let Err() = init_db_result` [INFO] [stdout] ... [INFO] [stdout] 39 | init_db_result.unwrap_err().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `init_db_result` after checking its variant with `is_err` [INFO] [stdout] --> src/commands/command_init_db.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 35 | if init_db_result.is_err() { [INFO] [stdout] | -------------------------- help: try: `if let Err() = init_db_result` [INFO] [stdout] ... [INFO] [stdout] 39 | init_db_result.unwrap_err().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_init_db.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 10 - io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] 10 + io::Error::other(e.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_init_db.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 10 - io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] 10 + io::Error::other(e.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_init_db.rs:19:24 [INFO] [stdout] | [INFO] [stdout] 19 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 19 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 19 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_init_db.rs:19:24 [INFO] [stdout] | [INFO] [stdout] 19 | return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 19 - return Err(io::Error::new(io::ErrorKind::Other, e.to_string())); [INFO] [stdout] 19 + return Err(io::Error::other(e.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_init_db.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | return Err(io::Error::new( [INFO] [stdout] | ____________________^ [INFO] [stdout] 38 | | io::ErrorKind::Other, [INFO] [stdout] 39 | | init_db_result.unwrap_err().to_string(), [INFO] [stdout] 40 | | )); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 37 ~ return Err(io::Error::other( [INFO] [stdout] 38 ~ init_db_result.unwrap_err().to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_init_db.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | return Err(io::Error::new( [INFO] [stdout] | ____________________^ [INFO] [stdout] 38 | | io::ErrorKind::Other, [INFO] [stdout] 39 | | init_db_result.unwrap_err().to_string(), [INFO] [stdout] 40 | | )); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 37 ~ return Err(io::Error::other( [INFO] [stdout] 38 ~ init_db_result.unwrap_err().to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_init_db.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 45 - io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] 45 + io::Error::other(e.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_init_db.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 45 - io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] 45 + io::Error::other(e.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_search_file.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 104 - io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] 104 + io::Error::other(e.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/commands/command_search_file.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 104 - io::Error::new(io::ErrorKind::Other, e.to_string()) [INFO] [stdout] 104 + io::Error::other(e.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/commands/command_search_file.rs:118:14 [INFO] [stdout] | [INFO] [stdout] 118 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/commands/command_search_file.rs:118:14 [INFO] [stdout] | [INFO] [stdout] 118 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.79s [INFO] running `Command { std: "docker" "inspect" "46dc3e8135eb32ee456de78576c46ee01b69a991a8e1d9eddd02da11a6dca8dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46dc3e8135eb32ee456de78576c46ee01b69a991a8e1d9eddd02da11a6dca8dc", kill_on_drop: false }` [INFO] [stdout] 46dc3e8135eb32ee456de78576c46ee01b69a991a8e1d9eddd02da11a6dca8dc