[INFO] cloning repository https://github.com/3mber666/Btree [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/3mber666/Btree" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F3mber666%2FBtree", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F3mber666%2FBtree'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f90c23736e32c4fd461ff223e9d770d3720cf0c7 [INFO] linting 3mber666/Btree against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F3mber666%2FBtree" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/3mber666/Btree [INFO] finished tweaking git repo https://github.com/3mber666/Btree [INFO] tweaked toml for git repo https://github.com/3mber666/Btree written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/3mber666/Btree on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/3mber666/Btree already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 32426d59f4d2486fe1b005df39e0dec89595ee918a39052c5b5bda8ac8bfb560 [INFO] running `Command { std: "docker" "start" "-a" "32426d59f4d2486fe1b005df39e0dec89595ee918a39052c5b5bda8ac8bfb560", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "32426d59f4d2486fe1b005df39e0dec89595ee918a39052c5b5bda8ac8bfb560", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32426d59f4d2486fe1b005df39e0dec89595ee918a39052c5b5bda8ac8bfb560", kill_on_drop: false }` [INFO] [stdout] 32426d59f4d2486fe1b005df39e0dec89595ee918a39052c5b5bda8ac8bfb560 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1419b88ed0e474999f90053984686d66d5f7c910d85648e37953cbeb27c0d2b4 [INFO] running `Command { std: "docker" "start" "-a" "1419b88ed0e474999f90053984686d66d5f7c910d85648e37953cbeb27c0d2b4", kill_on_drop: false }` [INFO] [stderr] Checking balance_rotate_btrees v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `PartialEq` and `PartialOrd` [INFO] [stdout] --> src/main.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{cmp::{PartialEq, PartialOrd}}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PartialEq` and `PartialOrd` [INFO] [stdout] --> src/main.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{cmp::{PartialEq, PartialOrd}}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Btree` is never constructed [INFO] [stdout] --> src/main.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | struct Btree { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Node` is never constructed [INFO] [stdout] --> src/main.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | struct Node { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Tree` is never constructed [INFO] [stdout] --> src/main.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 20 | struct Tree(Option>>); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `insert`, `to_sorted_vector`, and `search_node` are never used [INFO] [stdout] --> src/main.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 23 | impl Btree { [INFO] [stdout] | --------------------- associated items in this implementation [INFO] [stdout] 24 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 28 | fn insert(&mut self, payload: T) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | fn to_sorted_vector(self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | fn search_node(self, target: T) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/main.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 41 | impl Node { [INFO] [stdout] | -------------------- associated function in this implementation [INFO] [stdout] 42 | fn new(payload: T) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `insert`, `to_sorted_vector`, and `search_node` are never used [INFO] [stdout] --> src/main.rs:63:8 [INFO] [stdout] | [INFO] [stdout] 61 | impl Tree { [INFO] [stdout] | -------------------- methods in this implementation [INFO] [stdout] 62 | [INFO] [stdout] 63 | fn insert(&mut self, payload: T) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 77 | fn to_sorted_vector(self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 90 | fn search_node(self, target: T) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/main.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 32 | fn to_sorted_vector(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/main.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | fn to_sorted_vector(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 91 | let isTrue = self.to_sorted_vector().contains(&target); [INFO] [stdout] | ------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 92 | isTrue [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 91 ~ [INFO] [stdout] 92 ~ self.to_sorted_vector().contains(&target) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `isTrue` should have a snake case name [INFO] [stdout] --> src/main.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | let isTrue = self.to_sorted_vector().contains(&target); [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `is_true` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/main.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 32 | fn to_sorted_vector(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/main.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | fn to_sorted_vector(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 91 | let isTrue = self.to_sorted_vector().contains(&target); [INFO] [stdout] | ------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 92 | isTrue [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 91 ~ [INFO] [stdout] 92 ~ self.to_sorted_vector().contains(&target) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/main.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | assert_eq!(root.search_node(5), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 122 - assert_eq!(root.search_node(5), true); [INFO] [stdout] 122 + assert!(root.search_node(5)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:135:38 [INFO] [stdout] | [INFO] [stdout] 135 | assert_eq!(root.search_node(99), !true); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `isTrue` should have a snake case name [INFO] [stdout] --> src/main.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | let isTrue = self.to_sorted_vector().contains(&target); [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `is_true` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s [INFO] running `Command { std: "docker" "inspect" "1419b88ed0e474999f90053984686d66d5f7c910d85648e37953cbeb27c0d2b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1419b88ed0e474999f90053984686d66d5f7c910d85648e37953cbeb27c0d2b4", kill_on_drop: false }` [INFO] [stdout] 1419b88ed0e474999f90053984686d66d5f7c910d85648e37953cbeb27c0d2b4