[INFO] cloning repository https://github.com/371tti/x-casl2 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/371tti/x-casl2" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F371tti%2Fx-casl2", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F371tti%2Fx-casl2'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0e8df455a0069b436c6e1ec4ac9444aaca358b00 [INFO] linting 371tti/x-casl2 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F371tti%2Fx-casl2" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/371tti/x-casl2 [INFO] finished tweaking git repo https://github.com/371tti/x-casl2 [INFO] tweaked toml for git repo https://github.com/371tti/x-casl2 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/371tti/x-casl2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/371tti/x-casl2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 16a04b2fa4de120a4a83f71266e230e4a2d4ed8f204665f0f7aa0652a2a8e76d [INFO] running `Command { std: "docker" "start" "-a" "16a04b2fa4de120a4a83f71266e230e4a2d4ed8f204665f0f7aa0652a2a8e76d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "16a04b2fa4de120a4a83f71266e230e4a2d4ed8f204665f0f7aa0652a2a8e76d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16a04b2fa4de120a4a83f71266e230e4a2d4ed8f204665f0f7aa0652a2a8e76d", kill_on_drop: false }` [INFO] [stdout] 16a04b2fa4de120a4a83f71266e230e4a2d4ed8f204665f0f7aa0652a2a8e76d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae880e8103bf69fbd335b3aba03059b4a73f8d3a9e7a66a1a1393a676870aeb5 [INFO] running `Command { std: "docker" "start" "-a" "ae880e8103bf69fbd335b3aba03059b4a73f8d3a9e7a66a1a1393a676870aeb5", kill_on_drop: false }` [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking x-casl2 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `thread::LocalKey` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{fmt::Debug, thread::LocalKey}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DecResult` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:3:68 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::emurator::commet2::{alu::{ALUExecution, ALU}, decoder::{DecResult, Decoder, DecoderExecution}, prefix::{decoder_cycle, fet... [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thread::LocalKey` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{fmt::Debug, thread::LocalKey}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DecResult` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:3:68 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::emurator::commet2::{alu::{ALUExecution, ALU}, decoder::{DecResult, Decoder, DecoderExecution}, prefix::{decoder_cycle, fet... [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:144:33 [INFO] [stdout] | [INFO] [stdout] 144 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:156:37 [INFO] [stdout] | [INFO] [stdout] 156 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:165:37 [INFO] [stdout] | [INFO] [stdout] 165 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:144:33 [INFO] [stdout] | [INFO] [stdout] 144 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:183:41 [INFO] [stdout] | [INFO] [stdout] 183 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:192:41 [INFO] [stdout] | [INFO] [stdout] 192 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:156:37 [INFO] [stdout] | [INFO] [stdout] 156 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:165:37 [INFO] [stdout] | [INFO] [stdout] 165 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:212:41 [INFO] [stdout] | [INFO] [stdout] 212 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:183:41 [INFO] [stdout] | [INFO] [stdout] 183 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:192:41 [INFO] [stdout] | [INFO] [stdout] 192 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:212:41 [INFO] [stdout] | [INFO] [stdout] 212 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `VecDeque` [INFO] [stdout] --> src/emurator/casl2/code_gen.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::{HashMap, VecDeque}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `commet2::prefix::opecode_to_binary`, `err::Casl2AssemblerError`, and `prefix::assembler_instructions` [INFO] [stdout] --> src/emurator/casl2/code_gen.rs:3:31 [INFO] [stdout] | [INFO] [stdout] 3 | ...:{casl2::{err::Casl2AssemblerError, parser::ASTNode, prefix::assembler_instructions}, commet2::prefix::opecode_to_binary}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `VecDeque` [INFO] [stdout] --> src/emurator/casl2/code_gen.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::{HashMap, VecDeque}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `commet2::prefix::opecode_to_binary`, `err::Casl2AssemblerError`, and `prefix::assembler_instructions` [INFO] [stdout] --> src/emurator/casl2/code_gen.rs:3:31 [INFO] [stdout] | [INFO] [stdout] 3 | ...:{casl2::{err::Casl2AssemblerError, parser::ASTNode, prefix::assembler_instructions}, commet2::prefix::opecode_to_binary}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mode` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:93:24 [INFO] [stdout] | [INFO] [stdout] 93 | fn init(&mut self, mode: InitMode) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_mode` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mode` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:93:24 [INFO] [stdout] | [INFO] [stdout] 93 | fn init(&mut self, mode: InitMode) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_mode` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPUState` [INFO] [stdout] --> src/emurator/commet2/state.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 132 | / pub fn new() -> Self { [INFO] [stdout] 133 | | CPUState { [INFO] [stdout] 134 | | machine_cycle: 0, [INFO] [stdout] 135 | | step_cycle: 0, [INFO] [stdout] ... | [INFO] [stdout] 162 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 130 + impl Default for CPUState { [INFO] [stdout] 131 + fn default() -> Self { [INFO] [stdout] 132 + Self::new() [INFO] [stdout] 133 + } [INFO] [stdout] 134 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPUState` [INFO] [stdout] --> src/emurator/commet2/state.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 132 | / pub fn new() -> Self { [INFO] [stdout] 133 | | CPUState { [INFO] [stdout] 134 | | machine_cycle: 0, [INFO] [stdout] 135 | | step_cycle: 0, [INFO] [stdout] ... | [INFO] [stdout] 162 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 130 + impl Default for CPUState { [INFO] [stdout] 131 + fn default() -> Self { [INFO] [stdout] 132 + Self::new() [INFO] [stdout] 133 + } [INFO] [stdout] 134 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:106:22 [INFO] [stdout] | [INFO] [stdout] 106 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:106:22 [INFO] [stdout] | [INFO] [stdout] 106 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:119:22 [INFO] [stdout] | [INFO] [stdout] 119 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:119:22 [INFO] [stdout] | [INFO] [stdout] 119 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:170:22 [INFO] [stdout] | [INFO] [stdout] 170 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:170:22 [INFO] [stdout] | [INFO] [stdout] 170 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:187:22 [INFO] [stdout] | [INFO] [stdout] 187 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:187:22 [INFO] [stdout] | [INFO] [stdout] 187 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPU` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | / pub fn new() -> Self { [INFO] [stdout] 82 | | CPU { [INFO] [stdout] 83 | | state: CPUState::new(), [INFO] [stdout] 84 | | alu: ALU, [INFO] [stdout] ... | [INFO] [stdout] 87 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 80 + impl Default for CPU { [INFO] [stdout] 81 + fn default() -> Self { [INFO] [stdout] 82 + Self::new() [INFO] [stdout] 83 + } [INFO] [stdout] 84 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPU` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | / pub fn new() -> Self { [INFO] [stdout] 82 | | CPU { [INFO] [stdout] 83 | | state: CPUState::new(), [INFO] [stdout] 84 | | alu: ALU, [INFO] [stdout] ... | [INFO] [stdout] 87 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 80 + impl Default for CPU { [INFO] [stdout] 81 + fn default() -> Self { [INFO] [stdout] 82 + Self::new() [INFO] [stdout] 83 + } [INFO] [stdout] 84 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/emurator/commet2/cpu.rs:776:20 [INFO] [stdout] | [INFO] [stdout] 776 | if fr[1] == true{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `fr[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/emurator/commet2/cpu.rs:788:20 [INFO] [stdout] | [INFO] [stdout] 788 | if fr[2] == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!fr[2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/emurator/commet2/cpu.rs:800:20 [INFO] [stdout] | [INFO] [stdout] 800 | if fr[2] == true { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `fr[2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/emurator/commet2/cpu.rs:776:20 [INFO] [stdout] | [INFO] [stdout] 776 | if fr[1] == true{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `fr[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/emurator/commet2/cpu.rs:818:20 [INFO] [stdout] | [INFO] [stdout] 818 | if fr[1] == false && fr[2] == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!fr[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/emurator/commet2/cpu.rs:818:38 [INFO] [stdout] | [INFO] [stdout] 818 | if fr[1] == false && fr[2] == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!fr[2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/emurator/commet2/cpu.rs:788:20 [INFO] [stdout] | [INFO] [stdout] 788 | if fr[2] == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!fr[2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/emurator/commet2/cpu.rs:830:20 [INFO] [stdout] | [INFO] [stdout] 830 | if fr[0] == true { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `fr[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/emurator/commet2/cpu.rs:800:20 [INFO] [stdout] | [INFO] [stdout] 800 | if fr[2] == true { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `fr[2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/emurator/commet2/cpu.rs:818:20 [INFO] [stdout] | [INFO] [stdout] 818 | if fr[1] == false && fr[2] == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!fr[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/emurator/commet2/cpu.rs:818:38 [INFO] [stdout] | [INFO] [stdout] 818 | if fr[1] == false && fr[2] == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!fr[2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/emurator/commet2/cpu.rs:830:20 [INFO] [stdout] | [INFO] [stdout] 830 | if fr[0] == true { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `fr[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/emurator/commet2/decoder.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / match opcode { [INFO] [stdout] 25 | | instruction::w1::NOP [INFO] [stdout] 26 | | | instruction::w1::LD [INFO] [stdout] 27 | | | instruction::w1::ADDA [INFO] [stdout] ... | [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 24 ~ !matches!(opcode, instruction::w1::NOP [INFO] [stdout] 25 + | instruction::w1::LD [INFO] [stdout] 26 + | instruction::w1::ADDA [INFO] [stdout] 27 + | instruction::w1::SUBA [INFO] [stdout] 28 + | instruction::w1::ADDL [INFO] [stdout] 29 + | instruction::w1::SUBL [INFO] [stdout] 30 + | instruction::w1::AND [INFO] [stdout] 31 + | instruction::w1::OR [INFO] [stdout] 32 + | instruction::w1::XOR [INFO] [stdout] 33 + | instruction::w1::CPA [INFO] [stdout] 34 + | instruction::w1::CPL [INFO] [stdout] 35 + | instruction::w1::POP [INFO] [stdout] 36 + | instruction::w1::RET) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/emurator/commet2/decoder.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / match opcode { [INFO] [stdout] 25 | | instruction::w1::NOP [INFO] [stdout] 26 | | | instruction::w1::LD [INFO] [stdout] 27 | | | instruction::w1::ADDA [INFO] [stdout] ... | [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 24 ~ !matches!(opcode, instruction::w1::NOP [INFO] [stdout] 25 + | instruction::w1::LD [INFO] [stdout] 26 + | instruction::w1::ADDA [INFO] [stdout] 27 + | instruction::w1::SUBA [INFO] [stdout] 28 + | instruction::w1::ADDL [INFO] [stdout] 29 + | instruction::w1::SUBL [INFO] [stdout] 30 + | instruction::w1::AND [INFO] [stdout] 31 + | instruction::w1::OR [INFO] [stdout] 32 + | instruction::w1::XOR [INFO] [stdout] 33 + | instruction::w1::CPA [INFO] [stdout] 34 + | instruction::w1::CPL [INFO] [stdout] 35 + | instruction::w1::POP [INFO] [stdout] 36 + | instruction::w1::RET) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/emurator/commet2/prefix.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 82 | / let chars = match opcode { [INFO] [stdout] 83 | | instruction::w1::NOP => ['N', 'O', 'P', ' '], [INFO] [stdout] 84 | | instruction::w1::LD => ['L', 'D', ' ', ' '], [INFO] [stdout] 85 | | instruction::w1::ADDA => ['A', 'D', 'D', 'A'], [INFO] [stdout] ... | [INFO] [stdout] 121 | | _ => ['I', 'D', 'K', '?'], // Unknown opcode [INFO] [stdout] 122 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 123 | chars [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 82 ~ [INFO] [stdout] 83 ~ match opcode { [INFO] [stdout] 84 + instruction::w1::NOP => ['N', 'O', 'P', ' '], [INFO] [stdout] 85 + instruction::w1::LD => ['L', 'D', ' ', ' '], [INFO] [stdout] 86 + instruction::w1::ADDA => ['A', 'D', 'D', 'A'], [INFO] [stdout] 87 + instruction::w1::SUBA => ['S', 'U', 'B', 'A'], [INFO] [stdout] 88 + instruction::w1::ADDL => ['A', 'D', 'D', 'L'], [INFO] [stdout] 89 + instruction::w1::SUBL => ['S', 'U', 'B', 'L'], [INFO] [stdout] 90 + instruction::w1::AND => ['A', 'N', 'D', ' '], [INFO] [stdout] 91 + instruction::w1::OR => ['O', 'R', ' ', ' '], [INFO] [stdout] 92 + instruction::w1::XOR => ['X', 'O', 'R', ' '], [INFO] [stdout] 93 + instruction::w1::CPA => ['C', 'P', 'A', ' '], [INFO] [stdout] 94 + instruction::w1::CPL => ['C', 'P', 'L', ' '], [INFO] [stdout] 95 + instruction::w1::POP => ['P', 'O', 'P', ' '], [INFO] [stdout] 96 + instruction::w1::RET => ['R', 'E', 'T', ' '], [INFO] [stdout] 97 + instruction::w2::LD => ['L', 'D', ' ', ' '], [INFO] [stdout] 98 + instruction::w2::ST => ['S', 'T', ' ', ' '], [INFO] [stdout] 99 + instruction::w2::LAD => ['L', 'D', 'A', ' '], [INFO] [stdout] 100 + instruction::w2::ADDA => ['A', 'D', 'D', 'A'], [INFO] [stdout] 101 + instruction::w2::SUBA => ['S', 'U', 'B', 'A'], [INFO] [stdout] 102 + instruction::w2::ADDL => ['A', 'D', 'D', 'L'], [INFO] [stdout] 103 + instruction::w2::SUBL => ['S', 'U', 'B', 'L'], [INFO] [stdout] 104 + instruction::w2::AND => ['A', 'N', 'D', ' '], [INFO] [stdout] 105 + instruction::w2::OR => ['O', 'R', ' ', ' '], [INFO] [stdout] 106 + instruction::w2::XOR => ['X', 'O', 'R', ' '], [INFO] [stdout] 107 + instruction::w2::CPA => ['C', 'P', 'A', ' '], [INFO] [stdout] 108 + instruction::w2::CPL => ['C', 'P', 'L', ' '], [INFO] [stdout] 109 + instruction::w2::SLA => ['S', 'L', 'A', ' '], [INFO] [stdout] 110 + instruction::w2::SRA => ['S', 'R', 'A', ' '], [INFO] [stdout] 111 + instruction::w2::SLL => ['S', 'L', 'L', ' '], [INFO] [stdout] 112 + instruction::w2::SRL => ['S', 'R', 'L', ' '], [INFO] [stdout] 113 + instruction::w2::JMI => ['J', 'M', 'I', ' '], [INFO] [stdout] 114 + instruction::w2::JNZ => ['J', 'N', 'Z', ' '], [INFO] [stdout] 115 + instruction::w2::JZE => ['J', 'Z', 'E', ' '], [INFO] [stdout] 116 + instruction::w2::JUMP => ['J', 'U', 'M', 'P'], [INFO] [stdout] 117 + instruction::w2::JPL => ['J', 'P', 'L', ' '], [INFO] [stdout] 118 + instruction::w2::JOV => ['J', 'O', 'V', ' '], [INFO] [stdout] 119 + instruction::w2::PUSH => ['P', 'U', 'S', 'H'], [INFO] [stdout] 120 + instruction::w2::CALL => ['C', 'A', 'L', 'L'], [INFO] [stdout] 121 + instruction::w2::SVC => ['S', 'V', 'C', ' '], [INFO] [stdout] 122 + _ => ['I', 'D', 'K', '?'], // Unknown opcode [INFO] [stdout] 123 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/emurator/commet2/prefix.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 82 | / let chars = match opcode { [INFO] [stdout] 83 | | instruction::w1::NOP => ['N', 'O', 'P', ' '], [INFO] [stdout] 84 | | instruction::w1::LD => ['L', 'D', ' ', ' '], [INFO] [stdout] 85 | | instruction::w1::ADDA => ['A', 'D', 'D', 'A'], [INFO] [stdout] ... | [INFO] [stdout] 121 | | _ => ['I', 'D', 'K', '?'], // Unknown opcode [INFO] [stdout] 122 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 123 | chars [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 82 ~ [INFO] [stdout] 83 ~ match opcode { [INFO] [stdout] 84 + instruction::w1::NOP => ['N', 'O', 'P', ' '], [INFO] [stdout] 85 + instruction::w1::LD => ['L', 'D', ' ', ' '], [INFO] [stdout] 86 + instruction::w1::ADDA => ['A', 'D', 'D', 'A'], [INFO] [stdout] 87 + instruction::w1::SUBA => ['S', 'U', 'B', 'A'], [INFO] [stdout] 88 + instruction::w1::ADDL => ['A', 'D', 'D', 'L'], [INFO] [stdout] 89 + instruction::w1::SUBL => ['S', 'U', 'B', 'L'], [INFO] [stdout] 90 + instruction::w1::AND => ['A', 'N', 'D', ' '], [INFO] [stdout] 91 + instruction::w1::OR => ['O', 'R', ' ', ' '], [INFO] [stdout] 92 + instruction::w1::XOR => ['X', 'O', 'R', ' '], [INFO] [stdout] 93 + instruction::w1::CPA => ['C', 'P', 'A', ' '], [INFO] [stdout] 94 + instruction::w1::CPL => ['C', 'P', 'L', ' '], [INFO] [stdout] 95 + instruction::w1::POP => ['P', 'O', 'P', ' '], [INFO] [stdout] 96 + instruction::w1::RET => ['R', 'E', 'T', ' '], [INFO] [stdout] 97 + instruction::w2::LD => ['L', 'D', ' ', ' '], [INFO] [stdout] 98 + instruction::w2::ST => ['S', 'T', ' ', ' '], [INFO] [stdout] 99 + instruction::w2::LAD => ['L', 'D', 'A', ' '], [INFO] [stdout] 100 + instruction::w2::ADDA => ['A', 'D', 'D', 'A'], [INFO] [stdout] 101 + instruction::w2::SUBA => ['S', 'U', 'B', 'A'], [INFO] [stdout] 102 + instruction::w2::ADDL => ['A', 'D', 'D', 'L'], [INFO] [stdout] 103 + instruction::w2::SUBL => ['S', 'U', 'B', 'L'], [INFO] [stdout] 104 + instruction::w2::AND => ['A', 'N', 'D', ' '], [INFO] [stdout] 105 + instruction::w2::OR => ['O', 'R', ' ', ' '], [INFO] [stdout] 106 + instruction::w2::XOR => ['X', 'O', 'R', ' '], [INFO] [stdout] 107 + instruction::w2::CPA => ['C', 'P', 'A', ' '], [INFO] [stdout] 108 + instruction::w2::CPL => ['C', 'P', 'L', ' '], [INFO] [stdout] 109 + instruction::w2::SLA => ['S', 'L', 'A', ' '], [INFO] [stdout] 110 + instruction::w2::SRA => ['S', 'R', 'A', ' '], [INFO] [stdout] 111 + instruction::w2::SLL => ['S', 'L', 'L', ' '], [INFO] [stdout] 112 + instruction::w2::SRL => ['S', 'R', 'L', ' '], [INFO] [stdout] 113 + instruction::w2::JMI => ['J', 'M', 'I', ' '], [INFO] [stdout] 114 + instruction::w2::JNZ => ['J', 'N', 'Z', ' '], [INFO] [stdout] 115 + instruction::w2::JZE => ['J', 'Z', 'E', ' '], [INFO] [stdout] 116 + instruction::w2::JUMP => ['J', 'U', 'M', 'P'], [INFO] [stdout] 117 + instruction::w2::JPL => ['J', 'P', 'L', ' '], [INFO] [stdout] 118 + instruction::w2::JOV => ['J', 'O', 'V', ' '], [INFO] [stdout] 119 + instruction::w2::PUSH => ['P', 'U', 'S', 'H'], [INFO] [stdout] 120 + instruction::w2::CALL => ['C', 'A', 'L', 'L'], [INFO] [stdout] 121 + instruction::w2::SVC => ['S', 'V', 'C', ' '], [INFO] [stdout] 122 + _ => ['I', 'D', 'K', '?'], // Unknown opcode [INFO] [stdout] 123 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/emurator/casl2/parser.rs:84:47 [INFO] [stdout] | [INFO] [stdout] 84 | if operands.len() != 1 || !operands[0].parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `operands[0].parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:201:33 [INFO] [stdout] | [INFO] [stdout] 201 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 201 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:220:37 [INFO] [stdout] | [INFO] [stdout] 220 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid second operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid second operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 220 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid second operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:223:33 [INFO] [stdout] | [INFO] [stdout] 223 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 223 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:227:29 [INFO] [stdout] | [INFO] [stdout] 227 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid number of operands for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 227 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid number of operands for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 227 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid number of operands for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/emurator/casl2/parser.rs:84:47 [INFO] [stdout] | [INFO] [stdout] 84 | if operands.len() != 1 || !operands[0].parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `operands[0].parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:201:33 [INFO] [stdout] | [INFO] [stdout] 201 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 201 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:220:37 [INFO] [stdout] | [INFO] [stdout] 220 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid second operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid second operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 220 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid second operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:223:33 [INFO] [stdout] | [INFO] [stdout] 223 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 223 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:227:29 [INFO] [stdout] | [INFO] [stdout] 227 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid number of operands for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 227 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid number of operands for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 227 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid number of operands for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/main.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{self, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/main.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{self, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thread::LocalKey` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{fmt::Debug, thread::LocalKey}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DecResult` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:3:68 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::emurator::commet2::{alu::{ALUExecution, ALU}, decoder::{DecResult, Decoder, DecoderExecution}, prefix::{decoder_cycle, fet... [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thread::LocalKey` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{fmt::Debug, thread::LocalKey}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DecResult` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:3:68 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::emurator::commet2::{alu::{ALUExecution, ALU}, decoder::{DecResult, Decoder, DecoderExecution}, prefix::{decoder_cycle, fet... [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:144:33 [INFO] [stdout] | [INFO] [stdout] 144 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:156:37 [INFO] [stdout] | [INFO] [stdout] 156 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:165:37 [INFO] [stdout] | [INFO] [stdout] 165 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:183:41 [INFO] [stdout] | [INFO] [stdout] 183 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:192:41 [INFO] [stdout] | [INFO] [stdout] 192 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:212:41 [INFO] [stdout] | [INFO] [stdout] 212 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `VecDeque` [INFO] [stdout] --> src/emurator/casl2/code_gen.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::{HashMap, VecDeque}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `commet2::prefix::opecode_to_binary`, `err::Casl2AssemblerError`, and `prefix::assembler_instructions` [INFO] [stdout] --> src/emurator/casl2/code_gen.rs:3:31 [INFO] [stdout] | [INFO] [stdout] 3 | ...:{casl2::{err::Casl2AssemblerError, parser::ASTNode, prefix::assembler_instructions}, commet2::prefix::opecode_to_binary}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:144:33 [INFO] [stdout] | [INFO] [stdout] 144 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:156:37 [INFO] [stdout] | [INFO] [stdout] 156 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:165:37 [INFO] [stdout] | [INFO] [stdout] 165 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:183:41 [INFO] [stdout] | [INFO] [stdout] 183 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:192:41 [INFO] [stdout] | [INFO] [stdout] 192 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/emurator/casl2/parser.rs:212:41 [INFO] [stdout] | [INFO] [stdout] 212 | ... label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `VecDeque` [INFO] [stdout] --> src/emurator/casl2/code_gen.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::{HashMap, VecDeque}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `commet2::prefix::opecode_to_binary`, `err::Casl2AssemblerError`, and `prefix::assembler_instructions` [INFO] [stdout] --> src/emurator/casl2/code_gen.rs:3:31 [INFO] [stdout] | [INFO] [stdout] 3 | ...:{casl2::{err::Casl2AssemblerError, parser::ASTNode, prefix::assembler_instructions}, commet2::prefix::opecode_to_binary}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/main.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{self, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/main.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{self, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mode` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:93:24 [INFO] [stdout] | [INFO] [stdout] 93 | fn init(&mut self, mode: InitMode) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_mode` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mode` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:93:24 [INFO] [stdout] | [INFO] [stdout] 93 | fn init(&mut self, mode: InitMode) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_mode` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPUState` [INFO] [stdout] --> src/emurator/commet2/state.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 132 | / pub fn new() -> Self { [INFO] [stdout] 133 | | CPUState { [INFO] [stdout] 134 | | machine_cycle: 0, [INFO] [stdout] 135 | | step_cycle: 0, [INFO] [stdout] ... | [INFO] [stdout] 162 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 130 + impl Default for CPUState { [INFO] [stdout] 131 + fn default() -> Self { [INFO] [stdout] 132 + Self::new() [INFO] [stdout] 133 + } [INFO] [stdout] 134 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:106:22 [INFO] [stdout] | [INFO] [stdout] 106 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:119:22 [INFO] [stdout] | [INFO] [stdout] 119 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPUState` [INFO] [stdout] --> src/emurator/commet2/state.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 132 | / pub fn new() -> Self { [INFO] [stdout] 133 | | CPUState { [INFO] [stdout] 134 | | machine_cycle: 0, [INFO] [stdout] 135 | | step_cycle: 0, [INFO] [stdout] ... | [INFO] [stdout] 162 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 130 + impl Default for CPUState { [INFO] [stdout] 131 + fn default() -> Self { [INFO] [stdout] 132 + Self::new() [INFO] [stdout] 133 + } [INFO] [stdout] 134 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:170:22 [INFO] [stdout] | [INFO] [stdout] 170 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:187:22 [INFO] [stdout] | [INFO] [stdout] 187 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:106:22 [INFO] [stdout] | [INFO] [stdout] 106 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:119:22 [INFO] [stdout] | [INFO] [stdout] 119 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:170:22 [INFO] [stdout] | [INFO] [stdout] 170 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/emurator/commet2/alu.rs:187:22 [INFO] [stdout] | [INFO] [stdout] 187 | let result = result_of.0 as u16; // Convert back to u16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `result_of.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPU` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | / pub fn new() -> Self { [INFO] [stdout] 82 | | CPU { [INFO] [stdout] 83 | | state: CPUState::new(), [INFO] [stdout] 84 | | alu: ALU, [INFO] [stdout] ... | [INFO] [stdout] 87 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 80 + impl Default for CPU { [INFO] [stdout] 81 + fn default() -> Self { [INFO] [stdout] 82 + Self::new() [INFO] [stdout] 83 + } [INFO] [stdout] 84 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CPU` [INFO] [stdout] --> src/emurator/commet2/cpu.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | / pub fn new() -> Self { [INFO] [stdout] 82 | | CPU { [INFO] [stdout] 83 | | state: CPUState::new(), [INFO] [stdout] 84 | | alu: ALU, [INFO] [stdout] ... | [INFO] [stdout] 87 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 80 + impl Default for CPU { [INFO] [stdout] 81 + fn default() -> Self { [INFO] [stdout] 82 + Self::new() [INFO] [stdout] 83 + } [INFO] [stdout] 84 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/emurator/commet2/cpu.rs:776:20 [INFO] [stdout] | [INFO] [stdout] 776 | if fr[1] == true{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `fr[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/emurator/commet2/cpu.rs:788:20 [INFO] [stdout] | [INFO] [stdout] 788 | if fr[2] == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!fr[2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/emurator/commet2/cpu.rs:800:20 [INFO] [stdout] | [INFO] [stdout] 800 | if fr[2] == true { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `fr[2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/emurator/commet2/cpu.rs:818:20 [INFO] [stdout] | [INFO] [stdout] 818 | if fr[1] == false && fr[2] == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!fr[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/emurator/commet2/cpu.rs:818:38 [INFO] [stdout] | [INFO] [stdout] 818 | if fr[1] == false && fr[2] == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!fr[2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/emurator/commet2/cpu.rs:830:20 [INFO] [stdout] | [INFO] [stdout] 830 | if fr[0] == true { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `fr[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/emurator/commet2/decoder.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / match opcode { [INFO] [stdout] 25 | | instruction::w1::NOP [INFO] [stdout] 26 | | | instruction::w1::LD [INFO] [stdout] 27 | | | instruction::w1::ADDA [INFO] [stdout] ... | [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 24 ~ !matches!(opcode, instruction::w1::NOP [INFO] [stdout] 25 + | instruction::w1::LD [INFO] [stdout] 26 + | instruction::w1::ADDA [INFO] [stdout] 27 + | instruction::w1::SUBA [INFO] [stdout] 28 + | instruction::w1::ADDL [INFO] [stdout] 29 + | instruction::w1::SUBL [INFO] [stdout] 30 + | instruction::w1::AND [INFO] [stdout] 31 + | instruction::w1::OR [INFO] [stdout] 32 + | instruction::w1::XOR [INFO] [stdout] 33 + | instruction::w1::CPA [INFO] [stdout] 34 + | instruction::w1::CPL [INFO] [stdout] 35 + | instruction::w1::POP [INFO] [stdout] 36 + | instruction::w1::RET) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/emurator/commet2/cpu.rs:776:20 [INFO] [stdout] | [INFO] [stdout] 776 | if fr[1] == true{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `fr[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/emurator/commet2/cpu.rs:788:20 [INFO] [stdout] | [INFO] [stdout] 788 | if fr[2] == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!fr[2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/emurator/commet2/cpu.rs:800:20 [INFO] [stdout] | [INFO] [stdout] 800 | if fr[2] == true { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `fr[2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/emurator/commet2/cpu.rs:818:20 [INFO] [stdout] | [INFO] [stdout] 818 | if fr[1] == false && fr[2] == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!fr[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/emurator/commet2/cpu.rs:818:38 [INFO] [stdout] | [INFO] [stdout] 818 | if fr[1] == false && fr[2] == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!fr[2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/emurator/commet2/cpu.rs:830:20 [INFO] [stdout] | [INFO] [stdout] 830 | if fr[0] == true { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `fr[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/emurator/commet2/prefix.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 82 | / let chars = match opcode { [INFO] [stdout] 83 | | instruction::w1::NOP => ['N', 'O', 'P', ' '], [INFO] [stdout] 84 | | instruction::w1::LD => ['L', 'D', ' ', ' '], [INFO] [stdout] 85 | | instruction::w1::ADDA => ['A', 'D', 'D', 'A'], [INFO] [stdout] ... | [INFO] [stdout] 121 | | _ => ['I', 'D', 'K', '?'], // Unknown opcode [INFO] [stdout] 122 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 123 | chars [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 82 ~ [INFO] [stdout] 83 ~ match opcode { [INFO] [stdout] 84 + instruction::w1::NOP => ['N', 'O', 'P', ' '], [INFO] [stdout] 85 + instruction::w1::LD => ['L', 'D', ' ', ' '], [INFO] [stdout] 86 + instruction::w1::ADDA => ['A', 'D', 'D', 'A'], [INFO] [stdout] 87 + instruction::w1::SUBA => ['S', 'U', 'B', 'A'], [INFO] [stdout] 88 + instruction::w1::ADDL => ['A', 'D', 'D', 'L'], [INFO] [stdout] 89 + instruction::w1::SUBL => ['S', 'U', 'B', 'L'], [INFO] [stdout] 90 + instruction::w1::AND => ['A', 'N', 'D', ' '], [INFO] [stdout] 91 + instruction::w1::OR => ['O', 'R', ' ', ' '], [INFO] [stdout] 92 + instruction::w1::XOR => ['X', 'O', 'R', ' '], [INFO] [stdout] 93 + instruction::w1::CPA => ['C', 'P', 'A', ' '], [INFO] [stdout] 94 + instruction::w1::CPL => ['C', 'P', 'L', ' '], [INFO] [stdout] 95 + instruction::w1::POP => ['P', 'O', 'P', ' '], [INFO] [stdout] 96 + instruction::w1::RET => ['R', 'E', 'T', ' '], [INFO] [stdout] 97 + instruction::w2::LD => ['L', 'D', ' ', ' '], [INFO] [stdout] 98 + instruction::w2::ST => ['S', 'T', ' ', ' '], [INFO] [stdout] 99 + instruction::w2::LAD => ['L', 'D', 'A', ' '], [INFO] [stdout] 100 + instruction::w2::ADDA => ['A', 'D', 'D', 'A'], [INFO] [stdout] 101 + instruction::w2::SUBA => ['S', 'U', 'B', 'A'], [INFO] [stdout] 102 + instruction::w2::ADDL => ['A', 'D', 'D', 'L'], [INFO] [stdout] 103 + instruction::w2::SUBL => ['S', 'U', 'B', 'L'], [INFO] [stdout] 104 + instruction::w2::AND => ['A', 'N', 'D', ' '], [INFO] [stdout] 105 + instruction::w2::OR => ['O', 'R', ' ', ' '], [INFO] [stdout] 106 + instruction::w2::XOR => ['X', 'O', 'R', ' '], [INFO] [stdout] 107 + instruction::w2::CPA => ['C', 'P', 'A', ' '], [INFO] [stdout] 108 + instruction::w2::CPL => ['C', 'P', 'L', ' '], [INFO] [stdout] 109 + instruction::w2::SLA => ['S', 'L', 'A', ' '], [INFO] [stdout] 110 + instruction::w2::SRA => ['S', 'R', 'A', ' '], [INFO] [stdout] 111 + instruction::w2::SLL => ['S', 'L', 'L', ' '], [INFO] [stdout] 112 + instruction::w2::SRL => ['S', 'R', 'L', ' '], [INFO] [stdout] 113 + instruction::w2::JMI => ['J', 'M', 'I', ' '], [INFO] [stdout] 114 + instruction::w2::JNZ => ['J', 'N', 'Z', ' '], [INFO] [stdout] 115 + instruction::w2::JZE => ['J', 'Z', 'E', ' '], [INFO] [stdout] 116 + instruction::w2::JUMP => ['J', 'U', 'M', 'P'], [INFO] [stdout] 117 + instruction::w2::JPL => ['J', 'P', 'L', ' '], [INFO] [stdout] 118 + instruction::w2::JOV => ['J', 'O', 'V', ' '], [INFO] [stdout] 119 + instruction::w2::PUSH => ['P', 'U', 'S', 'H'], [INFO] [stdout] 120 + instruction::w2::CALL => ['C', 'A', 'L', 'L'], [INFO] [stdout] 121 + instruction::w2::SVC => ['S', 'V', 'C', ' '], [INFO] [stdout] 122 + _ => ['I', 'D', 'K', '?'], // Unknown opcode [INFO] [stdout] 123 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/emurator/commet2/decoder.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / match opcode { [INFO] [stdout] 25 | | instruction::w1::NOP [INFO] [stdout] 26 | | | instruction::w1::LD [INFO] [stdout] 27 | | | instruction::w1::ADDA [INFO] [stdout] ... | [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 24 ~ !matches!(opcode, instruction::w1::NOP [INFO] [stdout] 25 + | instruction::w1::LD [INFO] [stdout] 26 + | instruction::w1::ADDA [INFO] [stdout] 27 + | instruction::w1::SUBA [INFO] [stdout] 28 + | instruction::w1::ADDL [INFO] [stdout] 29 + | instruction::w1::SUBL [INFO] [stdout] 30 + | instruction::w1::AND [INFO] [stdout] 31 + | instruction::w1::OR [INFO] [stdout] 32 + | instruction::w1::XOR [INFO] [stdout] 33 + | instruction::w1::CPA [INFO] [stdout] 34 + | instruction::w1::CPL [INFO] [stdout] 35 + | instruction::w1::POP [INFO] [stdout] 36 + | instruction::w1::RET) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/emurator/commet2/prefix.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 82 | / let chars = match opcode { [INFO] [stdout] 83 | | instruction::w1::NOP => ['N', 'O', 'P', ' '], [INFO] [stdout] 84 | | instruction::w1::LD => ['L', 'D', ' ', ' '], [INFO] [stdout] 85 | | instruction::w1::ADDA => ['A', 'D', 'D', 'A'], [INFO] [stdout] ... | [INFO] [stdout] 121 | | _ => ['I', 'D', 'K', '?'], // Unknown opcode [INFO] [stdout] 122 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 123 | chars [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 82 ~ [INFO] [stdout] 83 ~ match opcode { [INFO] [stdout] 84 + instruction::w1::NOP => ['N', 'O', 'P', ' '], [INFO] [stdout] 85 + instruction::w1::LD => ['L', 'D', ' ', ' '], [INFO] [stdout] 86 + instruction::w1::ADDA => ['A', 'D', 'D', 'A'], [INFO] [stdout] 87 + instruction::w1::SUBA => ['S', 'U', 'B', 'A'], [INFO] [stdout] 88 + instruction::w1::ADDL => ['A', 'D', 'D', 'L'], [INFO] [stdout] 89 + instruction::w1::SUBL => ['S', 'U', 'B', 'L'], [INFO] [stdout] 90 + instruction::w1::AND => ['A', 'N', 'D', ' '], [INFO] [stdout] 91 + instruction::w1::OR => ['O', 'R', ' ', ' '], [INFO] [stdout] 92 + instruction::w1::XOR => ['X', 'O', 'R', ' '], [INFO] [stdout] 93 + instruction::w1::CPA => ['C', 'P', 'A', ' '], [INFO] [stdout] 94 + instruction::w1::CPL => ['C', 'P', 'L', ' '], [INFO] [stdout] 95 + instruction::w1::POP => ['P', 'O', 'P', ' '], [INFO] [stdout] 96 + instruction::w1::RET => ['R', 'E', 'T', ' '], [INFO] [stdout] 97 + instruction::w2::LD => ['L', 'D', ' ', ' '], [INFO] [stdout] 98 + instruction::w2::ST => ['S', 'T', ' ', ' '], [INFO] [stdout] 99 + instruction::w2::LAD => ['L', 'D', 'A', ' '], [INFO] [stdout] 100 + instruction::w2::ADDA => ['A', 'D', 'D', 'A'], [INFO] [stdout] 101 + instruction::w2::SUBA => ['S', 'U', 'B', 'A'], [INFO] [stdout] 102 + instruction::w2::ADDL => ['A', 'D', 'D', 'L'], [INFO] [stdout] 103 + instruction::w2::SUBL => ['S', 'U', 'B', 'L'], [INFO] [stdout] 104 + instruction::w2::AND => ['A', 'N', 'D', ' '], [INFO] [stdout] 105 + instruction::w2::OR => ['O', 'R', ' ', ' '], [INFO] [stdout] 106 + instruction::w2::XOR => ['X', 'O', 'R', ' '], [INFO] [stdout] 107 + instruction::w2::CPA => ['C', 'P', 'A', ' '], [INFO] [stdout] 108 + instruction::w2::CPL => ['C', 'P', 'L', ' '], [INFO] [stdout] 109 + instruction::w2::SLA => ['S', 'L', 'A', ' '], [INFO] [stdout] 110 + instruction::w2::SRA => ['S', 'R', 'A', ' '], [INFO] [stdout] 111 + instruction::w2::SLL => ['S', 'L', 'L', ' '], [INFO] [stdout] 112 + instruction::w2::SRL => ['S', 'R', 'L', ' '], [INFO] [stdout] 113 + instruction::w2::JMI => ['J', 'M', 'I', ' '], [INFO] [stdout] 114 + instruction::w2::JNZ => ['J', 'N', 'Z', ' '], [INFO] [stdout] 115 + instruction::w2::JZE => ['J', 'Z', 'E', ' '], [INFO] [stdout] 116 + instruction::w2::JUMP => ['J', 'U', 'M', 'P'], [INFO] [stdout] 117 + instruction::w2::JPL => ['J', 'P', 'L', ' '], [INFO] [stdout] 118 + instruction::w2::JOV => ['J', 'O', 'V', ' '], [INFO] [stdout] 119 + instruction::w2::PUSH => ['P', 'U', 'S', 'H'], [INFO] [stdout] 120 + instruction::w2::CALL => ['C', 'A', 'L', 'L'], [INFO] [stdout] 121 + instruction::w2::SVC => ['S', 'V', 'C', ' '], [INFO] [stdout] 122 + _ => ['I', 'D', 'K', '?'], // Unknown opcode [INFO] [stdout] 123 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/emurator/casl2/parser.rs:84:47 [INFO] [stdout] | [INFO] [stdout] 84 | if operands.len() != 1 || !operands[0].parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `operands[0].parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:201:33 [INFO] [stdout] | [INFO] [stdout] 201 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 201 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:220:37 [INFO] [stdout] | [INFO] [stdout] 220 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid second operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid second operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 220 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid second operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:223:33 [INFO] [stdout] | [INFO] [stdout] 223 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 223 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:227:29 [INFO] [stdout] | [INFO] [stdout] 227 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid number of operands for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 227 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid number of operands for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 227 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid number of operands for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/emurator/casl2/parser.rs:84:47 [INFO] [stdout] | [INFO] [stdout] 84 | if operands.len() != 1 || !operands[0].parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `operands[0].parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:201:33 [INFO] [stdout] | [INFO] [stdout] 201 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 201 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:220:37 [INFO] [stdout] | [INFO] [stdout] 220 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid second operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid second operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 220 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid second operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:223:33 [INFO] [stdout] | [INFO] [stdout] 223 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 223 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid first operand for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/emurator/casl2/parser.rs:227:29 [INFO] [stdout] | [INFO] [stdout] 227 | ... return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid number of operands for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 227 - return Err(Casl2AssemblerError::AnalyzeError(format!("Invalid number of operands for {} instruction, line: {}\n\t{}", opcode, line_number, str))); [INFO] [stdout] 227 + Err(Casl2AssemblerError::AnalyzeError(format!("Invalid number of operands for {} instruction, line: {}\n\t{}", opcode, line_number, str))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.27s [INFO] running `Command { std: "docker" "inspect" "ae880e8103bf69fbd335b3aba03059b4a73f8d3a9e7a66a1a1393a676870aeb5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae880e8103bf69fbd335b3aba03059b4a73f8d3a9e7a66a1a1393a676870aeb5", kill_on_drop: false }` [INFO] [stdout] ae880e8103bf69fbd335b3aba03059b4a73f8d3a9e7a66a1a1393a676870aeb5