[INFO] cloning repository https://github.com/371tti/wk-371tti-net-search-engine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/371tti/wk-371tti-net-search-engine" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F371tti%2Fwk-371tti-net-search-engine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F371tti%2Fwk-371tti-net-search-engine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0254a1355d4e5c54b0154047be479226c4da7491 [INFO] linting 371tti/wk-371tti-net-search-engine against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F371tti%2Fwk-371tti-net-search-engine" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/371tti/wk-371tti-net-search-engine [INFO] finished tweaking git repo https://github.com/371tti/wk-371tti-net-search-engine [INFO] tweaked toml for git repo https://github.com/371tti/wk-371tti-net-search-engine written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/371tti/wk-371tti-net-search-engine on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/371tti/wk-371tti-net-search-engine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/sorami/sudachi.rs.git` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded compression-core v0.4.29 [INFO] [stderr] Downloaded memmap2 v0.9.8 [INFO] [stderr] Downloaded yada v0.5.1 [INFO] [stderr] Downloaded html_format v0.2.2 [INFO] [stderr] Downloaded compression-codecs v0.4.31 [INFO] [stderr] Downloaded kurosabi v0.4.8 [INFO] [stderr] Downloaded async-compression v0.4.32 [INFO] [stderr] Downloaded rustls-webpki v0.103.6 [INFO] [stderr] Downloaded rustls v0.23.32 [INFO] [stderr] Downloaded tf-idf-vectorizer v0.5.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3710c58efa065f6e208ec05259bcb3b0a096c030d423c8386b650fbb851fb3e9 [INFO] running `Command { std: "docker" "start" "-a" "3710c58efa065f6e208ec05259bcb3b0a096c030d423c8386b650fbb851fb3e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3710c58efa065f6e208ec05259bcb3b0a096c030d423c8386b650fbb851fb3e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3710c58efa065f6e208ec05259bcb3b0a096c030d423c8386b650fbb851fb3e9", kill_on_drop: false }` [INFO] [stdout] 3710c58efa065f6e208ec05259bcb3b0a096c030d423c8386b650fbb851fb3e9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f1b9c4c3ef8d7df92e7f6e7f35579d047deabf81d908b676432e74412b2ba4e5 [INFO] running `Command { std: "docker" "start" "-a" "f1b9c4c3ef8d7df92e7f6e7f35579d047deabf81d908b676432e74412b2ba4e5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.176 [INFO] [stderr] Checking cfg-if v1.0.3 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling find-msvc-tools v0.1.2 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling rustls v0.23.32 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Compiling cc v1.2.39 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking brotli-decompressor v5.0.0 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Compiling unicase v2.8.1 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking compression-core v0.4.29 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking csv-core v0.1.12 [INFO] [stderr] Checking webpki-roots v1.0.2 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Checking jiff v0.2.15 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking rayon-core v1.13.0 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Checking yada v0.5.1 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking brotli v8.0.2 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking memmap2 v0.9.8 [INFO] [stderr] Checking regex-automata v0.4.11 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking indexmap v2.11.4 [INFO] [stderr] Checking compression-codecs v0.4.31 [INFO] [stderr] Checking regex v1.11.3 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling html_format v0.2.2 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking rustls-webpki v0.103.6 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking csv v1.3.1 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking tf-idf-vectorizer v0.5.9 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking sudachi v0.6.10 (https://github.com/sorami/sudachi.rs.git?tag=v0.6.10#7e2f287b) [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking async-compression v0.4.32 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking kurosabi v0.4.8 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.24 [INFO] [stderr] Checking wk-371tti-net-search-engine v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handler/search.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | range: range, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handler/search.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | results: results [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handler/search.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | range: range, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/handler/search.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | results: results [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tokenize.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | / let mut vec = Vec::new(); [INFO] [stdout] 36 | | vec.push(result); [INFO] [stdout] | |_____________________________^ help: consider using the `vec![]` macro: `let vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/tokenize.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | / let mut vec = Vec::new(); [INFO] [stdout] 36 | | vec.push(result); [INFO] [stdout] | |_____________________________^ help: consider using the `vec![]` macro: `let vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tokenize.rs:95:52 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn mix_doc_tokenizer(&self, text: &str) -> Result<(Vec>, u64), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tokenize.rs:95:52 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn mix_doc_tokenizer(&self, text: &str) -> Result<(Vec>, u64), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tokenize.rs:103:25 [INFO] [stdout] | [INFO] [stdout] 103 | .filter(|t| !c_tokens.binary_search(*t).is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c_tokens.binary_search(*t).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tokenize.rs:103:25 [INFO] [stdout] | [INFO] [stdout] 103 | .filter(|t| !c_tokens.binary_search(*t).is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c_tokens.binary_search(*t).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tokenize.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 108 | .chain(c_tokens_sub.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 108 - .chain(c_tokens_sub.into_iter()) [INFO] [stdout] 108 + .chain(c_tokens_sub) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tokenize.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 109 | .chain(a_speech_tokens.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 109 - .chain(a_speech_tokens.into_iter()) [INFO] [stdout] 109 + .chain(a_speech_tokens) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tokenize.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 108 | .chain(c_tokens_sub.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 108 - .chain(c_tokens_sub.into_iter()) [INFO] [stdout] 108 + .chain(c_tokens_sub) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tokenize.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 109 | .chain(a_speech_tokens.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 109 - .chain(a_speech_tokens.into_iter()) [INFO] [stdout] 109 + .chain(a_speech_tokens) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tokenize.rs:126:25 [INFO] [stdout] | [INFO] [stdout] 126 | .filter(|t| !c_tokens.binary_search(*t).is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c_tokens.binary_search(*t).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tokenize.rs:126:25 [INFO] [stdout] | [INFO] [stdout] 126 | .filter(|t| !c_tokens.binary_search(*t).is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c_tokens.binary_search(*t).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tokenize.rs:134:20 [INFO] [stdout] | [INFO] [stdout] 134 | .chain(c_tokens_sub.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 134 - .chain(c_tokens_sub.into_iter()) [INFO] [stdout] 134 + .chain(c_tokens_sub) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tokenize.rs:135:20 [INFO] [stdout] | [INFO] [stdout] 135 | .chain(a_speech_tokens.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 135 - .chain(a_speech_tokens.into_iter()) [INFO] [stdout] 135 + .chain(a_speech_tokens) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tokenize.rs:134:20 [INFO] [stdout] | [INFO] [stdout] 134 | .chain(c_tokens_sub.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 134 - .chain(c_tokens_sub.into_iter()) [INFO] [stdout] 134 + .chain(c_tokens_sub) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tokenize.rs:136:20 [INFO] [stdout] | [INFO] [stdout] 136 | .chain(a_2gram_tokens.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 136 - .chain(a_2gram_tokens.into_iter()) [INFO] [stdout] 136 + .chain(a_2gram_tokens) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tokenize.rs:135:20 [INFO] [stdout] | [INFO] [stdout] 135 | .chain(a_speech_tokens.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 135 - .chain(a_speech_tokens.into_iter()) [INFO] [stdout] 135 + .chain(a_speech_tokens) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/tokenize.rs:136:20 [INFO] [stdout] | [INFO] [stdout] 136 | .chain(a_2gram_tokens.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 136 - .chain(a_2gram_tokens.into_iter()) [INFO] [stdout] 136 + .chain(a_2gram_tokens) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tokenize.rs:161:55 [INFO] [stdout] | [INFO] [stdout] 161 | .map(|s| s.surface().trim_matches(&[' ', '　']).to_string().into_boxed_str()) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `[' ', '　']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tokenize.rs:161:55 [INFO] [stdout] | [INFO] [stdout] 161 | .map(|s| s.surface().trim_matches(&[' ', '　']).to_string().into_boxed_str()) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `[' ', '　']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/collect.rs:145:1 [INFO] [stdout] | [INFO] [stdout] 145 | / pub enum ScraperResult { [INFO] [stdout] 146 | | #[serde(rename = "true")] [INFO] [stdout] 147 | | / Success { [INFO] [stdout] 148 | | | status: u16, [INFO] [stdout] 149 | | | url: String, [INFO] [stdout] 150 | | | results: ScrapeResults, [INFO] [stdout] 151 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 242 bytes [INFO] [stdout] 152 | | #[serde(rename = "false")] [INFO] [stdout] 153 | | / Failed { [INFO] [stdout] 154 | | | error: String, [INFO] [stdout] 155 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 24 bytes [INFO] [stdout] 156 | | } [INFO] [stdout] | |___^ the entire enum is at least 248 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 150 - results: ScrapeResults, [INFO] [stdout] 150 + results: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/collect.rs:145:1 [INFO] [stdout] | [INFO] [stdout] 145 | / pub enum ScraperResult { [INFO] [stdout] 146 | | #[serde(rename = "true")] [INFO] [stdout] 147 | | / Success { [INFO] [stdout] 148 | | | status: u16, [INFO] [stdout] 149 | | | url: String, [INFO] [stdout] 150 | | | results: ScrapeResults, [INFO] [stdout] 151 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 242 bytes [INFO] [stdout] 152 | | #[serde(rename = "false")] [INFO] [stdout] 153 | | / Failed { [INFO] [stdout] 154 | | | error: String, [INFO] [stdout] 155 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 24 bytes [INFO] [stdout] 156 | | } [INFO] [stdout] | |___^ the entire enum is at least 248 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 150 - results: ScrapeResults, [INFO] [stdout] 150 + results: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/engine/tag.rs:73:1 [INFO] [stdout] | [INFO] [stdout] 73 | impl Into for Tags { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 73 ~ impl From for u64 { [INFO] [stdout] 74 ~ fn from(val: Tags) -> Self { [INFO] [stdout] 75 ~ val.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/engine/tag.rs:73:1 [INFO] [stdout] | [INFO] [stdout] 73 | impl Into for Tags { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 73 ~ impl From for u64 { [INFO] [stdout] 74 ~ fn from(val: Tags) -> Self { [INFO] [stdout] 75 ~ val.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/engine/save.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | return Err(Box::new(Error::new(std::io::ErrorKind::NotFound, "Index shard not found"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Err(Box::new(Error::new(std::io::ErrorKind::NotFound, "Index shard not found"))); [INFO] [stdout] 83 + Err(Box::new(Error::new(std::io::ErrorKind::NotFound, "Index shard not found"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/engine/save.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | return Err(Box::new(Error::new(std::io::ErrorKind::NotFound, "Index shard not found"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Err(Box::new(Error::new(std::io::ErrorKind::NotFound, "Index shard not found"))); [INFO] [stdout] 83 + Err(Box::new(Error::new(std::io::ErrorKind::NotFound, "Index shard not found"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/engine/save.rs:61:32 [INFO] [stdout] | [INFO] [stdout] 61 | return Err(std::io::Error::new(std::io::ErrorKind::Other, "RwLock poisoned").into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 61 - return Err(std::io::Error::new(std::io::ErrorKind::Other, "RwLock poisoned").into()); [INFO] [stdout] 61 + return Err(std::io::Error::other("RwLock poisoned").into()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/engine/save.rs:61:32 [INFO] [stdout] | [INFO] [stdout] 61 | return Err(std::io::Error::new(std::io::ErrorKind::Other, "RwLock poisoned").into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 61 - return Err(std::io::Error::new(std::io::ErrorKind::Other, "RwLock poisoned").into()); [INFO] [stdout] 61 + return Err(std::io::Error::other("RwLock poisoned").into()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/engine/mod.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | / idx.vectorizer.documents.get_mut(doc_id).map(|d| { [INFO] [stdout] 101 | | d.token_sum = meta.token_sum; [INFO] [stdout] 102 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 100 - idx.vectorizer.documents.get_mut(doc_id).map(|d| { [INFO] [stdout] 101 - d.token_sum = meta.token_sum; [INFO] [stdout] 102 - }); [INFO] [stdout] 100 + if let Some(d) = idx.vectorizer.documents.get_mut(doc_id) { d.token_sum = meta.token_sum; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/engine/mod.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | / idx.vectorizer.documents.get_mut(doc_id).map(|d| { [INFO] [stdout] 101 | | d.token_sum = meta.token_sum; [INFO] [stdout] 102 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 100 - idx.vectorizer.documents.get_mut(doc_id).map(|d| { [INFO] [stdout] 101 - d.token_sum = meta.token_sum; [INFO] [stdout] 102 - }); [INFO] [stdout] 100 + if let Some(d) = idx.vectorizer.documents.get_mut(doc_id) { d.token_sum = meta.token_sum; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/engine/mod.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | / idx.vectorizer.documents.get_mut(doc_id).map(|d| { [INFO] [stdout] 134 | | d.token_sum = meta.token_sum; [INFO] [stdout] 135 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 133 - idx.vectorizer.documents.get_mut(doc_id).map(|d| { [INFO] [stdout] 134 - d.token_sum = meta.token_sum; [INFO] [stdout] 135 - }); [INFO] [stdout] 133 + if let Some(d) = idx.vectorizer.documents.get_mut(doc_id) { d.token_sum = meta.token_sum; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/engine/mod.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | / idx.vectorizer.documents.get_mut(doc_id).map(|d| { [INFO] [stdout] 134 | | d.token_sum = meta.token_sum; [INFO] [stdout] 135 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 133 - idx.vectorizer.documents.get_mut(doc_id).map(|d| { [INFO] [stdout] 134 - d.token_sum = meta.token_sum; [INFO] [stdout] 135 - }); [INFO] [stdout] 133 + if let Some(d) = idx.vectorizer.documents.get_mut(doc_id) { d.token_sum = meta.token_sum; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/engine/mod.rs:145:17 [INFO] [stdout] | [INFO] [stdout] 145 | / idx.meta_from_id_mut(doc_id).map(|m| { [INFO] [stdout] 146 | | m.url = meta.url.clone(); [INFO] [stdout] 147 | | m.title = meta.title.clone(); [INFO] [stdout] 148 | | m.favicon = meta.favicon.clone(); [INFO] [stdout] ... | [INFO] [stdout] 155 | | m.token_sum = meta.token_sum; [INFO] [stdout] 156 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 145 - idx.meta_from_id_mut(doc_id).map(|m| { [INFO] [stdout] 146 - m.url = meta.url.clone(); [INFO] [stdout] 147 - m.title = meta.title.clone(); [INFO] [stdout] 148 - m.favicon = meta.favicon.clone(); [INFO] [stdout] 149 - m.tags = meta.tags.clone(); [INFO] [stdout] 150 - m.description = meta.description.clone(); [INFO] [stdout] 151 - m.points = meta.points; [INFO] [stdout] 152 - m.time = meta.time; [INFO] [stdout] 153 - m.lang = meta.lang.clone(); [INFO] [stdout] 154 - m.links = meta.links.clone(); [INFO] [stdout] 155 - m.token_sum = meta.token_sum; [INFO] [stdout] 156 - }); [INFO] [stdout] 145 + if let Some(m) = idx.meta_from_id_mut(doc_id) { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/engine/mod.rs:145:17 [INFO] [stdout] | [INFO] [stdout] 145 | / idx.meta_from_id_mut(doc_id).map(|m| { [INFO] [stdout] 146 | | m.url = meta.url.clone(); [INFO] [stdout] 147 | | m.title = meta.title.clone(); [INFO] [stdout] 148 | | m.favicon = meta.favicon.clone(); [INFO] [stdout] ... | [INFO] [stdout] 155 | | m.token_sum = meta.token_sum; [INFO] [stdout] 156 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 145 - idx.meta_from_id_mut(doc_id).map(|m| { [INFO] [stdout] 146 - m.url = meta.url.clone(); [INFO] [stdout] 147 - m.title = meta.title.clone(); [INFO] [stdout] 148 - m.favicon = meta.favicon.clone(); [INFO] [stdout] 149 - m.tags = meta.tags.clone(); [INFO] [stdout] 150 - m.description = meta.description.clone(); [INFO] [stdout] 151 - m.points = meta.points; [INFO] [stdout] 152 - m.time = meta.time; [INFO] [stdout] 153 - m.lang = meta.lang.clone(); [INFO] [stdout] 154 - m.links = meta.links.clone(); [INFO] [stdout] 155 - m.token_sum = meta.token_sum; [INFO] [stdout] 156 - }); [INFO] [stdout] 145 + if let Some(m) = idx.meta_from_id_mut(doc_id) { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Tags` which implements the `Copy` trait [INFO] [stdout] --> src/engine/mod.rs:149:30 [INFO] [stdout] | [INFO] [stdout] 149 | m.tags = meta.tags.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `meta.tags` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Tags` which implements the `Copy` trait [INFO] [stdout] --> src/engine/mod.rs:149:30 [INFO] [stdout] | [INFO] [stdout] 149 | m.tags = meta.tags.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `meta.tags` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/engine/mod.rs:250:13 [INFO] [stdout] | [INFO] [stdout] 250 | return Err(Box::new(Error::new(std::io::ErrorKind::NotFound, "Index shard not found"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 250 - return Err(Box::new(Error::new(std::io::ErrorKind::NotFound, "Index shard not found"))); [INFO] [stdout] 250 + Err(Box::new(Error::new(std::io::ErrorKind::NotFound, "Index shard not found"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/engine/mod.rs:250:13 [INFO] [stdout] | [INFO] [stdout] 250 | return Err(Box::new(Error::new(std::io::ErrorKind::NotFound, "Index shard not found"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 250 - return Err(Box::new(Error::new(std::io::ErrorKind::NotFound, "Index shard not found"))); [INFO] [stdout] 250 + Err(Box::new(Error::new(std::io::ErrorKind::NotFound, "Index shard not found"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/engine/mod.rs:241:32 [INFO] [stdout] | [INFO] [stdout] 241 | return Err(std::io::Error::new(std::io::ErrorKind::Other, "RwLock poisoned").into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 241 - return Err(std::io::Error::new(std::io::ErrorKind::Other, "RwLock poisoned").into()); [INFO] [stdout] 241 + return Err(std::io::Error::other("RwLock poisoned").into()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/engine/mod.rs:241:32 [INFO] [stdout] | [INFO] [stdout] 241 | return Err(std::io::Error::new(std::io::ErrorKind::Other, "RwLock poisoned").into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 241 - return Err(std::io::Error::new(std::io::ErrorKind::Other, "RwLock poisoned").into()); [INFO] [stdout] 241 + return Err(std::io::Error::other("RwLock poisoned").into()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/engine/mod.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 276 | / if is_new { [INFO] [stdout] 277 | | if let Some(m) = idx.meta_from_url(&url) { [INFO] [stdout] 278 | | shard_id = idx.id; [INFO] [stdout] 279 | | doc_id = m.id; [INFO] [stdout] ... | [INFO] [stdout] 283 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 276 ~ if is_new [INFO] [stdout] 277 ~ && let Some(m) = idx.meta_from_url(&url) { [INFO] [stdout] 278 | shard_id = idx.id; [INFO] [stdout] ... [INFO] [stdout] 281 | break; [INFO] [stdout] 282 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/engine/mod.rs:277:60 [INFO] [stdout] | [INFO] [stdout] 277 | if let Some(m) = idx.meta_from_url(&url) { [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/engine/mod.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 276 | / if is_new { [INFO] [stdout] 277 | | if let Some(m) = idx.meta_from_url(&url) { [INFO] [stdout] 278 | | shard_id = idx.id; [INFO] [stdout] 279 | | doc_id = m.id; [INFO] [stdout] ... | [INFO] [stdout] 283 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 276 ~ if is_new [INFO] [stdout] 277 ~ && let Some(m) = idx.meta_from_url(&url) { [INFO] [stdout] 278 | shard_id = idx.id; [INFO] [stdout] ... [INFO] [stdout] 281 | break; [INFO] [stdout] 282 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/engine/mod.rs:277:60 [INFO] [stdout] | [INFO] [stdout] 277 | if let Some(m) = idx.meta_from_url(&url) { [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/engine/mod.rs:319:13 [INFO] [stdout] | [INFO] [stdout] 319 | / if let Some(meta) = guard.meta_from_url(url) { [INFO] [stdout] 320 | | if let Some(tf) = guard.vectorizer.get_tf_into_token_freq(&meta.id) { [INFO] [stdout] 321 | | return Some(tf.clone()); [INFO] [stdout] 322 | | } [INFO] [stdout] 323 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 319 ~ if let Some(meta) = guard.meta_from_url(url) [INFO] [stdout] 320 ~ && let Some(tf) = guard.vectorizer.get_tf_into_token_freq(&meta.id) { [INFO] [stdout] 321 | return Some(tf.clone()); [INFO] [stdout] 322 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/engine/mod.rs:319:13 [INFO] [stdout] | [INFO] [stdout] 319 | / if let Some(meta) = guard.meta_from_url(url) { [INFO] [stdout] 320 | | if let Some(tf) = guard.vectorizer.get_tf_into_token_freq(&meta.id) { [INFO] [stdout] 321 | | return Some(tf.clone()); [INFO] [stdout] 322 | | } [INFO] [stdout] 323 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 319 ~ if let Some(meta) = guard.meta_from_url(url) [INFO] [stdout] 320 ~ && let Some(tf) = guard.vectorizer.get_tf_into_token_freq(&meta.id) { [INFO] [stdout] 321 | return Some(tf.clone()); [INFO] [stdout] 322 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/engine/mod.rs:401:9 [INFO] [stdout] | [INFO] [stdout] 401 | self.meta.last().and_then(|m| Some(m.id + 1)).unwrap_or(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.meta.last().map(|m| m.id + 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/engine/mod.rs:401:9 [INFO] [stdout] | [INFO] [stdout] 401 | self.meta.last().and_then(|m| Some(m.id + 1)).unwrap_or(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.meta.last().map(|m| m.id + 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `vals.get(0)` [INFO] [stdout] --> src/utils.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | let k1 = vals.get(0).copied().unwrap_or(1.2); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `vals.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `vals.get(0)` [INFO] [stdout] --> src/utils.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | let k1 = vals.get(0).copied().unwrap_or(1.2); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `vals.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/add.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | return c; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return c; [INFO] [stdout] 129 + c [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/add.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | return c; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 - return c; [INFO] [stdout] 136 + c [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/add.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | return c; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return c; [INFO] [stdout] 129 + c [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handler/add.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | return c; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 - return c; [INFO] [stdout] 136 + c [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/handler/add.rs:47:30 [INFO] [stdout] | [INFO] [stdout] 47 | req_url.push_str(&selector); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `selector` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/handler/add.rs:47:30 [INFO] [stdout] | [INFO] [stdout] 47 | req_url.push_str(&selector); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `selector` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/handler/add.rs:74:35 [INFO] [stdout] | [INFO] [stdout] 74 | let title = match index_req.title.or_else(|| results.title) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `or` instead [INFO] [stdout] | [INFO] [stdout] 74 - let title = match index_req.title.or_else(|| results.title) { [INFO] [stdout] 74 + let title = match index_req.title.or(results.title) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/handler/add.rs:84:49 [INFO] [stdout] | [INFO] [stdout] 84 | let favicon: Option> = index_req.favicon.or_else(|| results.favicon ).map(|s| s.into_boxed_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `or` instead [INFO] [stdout] | [INFO] [stdout] 84 - let favicon: Option> = index_req.favicon.or_else(|| results.favicon ).map(|s| s.into_boxed_str()); [INFO] [stdout] 84 + let favicon: Option> = index_req.favicon.or(results.favicon).map(|s| s.into_boxed_str()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/handler/add.rs:74:35 [INFO] [stdout] | [INFO] [stdout] 74 | let title = match index_req.title.or_else(|| results.title) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `or` instead [INFO] [stdout] | [INFO] [stdout] 74 - let title = match index_req.title.or_else(|| results.title) { [INFO] [stdout] 74 + let title = match index_req.title.or(results.title) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/handler/add.rs:84:49 [INFO] [stdout] | [INFO] [stdout] 84 | let favicon: Option> = index_req.favicon.or_else(|| results.favicon ).map(|s| s.into_boxed_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `or` instead [INFO] [stdout] | [INFO] [stdout] 84 - let favicon: Option> = index_req.favicon.or_else(|| results.favicon ).map(|s| s.into_boxed_str()); [INFO] [stdout] 84 + let favicon: Option> = index_req.favicon.or(results.favicon).map(|s| s.into_boxed_str()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/main.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | env_logger::try_init_from_env(env_logger::Env::default().default_filter_or("debug")).unwrap_or_else(|_| ()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 28 - env_logger::try_init_from_env(env_logger::Env::default().default_filter_or("debug")).unwrap_or_else(|_| ()); [INFO] [stdout] 28 + env_logger::try_init_from_env(env_logger::Env::default().default_filter_or("debug")).unwrap_or(()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/main.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | env_logger::try_init_from_env(env_logger::Env::default().default_filter_or("debug")).unwrap_or_else(|_| ()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 28 - env_logger::try_init_from_env(env_logger::Env::default().default_filter_or("debug")).unwrap_or_else(|_| ()); [INFO] [stdout] 28 + env_logger::try_init_from_env(env_logger::Env::default().default_filter_or("debug")).unwrap_or(()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.81s [INFO] running `Command { std: "docker" "inspect" "f1b9c4c3ef8d7df92e7f6e7f35579d047deabf81d908b676432e74412b2ba4e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1b9c4c3ef8d7df92e7f6e7f35579d047deabf81d908b676432e74412b2ba4e5", kill_on_drop: false }` [INFO] [stdout] f1b9c4c3ef8d7df92e7f6e7f35579d047deabf81d908b676432e74412b2ba4e5