[INFO] cloning repository https://github.com/2eitram2/2eitram2-node [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/2eitram2/2eitram2-node" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F2eitram2%2F2eitram2-node", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F2eitram2%2F2eitram2-node'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 12f6af4c2483469829a1c942d0c4dbb2d819e8f0 [INFO] linting 2eitram2/2eitram2-node against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F2eitram2%2F2eitram2-node" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/2eitram2/2eitram2-node [INFO] finished tweaking git repo https://github.com/2eitram2/2eitram2-node [INFO] tweaked toml for git repo https://github.com/2eitram2/2eitram2-node written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/2eitram2/2eitram2-node on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/2eitram2/2eitram2-node already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded proc-macro2 v1.0.93 [INFO] [stderr] Downloaded quote v1.0.38 [INFO] [stderr] Downloaded redox_syscall v0.5.8 [INFO] [stderr] Downloaded android-tzdata v0.1.1 [INFO] [stderr] Downloaded bitflags v2.8.0 [INFO] [stderr] Downloaded iana-time-zone-haiku v0.1.2 [INFO] [stderr] Downloaded smallvec v1.13.2 [INFO] [stderr] Downloaded android_system_properties v0.1.5 [INFO] [stderr] Downloaded iana-time-zone v0.1.61 [INFO] [stderr] Downloaded windows-core v0.52.0 [INFO] [stderr] Downloaded num-traits v0.2.19 [INFO] [stderr] Downloaded log v0.4.25 [INFO] [stderr] Downloaded serde_derive v1.0.217 [INFO] [stderr] Downloaded miniz_oxide v0.8.3 [INFO] [stderr] Downloaded serde v1.0.217 [INFO] [stderr] Downloaded crc32fast v1.4.2 [INFO] [stderr] Downloaded cc v1.2.14 [INFO] [stderr] Downloaded flate2 v1.0.35 [INFO] [stderr] Downloaded typenum v1.17.0 [INFO] [stderr] Downloaded rustversion v1.0.19 [INFO] [stderr] Downloaded unicode-ident v1.0.16 [INFO] [stderr] Downloaded syn v2.0.98 [INFO] [stderr] Downloaded chrono v0.4.39 [INFO] [stderr] Downloaded libc v0.2.169 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 88b881700bb3bf21c84bcbc787061b0363160e3447208feeb745c771ec0c4a87 [INFO] running `Command { std: "docker" "start" "-a" "88b881700bb3bf21c84bcbc787061b0363160e3447208feeb745c771ec0c4a87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "88b881700bb3bf21c84bcbc787061b0363160e3447208feeb745c771ec0c4a87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88b881700bb3bf21c84bcbc787061b0363160e3447208feeb745c771ec0c4a87", kill_on_drop: false }` [INFO] [stdout] 88b881700bb3bf21c84bcbc787061b0363160e3447208feeb745c771ec0c4a87 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8228238c66531c7de906b0eb8fcd186866afa64fd0e840f600748bc749763df4 [INFO] running `Command { std: "docker" "start" "-a" "8228238c66531c7de906b0eb8fcd186866afa64fd0e840f600748bc749763df4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling unicode-ident v1.0.16 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Checking miniz_oxide v0.8.3 [INFO] [stderr] Checking bytes v1.10.0 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Checking flate2 v1.0.35 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Checking curve25519-dalek v3.2.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking pqc_dilithium v0.2.0 [INFO] [stderr] Checking ed25519-dalek v1.0.1 [INFO] [stderr] Checking node v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `dst_user_id` [INFO] [stdout] --> src/modules/utils.rs:22:59 [INFO] [stdout] | [INFO] [stdout] 22 | pub async fn send_tcp_message(ip: &IpAddr, buffer: &[u8], dst_user_id: String) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_dst_user_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dst_user_id` [INFO] [stdout] --> src/modules/utils.rs:22:59 [INFO] [stdout] | [INFO] [stdout] 22 | pub async fn send_tcp_message(ip: &IpAddr, buffer: &[u8], dst_user_id: String) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_dst_user_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `save_packet` is never used [INFO] [stdout] --> src/modules/utils.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 134 | pub async fn save_packet(hash: String, packet: Vec) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/modules/handle.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | if !verify(&dilithium_signature, &data_to_sign_bytes, &dilithium_public_key_bytes).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `verify(&dilithium_signature, &data_to_sign_bytes, &dilithium_public_key_bytes).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:33:46 [INFO] [stdout] | [INFO] [stdout] 33 | let timestamp = utils::uint8_array_to_ts(×tamp_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `timestamp_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:41:16 [INFO] [stdout] | [INFO] [stdout] 41 | if !verify(&dilithium_signature, &data_to_sign_bytes, &dilithium_public_key_bytes).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `dilithium_signature` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:41:38 [INFO] [stdout] | [INFO] [stdout] 41 | if !verify(&dilithium_signature, &data_to_sign_bytes, &dilithium_public_key_bytes).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_sign_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:41:59 [INFO] [stdout] | [INFO] [stdout] 41 | if !verify(&dilithium_signature, &data_to_sign_bytes, &dilithium_public_key_bytes).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `dilithium_public_key_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:63:49 [INFO] [stdout] | [INFO] [stdout] 63 | if let Err(e) = locked_writer.write_all(&buffer).await { [INFO] [stdout] | ^^^^^^^ help: change this to: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:75:58 [INFO] [stdout] | [INFO] [stdout] 75 | let _ = utils::send_tcp_message(&ip, &buffer, user_id_hex).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:103:46 [INFO] [stdout] | [INFO] [stdout] 103 | let timestamp = utils::uint8_array_to_ts(×tamp_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `timestamp_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/modules/handle.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | &dilithium_public_key_bytes[..], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the original value instead: `dilithium_public_key_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/modules/handle.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | &ed25519_public_key[..], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use the original value instead: `ed25519_public_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/modules/handle.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | &nonce[..], [INFO] [stdout] | ^^^^^^^^^^ help: use the original value instead: `nonce` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:169:46 [INFO] [stdout] | [INFO] [stdout] 169 | let timestamp = utils::uint8_array_to_ts(×tamp_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `timestamp_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:180:45 [INFO] [stdout] | [INFO] [stdout] 180 | let public_id_hex = crypto::sha256_hash(&public_key_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `public_key_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `save_packet` is never used [INFO] [stdout] --> src/modules/utils.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 134 | pub async fn save_packet(hash: String, packet: Vec) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/modules/handle.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | if !verify(&dilithium_signature, &data_to_sign_bytes, &dilithium_public_key_bytes).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `verify(&dilithium_signature, &data_to_sign_bytes, &dilithium_public_key_bytes).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:33:46 [INFO] [stdout] | [INFO] [stdout] 33 | let timestamp = utils::uint8_array_to_ts(×tamp_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `timestamp_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:41:16 [INFO] [stdout] | [INFO] [stdout] 41 | if !verify(&dilithium_signature, &data_to_sign_bytes, &dilithium_public_key_bytes).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `dilithium_signature` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:41:38 [INFO] [stdout] | [INFO] [stdout] 41 | if !verify(&dilithium_signature, &data_to_sign_bytes, &dilithium_public_key_bytes).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `data_to_sign_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:41:59 [INFO] [stdout] | [INFO] [stdout] 41 | if !verify(&dilithium_signature, &data_to_sign_bytes, &dilithium_public_key_bytes).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `dilithium_public_key_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:63:49 [INFO] [stdout] | [INFO] [stdout] 63 | if let Err(e) = locked_writer.write_all(&buffer).await { [INFO] [stdout] | ^^^^^^^ help: change this to: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:75:58 [INFO] [stdout] | [INFO] [stdout] 75 | let _ = utils::send_tcp_message(&ip, &buffer, user_id_hex).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:91:24 [INFO] [stdout] | [INFO] [stdout] 91 | if user_id.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!user_id.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/main.rs:106:35 [INFO] [stdout] | [INFO] [stdout] 106 | if buffer.len() < payload_size as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `payload_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:103:46 [INFO] [stdout] | [INFO] [stdout] 103 | let timestamp = utils::uint8_array_to_ts(×tamp_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `timestamp_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/modules/handle.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | &dilithium_public_key_bytes[..], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the original value instead: `dilithium_public_key_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/modules/handle.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | &ed25519_public_key[..], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use the original value instead: `ed25519_public_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/modules/handle.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | &nonce[..], [INFO] [stdout] | ^^^^^^^^^^ help: use the original value instead: `nonce` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:130:20 [INFO] [stdout] | [INFO] [stdout] 130 | if user_id.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!user_id.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:169:46 [INFO] [stdout] | [INFO] [stdout] 169 | let timestamp = utils::uint8_array_to_ts(×tamp_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `timestamp_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/modules/handle.rs:180:45 [INFO] [stdout] | [INFO] [stdout] 180 | let public_id_hex = crypto::sha256_hash(&public_key_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `public_key_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/modules/utils.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | let N = 6; [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:91:24 [INFO] [stdout] | [INFO] [stdout] 91 | if user_id.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!user_id.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/main.rs:106:35 [INFO] [stdout] | [INFO] [stdout] 106 | if buffer.len() < payload_size as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `payload_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:130:20 [INFO] [stdout] | [INFO] [stdout] 130 | if user_id.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!user_id.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/modules/utils.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | let N = 6; [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.39s [INFO] running `Command { std: "docker" "inspect" "8228238c66531c7de906b0eb8fcd186866afa64fd0e840f600748bc749763df4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8228238c66531c7de906b0eb8fcd186866afa64fd0e840f600748bc749763df4", kill_on_drop: false }` [INFO] [stdout] 8228238c66531c7de906b0eb8fcd186866afa64fd0e840f600748bc749763df4