[INFO] cloning repository https://github.com/1eb/reference [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/1eb/reference" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F1eb%2Freference", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F1eb%2Freference'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 01c9189048f6ad49771ada7bc5df01473254adbc [INFO] linting 1eb/reference against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F1eb%2Freference" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/1eb/reference [INFO] finished tweaking git repo https://github.com/1eb/reference [INFO] tweaked toml for git repo https://github.com/1eb/reference written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/1eb/reference on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bmp v0.5.0 [INFO] [stderr] Downloaded zerocopy-derive v0.8.42 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e3b7bb07b5502ab0947b5e20577b79dd09dc00964953c4579adedc172adc74bf [INFO] running `Command { std: "docker" "start" "-a" "e3b7bb07b5502ab0947b5e20577b79dd09dc00964953c4579adedc172adc74bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e3b7bb07b5502ab0947b5e20577b79dd09dc00964953c4579adedc172adc74bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3b7bb07b5502ab0947b5e20577b79dd09dc00964953c4579adedc172adc74bf", kill_on_drop: false }` [INFO] [stdout] e3b7bb07b5502ab0947b5e20577b79dd09dc00964953c4579adedc172adc74bf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a5e5bfae26e35b0b5814945b132e9faa547703c77d093c0ed9a4c5f9802e494f [INFO] running `Command { std: "docker" "start" "-a" "a5e5bfae26e35b0b5814945b132e9faa547703c77d093c0ed9a4c5f9802e494f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking bmp v0.5.0 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking project-1eb-reference-core v0.1.0 (/opt/rustwide/workdir/core) [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> core/src/base_types.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | / if f < 0f32 { [INFO] [stdout] 171 | | 0f32 [INFO] [stdout] 172 | | } else if f > 1f32 { [INFO] [stdout] 173 | | 1f32 [INFO] [stdout] 174 | | } else { [INFO] [stdout] 175 | | f [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________^ help: replace with clamp: `f.clamp(0f32, 1f32)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> core/src/scene.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | / return Ray { [INFO] [stdout] 154 | | origin: self.position, [INFO] [stdout] 155 | | direction, [INFO] [stdout] 156 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 153 ~ Ray { [INFO] [stdout] 154 + origin: self.position, [INFO] [stdout] 155 + direction, [INFO] [stdout] 156 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Material` which implements the `Copy` trait [INFO] [stdout] --> core/src/scene.rs:284:27 [INFO] [stdout] | [INFO] [stdout] 284 | material: self.material.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.material` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> core/src/lib.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 89 | let specular = (d * f * g) / (4f32 * n.cos_angle_between(v) * n.cos_angle_between(v)); [INFO] [stdout] | -------------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 90 | specular [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 89 ~ [INFO] [stdout] 90 ~ (d * f * g) / (4f32 * n.cos_angle_between(v) * n.cos_angle_between(v)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking project-1eb-reference-exe v0.1.0 (/opt/rustwide/workdir/exe) [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> core/src/base_types.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | / if f < 0f32 { [INFO] [stdout] 171 | | 0f32 [INFO] [stdout] 172 | | } else if f > 1f32 { [INFO] [stdout] 173 | | 1f32 [INFO] [stdout] 174 | | } else { [INFO] [stdout] 175 | | f [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________^ help: replace with clamp: `f.clamp(0f32, 1f32)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> core/src/math.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 307 | / true && (a.0 .0 - b.0 .0).abs() < epsilon [INFO] [stdout] 308 | | && (a.0 .1 - b.0 .1).abs() < epsilon [INFO] [stdout] 309 | | && (a.0 .2 - b.0 .2).abs() < epsilon [INFO] [stdout] 310 | | && (a.0 .3 - b.0 .3).abs() < epsilon [INFO] [stdout] 311 | | && (a.1 .0 - b.1 .0).abs() < epsilon [INFO] [stdout] 312 | | && (a.1 .1 - b.1 .1).abs() < epsilon [INFO] [stdout] | |________________________________________________^ help: try: `(a.0 .0 - b.0 .0).abs() < epsilon && (a.0 .1 - b.0 .1).abs() < epsilon && (a.0 .2 - b.0 .2).abs() < epsilon && (a.0 .3 - b.0 .3).abs() < epsilon && (a.1 .0 - b.1 .0).abs() < epsilon && (a.1 .1 - b.1 .1).abs() < epsilon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.20s [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> core/src/math.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 307 | / true && (a.0 .0 - b.0 .0).abs() < epsilon [INFO] [stdout] 308 | | && (a.0 .1 - b.0 .1).abs() < epsilon [INFO] [stdout] 309 | | && (a.0 .2 - b.0 .2).abs() < epsilon [INFO] [stdout] 310 | | && (a.0 .3 - b.0 .3).abs() < epsilon [INFO] [stdout] 311 | | && (a.1 .0 - b.1 .0).abs() < epsilon [INFO] [stdout] | |________________________________________________^ help: try: `(a.0 .0 - b.0 .0).abs() < epsilon && (a.0 .1 - b.0 .1).abs() < epsilon && (a.0 .2 - b.0 .2).abs() < epsilon && (a.0 .3 - b.0 .3).abs() < epsilon && (a.1 .0 - b.1 .0).abs() < epsilon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> core/src/math.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 307 | / true && (a.0 .0 - b.0 .0).abs() < epsilon [INFO] [stdout] 308 | | && (a.0 .1 - b.0 .1).abs() < epsilon [INFO] [stdout] 309 | | && (a.0 .2 - b.0 .2).abs() < epsilon [INFO] [stdout] 310 | | && (a.0 .3 - b.0 .3).abs() < epsilon [INFO] [stdout] | |________________________________________________^ help: try: `(a.0 .0 - b.0 .0).abs() < epsilon && (a.0 .1 - b.0 .1).abs() < epsilon && (a.0 .2 - b.0 .2).abs() < epsilon && (a.0 .3 - b.0 .3).abs() < epsilon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> core/src/math.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 307 | / true && (a.0 .0 - b.0 .0).abs() < epsilon [INFO] [stdout] 308 | | && (a.0 .1 - b.0 .1).abs() < epsilon [INFO] [stdout] 309 | | && (a.0 .2 - b.0 .2).abs() < epsilon [INFO] [stdout] | |________________________________________________^ help: try: `(a.0 .0 - b.0 .0).abs() < epsilon && (a.0 .1 - b.0 .1).abs() < epsilon && (a.0 .2 - b.0 .2).abs() < epsilon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> core/src/math.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 307 | / true && (a.0 .0 - b.0 .0).abs() < epsilon [INFO] [stdout] 308 | | && (a.0 .1 - b.0 .1).abs() < epsilon [INFO] [stdout] | |________________________________________________^ help: try: `(a.0 .0 - b.0 .0).abs() < epsilon && (a.0 .1 - b.0 .1).abs() < epsilon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> core/src/math.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 307 | true && (a.0 .0 - b.0 .0).abs() < epsilon [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(a.0 .0 - b.0 .0).abs() < epsilon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> core/src/scene.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | / return Ray { [INFO] [stdout] 154 | | origin: self.position, [INFO] [stdout] 155 | | direction, [INFO] [stdout] 156 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 153 ~ Ray { [INFO] [stdout] 154 + origin: self.position, [INFO] [stdout] 155 + direction, [INFO] [stdout] 156 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Material` which implements the `Copy` trait [INFO] [stdout] --> core/src/scene.rs:284:27 [INFO] [stdout] | [INFO] [stdout] 284 | material: self.material.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.material` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> core/src/lib.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 89 | let specular = (d * f * g) / (4f32 * n.cos_angle_between(v) * n.cos_angle_between(v)); [INFO] [stdout] | -------------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 90 | specular [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 89 ~ [INFO] [stdout] 90 ~ (d * f * g) / (4f32 * n.cos_angle_between(v) * n.cos_angle_between(v)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "a5e5bfae26e35b0b5814945b132e9faa547703c77d093c0ed9a4c5f9802e494f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5e5bfae26e35b0b5814945b132e9faa547703c77d093c0ed9a4c5f9802e494f", kill_on_drop: false }` [INFO] [stdout] a5e5bfae26e35b0b5814945b132e9faa547703c77d093c0ed9a4c5f9802e494f