[INFO] cloning repository https://github.com/13W/rssh-agent [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/13W/rssh-agent" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F13W%2Frssh-agent", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F13W%2Frssh-agent'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b64e364f5202e09b81070cb7ed7f6fbba9b639a0 [INFO] linting 13W/rssh-agent against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F13W%2Frssh-agent" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-1-tc1/source/.cargo/config.toml [INFO] removed /workspace/builds/worker-1-tc1/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/13W/rssh-agent [INFO] finished tweaking git repo https://github.com/13W/rssh-agent [INFO] tweaked toml for git repo https://github.com/13W/rssh-agent written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/13W/rssh-agent on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/13W/rssh-agent already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ssh-cipher v0.2.0 [INFO] [stderr] Downloaded ssh-encoding v0.2.0 [INFO] [stderr] Downloaded bcrypt-pbkdf v0.10.0 [INFO] [stderr] Downloaded tokio-test v0.4.4 [INFO] [stderr] Downloaded rtoolbox v0.0.3 [INFO] [stderr] Downloaded clap_mangen v0.2.29 [INFO] [stderr] Downloaded zvariant_derive v5.7.0 [INFO] [stderr] Downloaded roff v0.2.2 [INFO] [stderr] Downloaded zvariant_utils v3.2.1 [INFO] [stderr] Downloaded criterion-plot v0.6.0 [INFO] [stderr] Downloaded assert_cmd v2.0.17 [INFO] [stderr] Downloaded anyhow v1.0.99 [INFO] [stderr] Downloaded clap_complete v4.5.58 [INFO] [stderr] Downloaded clap v4.5.47 [INFO] [stderr] Downloaded zvariant v5.7.0 [INFO] [stderr] Downloaded zbus_macros v5.11.0 [INFO] [stderr] Downloaded serde_derive v1.0.225 [INFO] [stderr] Downloaded clap_builder v4.5.47 [INFO] [stderr] Downloaded criterion v0.7.0 [INFO] [stderr] Downloaded rpassword v7.4.0 [INFO] [stderr] Downloaded zbus v5.11.0 [INFO] [stderr] Downloaded ssh-key v0.6.7 [INFO] [stderr] Downloaded serde_core v1.0.225 [INFO] [stderr] Downloaded serde v1.0.225 [INFO] [stderr] Downloaded bstr v1.12.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3707c2408b659d730faac0657b52e794c2d7822288c9d6aa8681041a3e2d2769 [INFO] running `Command { std: "docker" "start" "-a" "3707c2408b659d730faac0657b52e794c2d7822288c9d6aa8681041a3e2d2769", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3707c2408b659d730faac0657b52e794c2d7822288c9d6aa8681041a3e2d2769", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3707c2408b659d730faac0657b52e794c2d7822288c9d6aa8681041a3e2d2769", kill_on_drop: false }` [INFO] [stdout] 3707c2408b659d730faac0657b52e794c2d7822288c9d6aa8681041a3e2d2769 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ec18d4d8606dc90cf3487868e93e7f8629071e89f749cbc88568f15e1d6ed929 [INFO] running `Command { std: "docker" "start" "-a" "ec18d4d8606dc90cf3487868e93e7f8629071e89f749cbc88568f15e1d6ed929", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling unicode-ident v1.0.19 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Checking cfg-if v1.0.3 [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling serde_core v1.0.225 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling serde v1.0.225 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking base64ct v1.8.0 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Compiling winnow v0.7.13 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling hashbrown v0.16.0 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling semver v1.0.27 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Compiling toml_datetime v0.7.2 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling indexmap v2.11.4 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Compiling thiserror v2.0.16 [INFO] [stderr] Compiling anyhow v1.0.99 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking iana-time-zone v0.1.64 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Compiling toml_parser v1.0.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Compiling toml_edit v0.23.6 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking ssh-encoding v0.2.0 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking clap_builder v4.5.47 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking regex-automata v0.4.10 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking rtoolbox v0.0.3 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking rpassword v7.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Compiling rustversion v1.0.22 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling convert_case v0.7.1 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Compiling instability v0.3.9 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking predicates-core v1.0.9 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling litrs v0.4.2 [INFO] [stderr] Compiling indoc v2.0.6 [INFO] [stderr] Checking float-cmp v0.10.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking criterion-plot v0.6.0 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Compiling assert_cmd v2.0.17 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking roff v0.2.2 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Checking nu-ansi-term v0.50.1 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking predicates-tree v1.0.12 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking regex v1.11.2 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking bstr v1.12.0 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking tempfile v3.22.0 [INFO] [stderr] Compiling serde_derive v1.0.225 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling thiserror-impl v2.0.16 [INFO] [stderr] Compiling clap_derive v4.5.47 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking async-process v2.5.0 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking bcrypt-pbkdf v0.10.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking ssh-cipher v0.2.0 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking clap v4.5.47 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking clap_mangen v0.2.29 [INFO] [stderr] Checking clap_complete v4.5.58 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking rsa v0.9.8 [INFO] [stderr] Checking ssh-key v0.6.7 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking rssh-types v0.1.0 (/opt/rustwide/workdir/crates/rssh-types) [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking zvariant_utils v3.2.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking tracing-serde v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Compiling zvariant_derive v5.7.0 [INFO] [stderr] Checking criterion v0.7.0 [INFO] [stderr] Compiling zvariant v5.7.0 [INFO] [stderr] Checking rssh-core v0.1.0 (/opt/rustwide/workdir/crates/rssh-core) [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/rssh-core/src/config.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 193 | assert_eq!(parsed.settings.allow_rsa_sha1, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 193 - assert_eq!(parsed.settings.allow_rsa_sha1, false); [INFO] [stdout] 193 + assert!(!parsed.settings.allow_rsa_sha1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> crates/rssh-core/src/error.rs:155:23 [INFO] [stdout] | [INFO] [stdout] 155 | Error::Io(std::io::Error::new(std::io::ErrorKind::Other, "test")).exit_code(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 155 - Error::Io(std::io::Error::new(std::io::ErrorKind::Other, "test")).exit_code(), [INFO] [stdout] 155 + Error::Io(std::io::Error::other("test")).exit_code(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> crates/rssh-core/src/fs_policy.rs:165:14 [INFO] [stdout] | [INFO] [stdout] 165 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rssh-proto v0.1.0 (/opt/rustwide/workdir/crates/rssh-proto) [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> crates/rssh-core/src/keyfile.rs:1159:17 [INFO] [stdout] | [INFO] [stdout] 1159 | assert!(wire_data.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!wire_data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> crates/rssh-core/src/openssh.rs:271:17 [INFO] [stdout] | [INFO] [stdout] 271 | assert!(bits >= 2048 && bits <= 2056); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(2048..=2056).contains(&bits)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking zbus_names v4.2.0 [INFO] [stderr] Compiling zbus_macros v5.11.0 [INFO] [stderr] Checking zbus v5.11.0 [INFO] [stderr] Checking rssh-daemon v0.1.0 (/opt/rustwide/workdir/crates/rssh-daemon) [INFO] [stdout] warning: struct `SetDescRequest` is never constructed [INFO] [stdout] --> crates/rssh-daemon/src/extensions.rs:2107:12 [INFO] [stdout] | [INFO] [stdout] 2107 | struct SetDescRequest { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/rssh-daemon/src/systemd.rs:132:40 [INFO] [stdout] | [INFO] [stdout] 132 | env::set_var("LISTEN_PID", &std::process::id().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `std::process::id().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/rssh-daemon/src/systemd.rs:164:40 [INFO] [stdout] | [INFO] [stdout] 164 | env::set_var("LISTEN_PID", &std::process::id().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `std::process::id().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rssh-cli v0.1.0 (/opt/rustwide/workdir/crates/rssh-cli) [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/rssh-daemon/benches/storage_bench.rs:19:74 [INFO] [stdout] | [INFO] [stdout] 19 | secret_openssh_b64: general_purpose::STANDARD.encode(&[0u8; 64]), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `[0u8; 64]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/rssh-daemon/benches/storage_bench.rs:48:74 [INFO] [stdout] | [INFO] [stdout] 48 | secret_openssh_b64: general_purpose::STANDARD.encode(&[0u8; 64]), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `[0u8; 64]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/rssh-daemon/benches/storage_bench.rs:79:74 [INFO] [stdout] | [INFO] [stdout] 79 | secret_openssh_b64: general_purpose::STANDARD.encode(&[0u8; 512]), // Larger RSA key [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `[0u8; 512]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/rssh-daemon/benches/storage_bench.rs:130:70 [INFO] [stdout] | [INFO] [stdout] 130 | secret_openssh_b64: general_purpose::STANDARD.encode(&[i as u8; 64]), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `[i as u8; 64]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/rssh-daemon/benches/storage_bench.rs:196:66 [INFO] [stdout] | [INFO] [stdout] 196 | secret_openssh_b64: general_purpose::STANDARD.encode(&[0u8; 64]), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `[0u8; 64]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/rssh-daemon/benches/storage_bench.rs:218:66 [INFO] [stdout] | [INFO] [stdout] 218 | secret_openssh_b64: general_purpose::STANDARD.encode(&[0u8; 64]), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `[0u8; 64]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> crates/rssh-daemon/tests/extensions_test.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | assert_eq!(deserialized.success, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 223 - assert_eq!(deserialized.success, false); [INFO] [stdout] 223 + assert!(!deserialized.success); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/rssh-daemon/tests/e2e_test.rs:148:15 [INFO] [stdout] | [INFO] [stdout] 148 | .args(&["build", "--package", "rssh-cli", "--bin", "rssh-agent"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["build", "--package", "rssh-cli", "--bin", "rssh-agent"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/rssh-daemon/tests/e2e_test.rs:170:15 [INFO] [stdout] | [INFO] [stdout] 170 | .args(&["daemon", "--socket", &socket_str, "--foreground"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["daemon", "--socket", &socket_str, "--foreground"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/rssh-daemon/tests/tui_integration_test.rs:191:15 [INFO] [stdout] | [INFO] [stdout] 191 | .args(&["build", "--package", "rssh-cli", "--bin", "rssh-agent"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["build", "--package", "rssh-cli", "--bin", "rssh-agent"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/rssh-daemon/tests/tui_integration_test.rs:213:15 [INFO] [stdout] | [INFO] [stdout] 213 | .args(&["daemon", "--socket", &socket_str, "--foreground"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["daemon", "--socket", &socket_str, "--foreground"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/rssh-daemon/tests/integration_test.rs:425:15 [INFO] [stdout] | [INFO] [stdout] 425 | .args(&["build", "--package", "rssh-cli", "--bin", "rssh-agent"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["build", "--package", "rssh-cli", "--bin", "rssh-agent"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/rssh-daemon/tests/integration_test.rs:463:15 [INFO] [stdout] | [INFO] [stdout] 463 | .args(&["daemon", "--socket", &socket_str, "--foreground"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["daemon", "--socket", &socket_str, "--foreground"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> crates/rssh-daemon/tests/integration_test.rs:139:20 [INFO] [stdout] | [INFO] [stdout] 139 | let requests = vec![ [INFO] [stdout] | ____________________^ [INFO] [stdout] 140 | | read_mock_file("tests/mocks/01_list_empty.request"), [INFO] [stdout] 141 | | read_mock_file("tests/mocks/03_remove_all.request"), [INFO] [stdout] 142 | | read_mock_file("tests/mocks/01_list_empty.request"), [INFO] [stdout] 143 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 139 ~ let requests = [read_mock_file("tests/mocks/01_list_empty.request"), [INFO] [stdout] 140 + read_mock_file("tests/mocks/03_remove_all.request"), [INFO] [stdout] 141 ~ read_mock_file("tests/mocks/01_list_empty.request")]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> crates/rssh-cli/src/tui/modals/import_key.rs:153:21 [INFO] [stdout] | [INFO] [stdout] 153 | / if c.is_ascii() && !c.is_ascii_control() { [INFO] [stdout] 154 | | state.description.handle_char(c); [INFO] [stdout] 155 | | state.error = None; [INFO] [stdout] 156 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 152 ~ 0 [INFO] [stdout] 153 ~ if c.is_ascii() && !c.is_ascii_control() => { [INFO] [stdout] 154 | state.description.handle_char(c); [INFO] [stdout] 155 | state.error = None; [INFO] [stdout] 156 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> crates/rssh-cli/src/tui/modals/import_key.rs:153:21 [INFO] [stdout] | [INFO] [stdout] 153 | / if c.is_ascii() && !c.is_ascii_control() { [INFO] [stdout] 154 | | state.description.handle_char(c); [INFO] [stdout] 155 | | state.error = None; [INFO] [stdout] 156 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 152 ~ 0 [INFO] [stdout] 153 ~ if c.is_ascii() && !c.is_ascii_control() => { [INFO] [stdout] 154 | state.description.handle_char(c); [INFO] [stdout] 155 | state.error = None; [INFO] [stdout] 156 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> crates/rssh-cli/src/tui/mod.rs:677:13 [INFO] [stdout] | [INFO] [stdout] 677 | / if app.active_frame == ActiveFrame::InfoPanel { [INFO] [stdout] 678 | | if let Some(idx) = app.selected_key { [INFO] [stdout] 679 | | if idx < app.keys.len() { [INFO] [stdout] 680 | | let key = &app.keys[idx]; [INFO] [stdout] ... | [INFO] [stdout] 713 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 676 ~ KeyCode::Enter [INFO] [stdout] 677 ~ if app.active_frame == ActiveFrame::InfoPanel => { [INFO] [stdout] 678 | if let Some(idx) = app.selected_key { [INFO] [stdout] ... [INFO] [stdout] 712 | } [INFO] [stdout] 713 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> crates/rssh-cli/src/tui/mod.rs:677:13 [INFO] [stdout] | [INFO] [stdout] 677 | / if app.active_frame == ActiveFrame::InfoPanel { [INFO] [stdout] 678 | | if let Some(idx) = app.selected_key { [INFO] [stdout] 679 | | if idx < app.keys.len() { [INFO] [stdout] 680 | | let key = &app.keys[idx]; [INFO] [stdout] ... | [INFO] [stdout] 713 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 676 ~ KeyCode::Enter [INFO] [stdout] 677 ~ if app.active_frame == ActiveFrame::InfoPanel => { [INFO] [stdout] 678 | if let Some(idx) = app.selected_key { [INFO] [stdout] ... [INFO] [stdout] 712 | } [INFO] [stdout] 713 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.71s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: num-bigint-dig v0.8.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "ec18d4d8606dc90cf3487868e93e7f8629071e89f749cbc88568f15e1d6ed929", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec18d4d8606dc90cf3487868e93e7f8629071e89f749cbc88568f15e1d6ed929", kill_on_drop: false }` [INFO] [stdout] ec18d4d8606dc90cf3487868e93e7f8629071e89f749cbc88568f15e1d6ed929