[INFO] cloning repository https://github.com/132ikl/powerschedule [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/132ikl/powerschedule" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F132ikl%2Fpowerschedule", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F132ikl%2Fpowerschedule'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b6f73863d28aa5e7910a6bda8486c0d445a85705 [INFO] linting 132ikl/powerschedule against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F132ikl%2Fpowerschedule" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/132ikl/powerschedule [INFO] finished tweaking git repo https://github.com/132ikl/powerschedule [INFO] tweaked toml for git repo https://github.com/132ikl/powerschedule written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/132ikl/powerschedule on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/132ikl/powerschedule already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_spanned v0.6.3 [INFO] [stderr] Downloaded enum-iterator-derive v1.2.1 [INFO] [stderr] Downloaded yansi v1.0.0-rc.1 [INFO] [stderr] Downloaded combinations v0.1.0 [INFO] [stderr] Downloaded enum-iterator v1.4.1 [INFO] [stderr] Downloaded winnow v0.5.17 [INFO] [stderr] Downloaded csv v1.2.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 75bc1dcea7d61ece67cf3611e5e0f8db38bc0b797bcb1e406d55e89883d2ca48 [INFO] running `Command { std: "docker" "start" "-a" "75bc1dcea7d61ece67cf3611e5e0f8db38bc0b797bcb1e406d55e89883d2ca48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "75bc1dcea7d61ece67cf3611e5e0f8db38bc0b797bcb1e406d55e89883d2ca48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75bc1dcea7d61ece67cf3611e5e0f8db38bc0b797bcb1e406d55e89883d2ca48", kill_on_drop: false }` [INFO] [stdout] 75bc1dcea7d61ece67cf3611e5e0f8db38bc0b797bcb1e406d55e89883d2ca48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f91285f9728fd4ad1cd9edd4ee9b52e2633587ba52ca9e74f8e1801c4c7efdc6 [INFO] running `Command { std: "docker" "start" "-a" "f91285f9728fd4ad1cd9edd4ee9b52e2633587ba52ca9e74f8e1801c4c7efdc6", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking hashbrown v0.14.2 [INFO] [stderr] Checking memchr v2.6.2 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking winnow v0.5.17 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking yansi v1.0.0-rc.1 [INFO] [stderr] Checking combinations v0.1.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking indexmap v2.0.2 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling enum-iterator-derive v1.2.1 [INFO] [stderr] Checking enum-iterator v1.4.1 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking csv v1.2.2 [INFO] [stderr] Checking toml_edit v0.20.2 [INFO] [stderr] Checking toml v0.8.2 [INFO] [stderr] Checking powerschedule v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `get_many_mut` has been stable since 1.86.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | #![feature(get_many_mut)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `get_many_mut` has been stable since 1.86.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | #![feature(get_many_mut)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RequesiteRegistry` is never constructed [INFO] [stdout] --> src/requirements.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct RequesiteRegistry<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/class.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / impl PartialOrd for Class { [INFO] [stdout] 20 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 21 | | Some(self.name().cmp(&other.name())) [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 20 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 21 - Some(self.name().cmp(&other.name())) [INFO] [stdout] 22 - } [INFO] [stdout] 20 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/class.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / impl PartialOrd for Class { [INFO] [stdout] 20 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 21 | | Some(self.name().cmp(&other.name())) [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 20 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 21 - Some(self.name().cmp(&other.name())) [INFO] [stdout] 22 - } [INFO] [stdout] 20 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/data.rs:72:24 [INFO] [stdout] | [INFO] [stdout] 72 | return !(self.year % 2 == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.year % 2 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return false; [INFO] [stdout] 78 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/data.rs:72:25 [INFO] [stdout] | [INFO] [stdout] 72 | return !(self.year % 2 == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.year.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/data.rs:75:24 [INFO] [stdout] | [INFO] [stdout] 75 | return self.year % 2 == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `self.year.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | return Ok(Rc::new(self)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return Ok(Rc::new(self)); [INFO] [stdout] 117 + Ok(Rc::new(self)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/data.rs:135:25 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn new(classes: &Vec>, taken: Rc>, term: Term) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 135 ~ pub fn new(classes: &[Rc], taken: Rc>, term: Term) -> Self { [INFO] [stdout] 136 | let mut sched = Schedule { [INFO] [stdout] ... [INFO] [stdout] 141 | }; [INFO] [stdout] 142 ~ sched.remaining = classes.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return Ok(()); [INFO] [stdout] 152 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/data.rs:147:49 [INFO] [stdout] | [INFO] [stdout] 147 | let mut classes = self.semesters.iter().map(|x| x.0.clone()).flatten(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|x| x.0.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/data.rs:158:14 [INFO] [stdout] | [INFO] [stdout] 158 | .map(|x| x.0.clone()) [INFO] [stdout] | ______________^ [INFO] [stdout] 159 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|x| x.0.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/data.rs:165:45 [INFO] [stdout] | [INFO] [stdout] 165 | let classes = self.semesters.iter().map(|x| x.0.clone()).flatten(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|x| x.0.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/data.rs:189:38 [INFO] [stdout] | [INFO] [stdout] 189 | if !self.meets_group_credits(&config) { [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/data.rs:196:32 [INFO] [stdout] | [INFO] [stdout] 196 | match self.is_complete(&config) { [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/data.rs:72:24 [INFO] [stdout] | [INFO] [stdout] 72 | return !(self.year % 2 == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.year % 2 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return false; [INFO] [stdout] 78 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/data.rs:72:25 [INFO] [stdout] | [INFO] [stdout] 72 | return !(self.year % 2 == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.year.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/data.rs:75:24 [INFO] [stdout] | [INFO] [stdout] 75 | return self.year % 2 == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `self.year.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/data.rs:262:14 [INFO] [stdout] | [INFO] [stdout] 262 | .map(|i| Combinations::new(self.remaining.clone(), i)) [INFO] [stdout] | ______________^ [INFO] [stdout] 263 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|i| Combinations::new(self.remaining.clone(), i))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | return Ok(Rc::new(self)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return Ok(Rc::new(self)); [INFO] [stdout] 117 + Ok(Rc::new(self)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/data.rs:135:25 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn new(classes: &Vec>, taken: Rc>, term: Term) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 135 ~ pub fn new(classes: &[Rc], taken: Rc>, term: Term) -> Self { [INFO] [stdout] 136 | let mut sched = Schedule { [INFO] [stdout] ... [INFO] [stdout] 141 | }; [INFO] [stdout] 142 ~ sched.remaining = classes.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/data.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return Ok(()); [INFO] [stdout] 152 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/data.rs:147:49 [INFO] [stdout] | [INFO] [stdout] 147 | let mut classes = self.semesters.iter().map(|x| x.0.clone()).flatten(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|x| x.0.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/data.rs:158:14 [INFO] [stdout] | [INFO] [stdout] 158 | .map(|x| x.0.clone()) [INFO] [stdout] | ______________^ [INFO] [stdout] 159 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|x| x.0.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/data.rs:165:45 [INFO] [stdout] | [INFO] [stdout] 165 | let classes = self.semesters.iter().map(|x| x.0.clone()).flatten(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|x| x.0.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/data.rs:189:38 [INFO] [stdout] | [INFO] [stdout] 189 | if !self.meets_group_credits(&config) { [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/data.rs:196:32 [INFO] [stdout] | [INFO] [stdout] 196 | match self.is_complete(&config) { [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/data.rs:260:45 [INFO] [stdout] | [INFO] [stdout] 260 | let mut candidates: Vec = (min..=max) [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 261 | | .into_iter() [INFO] [stdout] | |________________________^ help: consider removing `.into_iter()`: `(min..=max)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/data.rs:286:18 [INFO] [stdout] | [INFO] [stdout] 286 | .map(|x| x.0.clone()) [INFO] [stdout] | __________________^ [INFO] [stdout] 287 | | .flatten() [INFO] [stdout] | |__________________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|x| x.0.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/data.rs:301:14 [INFO] [stdout] | [INFO] [stdout] 301 | .map(|x| x.0.clone()) [INFO] [stdout] | ______________^ [INFO] [stdout] 302 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|x| x.0.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/data.rs:262:14 [INFO] [stdout] | [INFO] [stdout] 262 | .map(|i| Combinations::new(self.remaining.clone(), i)) [INFO] [stdout] | ______________^ [INFO] [stdout] 263 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|i| Combinations::new(self.remaining.clone(), i))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/data.rs:260:45 [INFO] [stdout] | [INFO] [stdout] 260 | let mut candidates: Vec = (min..=max) [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 261 | | .into_iter() [INFO] [stdout] | |________________________^ help: consider removing `.into_iter()`: `(min..=max)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/data.rs:286:18 [INFO] [stdout] | [INFO] [stdout] 286 | .map(|x| x.0.clone()) [INFO] [stdout] | __________________^ [INFO] [stdout] 287 | | .flatten() [INFO] [stdout] | |__________________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|x| x.0.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/data.rs:301:14 [INFO] [stdout] | [INFO] [stdout] 301 | .map(|x| x.0.clone()) [INFO] [stdout] | ______________^ [INFO] [stdout] 302 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|x| x.0.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/main.rs:19:19 [INFO] [stdout] | [INFO] [stdout] 19 | fn step_schedules<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/main.rs:25:10 [INFO] [stdout] | [INFO] [stdout] 25 | .map(|sched| { [INFO] [stdout] | __________^ [INFO] [stdout] 26 | | sched [INFO] [stdout] 27 | | .generate_possible(config) [INFO] [stdout] 28 | | .into_iter() [INFO] [stdout] ... | [INFO] [stdout] 34 | | }) [INFO] [stdout] 35 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 25 ~ .flat_map(|sched| { [INFO] [stdout] 26 + sched [INFO] [stdout] 27 + .generate_possible(config) [INFO] [stdout] 28 + .into_iter() [INFO] [stdout] 29 + .map(|sem_result| match sem_result { [INFO] [stdout] 30 + Ok(sem) => sched.child(sem), [INFO] [stdout] 31 + Err(err) => Err(err), [INFO] [stdout] 32 + }) [INFO] [stdout] 33 + .collect::>>() [INFO] [stdout] 34 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iterator_try_collect` is declared but not used [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(iterator_try_collect)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iter_collect_into` is declared but not used [INFO] [stdout] --> src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(iter_collect_into)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/main.rs:19:19 [INFO] [stdout] | [INFO] [stdout] 19 | fn step_schedules<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/main.rs:25:10 [INFO] [stdout] | [INFO] [stdout] 25 | .map(|sched| { [INFO] [stdout] | __________^ [INFO] [stdout] 26 | | sched [INFO] [stdout] 27 | | .generate_possible(config) [INFO] [stdout] 28 | | .into_iter() [INFO] [stdout] ... | [INFO] [stdout] 34 | | }) [INFO] [stdout] 35 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 25 ~ .flat_map(|sched| { [INFO] [stdout] 26 + sched [INFO] [stdout] 27 + .generate_possible(config) [INFO] [stdout] 28 + .into_iter() [INFO] [stdout] 29 + .map(|sem_result| match sem_result { [INFO] [stdout] 30 + Ok(sem) => sched.child(sem), [INFO] [stdout] 31 + Err(err) => Err(err), [INFO] [stdout] 32 + }) [INFO] [stdout] 33 + .collect::>>() [INFO] [stdout] 34 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iterator_try_collect` is declared but not used [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(iterator_try_collect)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iter_collect_into` is declared but not used [INFO] [stdout] --> src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(iter_collect_into)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.84s [INFO] running `Command { std: "docker" "inspect" "f91285f9728fd4ad1cd9edd4ee9b52e2633587ba52ca9e74f8e1801c4c7efdc6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f91285f9728fd4ad1cd9edd4ee9b52e2633587ba52ca9e74f8e1801c4c7efdc6", kill_on_drop: false }` [INFO] [stdout] f91285f9728fd4ad1cd9edd4ee9b52e2633587ba52ca9e74f8e1801c4c7efdc6