[INFO] cloning repository https://github.com/100495675/trasteo_macros [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/100495675/trasteo_macros" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F100495675%2Ftrasteo_macros", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F100495675%2Ftrasteo_macros'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3b32b10f45df1944e22feeac7acaa5417e0b5c18 [INFO] linting 100495675/trasteo_macros against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F100495675%2Ftrasteo_macros" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/100495675/trasteo_macros [INFO] finished tweaking git repo https://github.com/100495675/trasteo_macros [INFO] tweaked toml for git repo https://github.com/100495675/trasteo_macros written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/100495675/trasteo_macros on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/100495675/trasteo_macros already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 681c5b8fff944f009a54be87876de393b208a63d07bbddf77ede0e048bfd3a4a [INFO] running `Command { std: "docker" "start" "-a" "681c5b8fff944f009a54be87876de393b208a63d07bbddf77ede0e048bfd3a4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "681c5b8fff944f009a54be87876de393b208a63d07bbddf77ede0e048bfd3a4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "681c5b8fff944f009a54be87876de393b208a63d07bbddf77ede0e048bfd3a4a", kill_on_drop: false }` [INFO] [stdout] 681c5b8fff944f009a54be87876de393b208a63d07bbddf77ede0e048bfd3a4a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8ef662fdc7489e025e889411569659a9eace9e8c757a5b48f251c6124b003665 [INFO] running `Command { std: "docker" "start" "-a" "8ef662fdc7489e025e889411569659a9eace9e8c757a5b48f251c6124b003665", kill_on_drop: false }` [INFO] [stderr] Compiling my_proc_macro v0.1.0 (/opt/rustwide/workdir/my_proc_macro) [INFO] [stderr] Checking trasteo_macros v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/prev.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / impl Into for Prev [INFO] [stdout] 13 | | where [INFO] [stdout] 14 | | N: Into, [INFO] [stdout] ... | [INFO] [stdout] 19 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 12 ~ impl From> for i32 [INFO] [stdout] 13 | where [INFO] [stdout] 14 | N: Into, [INFO] [stdout] 15 | { [INFO] [stdout] 16 ~ fn from(val: Prev) -> Self { [INFO] [stdout] 17 ~ val.0.into() - 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/prev.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / impl Into for Prev [INFO] [stdout] 13 | | where [INFO] [stdout] 14 | | N: Into, [INFO] [stdout] ... | [INFO] [stdout] 19 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 12 ~ impl From> for i32 [INFO] [stdout] 13 | where [INFO] [stdout] 14 | N: Into, [INFO] [stdout] 15 | { [INFO] [stdout] 16 ~ fn from(val: Prev) -> Self { [INFO] [stdout] 17 ~ val.0.into() - 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/succ.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / impl Into for Succ [INFO] [stdout] 13 | | where [INFO] [stdout] 14 | | N: Into, [INFO] [stdout] ... | [INFO] [stdout] 19 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 12 ~ impl From> for i32 [INFO] [stdout] 13 | where [INFO] [stdout] 14 | N: Into, [INFO] [stdout] 15 | { [INFO] [stdout] 16 ~ fn from(val: Succ) -> Self { [INFO] [stdout] 17 ~ 1 + val.0.into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/succ.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / impl Into for Succ [INFO] [stdout] 13 | | where [INFO] [stdout] 14 | | N: Into, [INFO] [stdout] ... | [INFO] [stdout] 19 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 12 ~ impl From> for i32 [INFO] [stdout] 13 | where [INFO] [stdout] 14 | N: Into, [INFO] [stdout] 15 | { [INFO] [stdout] 16 ~ fn from(val: Succ) -> Self { [INFO] [stdout] 17 ~ 1 + val.0.into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/zero.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | impl Into for Zero { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 11 ~ impl From for i32 { [INFO] [stdout] 12 ~ fn from(val: Zero) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/zero.rs:55:1 [INFO] [stdout] | [INFO] [stdout] 55 | / impl PartialOrd for Zero { [INFO] [stdout] 56 | | fn partial_cmp(&self, _other: &Zero) -> Option { [INFO] [stdout] 57 | | Some(Ordering::Equal) [INFO] [stdout] 58 | | } [INFO] [stdout] 59 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 56 - fn partial_cmp(&self, _other: &Zero) -> Option { [INFO] [stdout] 57 - Some(Ordering::Equal) [INFO] [stdout] 58 - } [INFO] [stdout] 56 + fn partial_cmp(&self, _other: &Zero) -> Option { Some(self.cmp(_other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/zero.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | impl Into for Zero { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 11 ~ impl From for i32 { [INFO] [stdout] 12 ~ fn from(val: Zero) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/zero.rs:55:1 [INFO] [stdout] | [INFO] [stdout] 55 | / impl PartialOrd for Zero { [INFO] [stdout] 56 | | fn partial_cmp(&self, _other: &Zero) -> Option { [INFO] [stdout] 57 | | Some(Ordering::Equal) [INFO] [stdout] 58 | | } [INFO] [stdout] 59 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 56 - fn partial_cmp(&self, _other: &Zero) -> Option { [INFO] [stdout] 57 - Some(Ordering::Equal) [INFO] [stdout] 58 - } [INFO] [stdout] 56 + fn partial_cmp(&self, _other: &Zero) -> Option { Some(self.cmp(_other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integer_tests.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | assert!(!(from_int!(0) > from_int!(0))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(from_int!(0) <= from_int!(0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integer_tests.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | assert!(!(from_int!(0) < from_int!(0))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(from_int!(0) >= from_int!(0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integer_tests.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | assert!(!(from_int!(1) > from_int!(1))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(from_int!(1) <= from_int!(1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integer_tests.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | assert!(!(from_int!(1) < from_int!(1))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(from_int!(1) >= from_int!(1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integer_tests.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | assert!(!(from_int!(-1) > from_int!(-1))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(from_int!(-1) <= from_int!(-1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integer_tests.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | assert!(!(from_int!(-1) < from_int!(-1))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(from_int!(-1) >= from_int!(-1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.29s [INFO] running `Command { std: "docker" "inspect" "8ef662fdc7489e025e889411569659a9eace9e8c757a5b48f251c6124b003665", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ef662fdc7489e025e889411569659a9eace9e8c757a5b48f251c6124b003665", kill_on_drop: false }` [INFO] [stdout] 8ef662fdc7489e025e889411569659a9eace9e8c757a5b48f251c6124b003665