[INFO] cloning repository https://github.com/0xatrilla/terminally-online [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/0xatrilla/terminally-online" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0xatrilla%2Fterminally-online", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0xatrilla%2Fterminally-online'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 995bbf7555133e04a6618bf846ee8942f428de7d [INFO] linting 0xatrilla/terminally-online against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0xatrilla%2Fterminally-online" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/0xatrilla/terminally-online [INFO] finished tweaking git repo https://github.com/0xatrilla/terminally-online [INFO] tweaked toml for git repo https://github.com/0xatrilla/terminally-online written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/0xatrilla/terminally-online on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/0xatrilla/terminally-online already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.104 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.104 [INFO] [stderr] Downloaded wasm-bindgen v0.2.104 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.104 [INFO] [stderr] Downloaded windows-strings v0.5.0 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.104 [INFO] [stderr] Downloaded unicode-ident v1.0.19 [INFO] [stderr] Downloaded pulldown-cmark-escape v0.10.1 [INFO] [stderr] Downloaded cfg-if v1.0.3 [INFO] [stderr] Downloaded difflib v0.4.0 [INFO] [stderr] Downloaded webbrowser v0.8.15 [INFO] [stderr] Downloaded humantime-serde v1.1.1 [INFO] [stderr] Downloaded float-cmp v0.10.0 [INFO] [stderr] Downloaded anstyle v1.0.11 [INFO] [stderr] Downloaded tree_magic_mini v3.2.0 [INFO] [stderr] Downloaded option-ext v0.2.0 [INFO] [stderr] Downloaded color_quant v1.1.0 [INFO] [stderr] Downloaded thiserror-impl v2.0.16 [INFO] [stderr] Downloaded gif v0.13.3 [INFO] [stderr] Downloaded gethostname v1.0.2 [INFO] [stderr] Downloaded dirs v5.0.1 [INFO] [stderr] Downloaded mio v0.8.11 [INFO] [stderr] Downloaded termtree v0.5.1 [INFO] [stderr] Downloaded assert_cmd v2.0.17 [INFO] [stderr] Downloaded regex v1.11.3 [INFO] [stderr] Downloaded bytemuck v1.23.2 [INFO] [stderr] Downloaded moxcms v0.7.5 [INFO] [stderr] Downloaded rusqlite v0.31.0 [INFO] [stderr] Downloaded hyper v1.7.0 [INFO] [stderr] Downloaded quinn-proto v0.11.13 [INFO] [stderr] Downloaded unicode-width v0.2.1 [INFO] [stderr] Downloaded syn v2.0.106 [INFO] [stderr] Downloaded webpki-roots v1.0.2 [INFO] [stderr] Downloaded image v0.25.8 [INFO] [stderr] Downloaded iri-string v0.7.8 [INFO] [stderr] Downloaded regex-syntax v0.8.6 [INFO] [stderr] Downloaded rustls v0.23.32 [INFO] [stderr] Downloaded icu_properties_data v2.0.1 [INFO] [stderr] Downloaded rustix v1.1.2 [INFO] [stderr] Downloaded ratatui v0.26.3 [INFO] [stderr] Downloaded humantime v2.3.0 [INFO] [stderr] Downloaded bstr v1.12.0 [INFO] [stderr] Downloaded crossterm v0.27.0 [INFO] [stderr] Downloaded reqwest v0.12.23 [INFO] [stderr] Downloaded zerovec v0.11.4 [INFO] [stderr] Downloaded wait-timeout v0.2.1 [INFO] [stderr] Downloaded image-webp v0.2.4 [INFO] [stderr] Downloaded web-sys v0.3.81 [INFO] [stderr] Downloaded regex-automata v0.4.11 [INFO] [stderr] Downloaded pulldown-cmark v0.10.3 [INFO] [stderr] Downloaded tower-http v0.6.6 [INFO] [stderr] Downloaded icu_collections v2.0.0 [INFO] [stderr] Downloaded hyper-util v0.1.17 [INFO] [stderr] Downloaded petgraph v0.6.5 [INFO] [stderr] Downloaded io-uring v0.7.10 [INFO] [stderr] Downloaded mio v1.0.4 [INFO] [stderr] Downloaded indexmap v2.11.4 [INFO] [stderr] Downloaded icu_locale_core v2.0.0 [INFO] [stderr] Downloaded fuzzy-matcher v0.3.7 [INFO] [stderr] Downloaded libc v0.2.176 [INFO] [stderr] Downloaded flate2 v1.1.2 [INFO] [stderr] Downloaded tokio v1.47.1 [INFO] [stderr] Downloaded pxfm v0.1.24 [INFO] [stderr] Downloaded rustls-webpki v0.103.6 [INFO] [stderr] Downloaded cc v1.2.39 [INFO] [stderr] Downloaded icu_normalizer_data v2.0.0 [INFO] [stderr] Downloaded zerotrie v0.2.2 [INFO] [stderr] Downloaded doc-comment v0.3.3 [INFO] [stderr] Downloaded predicates-tree v1.0.12 [INFO] [stderr] Downloaded dirs-sys v0.4.1 [INFO] [stderr] Downloaded half v2.6.0 [INFO] [stderr] Downloaded compact_str v0.7.1 [INFO] [stderr] Downloaded rustls-pki-types v1.12.0 [INFO] [stderr] Downloaded getrandom v0.3.3 [INFO] [stderr] Downloaded tiny_http v0.12.0 [INFO] [stderr] Downloaded icu_normalizer v2.0.0 [INFO] [stderr] Downloaded icu_provider v2.0.0 [INFO] [stderr] Downloaded icu_properties v2.0.1 [INFO] [stderr] Downloaded js-sys v0.3.81 [INFO] [stderr] Downloaded weezl v0.1.10 [INFO] [stderr] Downloaded parking_lot v0.12.4 [INFO] [stderr] Downloaded socket2 v0.6.0 [INFO] [stderr] Downloaded windows-core v0.62.1 [INFO] [stderr] Downloaded tempfile v3.23.0 [INFO] [stderr] Downloaded hashlink v0.9.1 [INFO] [stderr] Downloaded bitflags v2.9.4 [INFO] [stderr] Downloaded ascii v1.1.0 [INFO] [stderr] Downloaded raw-window-handle v0.5.2 [INFO] [stderr] Downloaded litemap v0.8.0 [INFO] [stderr] Downloaded tinystr v0.8.1 [INFO] [stderr] Downloaded zerovec-derive v0.11.1 [INFO] [stderr] Downloaded unicase v2.8.1 [INFO] [stderr] Downloaded lock_api v0.4.13 [INFO] [stderr] Downloaded redox_syscall v0.5.17 [INFO] [stderr] Downloaded parking_lot_core v0.9.11 [INFO] [stderr] Downloaded thiserror v2.0.16 [INFO] [stderr] Downloaded rustc-demangle v0.1.26 [INFO] [stderr] Downloaded fallible-iterator v0.3.0 [INFO] [stderr] Downloaded find-msvc-tools v0.1.2 [INFO] [stderr] Downloaded wasi v0.14.7+wasi-0.2.4 [INFO] [stderr] Downloaded writeable v0.6.1 [INFO] [stderr] Downloaded potential_utf v0.1.3 [INFO] [stderr] Downloaded yoke v0.8.0 [INFO] [stderr] Downloaded predicates v3.1.3 [INFO] [stderr] Downloaded fallible-streaming-iterator v0.1.9 [INFO] [stderr] Downloaded getopts v0.2.24 [INFO] [stderr] Downloaded unicode-linebreak v0.1.5 [INFO] [stderr] Downloaded predicates-core v1.0.9 [INFO] [stderr] Downloaded lru v0.12.5 [INFO] [stderr] Downloaded stability v0.2.1 [INFO] [stderr] Downloaded windows-targets v0.53.4 [INFO] [stderr] Downloaded windows-interface v0.59.2 [INFO] [stderr] Downloaded chunked_transfer v1.5.0 [INFO] [stderr] Downloaded windows-link v0.2.0 [INFO] [stderr] Downloaded yoke-derive v0.8.0 [INFO] [stderr] Downloaded normalize-line-endings v0.3.0 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.54 [INFO] [stderr] Downloaded windows-implement v0.60.1 [INFO] [stderr] Downloaded windows-result v0.4.0 [INFO] [stderr] Downloaded windows-sys v0.61.1 [INFO] [stderr] Downloaded libsqlite3-sys v0.28.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] be658d416378c9422d272a919c7ff7f9632a43ab405d092ea0a07e3113aa8273 [INFO] running `Command { std: "docker" "start" "-a" "be658d416378c9422d272a919c7ff7f9632a43ab405d092ea0a07e3113aa8273", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "be658d416378c9422d272a919c7ff7f9632a43ab405d092ea0a07e3113aa8273", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be658d416378c9422d272a919c7ff7f9632a43ab405d092ea0a07e3113aa8273", kill_on_drop: false }` [INFO] [stdout] be658d416378c9422d272a919c7ff7f9632a43ab405d092ea0a07e3113aa8273 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d59d36e57df059ae926f1016552983f175a75c2c9a5fce2c5b6f82d0d6e50b4d [INFO] running `Command { std: "docker" "start" "-a" "d59d36e57df059ae926f1016552983f175a75c2c9a5fce2c5b6f82d0d6e50b4d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling unicode-ident v1.0.19 [INFO] [stderr] Compiling libc v0.2.176 [INFO] [stderr] Checking cfg-if v1.0.3 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling find-msvc-tools v0.1.2 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling cc v1.2.39 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking writeable v0.6.1 [INFO] [stderr] Checking litemap v0.8.0 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Compiling icu_properties_data v2.0.1 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling rustversion v1.0.22 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking slab v0.4.11 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Compiling rustls v0.23.32 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling pkg-config v0.3.32 [INFO] [stderr] Checking regex-automata v0.4.11 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking indexmap v2.11.4 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking pxfm v0.1.24 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking rustls-webpki v0.103.6 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking weezl v0.1.10 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking allocator-api2 v0.2.21 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking gethostname v1.0.2 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking moxcms v0.7.5 [INFO] [stderr] Checking regex v1.11.3 [INFO] [stderr] Checking zune-jpeg v0.4.21 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking webpki-roots v1.0.2 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Compiling pulldown-cmark v0.10.3 [INFO] [stderr] Checking bytemuck v1.23.2 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Checking iana-time-zone v0.1.64 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking image v0.25.8 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling stability v0.2.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking getopts v0.2.24 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking humantime v2.3.0 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking chunked_transfer v1.5.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking unicase v2.8.1 [INFO] [stderr] Checking predicates-core v1.0.9 [INFO] [stderr] Checking pulldown-cmark-escape v0.10.1 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking home v0.5.11 [INFO] [stderr] Checking ratatui v0.26.3 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking tiny_http v0.12.0 [INFO] [stderr] Checking webbrowser v0.8.15 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking humantime-serde v1.1.1 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking textwrap v0.16.2 [INFO] [stderr] Checking reqwest v0.12.23 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking tree_magic_mini v3.2.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking float-cmp v0.10.0 [INFO] [stderr] Checking termtree v0.5.1 [INFO] [stderr] Compiling assert_cmd v2.0.17 [INFO] [stderr] Checking semver v1.0.27 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking predicates-tree v1.0.12 [INFO] [stderr] Checking bstr v1.12.0 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking terminally-online v0.1.21 (/opt/rustwide/workdir) [INFO] [stdout] warning: variants `EditContent` and `DeleteContent` are never constructed [INFO] [stdout] --> src/ui.rs:245:5 [INFO] [stdout] | [INFO] [stdout] 239 | enum ActionMenuAction { [INFO] [stdout] | ---------------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 245 | EditContent, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 246 | DeleteContent, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ActionMenuAction` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `install` and `github` are never read [INFO] [stdout] --> src/ui.rs:688:5 [INFO] [stdout] | [INFO] [stdout] 685 | struct MenuAccountPositions { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 688 | install: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 689 | github: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Link` is never constructed [INFO] [stdout] --> src/ui.rs:912:5 [INFO] [stdout] | [INFO] [stdout] 910 | enum PostType { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] 911 | Text, [INFO] [stdout] 912 | Link, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PostType` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `EditContent` and `DeleteContent` are never constructed [INFO] [stdout] --> src/ui.rs:245:5 [INFO] [stdout] | [INFO] [stdout] 239 | enum ActionMenuAction { [INFO] [stdout] | ---------------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 245 | EditContent, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 246 | DeleteContent, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ActionMenuAction` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `install` and `github` are never read [INFO] [stdout] --> src/ui.rs:688:5 [INFO] [stdout] | [INFO] [stdout] 685 | struct MenuAccountPositions { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 688 | install: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 689 | github: usize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Link` is never constructed [INFO] [stdout] --> src/ui.rs:912:5 [INFO] [stdout] | [INFO] [stdout] 910 | enum PostType { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] 911 | Text, [INFO] [stdout] 912 | Link, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PostType` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TextEditor` [INFO] [stdout] --> src/ui/editor.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | / pub fn new() -> Self { [INFO] [stdout] 35 | | Self { [INFO] [stdout] 36 | | content: String::new(), [INFO] [stdout] 37 | | cursor: (0, 0), [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 33 + impl Default for TextEditor { [INFO] [stdout] 34 + fn default() -> Self { [INFO] [stdout] 35 + Self::new() [INFO] [stdout] 36 + } [INFO] [stdout] 37 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `y` is used as a loop counter [INFO] [stdout] --> src/ui/editor.rs:461:5 [INFO] [stdout] | [INFO] [stdout] 461 | for (i, line) in lines.iter().enumerate().skip(start_line).take(end_line - start_line) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (y, (i, line)) in lines.iter().enumerate().skip(start_line).take(end_line - start_line).enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SubmissionForm` [INFO] [stdout] --> src/ui/editor.rs:554:5 [INFO] [stdout] | [INFO] [stdout] 554 | / pub fn new() -> Self { [INFO] [stdout] 555 | | Self { [INFO] [stdout] 556 | | editor: TextEditor::with_max_length(40000), // Reddit's limit [INFO] [stdout] 557 | | subreddit: String::new(), [INFO] [stdout] ... | [INFO] [stdout] 562 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 553 + impl Default for SubmissionForm { [INFO] [stdout] 554 + fn default() -> Self { [INFO] [stdout] 555 + Self::new() [INFO] [stdout] 556 + } [INFO] [stdout] 557 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ui.rs:1720:28 [INFO] [stdout] | [INFO] [stdout] 1720 | if is_animated_gif_url(&url) || is_video_url(&url) { [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ui.rs:1720:50 [INFO] [stdout] | [INFO] [stdout] 1720 | if is_animated_gif_url(&url) || is_video_url(&url) { [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TextEditor` [INFO] [stdout] --> src/ui/editor.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | / pub fn new() -> Self { [INFO] [stdout] 35 | | Self { [INFO] [stdout] 36 | | content: String::new(), [INFO] [stdout] 37 | | cursor: (0, 0), [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 33 + impl Default for TextEditor { [INFO] [stdout] 34 + fn default() -> Self { [INFO] [stdout] 35 + Self::new() [INFO] [stdout] 36 + } [INFO] [stdout] 37 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `y` is used as a loop counter [INFO] [stdout] --> src/ui/editor.rs:461:5 [INFO] [stdout] | [INFO] [stdout] 461 | for (i, line) in lines.iter().enumerate().skip(start_line).take(end_line - start_line) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (y, (i, line)) in lines.iter().enumerate().skip(start_line).take(end_line - start_line).enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SubmissionForm` [INFO] [stdout] --> src/ui/editor.rs:554:5 [INFO] [stdout] | [INFO] [stdout] 554 | / pub fn new() -> Self { [INFO] [stdout] 555 | | Self { [INFO] [stdout] 556 | | editor: TextEditor::with_max_length(40000), // Reddit's limit [INFO] [stdout] 557 | | subreddit: String::new(), [INFO] [stdout] ... | [INFO] [stdout] 562 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 553 + impl Default for SubmissionForm { [INFO] [stdout] 554 + fn default() -> Self { [INFO] [stdout] 555 + Self::new() [INFO] [stdout] 556 + } [INFO] [stdout] 557 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui.rs:3827:24 [INFO] [stdout] | [INFO] [stdout] 3827 | if self.posts.get(self.selected_post).is_some() [INFO] [stdout] | ________________________^ [INFO] [stdout] 3828 | | && self.comment_service.is_some() [INFO] [stdout] 3829 | | && true [INFO] [stdout] | |_______________________________^ help: try: `self.posts.get(self.selected_post).is_some() && self.comment_service.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:3826:17 [INFO] [stdout] | [INFO] [stdout] 3826 | / if self.focused_pane == Pane::Comments { [INFO] [stdout] 3827 | | if self.posts.get(self.selected_post).is_some() [INFO] [stdout] 3828 | | && self.comment_service.is_some() [INFO] [stdout] 3829 | | && true [INFO] [stdout] ... | [INFO] [stdout] 3844 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3825 ~ KeyCode::Char('t') | KeyCode::Char('T') [INFO] [stdout] 3826 ~ if self.focused_pane == Pane::Comments => { [INFO] [stdout] 3827 | if self.posts.get(self.selected_post).is_some() [INFO] [stdout] ... [INFO] [stdout] 3843 | } [INFO] [stdout] 3844 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:3851:17 [INFO] [stdout] | [INFO] [stdout] 3851 | / if !key.modifiers.contains(KeyModifiers::CONTROL) { [INFO] [stdout] 3852 | | self.toggle_media_fullscreen()?; [INFO] [stdout] 3853 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3850 ~ KeyCode::Char('f') | KeyCode::Char('F') [INFO] [stdout] 3851 ~ if !key.modifiers.contains(KeyModifiers::CONTROL) => { [INFO] [stdout] 3852 | self.toggle_media_fullscreen()?; [INFO] [stdout] 3853 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:3899:17 [INFO] [stdout] | [INFO] [stdout] 3899 | / if self.focused_pane == Pane::Comments { [INFO] [stdout] 3900 | | self.toggle_selected_comment_fold(); [INFO] [stdout] 3901 | | dirty = true; [INFO] [stdout] 3902 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3898 ~ KeyCode::Char('c') [INFO] [stdout] 3899 ~ if self.focused_pane == Pane::Comments => { [INFO] [stdout] 3900 | self.toggle_selected_comment_fold(); [INFO] [stdout] 3901 | dirty = true; [INFO] [stdout] 3902 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:3905:17 [INFO] [stdout] | [INFO] [stdout] 3905 | / if self.focused_pane == Pane::Comments { [INFO] [stdout] 3906 | | self.expand_all_comments(); [INFO] [stdout] 3907 | | dirty = true; [INFO] [stdout] 3908 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3904 ~ KeyCode::Char('C') [INFO] [stdout] 3905 ~ if self.focused_pane == Pane::Comments => { [INFO] [stdout] 3906 | self.expand_all_comments(); [INFO] [stdout] 3907 | dirty = true; [INFO] [stdout] 3908 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:3911:17 [INFO] [stdout] | [INFO] [stdout] 3911 | / if self.focused_pane == Pane::Comments && !self.comment_sort_selected { [INFO] [stdout] 3912 | | if let Err(err) = self.copy_selected_comment() { [INFO] [stdout] 3913 | | self.status_message = format!("Failed to copy comment: {err}"); [INFO] [stdout] 3914 | | self.mark_dirty(); [INFO] [stdout] 3915 | | } [INFO] [stdout] 3916 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3910 ~ KeyCode::Char('y') | KeyCode::Char('Y') [INFO] [stdout] 3911 ~ if self.focused_pane == Pane::Comments && !self.comment_sort_selected => { [INFO] [stdout] 3912 | if let Err(err) = self.copy_selected_comment() { [INFO] [stdout] ... [INFO] [stdout] 3915 | } [INFO] [stdout] 3916 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:3919:17 [INFO] [stdout] | [INFO] [stdout] 3919 | / if self.focused_pane == Pane::Navigation { [INFO] [stdout] 3920 | | self.commit_navigation_selection()?; [INFO] [stdout] 3921 | | dirty = true; [INFO] [stdout] 3922 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3918 ~ KeyCode::Enter [INFO] [stdout] 3919 ~ if self.focused_pane == Pane::Navigation => { [INFO] [stdout] 3920 | self.commit_navigation_selection()?; [INFO] [stdout] 3921 | dirty = true; [INFO] [stdout] 3922 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4008:17 [INFO] [stdout] | [INFO] [stdout] 4008 | / if self.focused_pane == Pane::Posts { [INFO] [stdout] 4009 | | if self.posts.is_empty() { [INFO] [stdout] 4010 | | self.status_message = "No posts available to select.".to_string(); [INFO] [stdout] 4011 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 4016 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4007 ~ KeyCode::Home [INFO] [stdout] 4008 ~ if self.focused_pane == Pane::Posts => { [INFO] [stdout] 4009 | if self.posts.is_empty() { [INFO] [stdout] ... [INFO] [stdout] 4015 | } [INFO] [stdout] 4016 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4019:17 [INFO] [stdout] | [INFO] [stdout] 4019 | / if self.focused_pane == Pane::Posts { [INFO] [stdout] 4020 | | if self.posts.is_empty() { [INFO] [stdout] 4021 | | self.status_message = "No posts available to select.".to_string(); [INFO] [stdout] 4022 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 4028 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4018 ~ KeyCode::End [INFO] [stdout] 4019 ~ if self.focused_pane == Pane::Posts => { [INFO] [stdout] 4020 | if self.posts.is_empty() { [INFO] [stdout] ... [INFO] [stdout] 4027 | } [INFO] [stdout] 4028 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4031:17 [INFO] [stdout] | [INFO] [stdout] 4031 | / if self.focused_pane == Pane::Posts { [INFO] [stdout] 4032 | | let now = Instant::now(); [INFO] [stdout] 4033 | | let digit = ch.to_digit(10).unwrap() as usize; [INFO] [stdout] 4034 | | let timeout = Duration::from_millis(800); [INFO] [stdout] ... | [INFO] [stdout] 4078 | | dirty = true; [INFO] [stdout] 4079 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4030 ~ KeyCode::Char(ch) if ch.is_ascii_digit() [INFO] [stdout] 4031 ~ && self.focused_pane == Pane::Posts => { [INFO] [stdout] 4032 | let now = Instant::now(); [INFO] [stdout] ... [INFO] [stdout] 4078 | dirty = true; [INFO] [stdout] 4079 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4138:17 [INFO] [stdout] | [INFO] [stdout] 4138 | / if self.menu_account_index + 1 < option_count { [INFO] [stdout] 4139 | | self.menu_account_index += 1; [INFO] [stdout] 4140 | | self.mark_dirty(); [INFO] [stdout] 4141 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4137 ~ KeyCode::Down | KeyCode::Char('j') [INFO] [stdout] 4138 ~ if self.menu_account_index + 1 < option_count => { [INFO] [stdout] 4139 | self.menu_account_index += 1; [INFO] [stdout] 4140 | self.mark_dirty(); [INFO] [stdout] 4141 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4144:17 [INFO] [stdout] | [INFO] [stdout] 4144 | / if self.menu_account_index > 0 { [INFO] [stdout] 4145 | | self.menu_account_index -= 1; [INFO] [stdout] 4146 | | self.mark_dirty(); [INFO] [stdout] 4147 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4143 ~ KeyCode::Up | KeyCode::Char('k') [INFO] [stdout] 4144 ~ if self.menu_account_index > 0 => { [INFO] [stdout] 4145 | self.menu_account_index -= 1; [INFO] [stdout] 4146 | self.mark_dirty(); [INFO] [stdout] 4147 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ui.rs:1720:28 [INFO] [stdout] | [INFO] [stdout] 1720 | if is_animated_gif_url(&url) || is_video_url(&url) { [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ui.rs:1720:50 [INFO] [stdout] | [INFO] [stdout] 1720 | if is_animated_gif_url(&url) || is_video_url(&url) { [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/ui.rs:4612:9 [INFO] [stdout] | [INFO] [stdout] 4612 | scored.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 4612 - scored.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] 4612 + scored.sort_by_key(|b| std::cmp::Reverse(b.0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4736:17 [INFO] [stdout] | [INFO] [stdout] 4736 | / if self.action_menu_selected > 0 { [INFO] [stdout] 4737 | | self.action_menu_selected -= 1; [INFO] [stdout] 4738 | | self.mark_dirty(); [INFO] [stdout] 4739 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4735 ~ KeyCode::Char('k') if key.modifiers.contains(KeyModifiers::CONTROL) [INFO] [stdout] 4736 ~ && self.action_menu_selected > 0 => { [INFO] [stdout] 4737 | self.action_menu_selected -= 1; [INFO] [stdout] 4738 | self.mark_dirty(); [INFO] [stdout] 4739 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4742:17 [INFO] [stdout] | [INFO] [stdout] 4742 | / if self.action_menu_selected + 1 < self.action_link_items.len() { [INFO] [stdout] 4743 | | self.action_menu_selected += 1; [INFO] [stdout] 4744 | | self.mark_dirty(); [INFO] [stdout] 4745 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4741 ~ KeyCode::Char('j') if key.modifiers.contains(KeyModifiers::CONTROL) [INFO] [stdout] 4742 ~ && self.action_menu_selected + 1 < self.action_link_items.len() => { [INFO] [stdout] 4743 | self.action_menu_selected += 1; [INFO] [stdout] 4744 | self.mark_dirty(); [INFO] [stdout] 4745 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4748:17 [INFO] [stdout] | [INFO] [stdout] 4748 | / if self.action_menu_selected > 0 { [INFO] [stdout] 4749 | | self.action_menu_selected -= 1; [INFO] [stdout] 4750 | | self.mark_dirty(); [INFO] [stdout] 4751 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4747 ~ KeyCode::Up | KeyCode::Char('k') | KeyCode::Char('K') [INFO] [stdout] 4748 ~ if self.action_menu_selected > 0 => { [INFO] [stdout] 4749 | self.action_menu_selected -= 1; [INFO] [stdout] 4750 | self.mark_dirty(); [INFO] [stdout] 4751 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4754:17 [INFO] [stdout] | [INFO] [stdout] 4754 | / if self.action_menu_selected + 1 < self.action_link_items.len() { [INFO] [stdout] 4755 | | self.action_menu_selected += 1; [INFO] [stdout] 4756 | | self.mark_dirty(); [INFO] [stdout] 4757 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4753 ~ KeyCode::Down | KeyCode::Char('j') | KeyCode::Char('J') [INFO] [stdout] 4754 ~ if self.action_menu_selected + 1 < self.action_link_items.len() => { [INFO] [stdout] 4755 | self.action_menu_selected += 1; [INFO] [stdout] 4756 | self.mark_dirty(); [INFO] [stdout] 4757 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4760:17 [INFO] [stdout] | [INFO] [stdout] 4760 | / if self.action_menu_selected > 0 { [INFO] [stdout] 4761 | | let step = self.action_menu_selected.min(5); [INFO] [stdout] 4762 | | self.action_menu_selected -= step; [INFO] [stdout] 4763 | | self.mark_dirty(); [INFO] [stdout] 4764 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4759 ~ KeyCode::PageUp [INFO] [stdout] 4760 ~ if self.action_menu_selected > 0 => { [INFO] [stdout] 4761 | let step = self.action_menu_selected.min(5); [INFO] [stdout] 4762 | self.action_menu_selected -= step; [INFO] [stdout] 4763 | self.mark_dirty(); [INFO] [stdout] 4764 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4767:17 [INFO] [stdout] | [INFO] [stdout] 4767 | / if self.action_menu_selected + 1 < self.action_link_items.len() { [INFO] [stdout] 4768 | | let remaining = self.action_link_items.len() - self.action_menu_selected - 1; [INFO] [stdout] 4769 | | let step = remaining.min(5); [INFO] [stdout] 4770 | | self.action_menu_selected += step; [INFO] [stdout] 4771 | | self.mark_dirty(); [INFO] [stdout] 4772 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4766 ~ KeyCode::PageDown [INFO] [stdout] 4767 ~ if self.action_menu_selected + 1 < self.action_link_items.len() => { [INFO] [stdout] 4768 | let remaining = self.action_link_items.len() - self.action_menu_selected - 1; [INFO] [stdout] ... [INFO] [stdout] 4771 | self.mark_dirty(); [INFO] [stdout] 4772 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4831:25 [INFO] [stdout] | [INFO] [stdout] 4831 | / if self.action_menu_selected > 0 { [INFO] [stdout] 4832 | | self.action_menu_selected -= 1; [INFO] [stdout] 4833 | | self.mark_dirty(); [INFO] [stdout] 4834 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4830 ~ KeyCode::Up | KeyCode::Char('k') | KeyCode::Char('K') [INFO] [stdout] 4831 ~ if self.action_menu_selected > 0 => { [INFO] [stdout] 4832 | self.action_menu_selected -= 1; [INFO] [stdout] 4833 | self.mark_dirty(); [INFO] [stdout] 4834 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4837:25 [INFO] [stdout] | [INFO] [stdout] 4837 | / if self.action_menu_selected + 1 < self.action_menu_items.len() { [INFO] [stdout] 4838 | | self.action_menu_selected += 1; [INFO] [stdout] 4839 | | self.mark_dirty(); [INFO] [stdout] 4840 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4836 ~ KeyCode::Down | KeyCode::Char('j') | KeyCode::Char('J') [INFO] [stdout] 4837 ~ if self.action_menu_selected + 1 < self.action_menu_items.len() => { [INFO] [stdout] 4838 | self.action_menu_selected += 1; [INFO] [stdout] 4839 | self.mark_dirty(); [INFO] [stdout] 4840 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4843:25 [INFO] [stdout] | [INFO] [stdout] 4843 | / if self.action_menu_selected > 0 { [INFO] [stdout] 4844 | | let step = self.action_menu_selected.min(5); [INFO] [stdout] 4845 | | self.action_menu_selected -= step; [INFO] [stdout] 4846 | | self.mark_dirty(); [INFO] [stdout] 4847 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4842 ~ KeyCode::PageUp [INFO] [stdout] 4843 ~ if self.action_menu_selected > 0 => { [INFO] [stdout] 4844 | let step = self.action_menu_selected.min(5); [INFO] [stdout] 4845 | self.action_menu_selected -= step; [INFO] [stdout] 4846 | self.mark_dirty(); [INFO] [stdout] 4847 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4850:25 [INFO] [stdout] | [INFO] [stdout] 4850 | / if self.action_menu_selected + 1 < self.action_menu_items.len() { [INFO] [stdout] 4851 | | let remaining = [INFO] [stdout] 4852 | | self.action_menu_items.len() - self.action_menu_selected - 1; [INFO] [stdout] 4853 | | let step = remaining.min(5); [INFO] [stdout] 4854 | | self.action_menu_selected += step; [INFO] [stdout] 4855 | | self.mark_dirty(); [INFO] [stdout] 4856 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4849 ~ KeyCode::PageDown [INFO] [stdout] 4850 ~ if self.action_menu_selected + 1 < self.action_menu_items.len() => { [INFO] [stdout] 4851 | let remaining = [INFO] [stdout] ... [INFO] [stdout] 4855 | self.mark_dirty(); [INFO] [stdout] 4856 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4971:25 [INFO] [stdout] | [INFO] [stdout] 4971 | / if state.editing && state.filter.pop().is_some() { [INFO] [stdout] 4972 | | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4973 | | self.mark_dirty(); [INFO] [stdout] 4974 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4970 ~ KeyCode::Backspace [INFO] [stdout] 4971 ~ if state.editing && state.filter.pop().is_some() => { [INFO] [stdout] 4972 | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4973 | self.mark_dirty(); [INFO] [stdout] 4974 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4977:25 [INFO] [stdout] | [INFO] [stdout] 4977 | / if state.editing && !state.filter.is_empty() { [INFO] [stdout] 4978 | | state.filter.clear(); [INFO] [stdout] 4979 | | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4980 | | self.mark_dirty(); [INFO] [stdout] 4981 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4976 ~ KeyCode::Delete [INFO] [stdout] 4977 ~ if state.editing && !state.filter.is_empty() => { [INFO] [stdout] 4978 | state.filter.clear(); [INFO] [stdout] 4979 | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4980 | self.mark_dirty(); [INFO] [stdout] 4981 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4984:25 [INFO] [stdout] | [INFO] [stdout] 4984 | / if state.editing && !state.filter.is_empty() { [INFO] [stdout] 4985 | | state.filter.clear(); [INFO] [stdout] 4986 | | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4987 | | self.mark_dirty(); [INFO] [stdout] 4988 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4983 ~ KeyCode::Char('u') if modifiers.contains(KeyModifiers::CONTROL) [INFO] [stdout] 4984 ~ && state.editing && !state.filter.is_empty() => { [INFO] [stdout] 4985 | state.filter.clear(); [INFO] [stdout] 4986 | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4987 | self.mark_dirty(); [INFO] [stdout] 4988 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4991:25 [INFO] [stdout] | [INFO] [stdout] 4991 | / if state.editing && pop_last_word(&mut state.filter) { [INFO] [stdout] 4992 | | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4993 | | self.mark_dirty(); [INFO] [stdout] 4994 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4990 ~ KeyCode::Char('w') if modifiers.contains(KeyModifiers::CONTROL) [INFO] [stdout] 4991 ~ && state.editing && pop_last_word(&mut state.filter) => { [INFO] [stdout] 4992 | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4993 | self.mark_dirty(); [INFO] [stdout] 4994 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/ui.rs:6050:36 [INFO] [stdout] | [INFO] [stdout] 6050 | ... if let Err(_) = self.load_default_subreddits() { [INFO] [stdout] | -------^^^^^^--------------------------------- help: try: `if self.load_default_subreddits().is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui.rs:3827:24 [INFO] [stdout] | [INFO] [stdout] 3827 | if self.posts.get(self.selected_post).is_some() [INFO] [stdout] | ________________________^ [INFO] [stdout] 3828 | | && self.comment_service.is_some() [INFO] [stdout] 3829 | | && true [INFO] [stdout] | |_______________________________^ help: try: `self.posts.get(self.selected_post).is_some() && self.comment_service.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:3826:17 [INFO] [stdout] | [INFO] [stdout] 3826 | / if self.focused_pane == Pane::Comments { [INFO] [stdout] 3827 | | if self.posts.get(self.selected_post).is_some() [INFO] [stdout] 3828 | | && self.comment_service.is_some() [INFO] [stdout] 3829 | | && true [INFO] [stdout] ... | [INFO] [stdout] 3844 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3825 ~ KeyCode::Char('t') | KeyCode::Char('T') [INFO] [stdout] 3826 ~ if self.focused_pane == Pane::Comments => { [INFO] [stdout] 3827 | if self.posts.get(self.selected_post).is_some() [INFO] [stdout] ... [INFO] [stdout] 3843 | } [INFO] [stdout] 3844 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:3851:17 [INFO] [stdout] | [INFO] [stdout] 3851 | / if !key.modifiers.contains(KeyModifiers::CONTROL) { [INFO] [stdout] 3852 | | self.toggle_media_fullscreen()?; [INFO] [stdout] 3853 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3850 ~ KeyCode::Char('f') | KeyCode::Char('F') [INFO] [stdout] 3851 ~ if !key.modifiers.contains(KeyModifiers::CONTROL) => { [INFO] [stdout] 3852 | self.toggle_media_fullscreen()?; [INFO] [stdout] 3853 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:3899:17 [INFO] [stdout] | [INFO] [stdout] 3899 | / if self.focused_pane == Pane::Comments { [INFO] [stdout] 3900 | | self.toggle_selected_comment_fold(); [INFO] [stdout] 3901 | | dirty = true; [INFO] [stdout] 3902 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3898 ~ KeyCode::Char('c') [INFO] [stdout] 3899 ~ if self.focused_pane == Pane::Comments => { [INFO] [stdout] 3900 | self.toggle_selected_comment_fold(); [INFO] [stdout] 3901 | dirty = true; [INFO] [stdout] 3902 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:3905:17 [INFO] [stdout] | [INFO] [stdout] 3905 | / if self.focused_pane == Pane::Comments { [INFO] [stdout] 3906 | | self.expand_all_comments(); [INFO] [stdout] 3907 | | dirty = true; [INFO] [stdout] 3908 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3904 ~ KeyCode::Char('C') [INFO] [stdout] 3905 ~ if self.focused_pane == Pane::Comments => { [INFO] [stdout] 3906 | self.expand_all_comments(); [INFO] [stdout] 3907 | dirty = true; [INFO] [stdout] 3908 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:3911:17 [INFO] [stdout] | [INFO] [stdout] 3911 | / if self.focused_pane == Pane::Comments && !self.comment_sort_selected { [INFO] [stdout] 3912 | | if let Err(err) = self.copy_selected_comment() { [INFO] [stdout] 3913 | | self.status_message = format!("Failed to copy comment: {err}"); [INFO] [stdout] 3914 | | self.mark_dirty(); [INFO] [stdout] 3915 | | } [INFO] [stdout] 3916 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3910 ~ KeyCode::Char('y') | KeyCode::Char('Y') [INFO] [stdout] 3911 ~ if self.focused_pane == Pane::Comments && !self.comment_sort_selected => { [INFO] [stdout] 3912 | if let Err(err) = self.copy_selected_comment() { [INFO] [stdout] ... [INFO] [stdout] 3915 | } [INFO] [stdout] 3916 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:3919:17 [INFO] [stdout] | [INFO] [stdout] 3919 | / if self.focused_pane == Pane::Navigation { [INFO] [stdout] 3920 | | self.commit_navigation_selection()?; [INFO] [stdout] 3921 | | dirty = true; [INFO] [stdout] 3922 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 3918 ~ KeyCode::Enter [INFO] [stdout] 3919 ~ if self.focused_pane == Pane::Navigation => { [INFO] [stdout] 3920 | self.commit_navigation_selection()?; [INFO] [stdout] 3921 | dirty = true; [INFO] [stdout] 3922 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4008:17 [INFO] [stdout] | [INFO] [stdout] 4008 | / if self.focused_pane == Pane::Posts { [INFO] [stdout] 4009 | | if self.posts.is_empty() { [INFO] [stdout] 4010 | | self.status_message = "No posts available to select.".to_string(); [INFO] [stdout] 4011 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 4016 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4007 ~ KeyCode::Home [INFO] [stdout] 4008 ~ if self.focused_pane == Pane::Posts => { [INFO] [stdout] 4009 | if self.posts.is_empty() { [INFO] [stdout] ... [INFO] [stdout] 4015 | } [INFO] [stdout] 4016 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4019:17 [INFO] [stdout] | [INFO] [stdout] 4019 | / if self.focused_pane == Pane::Posts { [INFO] [stdout] 4020 | | if self.posts.is_empty() { [INFO] [stdout] 4021 | | self.status_message = "No posts available to select.".to_string(); [INFO] [stdout] 4022 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 4028 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4018 ~ KeyCode::End [INFO] [stdout] 4019 ~ if self.focused_pane == Pane::Posts => { [INFO] [stdout] 4020 | if self.posts.is_empty() { [INFO] [stdout] ... [INFO] [stdout] 4027 | } [INFO] [stdout] 4028 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4031:17 [INFO] [stdout] | [INFO] [stdout] 4031 | / if self.focused_pane == Pane::Posts { [INFO] [stdout] 4032 | | let now = Instant::now(); [INFO] [stdout] 4033 | | let digit = ch.to_digit(10).unwrap() as usize; [INFO] [stdout] 4034 | | let timeout = Duration::from_millis(800); [INFO] [stdout] ... | [INFO] [stdout] 4078 | | dirty = true; [INFO] [stdout] 4079 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4030 ~ KeyCode::Char(ch) if ch.is_ascii_digit() [INFO] [stdout] 4031 ~ && self.focused_pane == Pane::Posts => { [INFO] [stdout] 4032 | let now = Instant::now(); [INFO] [stdout] ... [INFO] [stdout] 4078 | dirty = true; [INFO] [stdout] 4079 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4138:17 [INFO] [stdout] | [INFO] [stdout] 4138 | / if self.menu_account_index + 1 < option_count { [INFO] [stdout] 4139 | | self.menu_account_index += 1; [INFO] [stdout] 4140 | | self.mark_dirty(); [INFO] [stdout] 4141 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4137 ~ KeyCode::Down | KeyCode::Char('j') [INFO] [stdout] 4138 ~ if self.menu_account_index + 1 < option_count => { [INFO] [stdout] 4139 | self.menu_account_index += 1; [INFO] [stdout] 4140 | self.mark_dirty(); [INFO] [stdout] 4141 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4144:17 [INFO] [stdout] | [INFO] [stdout] 4144 | / if self.menu_account_index > 0 { [INFO] [stdout] 4145 | | self.menu_account_index -= 1; [INFO] [stdout] 4146 | | self.mark_dirty(); [INFO] [stdout] 4147 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4143 ~ KeyCode::Up | KeyCode::Char('k') [INFO] [stdout] 4144 ~ if self.menu_account_index > 0 => { [INFO] [stdout] 4145 | self.menu_account_index -= 1; [INFO] [stdout] 4146 | self.mark_dirty(); [INFO] [stdout] 4147 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/ui.rs:4612:9 [INFO] [stdout] | [INFO] [stdout] 4612 | scored.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 4612 - scored.sort_by(|a, b| b.0.cmp(&a.0)); [INFO] [stdout] 4612 + scored.sort_by_key(|b| std::cmp::Reverse(b.0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4736:17 [INFO] [stdout] | [INFO] [stdout] 4736 | / if self.action_menu_selected > 0 { [INFO] [stdout] 4737 | | self.action_menu_selected -= 1; [INFO] [stdout] 4738 | | self.mark_dirty(); [INFO] [stdout] 4739 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4735 ~ KeyCode::Char('k') if key.modifiers.contains(KeyModifiers::CONTROL) [INFO] [stdout] 4736 ~ && self.action_menu_selected > 0 => { [INFO] [stdout] 4737 | self.action_menu_selected -= 1; [INFO] [stdout] 4738 | self.mark_dirty(); [INFO] [stdout] 4739 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4742:17 [INFO] [stdout] | [INFO] [stdout] 4742 | / if self.action_menu_selected + 1 < self.action_link_items.len() { [INFO] [stdout] 4743 | | self.action_menu_selected += 1; [INFO] [stdout] 4744 | | self.mark_dirty(); [INFO] [stdout] 4745 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4741 ~ KeyCode::Char('j') if key.modifiers.contains(KeyModifiers::CONTROL) [INFO] [stdout] 4742 ~ && self.action_menu_selected + 1 < self.action_link_items.len() => { [INFO] [stdout] 4743 | self.action_menu_selected += 1; [INFO] [stdout] 4744 | self.mark_dirty(); [INFO] [stdout] 4745 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4748:17 [INFO] [stdout] | [INFO] [stdout] 4748 | / if self.action_menu_selected > 0 { [INFO] [stdout] 4749 | | self.action_menu_selected -= 1; [INFO] [stdout] 4750 | | self.mark_dirty(); [INFO] [stdout] 4751 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4747 ~ KeyCode::Up | KeyCode::Char('k') | KeyCode::Char('K') [INFO] [stdout] 4748 ~ if self.action_menu_selected > 0 => { [INFO] [stdout] 4749 | self.action_menu_selected -= 1; [INFO] [stdout] 4750 | self.mark_dirty(); [INFO] [stdout] 4751 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4754:17 [INFO] [stdout] | [INFO] [stdout] 4754 | / if self.action_menu_selected + 1 < self.action_link_items.len() { [INFO] [stdout] 4755 | | self.action_menu_selected += 1; [INFO] [stdout] 4756 | | self.mark_dirty(); [INFO] [stdout] 4757 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4753 ~ KeyCode::Down | KeyCode::Char('j') | KeyCode::Char('J') [INFO] [stdout] 4754 ~ if self.action_menu_selected + 1 < self.action_link_items.len() => { [INFO] [stdout] 4755 | self.action_menu_selected += 1; [INFO] [stdout] 4756 | self.mark_dirty(); [INFO] [stdout] 4757 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4760:17 [INFO] [stdout] | [INFO] [stdout] 4760 | / if self.action_menu_selected > 0 { [INFO] [stdout] 4761 | | let step = self.action_menu_selected.min(5); [INFO] [stdout] 4762 | | self.action_menu_selected -= step; [INFO] [stdout] 4763 | | self.mark_dirty(); [INFO] [stdout] 4764 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4759 ~ KeyCode::PageUp [INFO] [stdout] 4760 ~ if self.action_menu_selected > 0 => { [INFO] [stdout] 4761 | let step = self.action_menu_selected.min(5); [INFO] [stdout] 4762 | self.action_menu_selected -= step; [INFO] [stdout] 4763 | self.mark_dirty(); [INFO] [stdout] 4764 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4767:17 [INFO] [stdout] | [INFO] [stdout] 4767 | / if self.action_menu_selected + 1 < self.action_link_items.len() { [INFO] [stdout] 4768 | | let remaining = self.action_link_items.len() - self.action_menu_selected - 1; [INFO] [stdout] 4769 | | let step = remaining.min(5); [INFO] [stdout] 4770 | | self.action_menu_selected += step; [INFO] [stdout] 4771 | | self.mark_dirty(); [INFO] [stdout] 4772 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4766 ~ KeyCode::PageDown [INFO] [stdout] 4767 ~ if self.action_menu_selected + 1 < self.action_link_items.len() => { [INFO] [stdout] 4768 | let remaining = self.action_link_items.len() - self.action_menu_selected - 1; [INFO] [stdout] ... [INFO] [stdout] 4771 | self.mark_dirty(); [INFO] [stdout] 4772 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4831:25 [INFO] [stdout] | [INFO] [stdout] 4831 | / if self.action_menu_selected > 0 { [INFO] [stdout] 4832 | | self.action_menu_selected -= 1; [INFO] [stdout] 4833 | | self.mark_dirty(); [INFO] [stdout] 4834 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4830 ~ KeyCode::Up | KeyCode::Char('k') | KeyCode::Char('K') [INFO] [stdout] 4831 ~ if self.action_menu_selected > 0 => { [INFO] [stdout] 4832 | self.action_menu_selected -= 1; [INFO] [stdout] 4833 | self.mark_dirty(); [INFO] [stdout] 4834 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4837:25 [INFO] [stdout] | [INFO] [stdout] 4837 | / if self.action_menu_selected + 1 < self.action_menu_items.len() { [INFO] [stdout] 4838 | | self.action_menu_selected += 1; [INFO] [stdout] 4839 | | self.mark_dirty(); [INFO] [stdout] 4840 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4836 ~ KeyCode::Down | KeyCode::Char('j') | KeyCode::Char('J') [INFO] [stdout] 4837 ~ if self.action_menu_selected + 1 < self.action_menu_items.len() => { [INFO] [stdout] 4838 | self.action_menu_selected += 1; [INFO] [stdout] 4839 | self.mark_dirty(); [INFO] [stdout] 4840 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4843:25 [INFO] [stdout] | [INFO] [stdout] 4843 | / if self.action_menu_selected > 0 { [INFO] [stdout] 4844 | | let step = self.action_menu_selected.min(5); [INFO] [stdout] 4845 | | self.action_menu_selected -= step; [INFO] [stdout] 4846 | | self.mark_dirty(); [INFO] [stdout] 4847 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4842 ~ KeyCode::PageUp [INFO] [stdout] 4843 ~ if self.action_menu_selected > 0 => { [INFO] [stdout] 4844 | let step = self.action_menu_selected.min(5); [INFO] [stdout] 4845 | self.action_menu_selected -= step; [INFO] [stdout] 4846 | self.mark_dirty(); [INFO] [stdout] 4847 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4850:25 [INFO] [stdout] | [INFO] [stdout] 4850 | / if self.action_menu_selected + 1 < self.action_menu_items.len() { [INFO] [stdout] 4851 | | let remaining = [INFO] [stdout] 4852 | | self.action_menu_items.len() - self.action_menu_selected - 1; [INFO] [stdout] 4853 | | let step = remaining.min(5); [INFO] [stdout] 4854 | | self.action_menu_selected += step; [INFO] [stdout] 4855 | | self.mark_dirty(); [INFO] [stdout] 4856 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4849 ~ KeyCode::PageDown [INFO] [stdout] 4850 ~ if self.action_menu_selected + 1 < self.action_menu_items.len() => { [INFO] [stdout] 4851 | let remaining = [INFO] [stdout] ... [INFO] [stdout] 4855 | self.mark_dirty(); [INFO] [stdout] 4856 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4971:25 [INFO] [stdout] | [INFO] [stdout] 4971 | / if state.editing && state.filter.pop().is_some() { [INFO] [stdout] 4972 | | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4973 | | self.mark_dirty(); [INFO] [stdout] 4974 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4970 ~ KeyCode::Backspace [INFO] [stdout] 4971 ~ if state.editing && state.filter.pop().is_some() => { [INFO] [stdout] 4972 | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4973 | self.mark_dirty(); [INFO] [stdout] 4974 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4977:25 [INFO] [stdout] | [INFO] [stdout] 4977 | / if state.editing && !state.filter.is_empty() { [INFO] [stdout] 4978 | | state.filter.clear(); [INFO] [stdout] 4979 | | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4980 | | self.mark_dirty(); [INFO] [stdout] 4981 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4976 ~ KeyCode::Delete [INFO] [stdout] 4977 ~ if state.editing && !state.filter.is_empty() => { [INFO] [stdout] 4978 | state.filter.clear(); [INFO] [stdout] 4979 | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4980 | self.mark_dirty(); [INFO] [stdout] 4981 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4984:25 [INFO] [stdout] | [INFO] [stdout] 4984 | / if state.editing && !state.filter.is_empty() { [INFO] [stdout] 4985 | | state.filter.clear(); [INFO] [stdout] 4986 | | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4987 | | self.mark_dirty(); [INFO] [stdout] 4988 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4983 ~ KeyCode::Char('u') if modifiers.contains(KeyModifiers::CONTROL) [INFO] [stdout] 4984 ~ && state.editing && !state.filter.is_empty() => { [INFO] [stdout] 4985 | state.filter.clear(); [INFO] [stdout] 4986 | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4987 | self.mark_dirty(); [INFO] [stdout] 4988 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui.rs:4991:25 [INFO] [stdout] | [INFO] [stdout] 4991 | / if state.editing && pop_last_word(&mut state.filter) { [INFO] [stdout] 4992 | | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4993 | | self.mark_dirty(); [INFO] [stdout] 4994 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 4990 ~ KeyCode::Char('w') if modifiers.contains(KeyModifiers::CONTROL) [INFO] [stdout] 4991 ~ && state.editing && pop_last_word(&mut state.filter) => { [INFO] [stdout] 4992 | self.refresh_navigation_matches(&mut state); [INFO] [stdout] 4993 | self.mark_dirty(); [INFO] [stdout] 4994 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/ui.rs:7725:21 [INFO] [stdout] | [INFO] [stdout] 7725 | subreddits.sort_by(|a, b| a.to_lowercase().cmp(&b.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 7725 - subreddits.sort_by(|a, b| a.to_lowercase().cmp(&b.to_lowercase())); [INFO] [stdout] 7725 + subreddits.sort_by_key(|a| a.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/ui.rs:6050:36 [INFO] [stdout] | [INFO] [stdout] 6050 | ... if let Err(_) = self.load_default_subreddits() { [INFO] [stdout] | -------^^^^^^--------------------------------- help: try: `if self.load_default_subreddits().is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/ui.rs:10062:13 [INFO] [stdout] | [INFO] [stdout] 10062 | &subreddit[2..] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/ui.rs:10061:25 [INFO] [stdout] | [INFO] [stdout] 10061 | let subreddit = if subreddit.starts_with("r/") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 10061 ~ let subreddit = if let Some() = subreddit.strip_prefix("r/") { [INFO] [stdout] 10062 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/ui.rs:7725:21 [INFO] [stdout] | [INFO] [stdout] 7725 | subreddits.sort_by(|a, b| a.to_lowercase().cmp(&b.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 7725 - subreddits.sort_by(|a, b| a.to_lowercase().cmp(&b.to_lowercase())); [INFO] [stdout] 7725 + subreddits.sort_by_key(|a| a.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/ui.rs:10062:13 [INFO] [stdout] | [INFO] [stdout] 10062 | &subreddit[2..] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/ui.rs:10061:25 [INFO] [stdout] | [INFO] [stdout] 10061 | let subreddit = if subreddit.starts_with("r/") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 10061 ~ let subreddit = if let Some() = subreddit.strip_prefix("r/") { [INFO] [stdout] 10062 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 33.79s [INFO] running `Command { std: "docker" "inspect" "d59d36e57df059ae926f1016552983f175a75c2c9a5fce2c5b6f82d0d6e50b4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d59d36e57df059ae926f1016552983f175a75c2c9a5fce2c5b6f82d0d6e50b4d", kill_on_drop: false }` [INFO] [stdout] d59d36e57df059ae926f1016552983f175a75c2c9a5fce2c5b6f82d0d6e50b4d