[INFO] cloning repository https://github.com/0xKoda/port_checker [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/0xKoda/port_checker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0xKoda%2Fport_checker", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0xKoda%2Fport_checker'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9ba4ed1a90bd8ef21b82617205b1e29b360b3ddd [INFO] linting 0xKoda/port_checker against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0xKoda%2Fport_checker" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/0xKoda/port_checker [INFO] finished tweaking git repo https://github.com/0xKoda/port_checker [INFO] tweaked toml for git repo https://github.com/0xKoda/port_checker written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/0xKoda/port_checker on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/0xKoda/port_checker already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c7248858e2876883dbdaae5b6544dc163f5345a11c6014115af54f2bf7e48dfa [INFO] running `Command { std: "docker" "start" "-a" "c7248858e2876883dbdaae5b6544dc163f5345a11c6014115af54f2bf7e48dfa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c7248858e2876883dbdaae5b6544dc163f5345a11c6014115af54f2bf7e48dfa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7248858e2876883dbdaae5b6544dc163f5345a11c6014115af54f2bf7e48dfa", kill_on_drop: false }` [INFO] [stdout] c7248858e2876883dbdaae5b6544dc163f5345a11c6014115af54f2bf7e48dfa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2d9d56c6071f5bae7fde0d7fd4a86f1b5cfdbe2de25e734ef8d6bc783d1702a4 [INFO] running `Command { std: "docker" "start" "-a" "2d9d56c6071f5bae7fde0d7fd4a86f1b5cfdbe2de25e734ef8d6bc783d1702a4", kill_on_drop: false }` [INFO] [stderr] Checking port_checker v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | if !fs::metadata("suspicious_programs.txt").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("suspicious_programs.txt").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | if !fs::metadata("suspicious_programs.txt").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("suspicious_programs.txt").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `filter_map()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/main.rs:40:10 [INFO] [stdout] | [INFO] [stdout] 40 | .filter_map(Result::ok) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/main.rs:39:41 [INFO] [stdout] | [INFO] [stdout] 39 | let updated_programs: Vec = reader.lines() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `filter_map()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/main.rs:40:10 [INFO] [stdout] | [INFO] [stdout] 40 | .filter_map(Result::ok) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/main.rs:39:41 [INFO] [stdout] | [INFO] [stdout] 39 | let updated_programs: Vec = reader.lines() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/main.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | / Command::new("kill") [INFO] [stdout] 68 | | .arg("-9") [INFO] [stdout] 69 | | .arg(pid.to_string()) [INFO] [stdout] 70 | | .spawn() [INFO] [stdout] 71 | | .expect("Failed to kill program"); [INFO] [stdout] | | ^- help: try: `.wait()` [INFO] [stdout] | |_____________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/main.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | / Command::new("kill") [INFO] [stdout] 68 | | .arg("-9") [INFO] [stdout] 69 | | .arg(pid.to_string()) [INFO] [stdout] 70 | | .spawn() [INFO] [stdout] 71 | | .expect("Failed to kill program"); [INFO] [stdout] | | ^- help: try: `.wait()` [INFO] [stdout] | |_____________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `row_count` is used as a loop counter [INFO] [stdout] --> src/main.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | for line in output_str.lines() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (row_count, line) in output_str.lines().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `row_count` is used as a loop counter [INFO] [stdout] --> src/main.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | for line in output_str.lines() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (row_count, line) in output_str.lines().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s [INFO] running `Command { std: "docker" "inspect" "2d9d56c6071f5bae7fde0d7fd4a86f1b5cfdbe2de25e734ef8d6bc783d1702a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2d9d56c6071f5bae7fde0d7fd4a86f1b5cfdbe2de25e734ef8d6bc783d1702a4", kill_on_drop: false }` [INFO] [stdout] 2d9d56c6071f5bae7fde0d7fd4a86f1b5cfdbe2de25e734ef8d6bc783d1702a4