[INFO] cloning repository https://github.com/0x3Zero/hot-potato-meta-contract [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/0x3Zero/hot-potato-meta-contract" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0x3Zero%2Fhot-potato-meta-contract", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0x3Zero%2Fhot-potato-meta-contract'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ecf661f0f433c48846ba4edb3923a78659a5525f [INFO] linting 0x3Zero/hot-potato-meta-contract against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0x3Zero%2Fhot-potato-meta-contract" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/0x3Zero/hot-potato-meta-contract [INFO] finished tweaking git repo https://github.com/0x3Zero/hot-potato-meta-contract [INFO] tweaked toml for git repo https://github.com/0x3Zero/hot-potato-meta-contract written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/0x3Zero/hot-potato-meta-contract on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/0x3Zero/hot-potato-meta-contract already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded marine-timestamp-macro v0.7.1 [INFO] [stderr] Downloaded marine-rs-sdk-main v0.7.1 [INFO] [stderr] Downloaded marine-macro v0.7.1 [INFO] [stderr] Downloaded marine-rs-sdk-main v0.8.1 [INFO] [stderr] Downloaded marine-macro v0.8.1 [INFO] [stderr] Downloaded polyplets v0.3.3 [INFO] [stderr] Downloaded marine-rs-sdk v0.7.1 [INFO] [stderr] Downloaded primitive-types v0.12.1 [INFO] [stderr] Downloaded thiserror-impl v1.0.47 [INFO] [stderr] Downloaded parity-scale-codec-derive v3.6.4 [INFO] [stderr] Downloaded thiserror v1.0.47 [INFO] [stderr] Downloaded marine-macro-impl v0.7.1 [INFO] [stderr] Downloaded parity-scale-codec v3.6.4 [INFO] [stderr] Downloaded chrono v0.4.26 [INFO] [stderr] Downloaded toml_edit v0.19.14 [INFO] [stderr] Downloaded marine-macro-impl v0.8.1 [INFO] [stderr] Downloaded aho-corasick v1.0.4 [INFO] [stderr] Downloaded regex v1.9.4 [INFO] [stderr] Downloaded regex-automata v0.3.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 654279abf517dcc942abb2d5f86244b5c549f991dbc53af7af968f7da10a93cd [INFO] running `Command { std: "docker" "start" "-a" "654279abf517dcc942abb2d5f86244b5c549f991dbc53af7af968f7da10a93cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "654279abf517dcc942abb2d5f86244b5c549f991dbc53af7af968f7da10a93cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "654279abf517dcc942abb2d5f86244b5c549f991dbc53af7af968f7da10a93cd", kill_on_drop: false }` [INFO] [stdout] 654279abf517dcc942abb2d5f86244b5c549f991dbc53af7af968f7da10a93cd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3135eb15a2c35b7924699af02c347fb1284f9b36965681f09071276efbcbf739 [INFO] running `Command { std: "docker" "start" "-a" "3135eb15a2c35b7924699af02c347fb1284f9b36965681f09071276efbcbf739", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling ryu v1.0.15 [INFO] [stderr] Compiling itoa v1.0.9 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking uint v0.9.5 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rlp v0.5.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking impl-rlp v0.3.0 [INFO] [stderr] Compiling time v0.1.45 [INFO] [stderr] Checking aho-corasick v1.0.4 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Compiling thiserror v1.0.47 [INFO] [stderr] Checking fixed-hash v0.8.0 [INFO] [stderr] Compiling iana-time-zone v0.1.57 [INFO] [stderr] Checking keccak v0.1.4 [INFO] [stderr] Compiling chrono v0.4.26 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Compiling marine-timestamp-macro v0.7.1 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling thiserror-impl v1.0.47 [INFO] [stderr] Checking regex-automata v0.3.7 [INFO] [stderr] Checking regex v1.9.4 [INFO] [stderr] Checking impl-serde v0.4.0 [INFO] [stderr] Checking marine-rs-sdk-main v0.7.1 [INFO] [stderr] Checking ethbloom v0.13.0 [INFO] [stderr] Checking primitive-types v0.12.1 [INFO] [stderr] Compiling marine-rs-sdk-main v0.8.1 [INFO] [stderr] Checking ethereum-types v0.14.1 [INFO] [stderr] Compiling marine-macro-impl v0.8.1 [INFO] [stderr] Compiling marine-macro-impl v0.7.1 [INFO] [stderr] Checking ethabi v18.0.0 [INFO] [stderr] Compiling marine-macro v0.8.1 [INFO] [stderr] Checking polyplets v0.3.3 [INFO] [stderr] Compiling marine-macro v0.7.1 [INFO] [stderr] Checking marine-rs-sdk v0.7.1 [INFO] [stderr] Checking meta-contract v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `types::SerdeMetadata` [INFO] [stdout] --> src/main.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | use types::SerdeMetadata; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | let mut hash_map: HashMap = HashMap::new(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hash_map` [INFO] [stdout] --> src/main.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | let mut hash_map: HashMap = HashMap::new(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_hash_map` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `owner`, `cid`, and `version` are never read [INFO] [stdout] --> src/data.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct DataStructFork { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 5 | pub owner: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 6 | pub cid: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 7 | pub version: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DataStructFork` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SerdeMetadata` is never constructed [INFO] [stdout] --> src/types.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 66 | pub struct SerdeMetadata { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:42:10 [INFO] [stdout] | [INFO] [stdout] 42 | if data.alias == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.alias.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 47 | if transaction.alias == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `transaction.alias.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 - return true; [INFO] [stdout] 136 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:208:8 [INFO] [stdout] | [INFO] [stdout] 208 | if !error.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `error.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `error` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:212:23 [INFO] [stdout] | [INFO] [stdout] 208 | if !error.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 212 | error_string: error.unwrap().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:164:8 [INFO] [stdout] | [INFO] [stdout] 164 | if data.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:183:22 [INFO] [stdout] | [INFO] [stdout] 183 | if new_name.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!new_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:184:28 [INFO] [stdout] | [INFO] [stdout] 184 | name = format!("{}", new_name.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `new_name.clone().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/main.rs:197:85 [INFO] [stdout] | [INFO] [stdout] 197 | Err(e) => error = Some(format!("Invalid data structure: {}", e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/main.rs:201:77 [INFO] [stdout] | [INFO] [stdout] 201 | Err(e) => error = Some(format!("Invalid data structure: {}", e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/main.rs:204:73 [INFO] [stdout] | [INFO] [stdout] 204 | Err(e) => error = Some(format!("Invalid data structure: {}", e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:262:5 [INFO] [stdout] | [INFO] [stdout] 262 | let address: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `address` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 262 ~ [INFO] [stdout] 263 | let t; [INFO] [stdout] 264 | [INFO] [stdout] 265 ~ let address: String = if api_multiaddr.is_empty() { [INFO] [stdout] 266 ~ DEFAULT_IPFS_MULTIADDR.to_string() [INFO] [stdout] 267 | } else { [INFO] [stdout] 268 ~ api_multiaddr [INFO] [stdout] 269 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:263:5 [INFO] [stdout] | [INFO] [stdout] 263 | let t; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `t` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 263 ~ [INFO] [stdout] 264 | [INFO] [stdout] ... [INFO] [stdout] 270 | [INFO] [stdout] 271 ~ let t = if timeout_sec == 0 { [INFO] [stdout] 272 ~ DEFAULT_TIMEOUT_SEC [INFO] [stdout] 273 | } else { [INFO] [stdout] 274 ~ timeout_sec [INFO] [stdout] 275 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `types::SerdeMetadata` [INFO] [stdout] --> src/main.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | use types::SerdeMetadata; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | let mut hash_map: HashMap = HashMap::new(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hash_map` [INFO] [stdout] --> src/main.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | let mut hash_map: HashMap = HashMap::new(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_hash_map` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `owner`, `cid`, and `version` are never read [INFO] [stdout] --> src/data.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct DataStructFork { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 5 | pub owner: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 6 | pub cid: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 7 | pub version: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DataStructFork` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SerdeMetadata` is never constructed [INFO] [stdout] --> src/types.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 66 | pub struct SerdeMetadata { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:42:10 [INFO] [stdout] | [INFO] [stdout] 42 | if data.alias == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.alias.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 47 | if transaction.alias == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `transaction.alias.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 - return true; [INFO] [stdout] 136 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:208:8 [INFO] [stdout] | [INFO] [stdout] 208 | if !error.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `error.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `error` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:212:23 [INFO] [stdout] | [INFO] [stdout] 208 | if !error.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 212 | error_string: error.unwrap().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:164:8 [INFO] [stdout] | [INFO] [stdout] 164 | if data.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:183:22 [INFO] [stdout] | [INFO] [stdout] 183 | if new_name.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!new_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:184:28 [INFO] [stdout] | [INFO] [stdout] 184 | name = format!("{}", new_name.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `new_name.clone().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/main.rs:197:85 [INFO] [stdout] | [INFO] [stdout] 197 | Err(e) => error = Some(format!("Invalid data structure: {}", e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/main.rs:201:77 [INFO] [stdout] | [INFO] [stdout] 201 | Err(e) => error = Some(format!("Invalid data structure: {}", e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/main.rs:204:73 [INFO] [stdout] | [INFO] [stdout] 204 | Err(e) => error = Some(format!("Invalid data structure: {}", e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:262:5 [INFO] [stdout] | [INFO] [stdout] 262 | let address: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `address` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 262 ~ [INFO] [stdout] 263 | let t; [INFO] [stdout] 264 | [INFO] [stdout] 265 ~ let address: String = if api_multiaddr.is_empty() { [INFO] [stdout] 266 ~ DEFAULT_IPFS_MULTIADDR.to_string() [INFO] [stdout] 267 | } else { [INFO] [stdout] 268 ~ api_multiaddr [INFO] [stdout] 269 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:263:5 [INFO] [stdout] | [INFO] [stdout] 263 | let t; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `t` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 263 ~ [INFO] [stdout] 264 | [INFO] [stdout] ... [INFO] [stdout] 270 | [INFO] [stdout] 271 ~ let t = if timeout_sec == 0 { [INFO] [stdout] 272 ~ DEFAULT_TIMEOUT_SEC [INFO] [stdout] 273 | } else { [INFO] [stdout] 274 ~ timeout_sec [INFO] [stdout] 275 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 33.32s [INFO] running `Command { std: "docker" "inspect" "3135eb15a2c35b7924699af02c347fb1284f9b36965681f09071276efbcbf739", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3135eb15a2c35b7924699af02c347fb1284f9b36965681f09071276efbcbf739", kill_on_drop: false }` [INFO] [stdout] 3135eb15a2c35b7924699af02c347fb1284f9b36965681f09071276efbcbf739